All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: tas2552: Remove unneeded NULL test for tas2552->enable_gpio
@ 2015-07-25  7:32 Axel Lin
  2015-07-27 13:19 ` Dan Murphy
  2015-07-29 14:13 ` Applied "ASoC: tas2552: Remove unneeded NULL test for tas2552->enable_gpio" to the asoc tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2015-07-25  7:32 UTC (permalink / raw)
  To: Mark Brown; +Cc: alsa-devel, Dan Muprhy, Liam Girdwood

It's safe to call gpiod_set_value() with NULL desc.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 sound/soc/codecs/tas2552.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
index 2f6a65a..e3a0bca 100644
--- a/sound/soc/codecs/tas2552.c
+++ b/sound/soc/codecs/tas2552.c
@@ -493,8 +493,7 @@ static int tas2552_runtime_suspend(struct device *dev)
 	regcache_cache_only(tas2552->regmap, true);
 	regcache_mark_dirty(tas2552->regmap);
 
-	if (tas2552->enable_gpio)
-		gpiod_set_value(tas2552->enable_gpio, 0);
+	gpiod_set_value(tas2552->enable_gpio, 0);
 
 	return 0;
 }
@@ -503,8 +502,7 @@ static int tas2552_runtime_resume(struct device *dev)
 {
 	struct tas2552_data *tas2552 = dev_get_drvdata(dev);
 
-	if (tas2552->enable_gpio)
-		gpiod_set_value(tas2552->enable_gpio, 1);
+	gpiod_set_value(tas2552->enable_gpio, 1);
 
 	tas2552_sw_shutdown(tas2552, 0);
 
@@ -585,8 +583,7 @@ static int tas2552_codec_probe(struct snd_soc_codec *codec)
 		return ret;
 	}
 
-	if (tas2552->enable_gpio)
-		gpiod_set_value(tas2552->enable_gpio, 1);
+	gpiod_set_value(tas2552->enable_gpio, 1);
 
 	ret = pm_runtime_get_sync(codec->dev);
 	if (ret < 0) {
@@ -610,8 +607,7 @@ static int tas2552_codec_probe(struct snd_soc_codec *codec)
 	return 0;
 
 probe_fail:
-	if (tas2552->enable_gpio)
-		gpiod_set_value(tas2552->enable_gpio, 0);
+	gpiod_set_value(tas2552->enable_gpio, 0);
 
 	regulator_bulk_disable(ARRAY_SIZE(tas2552->supplies),
 					tas2552->supplies);
@@ -624,8 +620,7 @@ static int tas2552_codec_remove(struct snd_soc_codec *codec)
 
 	pm_runtime_put(codec->dev);
 
-	if (tas2552->enable_gpio)
-		gpiod_set_value(tas2552->enable_gpio, 0);
+	gpiod_set_value(tas2552->enable_gpio, 0);
 
 	return 0;
 };
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: tas2552: Remove unneeded NULL test for tas2552->enable_gpio
  2015-07-25  7:32 [PATCH] ASoC: tas2552: Remove unneeded NULL test for tas2552->enable_gpio Axel Lin
@ 2015-07-27 13:19 ` Dan Murphy
  2015-07-29 14:13 ` Applied "ASoC: tas2552: Remove unneeded NULL test for tas2552->enable_gpio" to the asoc tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Dan Murphy @ 2015-07-27 13:19 UTC (permalink / raw)
  To: Axel Lin, Mark Brown; +Cc: alsa-devel, Liam Girdwood


On 07/25/2015 02:32 AM, Axel Lin wrote:
> It's safe to call gpiod_set_value() with NULL desc.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  sound/soc/codecs/tas2552.c | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
> index 2f6a65a..e3a0bca 100644
> --- a/sound/soc/codecs/tas2552.c
> +++ b/sound/soc/codecs/tas2552.c
> @@ -493,8 +493,7 @@ static int tas2552_runtime_suspend(struct device *dev)
>  	regcache_cache_only(tas2552->regmap, true);
>  	regcache_mark_dirty(tas2552->regmap);
>  
> -	if (tas2552->enable_gpio)
> -		gpiod_set_value(tas2552->enable_gpio, 0);
> +	gpiod_set_value(tas2552->enable_gpio, 0);
>  
>  	return 0;
>  }
> @@ -503,8 +502,7 @@ static int tas2552_runtime_resume(struct device *dev)
>  {
>  	struct tas2552_data *tas2552 = dev_get_drvdata(dev);
>  
> -	if (tas2552->enable_gpio)
> -		gpiod_set_value(tas2552->enable_gpio, 1);
> +	gpiod_set_value(tas2552->enable_gpio, 1);
>  
>  	tas2552_sw_shutdown(tas2552, 0);
>  
> @@ -585,8 +583,7 @@ static int tas2552_codec_probe(struct snd_soc_codec *codec)
>  		return ret;
>  	}
>  
> -	if (tas2552->enable_gpio)
> -		gpiod_set_value(tas2552->enable_gpio, 1);
> +	gpiod_set_value(tas2552->enable_gpio, 1);
>  
>  	ret = pm_runtime_get_sync(codec->dev);
>  	if (ret < 0) {
> @@ -610,8 +607,7 @@ static int tas2552_codec_probe(struct snd_soc_codec *codec)
>  	return 0;
>  
>  probe_fail:
> -	if (tas2552->enable_gpio)
> -		gpiod_set_value(tas2552->enable_gpio, 0);
> +	gpiod_set_value(tas2552->enable_gpio, 0);
>  
>  	regulator_bulk_disable(ARRAY_SIZE(tas2552->supplies),
>  					tas2552->supplies);
> @@ -624,8 +620,7 @@ static int tas2552_codec_remove(struct snd_soc_codec *codec)
>  
>  	pm_runtime_put(codec->dev);
>  
> -	if (tas2552->enable_gpio)
> -		gpiod_set_value(tas2552->enable_gpio, 0);
> +	gpiod_set_value(tas2552->enable_gpio, 0);
>  
>  	return 0;
>  };

Acked-by: Dan Murphy <dmurphy@ti.com>

-- 
------------------
Dan Murphy

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Applied "ASoC: tas2552: Remove unneeded NULL test for tas2552->enable_gpio" to the asoc tree
  2015-07-25  7:32 [PATCH] ASoC: tas2552: Remove unneeded NULL test for tas2552->enable_gpio Axel Lin
  2015-07-27 13:19 ` Dan Murphy
@ 2015-07-29 14:13 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-07-29 14:13 UTC (permalink / raw)
  To: Axel Lin, Dan Murphy, Mark Brown; +Cc: alsa-devel

The patch

   ASoC: tas2552: Remove unneeded NULL test for tas2552->enable_gpio

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 82cf77a1bd61d981184a355742a9b5c78f286f97 Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@ingics.com>
Date: Sat, 25 Jul 2015 15:32:16 +0800
Subject: [PATCH] ASoC: tas2552: Remove unneeded NULL test for
 tas2552->enable_gpio

It's safe to call gpiod_set_value() with NULL desc.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/tas2552.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
index 4f25a7d0..d6ec004 100644
--- a/sound/soc/codecs/tas2552.c
+++ b/sound/soc/codecs/tas2552.c
@@ -493,8 +493,7 @@ static int tas2552_runtime_suspend(struct device *dev)
 	regcache_cache_only(tas2552->regmap, true);
 	regcache_mark_dirty(tas2552->regmap);
 
-	if (tas2552->enable_gpio)
-		gpiod_set_value(tas2552->enable_gpio, 0);
+	gpiod_set_value(tas2552->enable_gpio, 0);
 
 	return 0;
 }
@@ -503,8 +502,7 @@ static int tas2552_runtime_resume(struct device *dev)
 {
 	struct tas2552_data *tas2552 = dev_get_drvdata(dev);
 
-	if (tas2552->enable_gpio)
-		gpiod_set_value(tas2552->enable_gpio, 1);
+	gpiod_set_value(tas2552->enable_gpio, 1);
 
 	tas2552_sw_shutdown(tas2552, 0);
 
@@ -585,8 +583,7 @@ static int tas2552_codec_probe(struct snd_soc_codec *codec)
 		return ret;
 	}
 
-	if (tas2552->enable_gpio)
-		gpiod_set_value(tas2552->enable_gpio, 1);
+	gpiod_set_value(tas2552->enable_gpio, 1);
 
 	ret = pm_runtime_get_sync(codec->dev);
 	if (ret < 0) {
@@ -610,8 +607,7 @@ static int tas2552_codec_probe(struct snd_soc_codec *codec)
 	return 0;
 
 probe_fail:
-	if (tas2552->enable_gpio)
-		gpiod_set_value(tas2552->enable_gpio, 0);
+	gpiod_set_value(tas2552->enable_gpio, 0);
 
 	regulator_bulk_disable(ARRAY_SIZE(tas2552->supplies),
 					tas2552->supplies);
@@ -624,8 +620,7 @@ static int tas2552_codec_remove(struct snd_soc_codec *codec)
 
 	pm_runtime_put(codec->dev);
 
-	if (tas2552->enable_gpio)
-		gpiod_set_value(tas2552->enable_gpio, 0);
+	gpiod_set_value(tas2552->enable_gpio, 0);
 
 	return 0;
 };
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-29 14:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-25  7:32 [PATCH] ASoC: tas2552: Remove unneeded NULL test for tas2552->enable_gpio Axel Lin
2015-07-27 13:19 ` Dan Murphy
2015-07-29 14:13 ` Applied "ASoC: tas2552: Remove unneeded NULL test for tas2552->enable_gpio" to the asoc tree Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.