[U-Boot] [PATCH] video: discard empty video_set_lut implementation

[U-Boot] [PATCH] video: discard empty video_set_lut implementation

[Peng Fan]

Discard the empty video_set_lut function from platform video
drivers.

This commit "69d275458893eaec35229b589092c2a6bde5440f" introduces
a weak function video_set_lut, so we do not need an strong function
in platform drivers, which does nothing.

Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
---
 drivers/video/da8xx-fb.c     | 10 ----------
 drivers/video/mx3fb.c        |  9 ---------
 drivers/video/mxc_ipuv3_fb.c |  9 ---------
 3 files changed, 28 deletions(-)

diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 3a5f325..e2b2144 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -1035,16 +1035,6 @@ err_release_fb:
 	return NULL;
 }
 
-void video_set_lut(unsigned int index,	/* color number */
-		    unsigned char r,	/* red */
-		    unsigned char g,	/* green */
-		    unsigned char b	/* blue */
-		    )
-{
-
-	return;
-}
-
 void da8xx_video_init(const struct da8xx_panel *panel,
 		      const struct lcd_ctrl_config *lcd_cfg, int bits_pixel)
 {
diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
index aa4cc43..3f10d5c 100644
--- a/drivers/video/mx3fb.c
+++ b/drivers/video/mx3fb.c
@@ -904,12 +904,3 @@ void *video_hw_init(void)
 
 	return (void *) &panel;
 }
-
-void video_set_lut(unsigned int index,	/* color number */
-		    unsigned char r,	/* red */
-		    unsigned char g,	/* green */
-		    unsigned char b	/* blue */
-		    )
-{
-	return;
-}
diff --git a/drivers/video/mxc_ipuv3_fb.c b/drivers/video/mxc_ipuv3_fb.c
index 1fa9531..265274b 100644
--- a/drivers/video/mxc_ipuv3_fb.c
+++ b/drivers/video/mxc_ipuv3_fb.c
@@ -599,15 +599,6 @@ void *video_hw_init(void)
 	return (void *)&panel;
 }
 
-void video_set_lut(unsigned int index, /* color number */
-			unsigned char r,    /* red */
-			unsigned char g,    /* green */
-			unsigned char b     /* blue */
-			)
-{
-	return;
-}
-
 int ipuv3_fb_init(struct fb_videomode const *mode,
 		  uint8_t disp,
 		  uint32_t pixfmt)
-- 
1.8.4

[U-Boot] [PATCH] video: discard empty video_set_lut implementation

[Tom Rini]

On Sat, Jul 25, 2015 at 08:59:35PM +0800, Peng Fan wrote:

> Discard the empty video_set_lut function from platform video
> drivers.
> 
> This commit "69d275458893eaec35229b589092c2a6bde5440f" introduces
> a weak function video_set_lut, so we do not need an strong function
> in platform drivers, which does nothing.
> 
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150727/f9433d17/attachment.sig>

[U-Boot] [PATCH] video: discard empty video_set_lut implementation

[Anatolij Gustschin]

Hi,

On Sat, 25 Jul 2015 20:59:35 +0800
Peng Fan <Peng.Fan@freescale.com> wrote:

> Discard the empty video_set_lut function from platform video
> drivers.
> 
> This commit "69d275458893eaec35229b589092c2a6bde5440f" introduces
> a weak function video_set_lut, so we do not need an strong function
> in platform drivers, which does nothing.
> 
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> ---
>  drivers/video/da8xx-fb.c     | 10 ----------
>  drivers/video/mx3fb.c        |  9 ---------
>  drivers/video/mxc_ipuv3_fb.c |  9 ---------
>  3 files changed, 28 deletions(-)

applied, thanks!

Anatolij