All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] acpi: fix pvpanic device is not shown in ui
@ 2015-07-26  8:00 Gal Hammer
  2015-07-27  9:25 ` Igor Mammedov
  0 siblings, 1 reply; 2+ messages in thread
From: Gal Hammer @ 2015-07-26  8:00 UTC (permalink / raw)
  To: qemu-devel
  Cc: Gal Hammer, Igor Mammedov, Michael S. Tsirkin,
	Radim Krčmář

Commit 2332333c added a _STA method that hides the device. The fact
that the device is not shown in the gui make it harder to install its
Windows' device.

https://bugzilla.redhat.com/show_bug.cgi?id=1238141

Signed-off-by: Gal Hammer <ghammer@redhat.com>
---
 hw/i386/acpi-build.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index aed811a..46eddb8 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1108,8 +1108,8 @@ build_ssdt(GArray *table_data, GArray *linker,
         aml_append(field, aml_named_field("PEPT", 8));
         aml_append(dev, field);
 
-        /* device present, functioning, decoding, not shown in UI */
-        aml_append(dev, aml_name_decl("_STA", aml_int(0xB)));
+        /* device present, functioning, decoding, shown in UI */
+        aml_append(dev, aml_name_decl("_STA", aml_int(0xF)));
 
         method = aml_method("RDPT", 0);
         aml_append(method, aml_store(aml_name("PEPT"), aml_local(0)));
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] acpi: fix pvpanic device is not shown in ui
  2015-07-26  8:00 [Qemu-devel] [PATCH] acpi: fix pvpanic device is not shown in ui Gal Hammer
@ 2015-07-27  9:25 ` Igor Mammedov
  0 siblings, 0 replies; 2+ messages in thread
From: Igor Mammedov @ 2015-07-27  9:25 UTC (permalink / raw)
  To: Gal Hammer; +Cc: Michael S. Tsirkin, qemu-devel, Radim Krčmář

On Sun, 26 Jul 2015 11:00:51 +0300
Gal Hammer <ghammer@redhat.com> wrote:

> Commit 2332333c added a _STA method that hides the device. The fact
> that the device is not shown in the gui make it harder to install its
> Windows' device.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1238141
> 
> Signed-off-by: Gal Hammer <ghammer@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>


> ---
>  hw/i386/acpi-build.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index aed811a..46eddb8 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1108,8 +1108,8 @@ build_ssdt(GArray *table_data, GArray *linker,
>          aml_append(field, aml_named_field("PEPT", 8));
>          aml_append(dev, field);
>  
> -        /* device present, functioning, decoding, not shown in UI */
> -        aml_append(dev, aml_name_decl("_STA", aml_int(0xB)));
> +        /* device present, functioning, decoding, shown in UI */
> +        aml_append(dev, aml_name_decl("_STA", aml_int(0xF)));
>  
>          method = aml_method("RDPT", 0);
>          aml_append(method, aml_store(aml_name("PEPT"), aml_local(0)));

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-27  9:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-26  8:00 [Qemu-devel] [PATCH] acpi: fix pvpanic device is not shown in ui Gal Hammer
2015-07-27  9:25 ` Igor Mammedov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.