[PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Priyanka Jain]

T1040D4RDB/T1042D4RDB are Freescale Reference Design Board
which can support T1040/T1042 QorIQ Power
Architecture™ processor respectively

T1040D4RDB/T1042D4RDB board Overview
-------------------------------------
- SERDES Connections, 8 lanes supporting:
        - PCI
        - SGMII
        - SATA 2.0
        - QSGMII(only for T1040D4RDB)
    - DDR Controller
        - Supports rates of up to 1600 MHz data-rate
        - Supports one DDR4 UDIMM
    -IFC/Local Bus
        - NAND flash: 1GB 8-bit NAND flash
        - NOR: 128MB 16-bit NOR Flash
    - Ethernet
        - Two on-board RGMII 10/100/1G ethernet ports.
        - PHY #0 remains powered up during deep-sleep
    - CPLD
    - Clocks
        - System and DDR clock (SYSCLK, “DDRCLK”)
        - SERDES clocks
    - Power Supplies
    - USB
        - Supports two USB 2.0 ports with integrated PHYs
        - Two type A ports with 5V@1.5A per port.
    - SDHC
        - SDHC/SDXC connector
    - SPI
        - On-board 64MB SPI flash
    - I2C
        - Devices connected: EEPROM, thermal monitor, VID controller
    - Other IO
        - Two Serial ports
        - ProfiBus port

    Add support for T1040/T1042D4RDB board:
    -add device tree
    -Add entry in corenet_generic.c

Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
---
 Changes for v2:
	Incorporated Scott's comments on device tree

 arch/powerpc/boot/dts/t1040d4rdb.dts          |   46 ++++++
 arch/powerpc/boot/dts/t1042d4rdb.dts          |   53 +++++++
 arch/powerpc/boot/dts/t104xd4rdb.dtsi         |  196 +++++++++++++++++++++++++
 arch/powerpc/platforms/85xx/corenet_generic.c |    2 +
 4 files changed, 297 insertions(+), 0 deletions(-)
 create mode 100644 arch/powerpc/boot/dts/t1040d4rdb.dts
 create mode 100644 arch/powerpc/boot/dts/t1042d4rdb.dts
 create mode 100644 arch/powerpc/boot/dts/t104xd4rdb.dtsi

diff --git a/arch/powerpc/boot/dts/t1040d4rdb.dts b/arch/powerpc/boot/dts/t1040d4rdb.dts
new file mode 100644
index 0000000..2d1315a
--- /dev/null
+++ b/arch/powerpc/boot/dts/t1040d4rdb.dts
@@ -0,0 +1,46 @@
+/*
+ * T1040D4RDB Device Tree Source
+ *
+ * Copyright 2015 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *     * Redistributions of source code must retain the above copyright
+ *	 notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *	 notice, this list of conditions and the following disclaimer in the
+ *	 documentation and/or other materials provided with the distribution.
+ *     * Neither the name of Freescale Semiconductor nor the
+ *	 names of its contributors may be used to endorse or promote products
+ *	 derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/include/ "fsl/t104xsi-pre.dtsi"
+/include/ "t104xd4rdb.dtsi"
+
+/ {
+	model = "fsl,T1040D4RDB";
+	compatible = "fsl,T1040D4RDB";
+	#address-cells = <2>;
+	#size-cells = <2>;
+	interrupt-parent = <&mpic>;
+};
+
+/include/ "fsl/t1040si-post.dtsi"
diff --git a/arch/powerpc/boot/dts/t1042d4rdb.dts b/arch/powerpc/boot/dts/t1042d4rdb.dts
new file mode 100644
index 0000000..846f8c8
--- /dev/null
+++ b/arch/powerpc/boot/dts/t1042d4rdb.dts
@@ -0,0 +1,53 @@
+/*
+ * T1042D4RDB Device Tree Source
+ *
+ * Copyright 2015 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *     * Redistributions of source code must retain the above copyright
+ *	 notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *	 notice, this list of conditions and the following disclaimer in the
+ *	 documentation and/or other materials provided with the distribution.
+ *     * Neither the name of Freescale Semiconductor nor the
+ *	 names of its contributors may be used to endorse or promote products
+ *	 derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/include/ "fsl/t104xsi-pre.dtsi"
+/include/ "t104xd4rdb.dtsi"
+
+/ {
+	model = "fsl,T1042D4RDB";
+	compatible = "fsl,T1042D4RDB";
+	#address-cells = <2>;
+	#size-cells = <2>;
+	interrupt-parent = <&mpic>;
+
+	ifc: localbus@ffe124000 {
+		cpld@3,0 {
+			compatible = "fsl,t1040d4rdb-cpld",
+					"fsl,deepsleep-cpld";
+		};
+	};
+};
+
+/include/ "fsl/t1040si-post.dtsi"
diff --git a/arch/powerpc/boot/dts/t104xd4rdb.dtsi b/arch/powerpc/boot/dts/t104xd4rdb.dtsi
new file mode 100644
index 0000000..37d2817
--- /dev/null
+++ b/arch/powerpc/boot/dts/t104xd4rdb.dtsi
@@ -0,0 +1,196 @@
+/*
+ * T1040D4RDB/T1042D4RDB Device Tree Source
+ *
+ * Copyright 2015 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *     * Redistributions of source code must retain the above copyright
+ *	 notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *	 notice, this list of conditions and the following disclaimer in the
+ *	 documentation and/or other materials provided with the distribution.
+ *     * Neither the name of Freescale Semiconductor nor the
+ *	 names of its contributors may be used to endorse or promote products
+ *	 derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/ {
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		bman_fbpr: bman-fbpr {
+			size = <0 0x1000000>;
+			alignment = <0 0x1000000>;
+		};
+		qman_fqd: qman-fqd {
+			size = <0 0x400000>;
+			alignment = <0 0x400000>;
+		};
+		qman_pfdr: qman-pfdr {
+			size = <0 0x2000000>;
+			alignment = <0 0x2000000>;
+		};
+	};
+
+	ifc: localbus@ffe124000 {
+		reg = <0xf 0xfe124000 0 0x2000>;
+		ranges = <0 0 0xf 0xe8000000 0x08000000
+			  2 0 0xf 0xff800000 0x00010000
+			  3 0 0xf 0xffdf0000 0x00008000>;
+
+		nor@0,0 {
+			#address-cells = <1>;
+			#size-cells = <1>;
+			compatible = "cfi-flash";
+			reg = <0x0 0x0 0x8000000>;
+			bank-width = <2>;
+			device-width = <1>;
+		};
+
+		nand@2,0 {
+			#address-cells = <1>;
+			#size-cells = <1>;
+			compatible = "fsl,ifc-nand";
+			reg = <0x2 0x0 0x10000>;
+		};
+
+		cpld@3,0 {
+			compatible = "fsl,t1040d4rdb-cpld";
+			reg = <3 0 0x300>;
+		};
+	};
+
+	memory {
+		device_type = "memory";
+	};
+
+	dcsr: dcsr@f00000000 {
+		ranges = <0x00000000 0xf 0x00000000 0x01072000>;
+	};
+
+	bportals: bman-portals@ff4000000 {
+		ranges = <0x0 0xf 0xf4000000 0x2000000>;
+	};
+
+	qportals: qman-portals@ff6000000 {
+		ranges = <0x0 0xf 0xf6000000 0x2000000>;
+	};
+
+	soc: soc@ffe000000 {
+		ranges = <0x00000000 0xf 0xfe000000 0x1000000>;
+		reg = <0xf 0xfe000000 0 0x00001000>;
+
+		spi@110000 {
+			flash@0 {
+				#address-cells = <1>;
+				#size-cells = <1>;
+				compatible = "micron,n25q512ax3";
+				reg = <0>;
+				/* input clock */
+				spi-max-frequency = <10000000>;
+			};
+		};
+		i2c@118000 {
+			hwmon@4c {
+				compatible = "adi,adt7461";
+				reg = <0x4c>;
+			};
+
+			rtc@68 {
+				compatible = "dallas,ds1337";
+				reg = <0x68>;
+				interrupts = <0x2 0x1 0 0>;
+			};
+		};
+
+		i2c@118100 {
+			mux@77 {
+				compatible = "nxp,pca9546";
+				reg = <0x77>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+			};
+		};
+
+	};
+
+	pci0: pcie@ffe240000 {
+		reg = <0xf 0xfe240000 0 0x10000>;
+		ranges = <0x02000000 0 0xe0000000 0xc 0x0 0x0 0x10000000
+			  0x01000000 0 0x0 0xf 0xf8000000 0x0 0x00010000>;
+		pcie@0 {
+			ranges = <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+
+	pci1: pcie@ffe250000 {
+		reg = <0xf 0xfe250000 0 0x10000>;
+		ranges = <0x02000000 0 0xe0000000 0xc 0x10000000 0 0x10000000
+			  0x01000000 0 0 0xf 0xf8010000 0 0x00010000>;
+		pcie@0 {
+			ranges = <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+
+	pci2: pcie@ffe260000 {
+		reg = <0xf 0xfe260000 0 0x10000>;
+		ranges = <0x02000000 0 0xe0000000 0xc 0x20000000 0 0x10000000
+			  0x01000000 0 0x00000000 0xf 0xf8020000 0 0x00010000>;
+		pcie@0 {
+			ranges = <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+
+	pci3: pcie@ffe270000 {
+		reg = <0xf 0xfe270000 0 0x10000>;
+		ranges = <0x02000000 0 0xe0000000 0xc 0x30000000 0 0x10000000
+			  0x01000000 0 0x00000000 0xf 0xf8030000 0 0x00010000>;
+		pcie@0 {
+			ranges = <0x02000000 0 0xe0000000
+				  0x02000000 0 0xe0000000
+				  0 0x10000000
+
+				  0x01000000 0 0x00000000
+				  0x01000000 0 0x00000000
+				  0 0x00010000>;
+		};
+	};
+};
diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/corenet_generic.c
index bd839dc..b395571 100644
--- a/arch/powerpc/platforms/85xx/corenet_generic.c
+++ b/arch/powerpc/platforms/85xx/corenet_generic.c
@@ -153,6 +153,8 @@ static const char * const boards[] __initconst = {
 	"fsl,T1023RDB",
 	"fsl,T1024QDS",
 	"fsl,T1024RDB",
+	"fsl,T1040D4RDB",
+	"fsl,T1042D4RDB",
 	"fsl,T1040QDS",
 	"fsl,T1042QDS",
 	"fsl,T1040RDB",
-- 
1.7.4.1

Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Scott Wood]

On Wed, 2015-07-15 at 15:00 +0530, Priyanka Jain wrote:
> T1040D4RDB/T1042D4RDB are Freescale Reference Design Board
> which can support T1040/T1042 QorIQ Power
> Architecture™ processor respectively
> 
> T1040D4RDB/T1042D4RDB board Overview
> -------------------------------------
> - SERDES Connections, 8 lanes supporting:
>         - PCI
>         - SGMII
>         - SATA 2.0
>         - QSGMII(only for T1040D4RDB)
>     - DDR Controller
>         - Supports rates of up to 1600 MHz data-rate
>         - Supports one DDR4 UDIMM
>     -IFC/Local Bus
>         - NAND flash: 1GB 8-bit NAND flash
>         - NOR: 128MB 16-bit NOR Flash
>     - Ethernet
>         - Two on-board RGMII 10/100/1G ethernet ports.
>         - PHY #0 remains powered up during deep-sleep
>     - CPLD
>     - Clocks
>         - System and DDR clock (SYSCLK, “DDRCLK”)
>         - SERDES clocks
>     - Power Supplies
>     - USB
>         - Supports two USB 2.0 ports with integrated PHYs
>         - Two type A ports with  5V@1.5Aper port.
>     - SDHC
>         - SDHC/SDXC connector
>     - SPI
>         - On-board 64MB SPI flash
>     - I2C
>         - Devices connected: EEPROM, thermal monitor, VID controller
>     - Other IO
>         - Two Serial ports
>         - ProfiBus port
> 
>     Add support for T1040/T1042D4RDB board:
>     -add device tree
>     -Add entry in corenet_generic.c
> 
> Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
> ---
>  Changes for v2:
>       Incorporated Scott's comments on device tree

You didn't respond to the comments on the CPLD node.

+                i2c@118100{
> +                      mux@77{
> +                             compatible = "nxp,pca9546";
> +                             reg = <0x77>;
> +                             #address-cells = <1>;
> +                             #size-cells = <0>;
> +                     };
> +             };

A mux with no nodes under it (and yet it has #address-cells/#size-cells)?  
What is it multiplexing?

-Scott

RE: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Priyanka Jain]

DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBXb29kIFNjb3R0LUIwNzQyMSAN
ClNlbnQ6IFdlZG5lc2RheSwgSnVseSAxNSwgMjAxNSAxMToxNyBQTQ0KVG86IEphaW4gUHJpeWFu
a2EtQjMyMTY3DQpDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmcNClN1YmplY3Q6IFJl
OiBbUEFUQ0hdW3YyXSBwb3dlcnBjL2ZzbC1ib29rZTogQWRkIFQxMDQwRDRSREIvVDEwNDJENFJE
QiBib2FyZCBzdXBwb3J0DQoNCk9uIFdlZCwgMjAxNS0wNy0xNSBhdCAxNTowMCArMDUzMCwgUHJp
eWFua2EgSmFpbiB3cm90ZToNCj4gVDEwNDBENFJEQi9UMTA0MkQ0UkRCIGFyZSBGcmVlc2NhbGUg
UmVmZXJlbmNlIERlc2lnbiBCb2FyZCB3aGljaCBjYW4gDQo+IHN1cHBvcnQgVDEwNDAvVDEwNDIg
UW9ySVEgUG93ZXIgQXJjaGl0ZWN0dXJl4oSiIHByb2Nlc3NvciByZXNwZWN0aXZlbHkNCj4gDQo+
IFQxMDQwRDRSREIvVDEwNDJENFJEQiBib2FyZCBPdmVydmlldw0KPiAtLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+IC0gU0VSREVTIENvbm5lY3Rpb25zLCA4IGxhbmVzIHN1
cHBvcnRpbmc6DQo+ICAgICAgICAgLSBQQ0kNCj4gICAgICAgICAtIFNHTUlJDQo+ICAgICAgICAg
LSBTQVRBIDIuMA0KPiAgICAgICAgIC0gUVNHTUlJKG9ubHkgZm9yIFQxMDQwRDRSREIpDQo+ICAg
ICAtIEREUiBDb250cm9sbGVyDQo+ICAgICAgICAgLSBTdXBwb3J0cyByYXRlcyBvZiB1cCB0byAx
NjAwIE1IeiBkYXRhLXJhdGUNCj4gICAgICAgICAtIFN1cHBvcnRzIG9uZSBERFI0IFVESU1NDQo+
ICAgICAtSUZDL0xvY2FsIEJ1cw0KPiAgICAgICAgIC0gTkFORCBmbGFzaDogMUdCIDgtYml0IE5B
TkQgZmxhc2gNCj4gICAgICAgICAtIE5PUjogMTI4TUIgMTYtYml0IE5PUiBGbGFzaA0KPiAgICAg
LSBFdGhlcm5ldA0KPiAgICAgICAgIC0gVHdvIG9uLWJvYXJkIFJHTUlJIDEwLzEwMC8xRyBldGhl
cm5ldCBwb3J0cy4NCj4gICAgICAgICAtIFBIWSAjMCByZW1haW5zIHBvd2VyZWQgdXAgZHVyaW5n
IGRlZXAtc2xlZXANCj4gICAgIC0gQ1BMRA0KPiAgICAgLSBDbG9ja3MNCj4gICAgICAgICAtIFN5
c3RlbSBhbmQgRERSIGNsb2NrIChTWVNDTEssIOKAnEREUkNMS+KAnSkNCj4gICAgICAgICAtIFNF
UkRFUyBjbG9ja3MNCj4gICAgIC0gUG93ZXIgU3VwcGxpZXMNCj4gICAgIC0gVVNCDQo+ICAgICAg
ICAgLSBTdXBwb3J0cyB0d28gVVNCIDIuMCBwb3J0cyB3aXRoIGludGVncmF0ZWQgUEhZcw0KPiAg
ICAgICAgIC0gVHdvIHR5cGUgQSBwb3J0cyB3aXRoICA1VkAxLjVBcGVyIHBvcnQuDQo+ICAgICAt
IFNESEMNCj4gICAgICAgICAtIFNESEMvU0RYQyBjb25uZWN0b3INCj4gICAgIC0gU1BJDQo+ICAg
ICAgICAgLSBPbi1ib2FyZCA2NE1CIFNQSSBmbGFzaA0KPiAgICAgLSBJMkMNCj4gICAgICAgICAt
IERldmljZXMgY29ubmVjdGVkOiBFRVBST00sIHRoZXJtYWwgbW9uaXRvciwgVklEIGNvbnRyb2xs
ZXINCj4gICAgIC0gT3RoZXIgSU8NCj4gICAgICAgICAtIFR3byBTZXJpYWwgcG9ydHMNCj4gICAg
ICAgICAtIFByb2ZpQnVzIHBvcnQNCj4gDQo+ICAgICBBZGQgc3VwcG9ydCBmb3IgVDEwNDAvVDEw
NDJENFJEQiBib2FyZDoNCj4gICAgIC1hZGQgZGV2aWNlIHRyZWUNCj4gICAgIC1BZGQgZW50cnkg
aW4gY29yZW5ldF9nZW5lcmljLmMNCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFByaXlhbmthIEphaW4g
PFByaXlhbmthLkphaW5AZnJlZXNjYWxlLmNvbT4NCj4gLS0tDQo+ICBDaGFuZ2VzIGZvciB2MjoN
Cj4gICAgICAgSW5jb3Jwb3JhdGVkIFNjb3R0J3MgY29tbWVudHMgb24gZGV2aWNlIHRyZWUNCg0K
WW91IGRpZG4ndCByZXNwb25kIHRvIHRoZSBjb21tZW50cyBvbiB0aGUgQ1BMRCBub2RlLg0KW1By
aXlhbmthXQ0KVDEwNDJENFJEQiwgIFQxMDQwRDRSREIgYXJlIGRlcml2YXRpdmVzIG9mIHNhbWUg
Ym9hcmQgLCBDUExEIGlzIHNhbWUgZm9yIGJvdGguDQpTbywgSSBoYXZlIG1vdmVkIGJlbG93IG5v
ZGUgaGF2aW5nIGNvbXBhdGlibGUgYW5kIHJlZyBmaWVsZCB0b2dldGhlciBpbiB0MTA0eGQ0cmRi
LmR0c2kuDQpJcyB0aGlzIGZpbmU/DQoJCWNwbGRAMywwIHsNCgkJCWNvbXBhdGlibGUgPSAiZnNs
LHQxMDQwZDRyZGItY3BsZCI7DQoJCQlyZWcgPSA8MyAwIDB4MzAwPjsNCgkJfTsNCg0KDQorICAg
ICAgICAgICAgICAgIGkyY0AxMTgxMDB7DQo+ICsgICAgICAgICAgICAgICAgICAgICAgbXV4QDc3
ew0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gIm54cCxwY2E5
NTQ2IjsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4Nzc+Ow0KPiAr
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwxPjsNCj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgI3NpemUtY2VsbHMgPSA8MD47DQo+ICsgICAgICAg
ICAgICAgICAgICAgICB9Ow0KPiArICAgICAgICAgICAgIH07DQoNCkEgbXV4IHdpdGggbm8gbm9k
ZXMgdW5kZXIgaXQgKGFuZCB5ZXQgaXQgaGFzICNhZGRyZXNzLWNlbGxzLyNzaXplLWNlbGxzKT8g
IA0KV2hhdCBpcyBpdCBtdWx0aXBsZXhpbmc/DQpbUHJpeWFua2FdOiBQQ0E5NTQ2IGlzIGkyYyBt
dXggZGV2aWNlICwgdG8gd2hpY2ggb3RoZXIgaTJjIGRldmljZXMgKHVwLXRvIDggKSBjYW4gYmUg
ZnVydGhlciBjb25uZWN0ZWQgb24gb3V0cHV0IGNoYW5uZWxzDQpPbiBUMTA0eEQ0UkRCLCAgY2hh
bm5lbCAwLCAxLCAzIGxpbmUgYXJlIGNvbm5lY3RlZCB0byBQRVggZGV2aWNlLCBDaGFubmVsIDIg
dG8gaGRtaSBpbnRlcmZhY2UgKGluaXRpYWxpemF0aW9uIGlzIGRvbmUgaW4gdS1ib290IG9ubHkp
LCBvdGhlciBjaGFubmVscyBhcmUgZ3JvdW5kZWQuIFNvLCBhcyBzdWNoIExpbnV4IGlzIG5vdCB1
c2luZyB0aGUgc2Vjb25kIGxldmVsIEkyQyBkZXZpY2VzIGNvbm5lY3RlZCBvbiB0aGlzIE1VWCBk
ZXZpY2UuIFNvLCBJIGhhdmUgbm90IHNob3duIG5leHQgbGV2ZWwgaGllcmFyY2h5Lg0KU2hvdWxk
IEkgcmVwbGFjZSAnbXV4JyB3aXRoIHNvbWUgb3RoZXIgbmFtZT8gLiBQbGVhc2Ugc3VnZ2VzdC4N
Cg0KDQotU2NvdHQNCg0K

Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Scott Wood]

On Thu, 2015-07-16 at 04:34 -0500, Jain Priyanka-B32167 wrote:
> 
> -----Original Message-----
> From: Wood Scott-B07421 
> Sent: Wednesday, July 15, 2015 11:17 PM
> To: Jain Priyanka-B32167
> Cc: linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board 
> support
> 
> On Wed, 2015-07-15 at 15:00 +0530, Priyanka Jain wrote:
> > T1040D4RDB/T1042D4RDB are Freescale Reference Design Board which can 
> > support T1040/T1042 QorIQ Power Architecture™ processor respectively
> > 
> > T1040D4RDB/T1042D4RDB board Overview
> > -------------------------------------
> > - SERDES Connections, 8 lanes supporting:
> >         - PCI
> >         - SGMII
> >         - SATA 2.0
> >         - QSGMII(only for T1040D4RDB)
> >     - DDR Controller
> >         - Supports rates of up to 1600 MHz data-rate
> >         - Supports one DDR4 UDIMM
> >     -IFC/Local Bus
> >         - NAND flash: 1GB 8-bit NAND flash
> >         - NOR: 128MB 16-bit NOR Flash
> >     - Ethernet
> >         - Two on-board RGMII 10/100/1G ethernet ports.
> >         - PHY #0 remains powered up during deep-sleep
> >     - CPLD
> >     - Clocks
> >         - System and DDR clock (SYSCLK, “DDRCLK”)
> >         - SERDES clocks
> >     - Power Supplies
> >     - USB
> >         - Supports two USB 2.0 ports with integrated PHYs
> >         - Two type A ports with   5V@1.5Aperport.
> >     - SDHC
> >         - SDHC/SDXC connector
> >     - SPI
> >         - On-board 64MB SPI flash
> >     - I2C
> >         - Devices connected: EEPROM, thermal monitor, VID controller
> >     - Other IO
> >         - Two Serial ports
> >         - ProfiBus port
> > 
> >     Add support for T1040/T1042D4RDB board:
> >     -add device tree
> >     -Add entry in corenet_generic.c
> > 
> > Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
> > ---
> >  Changes for v2:
> >       Incorporated Scott's comments on device tree
> 
> You didn't respond to the comments on the CPLD node.
> [Priyanka]
> T1042D4RDB,  T1040D4RDB are derivatives of same board , CPLD is same for 
> both.
> So, I have moved below node having compatible and reg field together in 
> t104xd4rdb.dtsi.
> Is this fine?
>               cpld@3,0 {
>                       compatible = "fsl,t1040d4rdb-cpld";
>                       reg = <3 0 0x300>;
>               };

If the CPLD image is exactly the same on both, this is fine.

> > +                i2c@118100{
> > +                      mux@77{
> > +                             compatible = "nxp,pca9546";
> > +                             reg = <0x77>;
> > +                             #address-cells = <1>;
> > +                             #size-cells = <0>;
> > +                     };
> > +             };
> 
> A mux with no nodes under it (and yet it has #address-cells/#size-cells)?  
> What is it multiplexing?
> [Priyanka]: PCA9546 is i2c mux device , to which other i2c devices (up-to 8 
> ) can be further connected on output channels
> On T104xD4RDB,  channel 0, 1, 3 line are connected to PEX device, Channel 2 
> to hdmi interface (initialization is done in u-boot only), other channels 
> are grounded. So, as such Linux is not using the second level I2C devices 
> connected on this MUX device. So, I have not shown next level hierarchy.
> Should I replace 'mux' with some other name? . Please suggest.

The device tree describes the hardware, not just what Linux uses... but what I
don't understand is why you describe the mux at all if you're not going to 
describe what goes underneath it.

-Scott

RE: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Priyanka Jain]

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogRnJpZGF5LCBKdWx5IDE3LCAyMDE1IDE6MDYgQU0NCj4gVG86IEphaW4gUHJp
eWFua2EtQjMyMTY3DQo+IENjOiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiBTdWJq
ZWN0OiBSZTogW1BBVENIXVt2Ml0gcG93ZXJwYy9mc2wtYm9va2U6IEFkZCBUMTA0MEQ0UkRCL1Qx
MDQyRDRSREINCj4gYm9hcmQgc3VwcG9ydA0KPiANCj4gT24gVGh1LCAyMDE1LTA3LTE2IGF0IDA0
OjM0IC0wNTAwLCBKYWluIFByaXlhbmthLUIzMjE2NyB3cm90ZToNCj4gPg0KPiA+IC0tLS0tT3Jp
Z2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiBTZW50
OiBXZWRuZXNkYXksIEp1bHkgMTUsIDIwMTUgMTE6MTcgUE0NCj4gPiBUbzogSmFpbiBQcml5YW5r
YS1CMzIxNjcNCj4gPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmcNCj4gPiBTdWJq
ZWN0OiBSZTogW1BBVENIXVt2Ml0gcG93ZXJwYy9mc2wtYm9va2U6IEFkZA0KPiBUMTA0MEQ0UkRC
L1QxMDQyRDRSREINCj4gPiBib2FyZCBzdXBwb3J0DQo+ID4NCj4gPiBPbiBXZWQsIDIwMTUtMDct
MTUgYXQgMTU6MDAgKzA1MzAsIFByaXlhbmthIEphaW4gd3JvdGU6DQo+ID4gPiBUMTA0MEQ0UkRC
L1QxMDQyRDRSREIgYXJlIEZyZWVzY2FsZSBSZWZlcmVuY2UgRGVzaWduIEJvYXJkIHdoaWNoDQo+
IGNhbg0KPiA+ID4gc3VwcG9ydCBUMTA0MC9UMTA0MiBRb3JJUSBQb3dlciBBcmNoaXRlY3R1cmXi
hKIgcHJvY2Vzc29yIHJlc3BlY3RpdmVseQ0KPiA+ID4NCj4gPiA+IFQxMDQwRDRSREIvVDEwNDJE
NFJEQiBib2FyZCBPdmVydmlldw0KPiA+ID4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLQ0KPiA+ID4gLSBTRVJERVMgQ29ubmVjdGlvbnMsIDggbGFuZXMgc3VwcG9ydGluZzoN
Cj4gPiA+ICAgICAgICAgLSBQQ0kNCj4gPiA+ICAgICAgICAgLSBTR01JSQ0KPiA+ID4gICAgICAg
ICAtIFNBVEEgMi4wDQo+ID4gPiAgICAgICAgIC0gUVNHTUlJKG9ubHkgZm9yIFQxMDQwRDRSREIp
DQo+ID4gPiAgICAgLSBERFIgQ29udHJvbGxlcg0KPiA+ID4gICAgICAgICAtIFN1cHBvcnRzIHJh
dGVzIG9mIHVwIHRvIDE2MDAgTUh6IGRhdGEtcmF0ZQ0KPiA+ID4gICAgICAgICAtIFN1cHBvcnRz
IG9uZSBERFI0IFVESU1NDQo+ID4gPiAgICAgLUlGQy9Mb2NhbCBCdXMNCj4gPiA+ICAgICAgICAg
LSBOQU5EIGZsYXNoOiAxR0IgOC1iaXQgTkFORCBmbGFzaA0KPiA+ID4gICAgICAgICAtIE5PUjog
MTI4TUIgMTYtYml0IE5PUiBGbGFzaA0KPiA+ID4gICAgIC0gRXRoZXJuZXQNCj4gPiA+ICAgICAg
ICAgLSBUd28gb24tYm9hcmQgUkdNSUkgMTAvMTAwLzFHIGV0aGVybmV0IHBvcnRzLg0KPiA+ID4g
ICAgICAgICAtIFBIWSAjMCByZW1haW5zIHBvd2VyZWQgdXAgZHVyaW5nIGRlZXAtc2xlZXANCj4g
PiA+ICAgICAtIENQTEQNCj4gPiA+ICAgICAtIENsb2Nrcw0KPiA+ID4gICAgICAgICAtIFN5c3Rl
bSBhbmQgRERSIGNsb2NrIChTWVNDTEssIOKAnEREUkNMS+KAnSkNCj4gPiA+ICAgICAgICAgLSBT
RVJERVMgY2xvY2tzDQo+ID4gPiAgICAgLSBQb3dlciBTdXBwbGllcw0KPiA+ID4gICAgIC0gVVNC
DQo+ID4gPiAgICAgICAgIC0gU3VwcG9ydHMgdHdvIFVTQiAyLjAgcG9ydHMgd2l0aCBpbnRlZ3Jh
dGVkIFBIWXMNCj4gPiA+ICAgICAgICAgLSBUd28gdHlwZSBBIHBvcnRzIHdpdGggICA1VkAxLjVB
cGVycG9ydC4NCj4gPiA+ICAgICAtIFNESEMNCj4gPiA+ICAgICAgICAgLSBTREhDL1NEWEMgY29u
bmVjdG9yDQo+ID4gPiAgICAgLSBTUEkNCj4gPiA+ICAgICAgICAgLSBPbi1ib2FyZCA2NE1CIFNQ
SSBmbGFzaA0KPiA+ID4gICAgIC0gSTJDDQo+ID4gPiAgICAgICAgIC0gRGV2aWNlcyBjb25uZWN0
ZWQ6IEVFUFJPTSwgdGhlcm1hbCBtb25pdG9yLCBWSUQgY29udHJvbGxlcg0KPiA+ID4gICAgIC0g
T3RoZXIgSU8NCj4gPiA+ICAgICAgICAgLSBUd28gU2VyaWFsIHBvcnRzDQo+ID4gPiAgICAgICAg
IC0gUHJvZmlCdXMgcG9ydA0KPiA+ID4NCj4gPiA+ICAgICBBZGQgc3VwcG9ydCBmb3IgVDEwNDAv
VDEwNDJENFJEQiBib2FyZDoNCj4gPiA+ICAgICAtYWRkIGRldmljZSB0cmVlDQo+ID4gPiAgICAg
LUFkZCBlbnRyeSBpbiBjb3JlbmV0X2dlbmVyaWMuYw0KPiA+ID4NCj4gPiA+IFNpZ25lZC1vZmYt
Ynk6IFByaXlhbmthIEphaW4gPFByaXlhbmthLkphaW5AZnJlZXNjYWxlLmNvbT4NCj4gPiA+IC0t
LQ0KPiA+ID4gIENoYW5nZXMgZm9yIHYyOg0KPiA+ID4gICAgICAgSW5jb3Jwb3JhdGVkIFNjb3R0
J3MgY29tbWVudHMgb24gZGV2aWNlIHRyZWUNCj4gPg0KPiA+IFlvdSBkaWRuJ3QgcmVzcG9uZCB0
byB0aGUgY29tbWVudHMgb24gdGhlIENQTEQgbm9kZS4NCj4gPiBbUHJpeWFua2FdDQo+ID4gVDEw
NDJENFJEQiwgIFQxMDQwRDRSREIgYXJlIGRlcml2YXRpdmVzIG9mIHNhbWUgYm9hcmQgLCBDUExE
IGlzIHNhbWUNCj4gPiBmb3IgYm90aC4NCj4gPiBTbywgSSBoYXZlIG1vdmVkIGJlbG93IG5vZGUg
aGF2aW5nIGNvbXBhdGlibGUgYW5kIHJlZyBmaWVsZCB0b2dldGhlcg0KPiA+IGluIHQxMDR4ZDRy
ZGIuZHRzaS4NCj4gPiBJcyB0aGlzIGZpbmU/DQo+ID4gICAgICAgICAgICAgICBjcGxkQDMsMCB7
DQo+ID4gICAgICAgICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAiZnNsLHQxMDQwZDRyZGIt
Y3BsZCI7DQo+ID4gICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwzIDAgMHgzMDA+Ow0KPiA+
ICAgICAgICAgICAgICAgfTsNCj4gDQo+IElmIHRoZSBDUExEIGltYWdlIGlzIGV4YWN0bHkgdGhl
IHNhbWUgb24gYm90aCwgdGhpcyBpcyBmaW5lLg0KPiANCj4gPiA+ICsgICAgICAgICAgICAgICAg
aTJjQDExODEwMHsNCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgbXV4QDc3ew0KPiA+ID4g
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJueHAscGNhOTU0NiI7
DQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MHg3Nz47DQo+ID4g
PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwxPjsNCj4g
PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICNzaXplLWNlbGxzID0gPDA+Ow0KPiA+
ID4gKyAgICAgICAgICAgICAgICAgICAgIH07DQo+ID4gPiArICAgICAgICAgICAgIH07DQo+ID4N
Cj4gPiBBIG11eCB3aXRoIG5vIG5vZGVzIHVuZGVyIGl0IChhbmQgeWV0IGl0IGhhcyAjYWRkcmVz
cy1jZWxscy8jc2l6ZS1jZWxscyk/DQo+ID4gV2hhdCBpcyBpdCBtdWx0aXBsZXhpbmc/DQo+ID4g
W1ByaXlhbmthXTogUENBOTU0NiBpcyBpMmMgbXV4IGRldmljZSAsIHRvIHdoaWNoIG90aGVyIGky
YyBkZXZpY2VzDQo+ID4gKHVwLXRvIDgNCj4gPiApIGNhbiBiZSBmdXJ0aGVyIGNvbm5lY3RlZCBv
biBvdXRwdXQgY2hhbm5lbHMgT24gVDEwNHhENFJEQiwgIGNoYW5uZWwNCj4gPiAwLCAxLCAzIGxp
bmUgYXJlIGNvbm5lY3RlZCB0byBQRVggZGV2aWNlLCBDaGFubmVsIDIgdG8gaGRtaSBpbnRlcmZh
Y2UNCj4gPiAoaW5pdGlhbGl6YXRpb24gaXMgZG9uZSBpbiB1LWJvb3Qgb25seSksIG90aGVyIGNo
YW5uZWxzIGFyZSBncm91bmRlZC4NCj4gPiBTbywgYXMgc3VjaCBMaW51eCBpcyBub3QgdXNpbmcg
dGhlIHNlY29uZCBsZXZlbCBJMkMgZGV2aWNlcyBjb25uZWN0ZWQNCj4gPiBvbiB0aGlzIE1VWCBk
ZXZpY2UuIFNvLCBJIGhhdmUgbm90IHNob3duIG5leHQgbGV2ZWwgaGllcmFyY2h5Lg0KPiA+IFNo
b3VsZCBJIHJlcGxhY2UgJ211eCcgd2l0aCBzb21lIG90aGVyIG5hbWU/IC4gUGxlYXNlIHN1Z2dl
c3QuDQo+IA0KPiBUaGUgZGV2aWNlIHRyZWUgZGVzY3JpYmVzIHRoZSBoYXJkd2FyZSwgbm90IGp1
c3Qgd2hhdCBMaW51eCB1c2VzLi4uIGJ1dCB3aGF0DQo+IEkgZG9uJ3QgdW5kZXJzdGFuZCBpcyB3
aHkgeW91IGRlc2NyaWJlIHRoZSBtdXggYXQgYWxsIGlmIHlvdSdyZSBub3QgZ29pbmcgdG8NCj4g
ZGVzY3JpYmUgd2hhdCBnb2VzIHVuZGVybmVhdGggaXQuDQo+IA0KW0phaW4gUHJpeWFua2EtQjMy
MTY3XSA6IElzIGJlbG93IGxvb2tzIE9LPw0KaTJjQDExODEwMHsNCiArICAgICAgICAgICAgICAg
ICAgICAgIGkyY0A3N3sNCiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxl
ID0gIm54cCxwY2E5NTQ2IjsNCiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8
MHg3Nz47DQogKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8
MT47DQogKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgI3NpemUtY2VsbHMgPSA8MD47DQog
KyAgICAgICAgICAgICAgICAgICAgIH07DQogKyAgICAgICAgICAgICB9Ow0KPiAtU2NvdHQNCg0K

Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Scott Wood]

On Fri, 2015-07-17 at 01:17 -0500, Jain Priyanka-B32167 wrote:
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, July 17, 2015 1:06 AM
> > To: Jain Priyanka-B32167
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB
> > board support
> > 
> > > > +                i2c@118100{
> > > > +                      mux@77{
> > > > +                             compatible = "nxp,pca9546";
> > > > +                             reg = <0x77>;
> > > > +                             #address-cells = <1>;
> > > > +                             #size-cells = <0>;
> > > > +                     };
> > > > +             };
> > > 
> > > A mux with no nodes under it (and yet it has #address-cells/#size-
> > > cells)?
> > > What is it multiplexing?
> > > [Priyanka]: PCA9546 is i2c mux device , to which other i2c devices
> > > (up-to 8
> > > ) can be further connected on output channels On T104xD4RDB,  channel
> > > 0, 1, 3 line are connected to PEX device, Channel 2 to hdmi interface
> > > (initialization is done in u-boot only), other channels are grounded.
> > > So, as such Linux is not using the second level I2C devices connected
> > > on this MUX device. So, I have not shown next level hierarchy.
> > > Should I replace 'mux' with some other name? . Please suggest.
> > 
> > The device tree describes the hardware, not just what Linux uses... but 
> > what
> > I don't understand is why you describe the mux at all if you're not going 
> > to
> > describe what goes underneath it.
> > 
> [Jain Priyanka-B32167] : Is below looks OK?
> i2c@118100{
>  +                      i2c@77{
>  +                             compatible = "nxp,pca9546";
>  +                             reg = <0x77>;
>  +                             #address-cells = <1>;
>  +                             #size-cells = <0>;
>  +                     };
>  +             };

Where in my above comment did it appear that I was complaining about the node 
name?

-Scott

RE: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Priyanka Jain]

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogRnJpZGF5LCBKdWx5IDE3LCAyMDE1IDEwOjM3IFBNDQo+IFRvOiBKYWluIFBy
aXlhbmthLUIzMjE2Nw0KPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmcNCj4gU3Vi
amVjdDogUmU6IFtQQVRDSF1bdjJdIHBvd2VycGMvZnNsLWJvb2tlOiBBZGQgVDEwNDBENFJEQi9U
MTA0MkQ0UkRCDQo+IGJvYXJkIHN1cHBvcnQNCj4gDQo+IE9uIEZyaSwgMjAxNS0wNy0xNyBhdCAw
MToxNyAtMDUwMCwgSmFpbiBQcml5YW5rYS1CMzIxNjcgd3JvdGU6DQo+ID4NCj4gPiA+IC0tLS0t
T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+
ID4gU2VudDogRnJpZGF5LCBKdWx5IDE3LCAyMDE1IDE6MDYgQU0NCj4gPiA+IFRvOiBKYWluIFBy
aXlhbmthLUIzMjE2Nw0KPiA+ID4gQ2M6IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+
ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIXVt2Ml0gcG93ZXJwYy9mc2wtYm9va2U6IEFkZA0KPiA+
ID4gVDEwNDBENFJEQi9UMTA0MkQ0UkRCIGJvYXJkIHN1cHBvcnQNCj4gPiA+DQo+ID4gPiA+ID4g
KyAgICAgICAgICAgICAgICBpMmNAMTE4MTAwew0KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAg
ICAgICAgbXV4QDc3ew0KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNv
bXBhdGlibGUgPSAibnhwLHBjYTk1NDYiOw0KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHJlZyA9IDwweDc3PjsNCj4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwxPjsNCj4gPiA+ID4gPiArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsNCj4gPiA+ID4gPiArICAgICAgICAgICAg
ICAgICAgICAgfTsNCj4gPiA+ID4gPiArICAgICAgICAgICAgIH07DQo+ID4gPiA+DQo+ID4gPiA+
IEEgbXV4IHdpdGggbm8gbm9kZXMgdW5kZXIgaXQgKGFuZCB5ZXQgaXQgaGFzICNhZGRyZXNzLWNl
bGxzLyNzaXplLQ0KPiA+ID4gPiBjZWxscyk/DQo+ID4gPiA+IFdoYXQgaXMgaXQgbXVsdGlwbGV4
aW5nPw0KPiA+ID4gPiBbUHJpeWFua2FdOiBQQ0E5NTQ2IGlzIGkyYyBtdXggZGV2aWNlICwgdG8g
d2hpY2ggb3RoZXIgaTJjIGRldmljZXMNCj4gPiA+ID4gKHVwLXRvIDgNCj4gPiA+ID4gKSBjYW4g
YmUgZnVydGhlciBjb25uZWN0ZWQgb24gb3V0cHV0IGNoYW5uZWxzIE9uIFQxMDR4RDRSREIsDQo+
ID4gPiA+IGNoYW5uZWwgMCwgMSwgMyBsaW5lIGFyZSBjb25uZWN0ZWQgdG8gUEVYIGRldmljZSwg
Q2hhbm5lbCAyIHRvDQo+ID4gPiA+IGhkbWkgaW50ZXJmYWNlIChpbml0aWFsaXphdGlvbiBpcyBk
b25lIGluIHUtYm9vdCBvbmx5KSwgb3RoZXIgY2hhbm5lbHMgYXJlDQo+IGdyb3VuZGVkLg0KPiA+
ID4gPiBTbywgYXMgc3VjaCBMaW51eCBpcyBub3QgdXNpbmcgdGhlIHNlY29uZCBsZXZlbCBJMkMg
ZGV2aWNlcw0KPiA+ID4gPiBjb25uZWN0ZWQgb24gdGhpcyBNVVggZGV2aWNlLiBTbywgSSBoYXZl
IG5vdCBzaG93biBuZXh0IGxldmVsDQo+IGhpZXJhcmNoeS4NCj4gPiA+ID4gU2hvdWxkIEkgcmVw
bGFjZSAnbXV4JyB3aXRoIHNvbWUgb3RoZXIgbmFtZT8gLiBQbGVhc2Ugc3VnZ2VzdC4NCj4gPiA+
DQo+ID4gPiBUaGUgZGV2aWNlIHRyZWUgZGVzY3JpYmVzIHRoZSBoYXJkd2FyZSwgbm90IGp1c3Qg
d2hhdCBMaW51eCB1c2VzLi4uDQo+ID4gPiBidXQgd2hhdCBJIGRvbid0IHVuZGVyc3RhbmQgaXMg
d2h5IHlvdSBkZXNjcmliZSB0aGUgbXV4IGF0IGFsbCBpZg0KPiA+ID4geW91J3JlIG5vdCBnb2lu
ZyB0byBkZXNjcmliZSB3aGF0IGdvZXMgdW5kZXJuZWF0aCBpdC4NCj4gPiA+DQo+ID4gW0phaW4g
UHJpeWFua2EtQjMyMTY3XSA6IElzIGJlbG93IGxvb2tzIE9LPw0KPiA+IGkyY0AxMTgxMDB7DQo+
ID4gICsgICAgICAgICAgICAgICAgICAgICAgaTJjQDc3ew0KPiA+ICArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBjb21wYXRpYmxlID0gIm54cCxwY2E5NTQ2IjsNCj4gPiAgKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4Nzc+Ow0KPiA+ICArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwxPjsNCj4gPiAgKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgI3NpemUtY2VsbHMgPSA8MD47DQo+ID4gICsgICAgICAgICAgICAgICAg
ICAgICB9Ow0KPiA+ICArICAgICAgICAgICAgIH07DQo+IA0KPiBXaGVyZSBpbiBteSBhYm92ZSBj
b21tZW50IGRpZCBpdCBhcHBlYXIgdGhhdCBJIHdhcyBjb21wbGFpbmluZyBhYm91dCB0aGUNCj4g
bm9kZSBuYW1lPw0KPiANCltKYWluIFByaXlhbmthLUIzMjE2N10NCkZyb20gd2hhdCBJIHVuZGVy
c3RhbmQ6DQpQQ0E5NTQ2IGlzIGEgbXV4IGRldmljZSBhbmQgaXQgd291bGQgYmUgZ29vZCBpZiB3
ZSB3ZXJlIGFibGUgdG8gcHJlc2VudCB0aGUgSTJDIGRldmljZXMgb24gb3V0cHV0IGxpbmVzIGFz
IHN1Ym5vZGVzIGxpa2UgaW4gY2FzZSBvZiBCNHFkcyBib2FyZCBhbmQgdGhlbiAnbXV4JyBuYW1l
IHdvdWxkIGhhdmUgbWFrZSBtb3JlIHNlbnNlLg0KQnV0IGluIGNhc2Ugb2YgVDEwNDBENFJEQiBi
b2FyZCwgb3V0cHV0IGkyYyBsaW5lcyBhcmUgZ29pbmcgdG8gUEVYIHNsb3RzLCBQQ0kgY29ubmVj
dG9yLiBJIGFtIG5vdCBhd2FyZSBvZiBob3cgdG8gcmVwcmVzZW50cyB0aGVtIGFzIHN1Yi1ub2Rl
cyBpbiBkdHMuDQo+IC1TY290dA0KDQo=

Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Scott Wood]

On Wed, 2015-07-22 at 05:49 -0500, Jain Priyanka-B32167 wrote:
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, July 17, 2015 10:37 PM
> > To: Jain Priyanka-B32167
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB
> > board support
> > 
> > On Fri, 2015-07-17 at 01:17 -0500, Jain Priyanka-B32167 wrote:
> > > 
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Friday, July 17, 2015 1:06 AM
> > > > To: Jain Priyanka-B32167
> > > > Cc: linuxppc-dev@lists.ozlabs.org
> > > > Subject: Re: [PATCH][v2] powerpc/fsl-booke: Add
> > > > T1040D4RDB/T1042D4RDB board support
> > > > 
> > > > > > +                i2c@118100{
> > > > > > +                      mux@77{
> > > > > > +                             compatible = "nxp,pca9546";
> > > > > > +                             reg = <0x77>;
> > > > > > +                             #address-cells = <1>;
> > > > > > +                             #size-cells = <0>;
> > > > > > +                     };
> > > > > > +             };
> > > > > 
> > > > > A mux with no nodes under it (and yet it has #address-cells/#size-
> > > > > cells)?
> > > > > What is it multiplexing?
> > > > > [Priyanka]: PCA9546 is i2c mux device , to which other i2c devices
> > > > > (up-to 8
> > > > > ) can be further connected on output channels On T104xD4RDB,
> > > > > channel 0, 1, 3 line are connected to PEX device, Channel 2 to
> > > > > hdmi interface (initialization is done in u-boot only), other 
> > > > > channels are
> > grounded.
> > > > > So, as such Linux is not using the second level I2C devices
> > > > > connected on this MUX device. So, I have not shown next level
> > hierarchy.
> > > > > Should I replace 'mux' with some other name? . Please suggest.
> > > > 
> > > > The device tree describes the hardware, not just what Linux uses...
> > > > but what I don't understand is why you describe the mux at all if
> > > > you're not going to describe what goes underneath it.
> > > > 
> > > [Jain Priyanka-B32167] : Is below looks OK?
> > > i2c@118100{
> > >  +                      i2c@77{
> > >  +                             compatible = "nxp,pca9546";
> > >  +                             reg = <0x77>;
> > >  +                             #address-cells = <1>;
> > >  +                             #size-cells = <0>;
> > >  +                     };
> > >  +             };
> > 
> > Where in my above comment did it appear that I was complaining about the
> > node name?
> > 
> [Jain Priyanka-B32167]
> From what I understand:
> PCA9546 is a mux device and it would be good if we were able to present the 
> I2C devices on output lines as subnodes like in case of B4qds board and 
> then 'mux' name would have make more sense.

The name "mux" makes more sense regardless.

> But in case of T1040D4RDB board, output i2c lines are going to PEX slots, 
> PCI connector. I am not aware of how to represents them as sub-nodes in dts.

OK, so you're saying the i2c devices are pluggable (and I'm assuming by "PEX 
slots" you just mean that the physical slot is repurposed, not that the PCI 
express protocol is involved)?  Making a non-runtime-enumerable bus be 
pluggable seems like a bad idea, but if that's really what has been done, 
there needs to be a device tree that represents the entire system, not just 
the motherboard.  This could be done either via a dts file that /include/s 
the motherboard dts, or via firmware dtb edits.  The dts for the motherboard 
should include the mux node with a comment explaining what the situation is.

-Scott

RE: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Priyanka Jain]

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogRnJpZGF5LCBKdWx5IDI0LCAyMDE1IDg6NTggUE0NCj4gVG86IEphaW4gUHJp
eWFua2EtQjMyMTY3DQo+IENjOiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiBTdWJq
ZWN0OiBSZTogW1BBVENIXVt2Ml0gcG93ZXJwYy9mc2wtYm9va2U6IEFkZCBUMTA0MEQ0UkRCL1Qx
MDQyRDRSREINCj4gYm9hcmQgc3VwcG9ydA0KPiANCj4gT24gV2VkLCAyMDE1LTA3LTIyIGF0IDA1
OjQ5IC0wNTAwLCBKYWluIFByaXlhbmthLUIzMjE2NyB3cm90ZToNCj4gPg0KPiA+ID4gLS0tLS1P
cmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+ID4g
PiBTZW50OiBGcmlkYXksIEp1bHkgMTcsIDIwMTUgMTA6MzcgUE0NCj4gPiA+IFRvOiBKYWluIFBy
aXlhbmthLUIzMjE2Nw0KPiA+ID4gQ2M6IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+
ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIXVt2Ml0gcG93ZXJwYy9mc2wtYm9va2U6IEFkZA0KPiA+
ID4gVDEwNDBENFJEQi9UMTA0MkQ0UkRCIGJvYXJkIHN1cHBvcnQNCj4gPiA+DQo+ID4gPiBPbiBG
cmksIDIwMTUtMDctMTcgYXQgMDE6MTcgLTA1MDAsIEphaW4gUHJpeWFua2EtQjMyMTY3IHdyb3Rl
Og0KPiA+ID4gPg0KPiA+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiA+
ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+ID4gPiBTZW50OiBGcmlkYXksIEp1bHkg
MTcsIDIwMTUgMTowNiBBTQ0KPiA+ID4gPiA+IFRvOiBKYWluIFByaXlhbmthLUIzMjE2Nw0KPiA+
ID4gPiA+IENjOiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiA+ID4gPiA+IFN1Ympl
Y3Q6IFJlOiBbUEFUQ0hdW3YyXSBwb3dlcnBjL2ZzbC1ib29rZTogQWRkDQo+ID4gPiA+ID4gVDEw
NDBENFJEQi9UMTA0MkQ0UkRCIGJvYXJkIHN1cHBvcnQNCj4gPiA+ID4gPg0KPiA+ID4gPiA+ID4g
PiArICAgICAgICAgICAgICAgIGkyY0AxMTgxMDB7DQo+ID4gPiA+ID4gPiA+ICsgICAgICAgICAg
ICAgICAgICAgICAgbXV4QDc3ew0KPiA+ID4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBjb21wYXRpYmxlID0gIm54cCxwY2E5NTQ2IjsNCj4gPiA+ID4gPiA+ID4gKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4Nzc+Ow0KPiA+ID4gPiA+ID4gPiArICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwxPjsNCj4gPiA+ID4g
PiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgI3NpemUtY2VsbHMgPSA8MD47DQo+
ID4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICB9Ow0KPiA+ID4gPiA+ID4gPiArICAg
ICAgICAgICAgIH07DQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gQSBtdXggd2l0aCBubyBub2Rl
cyB1bmRlciBpdCAoYW5kIHlldCBpdCBoYXMNCj4gPiA+ID4gPiA+ICNhZGRyZXNzLWNlbGxzLyNz
aXplLSBjZWxscyk/DQo+ID4gPiA+ID4gPiBXaGF0IGlzIGl0IG11bHRpcGxleGluZz8NCj4gPiA+
ID4gPiA+IFtQcml5YW5rYV06IFBDQTk1NDYgaXMgaTJjIG11eCBkZXZpY2UgLCB0byB3aGljaCBv
dGhlciBpMmMNCj4gPiA+ID4gPiA+IGRldmljZXMgKHVwLXRvIDgNCj4gPiA+ID4gPiA+ICkgY2Fu
IGJlIGZ1cnRoZXIgY29ubmVjdGVkIG9uIG91dHB1dCBjaGFubmVscyBPbiBUMTA0eEQ0UkRCLA0K
PiA+ID4gPiA+ID4gY2hhbm5lbCAwLCAxLCAzIGxpbmUgYXJlIGNvbm5lY3RlZCB0byBQRVggZGV2
aWNlLCBDaGFubmVsIDIgdG8NCj4gPiA+ID4gPiA+IGhkbWkgaW50ZXJmYWNlIChpbml0aWFsaXph
dGlvbiBpcyBkb25lIGluIHUtYm9vdCBvbmx5KSwgb3RoZXINCj4gPiA+ID4gPiA+IGNoYW5uZWxz
IGFyZQ0KPiA+ID4gZ3JvdW5kZWQuDQo+ID4gPiA+ID4gPiBTbywgYXMgc3VjaCBMaW51eCBpcyBu
b3QgdXNpbmcgdGhlIHNlY29uZCBsZXZlbCBJMkMgZGV2aWNlcw0KPiA+ID4gPiA+ID4gY29ubmVj
dGVkIG9uIHRoaXMgTVVYIGRldmljZS4gU28sIEkgaGF2ZSBub3Qgc2hvd24gbmV4dCBsZXZlbA0K
PiA+ID4gaGllcmFyY2h5Lg0KPiA+ID4gPiA+ID4gU2hvdWxkIEkgcmVwbGFjZSAnbXV4JyB3aXRo
IHNvbWUgb3RoZXIgbmFtZT8gLiBQbGVhc2Ugc3VnZ2VzdC4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+
IFRoZSBkZXZpY2UgdHJlZSBkZXNjcmliZXMgdGhlIGhhcmR3YXJlLCBub3QganVzdCB3aGF0IExp
bnV4IHVzZXMuLi4NCj4gPiA+ID4gPiBidXQgd2hhdCBJIGRvbid0IHVuZGVyc3RhbmQgaXMgd2h5
IHlvdSBkZXNjcmliZSB0aGUgbXV4IGF0IGFsbA0KPiA+ID4gPiA+IGlmIHlvdSdyZSBub3QgZ29p
bmcgdG8gZGVzY3JpYmUgd2hhdCBnb2VzIHVuZGVybmVhdGggaXQuDQo+ID4gPiA+ID4NCj4gPiA+
ID4gW0phaW4gUHJpeWFua2EtQjMyMTY3XSA6IElzIGJlbG93IGxvb2tzIE9LPw0KPiA+ID4gPiBp
MmNAMTE4MTAwew0KPiA+ID4gPiAgKyAgICAgICAgICAgICAgICAgICAgICBpMmNANzd7DQo+ID4g
PiA+ICArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gIm54cCxwY2E5
NTQ2IjsNCj4gPiA+ID4gICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweDc3
PjsNCj4gPiA+ID4gICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICNhZGRyZXNzLWNlbGxz
ID0gPDE+Ow0KPiA+ID4gPiAgKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgI3NpemUtY2Vs
bHMgPSA8MD47DQo+ID4gPiA+ICArICAgICAgICAgICAgICAgICAgICAgfTsNCj4gPiA+ID4gICsg
ICAgICAgICAgICAgfTsNCj4gPiA+DQo+ID4gPiBXaGVyZSBpbiBteSBhYm92ZSBjb21tZW50IGRp
ZCBpdCBhcHBlYXIgdGhhdCBJIHdhcyBjb21wbGFpbmluZyBhYm91dA0KPiA+ID4gdGhlIG5vZGUg
bmFtZT8NCj4gPiA+DQo+ID4gW0phaW4gUHJpeWFua2EtQjMyMTY3XQ0KPiA+IEZyb20gd2hhdCBJ
IHVuZGVyc3RhbmQ6DQo+ID4gUENBOTU0NiBpcyBhIG11eCBkZXZpY2UgYW5kIGl0IHdvdWxkIGJl
IGdvb2QgaWYgd2Ugd2VyZSBhYmxlIHRvDQo+ID4gcHJlc2VudCB0aGUgSTJDIGRldmljZXMgb24g
b3V0cHV0IGxpbmVzIGFzIHN1Ym5vZGVzIGxpa2UgaW4gY2FzZSBvZg0KPiA+IEI0cWRzIGJvYXJk
IGFuZCB0aGVuICdtdXgnIG5hbWUgd291bGQgaGF2ZSBtYWtlIG1vcmUgc2Vuc2UuDQo+IA0KPiBU
aGUgbmFtZSAibXV4IiBtYWtlcyBtb3JlIHNlbnNlIHJlZ2FyZGxlc3MuDQo+IA0KPiA+IEJ1dCBp
biBjYXNlIG9mIFQxMDQwRDRSREIgYm9hcmQsIG91dHB1dCBpMmMgbGluZXMgYXJlIGdvaW5nIHRv
IFBFWA0KPiA+IHNsb3RzLCBQQ0kgY29ubmVjdG9yLiBJIGFtIG5vdCBhd2FyZSBvZiBob3cgdG8g
cmVwcmVzZW50cyB0aGVtIGFzIHN1Yi0NCj4gbm9kZXMgaW4gZHRzLg0KPiANCj4gT0ssIHNvIHlv
dSdyZSBzYXlpbmcgdGhlIGkyYyBkZXZpY2VzIGFyZSBwbHVnZ2FibGUgKGFuZCBJJ20gYXNzdW1p
bmcgYnkgIlBFWA0KPiBzbG90cyIgeW91IGp1c3QgbWVhbiB0aGF0IHRoZSBwaHlzaWNhbCBzbG90
IGlzIHJlcHVycG9zZWQsIG5vdCB0aGF0IHRoZSBQQ0kNCj4gZXhwcmVzcyBwcm90b2NvbCBpcyBp
bnZvbHZlZCk/ICBNYWtpbmcgYSBub24tcnVudGltZS1lbnVtZXJhYmxlIGJ1cyBiZQ0KPiBwbHVn
Z2FibGUgc2VlbXMgbGlrZSBhIGJhZCBpZGVhLCBidXQgaWYgdGhhdCdzIHJlYWxseSB3aGF0IGhh
cyBiZWVuIGRvbmUsDQo+IHRoZXJlIG5lZWRzIHRvIGJlIGEgZGV2aWNlIHRyZWUgdGhhdCByZXBy
ZXNlbnRzIHRoZSBlbnRpcmUgc3lzdGVtLCBub3QganVzdA0KPiB0aGUgbW90aGVyYm9hcmQuICBU
aGlzIGNvdWxkIGJlIGRvbmUgZWl0aGVyIHZpYSBhIGR0cyBmaWxlIHRoYXQgL2luY2x1ZGUvcyB0
aGUNCj4gbW90aGVyYm9hcmQgZHRzLCBvciB2aWEgZmlybXdhcmUgZHRiIGVkaXRzLiAgVGhlIGR0
cyBmb3IgdGhlIG1vdGhlcmJvYXJkDQo+IHNob3VsZCBpbmNsdWRlIHRoZSBtdXggbm9kZSB3aXRo
IGEgY29tbWVudCBleHBsYWluaW5nIHdoYXQgdGhlIHNpdHVhdGlvbg0KPiBpcy4NCj4gDQpbSmFp
biBQcml5YW5rYS1CMzIxNjddIElzIHRoZSBiZWxvdyBjb21tZW50IGxvb2tzIE9LPw0KIk91dHB1
dCBJMkMgZGF0YSwgY2xvY2sgbGluZXMgKFNETy9TQzAsU0QxL1NDMSAsIFNEMi9TQzIsIFNEMy9T
QzMpIGFyZSBnb2luZyBtaW5pIFBDSSBjb25uZWN0b3Igc2xvdDEsIG1pbmkgUENJIGNvbm5lY3Rv
ciBzbG90MiwgSERNSSBjb25uZWN0b3IsIFBFWCBzbG90IHJlc3BlY3RpdmVseQ0KIFRoZSBzdWIt
bm9kZXMgd2lsbCBkZXBlbmQgdXBvbiB0aGUgZGV2aWNlIHRoYXQgd2lsbCBiZSBjb25uZWN0ZWQg
b24gdGhlc2Ugc2xvdHMiDQoNCj4gLVNjb3R0DQoNCg==

Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Scott Wood]

On Wed, 2015-07-29 at 04:07 -0500, Jain Priyanka-B32167 wrote:
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, July 24, 2015 8:58 PM
> > To: Jain Priyanka-B32167
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB
> > board support
> > 
> > OK, so you're saying the i2c devices are pluggable (and I'm assuming by 
> > "PEX
> > slots" you just mean that the physical slot is repurposed, not that the 
> > PCI
> > express protocol is involved)?  Making a non-runtime-enumerable bus be
> > pluggable seems like a bad idea, but if that's really what has been done,
> > there needs to be a device tree that represents the entire system, not 
> > just
> > the motherboard.  This could be done either via a dts file that 
> > /include/s the
> > motherboard dts, or via firmware dtb edits.  The dts for the motherboard
> > should include the mux node with a comment explaining what the situation
> > is.
> > 
> [Jain Priyanka-B32167] Is the below comment looks OK?
> "Output I2C data, clock lines (SDO/SC0,SD1/SC1 , SD2/SC2, SD3/SC3) are 
> going mini PCI connector slot1, mini PCI connector slot2, HDMI connector, 
> PEX slot respectively
>  The sub-nodes will depend upon the device that will be connected on these 
> slots"

How about:

"Child nodes depend on which i2c devices are connected via the mini PCI 

connector slot1, the mini PCI connector slot2, the HDMI connector, and the 

PEX slot.  Systems with such devices attached should provide a wrapper .dts 
file that includes this one, and adds those nodes."

-Scott

RE: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Priyanka Jain]

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogVGh1cnNkYXksIEp1bHkgMzAsIDIwMTUgMzo0NSBBTQ0KPiBUbzogSmFpbiBQ
cml5YW5rYS1CMzIxNjcNCj4gQ2M6IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+IFN1
YmplY3Q6IFJlOiBbUEFUQ0hdW3YyXSBwb3dlcnBjL2ZzbC1ib29rZTogQWRkIFQxMDQwRDRSREIv
VDEwNDJENFJEQg0KPiBib2FyZCBzdXBwb3J0DQo+IA0KPiBPbiBXZWQsIDIwMTUtMDctMjkgYXQg
MDQ6MDcgLTA1MDAsIEphaW4gUHJpeWFua2EtQjMyMTY3IHdyb3RlOg0KPiA+DQo+ID4gPiAtLS0t
LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4g
PiA+IFNlbnQ6IEZyaWRheSwgSnVseSAyNCwgMjAxNSA4OjU4IFBNDQo+ID4gPiBUbzogSmFpbiBQ
cml5YW5rYS1CMzIxNjcNCj4gPiA+IENjOiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0K
PiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSF1bdjJdIHBvd2VycGMvZnNsLWJvb2tlOiBBZGQNCj4g
PiA+IFQxMDQwRDRSREIvVDEwNDJENFJEQiBib2FyZCBzdXBwb3J0DQo+ID4gPg0KPiA+ID4gT0ss
IHNvIHlvdSdyZSBzYXlpbmcgdGhlIGkyYyBkZXZpY2VzIGFyZSBwbHVnZ2FibGUgKGFuZCBJJ20g
YXNzdW1pbmcNCj4gPiA+IGJ5ICJQRVggc2xvdHMiIHlvdSBqdXN0IG1lYW4gdGhhdCB0aGUgcGh5
c2ljYWwgc2xvdCBpcyByZXB1cnBvc2VkLA0KPiA+ID4gbm90IHRoYXQgdGhlIFBDSSBleHByZXNz
IHByb3RvY29sIGlzIGludm9sdmVkKT8gIE1ha2luZyBhDQo+ID4gPiBub24tcnVudGltZS1lbnVt
ZXJhYmxlIGJ1cyBiZSBwbHVnZ2FibGUgc2VlbXMgbGlrZSBhIGJhZCBpZGVhLCBidXQNCj4gPiA+
IGlmIHRoYXQncyByZWFsbHkgd2hhdCBoYXMgYmVlbiBkb25lLCB0aGVyZSBuZWVkcyB0byBiZSBh
IGRldmljZSB0cmVlDQo+ID4gPiB0aGF0IHJlcHJlc2VudHMgdGhlIGVudGlyZSBzeXN0ZW0sIG5v
dCBqdXN0IHRoZSBtb3RoZXJib2FyZC4gIFRoaXMNCj4gPiA+IGNvdWxkIGJlIGRvbmUgZWl0aGVy
IHZpYSBhIGR0cyBmaWxlIHRoYXQgL2luY2x1ZGUvcyB0aGUgbW90aGVyYm9hcmQNCj4gPiA+IGR0
cywgb3IgdmlhIGZpcm13YXJlIGR0YiBlZGl0cy4gIFRoZSBkdHMgZm9yIHRoZSBtb3RoZXJib2Fy
ZCBzaG91bGQNCj4gPiA+IGluY2x1ZGUgdGhlIG11eCBub2RlIHdpdGggYSBjb21tZW50IGV4cGxh
aW5pbmcgd2hhdCB0aGUgc2l0dWF0aW9uDQo+ID4gPiBpcy4NCj4gPiA+DQo+ID4gW0phaW4gUHJp
eWFua2EtQjMyMTY3XSBJcyB0aGUgYmVsb3cgY29tbWVudCBsb29rcyBPSz8NCj4gPiAiT3V0cHV0
IEkyQyBkYXRhLCBjbG9jayBsaW5lcyAoU0RPL1NDMCxTRDEvU0MxICwgU0QyL1NDMiwgU0QzL1ND
MykgYXJlDQo+ID4gZ29pbmcgbWluaSBQQ0kgY29ubmVjdG9yIHNsb3QxLCBtaW5pIFBDSSBjb25u
ZWN0b3Igc2xvdDIsIEhETUkNCj4gPiBjb25uZWN0b3IsIFBFWCBzbG90IHJlc3BlY3RpdmVseSAg
VGhlIHN1Yi1ub2RlcyB3aWxsIGRlcGVuZCB1cG9uIHRoZQ0KPiA+IGRldmljZSB0aGF0IHdpbGwg
YmUgY29ubmVjdGVkIG9uIHRoZXNlIHNsb3RzIg0KPiANCj4gSG93IGFib3V0Og0KPiANCj4gIkNo
aWxkIG5vZGVzIGRlcGVuZCBvbiB3aGljaCBpMmMgZGV2aWNlcyBhcmUgY29ubmVjdGVkIHZpYSB0
aGUgbWluaSBQQ0kNCj4gDQo+IGNvbm5lY3RvciBzbG90MSwgdGhlIG1pbmkgUENJIGNvbm5lY3Rv
ciBzbG90MiwgdGhlIEhETUkgY29ubmVjdG9yLCBhbmQgdGhlDQo+IA0KPiBQRVggc2xvdC4gIFN5
c3RlbXMgd2l0aCBzdWNoIGRldmljZXMgYXR0YWNoZWQgc2hvdWxkIHByb3ZpZGUgYSB3cmFwcGVy
IC5kdHMNCj4gZmlsZSB0aGF0IGluY2x1ZGVzIHRoaXMgb25lLCBhbmQgYWRkcyB0aG9zZSBub2Rl
cy4iDQo+IA0KW0phaW4gUHJpeWFua2EtQjMyMTY3XSBUaGFua3MsIFRoaXMgbG9va3MgZ29vZC4g
SSB3aWxsIHNlbmQgdGhlIHVwZGF0ZWQgcGF0Y2guDQo+IC1TY290dA0KDQo=