All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "usb: musb: host: rely on port_mode to call musb_start()" has been added to the 4.1-stable tree
@ 2015-07-30  1:49 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-07-30  1:49 UTC (permalink / raw)
  To: balbi, bigeasy, gregkh, nsekhar; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    usb: musb: host: rely on port_mode to call musb_start()

to the 4.1-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-musb-host-rely-on-port_mode-to-call-musb_start.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From be9d39881fc4fa39a64b6eed6bab5d9ee5125344 Mon Sep 17 00:00:00 2001
From: Felipe Balbi <balbi@ti.com>
Date: Tue, 2 Jun 2015 13:03:36 -0500
Subject: usb: musb: host: rely on port_mode to call musb_start()

From: Felipe Balbi <balbi@ti.com>

commit be9d39881fc4fa39a64b6eed6bab5d9ee5125344 upstream.

Currently, we're calling musb_start() twice for DRD ports
in some situations. This has been observed to cause enumeration
issues after suspend/resume cycles with AM335x.

In order to fix the problem, we just have to fix the check
on musb_has_gadget() so that it only returns true if
current mode is Host and ignore the fact that we have or
not a gadget driver loaded.

Fixes: ae44df2e21b5 (usb: musb: call musb_start() only once in OTG mode)
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Tested-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/musb/musb_virthub.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/usb/musb/musb_virthub.c
+++ b/drivers/usb/musb/musb_virthub.c
@@ -273,9 +273,7 @@ static int musb_has_gadget(struct musb *
 #ifdef CONFIG_USB_MUSB_HOST
 	return 1;
 #else
-	if (musb->port_mode == MUSB_PORT_MODE_HOST)
-		return 1;
-	return musb->g.dev.driver != NULL;
+	return musb->port_mode == MUSB_PORT_MODE_HOST;
 #endif
 }
 


Patches currently in stable-queue which might be from balbi@ti.com are

queue-4.1/usb-f_mass_storage-limit-number-of-reported-luns.patch
queue-4.1/usb-dwc3-reset-the-transfer-resource-index-on-set_interface.patch
queue-4.1/usb-musb-host-rely-on-port_mode-to-call-musb_start.patch
queue-4.1/usb-gadget-mv_udc_core-fix-phy_regs-i-o-memory-leak.patch
queue-4.1/usb-dwc3-gadget-don-t-clear-ep_busy-too-early.patch
queue-4.1/usb-gadget-composite-fix-null-pointer-dereference.patch
queue-4.1/usb-dwc3-gadget-return-error-if-command-sent-to-depcmd-register-fails.patch
queue-4.1/usb-phy-mxs-suspend-to-ram-causes-null-pointer-dereference.patch
queue-4.1/usb-gadget-f_fs-do-not-set-cancel-function-on-synchronous-read-write.patch
queue-4.1/usb-dwc3-gadget-return-error-if-command-sent-to-dgcmd-register-fails.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-07-30  1:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-30  1:49 Patch "usb: musb: host: rely on port_mode to call musb_start()" has been added to the 4.1-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.