All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i2c: designware: Make debug print in i2c_dw_isr() shorter
@ 2015-08-07 11:53 Jarkko Nikula
       [not found] ` <1438948383-20646-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Jarkko Nikula @ 2015-08-07 11:53 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Jarkko Nikula

Printing adapter name is irrelevant from this debug print and makes output
needlessly long. Having already device and functions names printed here is
enough for debugging.

While at it remove extra space from "enabled= 0x" and use "%#x" for
printing "0x" prefixed hexadecimal values.

Signed-off-by: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
This is my previous "[PATCH 1/2] i2c: designware: Remove space between
variable and its value in debug print" and "[PATCH 2/2] i2c: designware:
Remove adapter name from debug print in i2c_dw_isr()" squashed.
---
 drivers/i2c/busses/i2c-designware-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c
index 6f19a33773fe..cc98b2a75591 100644
--- a/drivers/i2c/busses/i2c-designware-core.c
+++ b/drivers/i2c/busses/i2c-designware-core.c
@@ -777,8 +777,8 @@ irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
 
 	enabled = dw_readl(dev, DW_IC_ENABLE);
 	stat = dw_readl(dev, DW_IC_RAW_INTR_STAT);
-	dev_dbg(dev->dev, "%s:  %s enabled= 0x%x stat=0x%x\n", __func__,
-		dev->adapter.name, enabled, stat);
+	dev_dbg(dev->dev, "%s: enabled=%#x stat=%#x\n", __func__,
+		enabled, stat);
 	if (!enabled || !(stat & ~DW_IC_INTR_ACTIVITY))
 		return IRQ_NONE;
 
-- 
2.4.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] i2c: designware: Make debug print in i2c_dw_isr() shorter
       [not found] ` <1438948383-20646-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
@ 2015-08-07 16:02   ` Wolfram Sang
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2015-08-07 16:02 UTC (permalink / raw)
  To: Jarkko Nikula; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

On Fri, Aug 07, 2015 at 02:53:03PM +0300, Jarkko Nikula wrote:
> Printing adapter name is irrelevant from this debug print and makes output
> needlessly long. Having already device and functions names printed here is
> enough for debugging.
> 
> While at it remove extra space from "enabled= 0x" and use "%#x" for
> printing "0x" prefixed hexadecimal values.
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-07 16:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-07 11:53 [PATCH] i2c: designware: Make debug print in i2c_dw_isr() shorter Jarkko Nikula
     [not found] ` <1438948383-20646-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-08-07 16:02   ` Wolfram Sang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.