All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] misc: eeprom: Export I2C module alias information in missing drivers
@ 2015-08-07 12:04 Javier Martinez Canillas
  2015-08-07 16:09 ` Wolfram Sang
  0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2015-08-07 12:04 UTC (permalink / raw)
  To: Jean Delvare; +Cc: Wolfram Sang, linux-kernel, Javier Martinez Canillas

The I2C core always reports the MODALIAS uevent as "i2c:<client name"
regardless if the driver later is match using the I2C id_table or the
of_match_table. So the driver needs to export the I2C table and this
be built into the module or udev won't have the necessary information
to auto load the correct module when the device is added.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
---

Changes since v1:
 - Remove MODULE_DEVICE_TABLE() from legacy eeprom driver.
   Suggested by Jean Delvare
 - Added Jean Delvare Reviewed-by tag.

 drivers/misc/eeprom/max6875.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/eeprom/max6875.c b/drivers/misc/eeprom/max6875.c
index 580ff9df5529..c74920cc3d18 100644
--- a/drivers/misc/eeprom/max6875.c
+++ b/drivers/misc/eeprom/max6875.c
@@ -197,6 +197,7 @@ static const struct i2c_device_id max6875_id[] = {
 	{ "max6875", 0 },
 	{ }
 };
+MODULE_DEVICE_TABLE(i2c, max6875_id);
 
 static struct i2c_driver max6875_driver = {
 	.driver = {
-- 
2.4.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] misc: eeprom: Export I2C module alias information in missing drivers
  2015-08-07 12:04 [PATCH v2] misc: eeprom: Export I2C module alias information in missing drivers Javier Martinez Canillas
@ 2015-08-07 16:09 ` Wolfram Sang
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2015-08-07 16:09 UTC (permalink / raw)
  To: Javier Martinez Canillas; +Cc: Jean Delvare, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

On Fri, Aug 07, 2015 at 02:04:19PM +0200, Javier Martinez Canillas wrote:
> The I2C core always reports the MODALIAS uevent as "i2c:<client name"
> regardless if the driver later is match using the I2C id_table or the
> of_match_table. So the driver needs to export the I2C table and this
> be built into the module or udev won't have the necessary information
> to auto load the correct module when the device is added.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-07 16:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-07 12:04 [PATCH v2] misc: eeprom: Export I2C module alias information in missing drivers Javier Martinez Canillas
2015-08-07 16:09 ` Wolfram Sang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.