[PATCH 1/2] usb: gadget: goku_udc: fix build break by adding missing 'break'

[PATCH 1/2] usb: gadget: goku_udc: fix build break by adding missing 'break'

[Robert Baldyga]

Add missing break after 'default' label to fix compilation error.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
---
 drivers/usb/gadget/udc/goku_udc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c
index 2b628b3..dbb51a4 100644
--- a/drivers/usb/gadget/udc/goku_udc.c
+++ b/drivers/usb/gadget/udc/goku_udc.c
@@ -1013,6 +1013,7 @@ static struct usb_ep *goku_match_ep(struct usb_gadget *g,
 		}
 		break;
 	default:
+		break;
 	}
 
 	return NULL;
-- 
1.9.1

[PATCH 2/2] usb: musb: gadget: fix build break by adding missing 'break'

[Robert Baldyga]

Add missing break after 'default' label to fix compilation error.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
---
 drivers/usb/musb/musb_gadget.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index 5f52bcb..31049d3 100644
--- a/drivers/usb/musb/musb_gadget.c
+++ b/drivers/usb/musb/musb_gadget.c
@@ -1706,6 +1706,7 @@ static struct usb_ep *musb_match_ep(struct usb_gadget *g,
 			ep = gadget_find_ep_by_name(g, "ep2out");
 		break;
 	default:
+		break;
 	}
 
 	if (ep && usb_gadget_ep_match_desc(g, ep, desc, ep_comp))
-- 
1.9.1

Re: [PATCH 1/2] usb: gadget: goku_udc: fix build break by adding missing 'break'

[Robert Baldyga]

Hi Felipe,

I see that you already fixed this in your tree. So only the second patch
is needed.

Thanks,
Robert

On 08/07/2015 02:13 PM, Robert Baldyga wrote:
> Add missing break after 'default' label to fix compilation error.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> ---
>  drivers/usb/gadget/udc/goku_udc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c
> index 2b628b3..dbb51a4 100644
> --- a/drivers/usb/gadget/udc/goku_udc.c
> +++ b/drivers/usb/gadget/udc/goku_udc.c
> @@ -1013,6 +1013,7 @@ static struct usb_ep *goku_match_ep(struct usb_gadget *g,
>  		}
>  		break;
>  	default:
> +		break;
>  	}
>  
>  	return NULL;
> 

Re: [PATCH 2/2] usb: musb: gadget: fix build break by adding missing 'break'

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

On Fri, Aug 07, 2015 at 02:13:34PM +0200, Robert Baldyga wrote:
> Add missing break after 'default' label to fix compilation error.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>

the funny thing is that this doesn't break with ARM build:

$ make ARCH=arm drivers/usb/musb/
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  UPD     include/config/kernel.release
  CHK     include/generated/utsrelease.h
  UPD     include/generated/utsrelease.h
make[1]: 'include/generated/mach-types.h' is up to date.
  CHK     include/generated/timeconst.h
  CHK     include/generated/bounds.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  LD      drivers/usb/musb/built-in.o
  CC [M]  drivers/usb/musb/musb_core.o
  CC [M]  drivers/usb/musb/musb_virthub.o
  CC [M]  drivers/usb/musb/musb_host.o
  CC [M]  drivers/usb/musb/musb_gadget_ep0.o
  CC [M]  drivers/usb/musb/musb_gadget.o
  CC [M]  drivers/usb/musb/musb_debugfs.o
  CC [M]  drivers/usb/musb/omap2430.o
  CC [M]  drivers/usb/musb/musb_dsps.o
  CC [M]  drivers/usb/musb/musb_am335x.o
  CC [M]  drivers/usb/musb/am35x.o
  CC [M]  drivers/usb/musb/sunxi.o
  CC [M]  drivers/usb/musb/tusb6010.o
  CC [M]  drivers/usb/musb/ux500.o
  LD [M]  drivers/usb/musb/musb_hdrc.o

oh well :-p

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]