All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "iwlwifi: mvm: fix antenna selection when BT is active" has been added to the 4.1-stable tree
@ 2015-08-08 21:06 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-08-08 21:06 UTC (permalink / raw)
  To: emmanuel.grumbach, gregkh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    iwlwifi: mvm: fix antenna selection when BT is active

to the 4.1-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     iwlwifi-mvm-fix-antenna-selection-when-bt-is-active.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 923a8c1d8069104726bde55c37cec66324ccc328 Mon Sep 17 00:00:00 2001
From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Date: Sun, 31 May 2015 21:44:22 +0300
Subject: iwlwifi: mvm: fix antenna selection when BT is active

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

commit 923a8c1d8069104726bde55c37cec66324ccc328 upstream.

When BT is active, we want to avoid the shared antenna for
management frame to make sure we don't disturb BT. There
was a bug in that code because it chose the antenna
BIT(ANT_A) where ANT_A is already a bitmap (0x1). This
means that the antenna chosen in the end was ANT_B.
While this is not optimal on devices with 2 antennas (it'd
disturb BT), it is critical on single antenna devices like
3160 which couldn't connect at all when BT was active.

This fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=97181

Fixes: 34c8b24ff284 ("iwlwifi: mvm: BT Coex - avoid the shared antenna for management frames")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/net/wireless/iwlwifi/mvm/tx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/wireless/iwlwifi/mvm/tx.c
+++ b/drivers/net/wireless/iwlwifi/mvm/tx.c
@@ -225,7 +225,7 @@ void iwl_mvm_set_tx_cmd_rate(struct iwl_
 
 	if (info->band == IEEE80211_BAND_2GHZ &&
 	    !iwl_mvm_bt_coex_is_shared_ant_avail(mvm))
-		rate_flags = BIT(mvm->cfg->non_shared_ant) << RATE_MCS_ANT_POS;
+		rate_flags = mvm->cfg->non_shared_ant << RATE_MCS_ANT_POS;
 	else
 		rate_flags =
 			BIT(mvm->mgmt_last_antenna_idx) << RATE_MCS_ANT_POS;


Patches currently in stable-queue which might be from emmanuel.grumbach@intel.com are

queue-4.1/iwlwifi-mvm-fix-antenna-selection-when-bt-is-active.patch
queue-4.1/iwlwifi-pcie-prepare-the-device-before-accessing-it.patch
queue-4.1/iwlwifi-nvm-remove-mac-address-byte-swapping-in-8000-family.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-08-08 21:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-08 21:06 Patch "iwlwifi: mvm: fix antenna selection when BT is active" has been added to the 4.1-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.