[meta-raspberrypi][PATCH 1/2] linux-raspberrypi: support configuration fragments

[meta-raspberrypi][PATCH 1/2] linux-raspberrypi: support configuration fragments

[Alex J Lennon]

- remove placeholder defconfig and custom copying logic
- use KBUILD_DEFCONFIG for default in-tree configurations instead
- do not replace all Yocto configured settings in do_configure_prepend

see: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474

Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
---
 recipes-kernel/linux/linux-raspberrypi.inc       | 15 ++++-----------
 recipes-kernel/linux/linux-raspberrypi/defconfig |  1 -
 recipes-kernel/linux/linux.inc                   |  6 +++---
 3 files changed, 7 insertions(+), 15 deletions(-)
 delete mode 100644 recipes-kernel/linux/linux-raspberrypi/defconfig

diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
index 7e36408..e38d905 100644
--- a/recipes-kernel/linux/linux-raspberrypi.inc
+++ b/recipes-kernel/linux/linux-raspberrypi.inc
@@ -6,17 +6,14 @@ SECTION = "kernel"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
-SRC_URI += " \
-        file://defconfig \
-        "
-
 COMPATIBLE_MACHINE = "raspberrypi"
 
 PV = "${LINUX_VERSION}+git${SRCREV}"
 
-# NOTE: For now we pull in the default config from the RPi kernel GIT tree.
-KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
-KERNEL_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
+KMACHINE ?= "${MACHINE}"
+KCONFIG_MODE = "--alldefconfig"
+KBUILD_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
+KBUILD_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
 
 # CMDLINE for raspberrypi
 CMDLINE = "dwc_otg.lpm_enable=0 console=ttyAMA0,115200 kgdboc=ttyAMA0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
@@ -38,10 +35,6 @@ python __anonymous () {
             d.setVar("DEPENDS", depends)
 }
 
-do_kernel_configme_prepend() {
-    install -m 0644 ${S}/arch/${ARCH}/configs/${KERNEL_DEFCONFIG} ${WORKDIR}/defconfig || die "No default configuration for ${MACHINE} / ${KERNEL_DEFCONFIG} available."
-}
-
 do_install_prepend() {
     install -d ${D}/lib/firmware
 }
diff --git a/recipes-kernel/linux/linux-raspberrypi/defconfig b/recipes-kernel/linux/linux-raspberrypi/defconfig
deleted file mode 100644
index ecbf32c..0000000
--- a/recipes-kernel/linux/linux-raspberrypi/defconfig
+++ /dev/null
@@ -1 +0,0 @@
-# Dummy file to get through do_kernel_configme.
diff --git a/recipes-kernel/linux/linux.inc b/recipes-kernel/linux/linux.inc
index fae78b7..103512b 100644
--- a/recipes-kernel/linux/linux.inc
+++ b/recipes-kernel/linux/linux.inc
@@ -33,8 +33,7 @@ kernel_configure_variable() {
 }
 
 do_configure_prepend() {
-    # Clean .config
-    echo "" > ${B}/.config
+    mv -f ${B}/.config ${B}/.config.patched
     CONF_SED_SCRIPT=""
 
     # oabi / eabi support
@@ -109,7 +108,8 @@ do_configure_prepend() {
 
     # Keep this the last line
     # Remove all modified configs and add the rest to .config
-    sed -e "${CONF_SED_SCRIPT}" < '${WORKDIR}/defconfig' >> '${B}/.config'
+    sed -e "${CONF_SED_SCRIPT}" < '${B}/.config.patched' >> '${B}/.config'
+    rm -f ${B}/.config.patched
 
     yes '' | oe_runmake oldconfig
 }
-- 
1.9.1

[meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Alex J Lennon]

Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
---
 recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
index e38d905..8024412 100644
--- a/recipes-kernel/linux/linux-raspberrypi.inc
+++ b/recipes-kernel/linux/linux-raspberrypi.inc
@@ -6,6 +6,10 @@ SECTION = "kernel"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
+SRC_URI += " \
+        file://build-in-audio.cfg \
+        "
+
 COMPATIBLE_MACHINE = "raspberrypi"
 
 PV = "${LINUX_VERSION}+git${SRCREV}"
-- 
1.9.1

Re: [meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Petter Mabäcker]

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]

 

2015-08-11 19:04 skrev Alex J Lennon: 

> Signed-off-by: Alex J
Lennon <ajlennon@dynamicdevices.co.uk>
> ---
>
recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++
> 1 file changed, 4
insertions(+)
> 
> diff --git
a/recipes-kernel/linux/linux-raspberrypi.inc
b/recipes-kernel/linux/linux-raspberrypi.inc
> index e38d905..8024412
100644
> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> +++
b/recipes-kernel/linux/linux-raspberrypi.inc
> @@ -6,6 +6,10 @@ SECTION
= "kernel"
> LICENSE = "GPLv2"
> LIC_FILES_CHKSUM =
"file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
> 
> +SRC_URI += "

> + file://build-in-audio.cfg [1] 
> + "
> +
> COMPATIBLE_MACHINE =
"raspberrypi"
> 
> PV = "${LINUX_VERSION}+git${SRCREV}"
> -- 
>
1.9.1

It seems like the file build-in-audio.cfg is missing from the
changeset? 

/Petter 

Petter Mabäcker

Technux
<petter@technux.se>
www.technux.se
 

Links:
------
[1]
file://build-in-audio.cfg

[-- Attachment #2: Type: text/html, Size: 1404 bytes --]

Re: [meta-raspberrypi][PATCH 1/2] linux-raspberrypi: support configuration fragments

[Petter Mabäcker]

[-- Attachment #1: Type: text/plain, Size: 3760 bytes --]

 

2015-08-11 19:04 skrev Alex J Lennon: 

> - remove placeholder
defconfig and custom copying logic
> - use KBUILD_DEFCONFIG for default
in-tree configurations instead
> - do not replace all Yocto configured
settings in do_configure_prepen
> 
> see:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474 [1]
> 
>
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
> ---
>
recipes-kernel/linux/linux-raspberrypi.inc | 15 ++++-----------
>
recipes-kernel/linux/linux-raspberrypi/defconfig | 1 -
>
recipes-kernel/linux/linux.inc | 6 +++---
> 3 files changed, 7
insertions(+), 15 deletions(-)
> delete mode 100644
recipes-kernel/linux/linux-raspberrypi/defconfig
> 
> diff --git
a/recipes-kernel/linux/linux-raspberrypi.inc
b/recipes-kernel/linux/linux-raspberrypi.inc
> index 7e36408..e38d905
100644
> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> +++
b/recipes-kernel/linux/linux-raspberrypi.inc
> @@ -6,17 +6,14 @@ SECTION
= "kernel"
> LICENSE = "GPLv2"
> LIC_FILES_CHKSUM =
"file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
> 
> -SRC_URI += "

> - file://defconfig 
> - "
> -
> COMPATIBLE_MACHINE = "raspberrypi"
>

> PV = "${LINUX_VERSION}+git${SRCREV}"
> 
> -# NOTE: For now we pull in
the default config from the RPi kernel GIT tree.
>
-KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
>
-KERNEL_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
> +KMACHINE ?=
"${MACHINE}"
> +KCONFIG_MODE = "--alldefconfig"
>
+KBUILD_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
>
+KBUILD_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
> 
> # CMDLINE for
raspberrypi
> CMDLINE = "dwc_otg.lpm_enable=0 console=ttyAMA0,115200
kgdboc=ttyAMA0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
> @@
-38,10 +35,6 @@ python __anonymous () {
> d.setVar("DEPENDS", depends)
>
}
> 
> -do_kernel_configme_prepend() {
> - install -m 0644
${S}/arch/${ARCH}/configs/${KERNEL_DEFCONFIG} ${WORKDIR}/defconfig ||
die "No default configuration for ${MACHINE} / ${KERNEL_DEFCONFIG}
available."
> -}
> -
> do_install_prepend() {
> install -d
${D}/lib/firmware
> }
> diff --git
a/recipes-kernel/linux/linux-raspberrypi/defconfig
b/recipes-kernel/linux/linux-raspberrypi/defconfig
> deleted file mode
100644
> index ecbf32c..0000000
> ---
a/recipes-kernel/linux/linux-raspberrypi/defconfig
> +++ /dev/null
> @@
-1 +0,0 @@
> -# Dummy file to get through do_kernel_configme.
> diff
--git a/recipes-kernel/linux/linux.inc
b/recipes-kernel/linux/linux.inc
> index fae78b7..103512b 100644
> ---
a/recipes-kernel/linux/linux.inc
> +++
b/recipes-kernel/linux/linux.inc
> @@ -33,8 +33,7 @@
kernel_configure_variable() {
> }
> 
> do_configure_prepend() {
> - #
Clean .config
> - echo "" > ${B}/.config
> + mv -f ${B}/.config
${B}/.config.patched
> CONF_SED_SCRIPT=""
> 
> # oabi / eabi support
>
@@ -109,7 +108,8 @@ do_configure_prepend() {
> 
> # Keep this the last
line
> # Remove all modified configs and add the rest to .config
> - sed
-e "${CONF_SED_SCRIPT}" < '${WORKDIR}/defconfig' >> '${B}/.config'
> +
sed -e "${CONF_SED_SCRIPT}" < '${B}/.config.patched' >> '${B}/.config'
>
+ rm -f ${B}/.config.patched
> 
> yes '' | oe_runmake oldconfig
> }
> --

> 1.9.1

Nice, some small comments only. Please write a short summary
of the feature (kernel-yocto: allow in-tree defconfig) but keep the
bugzilla as a reference for further info. Always good to have some
background found directly in the commit msg itself. Have you tested it
using both poky:master and poky:fido? 

BR, Petter 

Petter
Mabäcker

Technux <petter@technux.se>
www.technux.se



Links:
------
[1]
https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474

[-- Attachment #2: Type: text/html, Size: 4155 bytes --]

Re: [meta-raspberrypi][PATCH 1/2] linux-raspberrypi: support configuration fragments

[Alex J Lennon]

On 11/08/2015 19:54, Petter Mabäcker wrote:
> 2015-08-11 19:04 skrev Alex J Lennon:
> 
>> - remove placeholder defconfig and custom copying logic
>> - use KBUILD_DEFCONFIG for default in-tree configurations instead
>> - do not replace all Yocto configured settings in do_configure_prepen
>>
>> see: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474
>>
>> Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk <mailto:ajlennon@dynamicdevices.co.uk>>
>> ---
>>  recipes-kernel/linux/linux-raspberrypi.inc       | 15 ++++-----------
>>  recipes-kernel/linux/linux-raspberrypi/defconfig |  1 -
>>  recipes-kernel/linux/linux.inc                   |  6 +++---
>>  3 files changed, 7 insertions(+), 15 deletions(-)
>>  delete mode 100644 recipes-kernel/linux/linux-raspberrypi/defconfig
>>
>> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
>> index 7e36408..e38d905 100644
>> --- a/recipes-kernel/linux/linux-raspberrypi.inc
>> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
>> @@ -6,17 +6,14 @@ SECTION = "kernel"
>>  LICENSE = "GPLv2"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>>  
>> -SRC_URI += " \
>> -        file://defconfig \
>> -        "
>> -
>>  COMPATIBLE_MACHINE = "raspberrypi"
>>  
>>  PV = "${LINUX_VERSION}+git${SRCREV}"
>>  
>> -# NOTE: For now we pull in the default config from the RPi kernel GIT tree.
>> -KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
>> -KERNEL_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
>> +KMACHINE ?= "${MACHINE}"
>> +KCONFIG_MODE = "--alldefconfig"
>> +KBUILD_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
>> +KBUILD_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
>>  
>>  # CMDLINE for raspberrypi
>>  CMDLINE = "dwc_otg.lpm_enable=0 console=ttyAMA0,115200 kgdboc=ttyAMA0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
>> @@ -38,10 +35,6 @@ python __anonymous () {
>>              d.setVar("DEPENDS", depends)
>>  }
>>  
>> -do_kernel_configme_prepend() {
>> -    install -m 0644 ${S}/arch/${ARCH}/configs/${KERNEL_DEFCONFIG} ${WORKDIR}/defconfig || die "No default configuration for ${MACHINE} / ${KERNEL_DEFCONFIG} available."
>> -}
>> -
>>  do_install_prepend() {
>>      install -d ${D}/lib/firmware
>>  }
>> diff --git a/recipes-kernel/linux/linux-raspberrypi/defconfig b/recipes-kernel/linux/linux-raspberrypi/defconfig
>> deleted file mode 100644
>> index ecbf32c..0000000
>> --- a/recipes-kernel/linux/linux-raspberrypi/defconfig
>> +++ /dev/null
>> @@ -1 +0,0 @@
>> -# Dummy file to get through do_kernel_configme.
>> diff --git a/recipes-kernel/linux/linux.inc b/recipes-kernel/linux/linux.inc
>> index fae78b7..103512b 100644
>> --- a/recipes-kernel/linux/linux.inc
>> +++ b/recipes-kernel/linux/linux.inc
>> @@ -33,8 +33,7 @@ kernel_configure_variable() {
>>  }
>>  
>>  do_configure_prepend() {
>> -    # Clean .config
>> -    echo "" > ${B}/.config
>> +    mv -f ${B}/.config ${B}/.config.patched
>>      CONF_SED_SCRIPT=""
>>  
>>      # oabi / eabi support
>> @@ -109,7 +108,8 @@ do_configure_prepend() {
>>  
>>      # Keep this the last line
>>      # Remove all modified configs and add the rest to .config
>> -    sed -e "${CONF_SED_SCRIPT}" < '${WORKDIR}/defconfig' >> '${B}/.config'
>> +    sed -e "${CONF_SED_SCRIPT}" < '${B}/.config.patched' >> '${B}/.config'
>> +    rm -f ${B}/.config.patched
>>  
>>      yes '' | oe_runmake oldconfig
>>  }
>> -- 1.9.1
> 
> Nice, some small comments only. Please write a short summary of the
> feature (kernel-yocto: allow in-tree defconfig) but keep the bugzilla as
> a reference for further info. Always good to have some background found

This is seems a significant core change so I wanted to make sure these
individual changes were as easily searchable as possible in case any
problems arise in future. Can you provide an example of what you are
suggesting for the commit msg?

> directly in the commit msg itself. Have you tested it using both
> poky:master and poky:fido?

Rpi2 fido 3.18.16 with/without sound patch, 4.1.3 with/without sound patch.

BR,

Alex

Re: [meta-raspberrypi][PATCH 1/2] linux-raspberrypi: support configuration fragments

[Petter Mabäcker]

[-- Attachment #1: Type: text/plain, Size: 5185 bytes --]

 

2015-08-11 21:20 skrev Alex J Lennon: 

> On 11/08/2015 19:54,
Petter Mabäcker wrote:
> 
>> 2015-08-11 19:04 skrev Alex J Lennon: 
>>

>>> - remove placeholder defconfig and custom copying logic - use
KBUILD_DEFCONFIG for default in-tree configurations instead - do not
replace all Yocto configured settings in do_configure_prepen see:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474 [1]
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk
<mailto:ajlennon@dynamicdevices.co.uk>> ---
recipes-kernel/linux/linux-raspberrypi.inc | 15 ++++-----------
recipes-kernel/linux/linux-raspberrypi/defconfig | 1 -
recipes-kernel/linux/linux.inc | 6 +++--- 3 files changed, 7
insertions(+), 15 deletions(-) delete mode 100644
recipes-kernel/linux/linux-raspberrypi/defconfig diff --git
a/recipes-kernel/linux/linux-raspberrypi.inc
b/recipes-kernel/linux/linux-raspberrypi.inc index 7e36408..e38d905
100644 --- a/recipes-kernel/linux/linux-raspberrypi.inc +++
b/recipes-kernel/linux/linux-raspberrypi.inc @@ -6,17 +6,14 @@ SECTION =
"kernel" LICENSE = "GPLv2" LIC_FILES_CHKSUM =
"file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" -SRC_URI += " -
file://defconfig - " - COMPATIBLE_MACHINE = "raspberrypi" PV =
"${LINUX_VERSION}+git${SRCREV}" -# NOTE: For now we pull in the default
config from the RPi kernel GIT tree. -KERNEL_DEFCONFIG_raspberrypi ?=
"bcmrpi_defconfig" -KERNEL_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
+KMACHINE ?= "${MACHINE}" +KCONFIG_MODE = "--alldefconfig"
+KBUILD_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
+KBUILD_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig" # CMDLINE for
raspberrypi CMDLINE = "dwc_otg.lpm_enable=0 console=ttyAMA0,115200
kgdboc=ttyAMA0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait" @@
-38,10 +35,6 @@ python __anonymous () { d.setVar("DEPENDS", depends) }
-do_kernel_configme_prepend() { - install -m 0644
${S}/arch/${ARCH}/configs/${KERNEL_DEFCONFIG} ${WORKDIR}/defconfig ||
die "No default configuration for ${MACHINE} / ${KERNEL_DEFCONFIG}
available." -} - do_install_prepend() { install -d ${D}/lib/firmware }
diff --git a/recipes-kernel/linux/linux-raspberrypi/defconfig
b/recipes-kernel/linux/linux-raspberrypi/defconfig deleted file mode
100644 index ecbf32c..0000000 ---
a/recipes-kernel/linux/linux-raspberrypi/defconfig +++ /dev/null @@ -1
+0,0 @@ -# Dummy file to get through do_kernel_configme. diff --git
a/recipes-kernel/linux/linux.inc b/recipes-kernel/linux/linux.inc index
fae78b7..103512b 100644 --- a/recipes-kernel/linux/linux.inc +++
b/recipes-kernel/linux/linux.inc @@ -33,8 +33,7 @@
kernel_configure_variable() { } do_configure_prepend() { - # Clean
.config - echo "" > ${B}/.config + mv -f ${B}/.config
${B}/.config.patched CONF_SED_SCRIPT="" # oabi / eabi support @@ -109,7
+108,8 @@ do_configure_prepend() { # Keep this the last line # Remove
all modified configs and add the rest to .config - sed -e
"${CONF_SED_SCRIPT}" < '${WORKDIR}/defconfig' >> '${B}/.config' + sed -e
"${CONF_SED_SCRIPT}" < '${B}/.config.patched' >> '${B}/.config' + rm -f
${B}/.config.patched yes '' | oe_runmake oldconfig } -- 1.9.1
>> Nice,
some small comments only. Please write a short summary of the feature
(kernel-yocto: allow in-tree defconfig) but keep the bugzilla as a
reference for further info. Always good to have some background found
>

> This is seems a significant core change so I wanted to make sure
these
> individual changes were as easily searchable as possible in case
any
> problems arise in future. Can you provide an example of what you
are
> suggesting for the commit msg?

Perhaps something like:

Start
using the "in-tree defconfig" solution provided in poky[0]. To specify
an "in-tree" defconfig file, edit the recipe that builds your kernel so
that it has the following command form:

 KBUILD_DEFCONFIG_KMACHINE ?=
defconfig_file

You need to append the variable with KMACHINE and then
supply the path to your "in-tree" defconfig file. 

In order to achieve
this in meta-raspberrypi will need to:

- start using
KBUILD_DEFCONFIG_KMACHINE
- Remove placeholder defconfig and custom
copying logic.
- Avoid replacing all Yocto project configured settings
in do_configure_prepend.

For more background regarding this migration
read the bugzilla bug info[1].

[0] -
http://www.yoctoproject.org/docs/1.8/kernel-dev/kernel-dev.html#using-an-in-tree-defconfig-file
[1]
- https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474

>> directly
in the commit msg itself. Have you tested it using both poky:master and
poky:fido?
> 
> Rpi2 fido 3.18.16 with/without sound patch, 4.1.3
with/without sound patch.
> 
> BR,
> 
> Alex

Ok, since there has been
some changes (not only the early DT change) in poky:master it would be
good to do the same tests there. Andrei have to correct me if wrong, but
since we have a fido branch in meta-raspberrypi that's the branch that
is recommended to use against poky:fido, 'master' is in first place
verified against poky:master (latest and greatest). 

BR Petter


Links:
------
[1]
https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474

[-- Attachment #2: Type: text/html, Size: 6086 bytes --]

Re: [meta-raspberrypi][PATCH 1/2] linux-raspberrypi: support configuration fragments

[Alex J Lennon]

On 12/08/2015 09:08, Petter Mabäcker wrote:
> 2015-08-11 21:20 skrev Alex J Lennon:
> 
>> On 11/08/2015 19:54, Petter Mabäcker wrote:
>>> 2015-08-11 19:04 skrev Alex J Lennon:
>>>> - remove placeholder defconfig and custom copying logic - use
>>>> KBUILD_DEFCONFIG for default in-tree configurations instead - do not
>>>> replace all Yocto configured settings in do_configure_prepen see:
>>>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474
>>>> Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk
>>>> <mailto:ajlennon@dynamicdevices.co.uk>
>>>> <mailto:ajlennon@dynamicdevices.co.uk
>>>> <mailto:ajlennon@dynamicdevices.co.uk>>> ---
>>>> recipes-kernel/linux/linux-raspberrypi.inc | 15 ++++-----------
>>>> recipes-kernel/linux/linux-raspberrypi/defconfig | 1 -
>>>> recipes-kernel/linux/linux.inc | 6 +++--- 3 files changed, 7
>>>> insertions(+), 15 deletions(-) delete mode 100644
>>>> recipes-kernel/linux/linux-raspberrypi/defconfig diff --git
>>>> a/recipes-kernel/linux/linux-raspberrypi.inc
>>>> b/recipes-kernel/linux/linux-raspberrypi.inc index 7e36408..e38d905
>>>> 100644 --- a/recipes-kernel/linux/linux-raspberrypi.inc +++
>>>> b/recipes-kernel/linux/linux-raspberrypi.inc @@ -6,17 +6,14 @@
>>>> SECTION = "kernel" LICENSE = "GPLv2" LIC_FILES_CHKSUM =
>>>> "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" -SRC_URI += "
>>>> \ - file://defconfig \ - " - COMPATIBLE_MACHINE = "raspberrypi" PV =
>>>> "${LINUX_VERSION}+git${SRCREV}" -# NOTE: For now we pull in the
>>>> default config from the RPi kernel GIT tree.
>>>> -KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
>>>> -KERNEL_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig" +KMACHINE ?=
>>>> "${MACHINE}" +KCONFIG_MODE = "--alldefconfig"
>>>> +KBUILD_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
>>>> +KBUILD_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig" # CMDLINE for
>>>> raspberrypi CMDLINE = "dwc_otg.lpm_enable=0 console=ttyAMA0,115200
>>>> kgdboc=ttyAMA0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
>>>> @@ -38,10 +35,6 @@ python __anonymous () { d.setVar("DEPENDS",
>>>> depends) } -do_kernel_configme_prepend() { - install -m 0644
>>>> ${S}/arch/${ARCH}/configs/${KERNEL_DEFCONFIG} ${WORKDIR}/defconfig
>>>> || die "No default configuration for ${MACHINE} /
>>>> ${KERNEL_DEFCONFIG} available." -} - do_install_prepend() { install
>>>> -d ${D}/lib/firmware } diff --git
>>>> a/recipes-kernel/linux/linux-raspberrypi/defconfig
>>>> b/recipes-kernel/linux/linux-raspberrypi/defconfig deleted file mode
>>>> 100644 index ecbf32c..0000000 ---
>>>> a/recipes-kernel/linux/linux-raspberrypi/defconfig +++ /dev/null @@
>>>> -1 +0,0 @@ -# Dummy file to get through do_kernel_configme. diff
>>>> --git a/recipes-kernel/linux/linux.inc
>>>> b/recipes-kernel/linux/linux.inc index fae78b7..103512b 100644 ---
>>>> a/recipes-kernel/linux/linux.inc +++
>>>> b/recipes-kernel/linux/linux.inc @@ -33,8 +33,7 @@
>>>> kernel_configure_variable() { } do_configure_prepend() { - # Clean
>>>> .config - echo "" > ${B}/.config + mv -f ${B}/.config
>>>> ${B}/.config.patched CONF_SED_SCRIPT="" # oabi / eabi support @@
>>>> -109,7 +108,8 @@ do_configure_prepend() { # Keep this the last line
>>>> # Remove all modified configs and add the rest to .config - sed -e
>>>> "${CONF_SED_SCRIPT}" < '${WORKDIR}/defconfig' >> '${B}/.config' +
>>>> sed -e "${CONF_SED_SCRIPT}" < '${B}/.config.patched' >>
>>>> '${B}/.config' + rm -f ${B}/.config.patched yes '' | oe_runmake
>>>> oldconfig } -- 1.9.1
>>> Nice, some small comments only. Please write a short summary of the
>>> feature (kernel-yocto: allow in-tree defconfig) but keep the bugzilla
>>> as a reference for further info. Always good to have some background
>>> found
>> This is seems a significant core change so I wanted to make sure these
>> individual changes were as easily searchable as possible in case any
>> problems arise in future. Can you provide an example of what you are
>> suggesting for the commit msg?
> Perhaps something like:
> 
> Start using the "in-tree defconfig" solution provided in poky[0]. To specify an "in-tree" defconfig file, edit the recipe that builds your kernel so that it has the following command form:
> 
>      KBUILD_DEFCONFIG_KMACHINE ?= defconfig_file
>                 
> 
> You need to append the variable with KMACHINE and then supply the path to your "in-tree" defconfig file. 
> 
> In order to achieve this in meta-raspberrypi will need to:
> 
> - start using KBUILD_DEFCONFIG_KMACHINE
> - Remove placeholder defconfig and custom copying logic.
> - Avoid replacing all Yocto project configured settings in do_configure_prepend.
> 
> For more background regarding this migration read the bugzilla bug info[1].
> 
> [0] - http://www.yoctoproject.org/docs/1.8/kernel-dev/kernel-dev.html#using-an-in-tree-defconfig-file
> [1] - https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474
> 

Very comprehensive. Many thanks.

>>> directly in the commit msg itself. Have you tested it using both
>>> poky:master and poky:fido?
>> Rpi2 fido 3.18.16 with/without sound patch, 4.1.3 with/without sound patch.
>>
>> BR,
>>
>> Alex
> 
> Ok, since there has been some changes (not only the early DT change) in
> poky:master it would be good to do the same tests there. Andrei have to
> correct me if wrong, but since we have a fido branch in meta-raspberrypi
> that's the branch that is recommended to use against poky:fido, 'master'
> is in first place verified against poky:master (latest and greatest).
>

Four test builds was enough yesterday. I will look at master when I get
a chance. As we pursue the conversation on a review process a related
conversation is getting an automated build system going again as I think
it would be very useful in this context.

DynamicDevices may be able to help here. I had a very positive
experience with AppVeyor when I was putting the Mono Win32 automated
build system together and am wondering what's currently best for Linux
automated building (Jenkins?). Maybe that conversation is best broken
out in the Github vs Gerrit vs A.N.Other thread.

BR, Alex

Re: [meta-raspberrypi][PATCH 1/2] linux-raspberrypi: support configuration fragments

[Petter Mabäcker]

[-- Attachment #1: Type: text/plain, Size: 6516 bytes --]

 

2015-08-12 10:28 skrev Alex J Lennon: 

> On 12/08/2015 09:08,
Petter Mabäcker wrote:
> 
>> 2015-08-11 21:20 skrev Alex J Lennon: 
>>

>>> On 11/08/2015 19:54, Petter Mabäcker wrote: 
>>> 
>>>> 2015-08-11
19:04 skrev Alex J Lennon: 
>>>> 
>>>>> - remove placeholder defconfig
and custom copying logic - use KBUILD_DEFCONFIG for default in-tree
configurations instead - do not replace all Yocto configured settings in
do_configure_prepen see:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474 [1]
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk
<mailto:ajlennon@dynamicdevices.co.uk>
<mailto:ajlennon@dynamicdevices.co.uk
<mailto:ajlennon@dynamicdevices.co.uk>>> ---
recipes-kernel/linux/linux-raspberrypi.inc | 15 ++++-----------
recipes-kernel/linux/linux-raspberrypi/defconfig | 1 -
recipes-kernel/linux/linux.inc | 6 +++--- 3 files changed, 7
insertions(+), 15 deletions(-) delete mode 100644
recipes-kernel/linux/linux-raspberrypi/defconfig diff --git
a/recipes-kernel/linux/linux-raspberrypi.inc
b/recipes-kernel/linux/linux-raspberrypi.inc index 7e36408..e38d905
100644 --- a/recipes-kernel/linux/linux-raspberrypi.inc +++
b/recipes-kernel/linux/linux-raspberrypi.inc @@ -6,17 +6,14 @@ SECTION =
"kernel" LICENSE = "GPLv2" LIC_FILES_CHKSUM =
"file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" -SRC_URI += " -
file://defconfig - " - COMPATIBLE_MACHINE = "raspberrypi" PV =
"${LINUX_VERSION}+git${SRCREV}" -# NOTE: For now we pull in the default
config from the RPi kernel GIT tree. -KERNEL_DEFCONFIG_raspberrypi ?=
"bcmrpi_defconfig" -KERNEL_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
+KMACHINE ?= "${MACHINE}" +KCONFIG_MODE = "--alldefconfig"
+KBUILD_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
+KBUILD_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig" # CMDLINE for
raspberrypi CMDLINE = "dwc_otg.lpm_enable=0 console=ttyAMA0,115200
kgdboc=ttyAMA0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait" @@
-38,10 +35,6 @@ python __anonymous () { d.setVar("DEPENDS", depends) }
-do_kernel_configme_prepend() { - install -m 0644
${S}/arch/${ARCH}/configs/${KERNEL_DEFCONFIG} ${WORKDIR}/defconfig ||
die "No default configuration for ${MACHINE} / ${KERNEL_DEFCONFIG}
available." -} - do_install_prepend() { install -d ${D}/lib/firmware }
diff --git a/recipes-kernel/linux/linux-raspberrypi/defconfig
b/recipes-kernel/linux/linux-raspberrypi/defconfig deleted file mode
100644 index ecbf32c..0000000 ---
a/recipes-kernel/linux/linux-raspberrypi/defconfig +++ /dev/null @@ -1
+0,0 @@ -# Dummy file to get through do_kernel_configme. diff --git
a/recipes-kernel/linux/linux.inc b/recipes-kernel/linux/linux.inc index
fae78b7..103512b 100644 --- a/recipes-kernel/linux/linux.inc +++
b/recipes-kernel/linux/linux.inc @@ -33,8 +33,7 @@
kernel_configure_variable() { } do_configure_prepend() { - # Clean
.config - echo "" > ${B}/.config + mv -f ${B}/.config
${B}/.config.patched CONF_SED_SCRIPT="" # oabi / eabi support @@ -109,7
+108,8 @@ do_configure_prepend() { # Keep this the last line # Remove
all modified configs and add the rest to .config - sed -e
"${CONF_SED_SCRIPT}" < '${WORKDIR}/defconfig' >> '${B}/.config' + sed -e
"${CONF_SED_SCRIPT}" < '${B}/.config.patched' >> '${B}/.config' + rm -f
${B}/.config.patched yes '' | oe_runmake oldconfig } -- 1.9.1
>>>> Nice,
some small comments only. Please write a short summary of the feature
(kernel-yocto: allow in-tree defconfig) but keep the bugzilla as a
reference for further info. Always good to have some background
found
>>> This is seems a significant core change so I wanted to make
sure these individual changes were as easily searchable as possible in
case any problems arise in future. Can you provide an example of what
you are suggesting for the commit msg?
>> Perhaps something like: Start
using the "in-tree defconfig" solution provided in poky[0]. To specify
an "in-tree" defconfig file, edit the recipe that builds your kernel so
that it has the following command form: KBUILD_DEFCONFIG_KMACHINE ?=
defconfig_file You need to append the variable with KMACHINE and then
supply the path to your "in-tree" defconfig file. In order to achieve
this in meta-raspberrypi will need to: - start using
KBUILD_DEFCONFIG_KMACHINE - Remove placeholder defconfig and custom
copying logic. - Avoid replacing all Yocto project configured settings
in do_configure_prepend. For more background regarding this migration
read the bugzilla bug info[1]. [0] -
http://www.yoctoproject.org/docs/1.8/kernel-dev/kernel-dev.html#using-an-in-tree-defconfig-file
[2] [1] - https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474 [1]
>

> Very comprehensive. Many thanks.
> 
>>>> directly in the commit msg
itself. Have you tested it using both poky:master and poky:fido?
>>>
Rpi2 fido 3.18.16 with/without sound patch, 4.1.3 with/without sound
patch. BR, Alex
>> Ok, since there has been some changes (not only the
early DT change) in poky:master it would be good to do the same tests
there. Andrei have to correct me if wrong, but since we have a fido
branch in meta-raspberrypi that's the branch that is recommended to use
against poky:fido, 'master' is in first place verified against
poky:master (latest and greatest).
> 
> Four test builds was enough
yesterday. I will look at master when I get
> a chance. As we pursue the
conversation on a review process a related
> conversation is getting an
automated build system going again as I think
> it would be very useful
in this context.
> 
> DynamicDevices may be able to help here. I had a
very positive
> experience with AppVeyor when I was putting the Mono
Win32 automated
> build system together and am wondering what's
currently best for Linux
> automated building (Jenkins?). Maybe that
conversation is best broken
> out in the Github vs Gerrit vs A.N.Other
thread.
> 
> BR, Alex

Yes, that would be really nice. I mostly have
experience with Jenkins, my experience is that it works very well
together with gerrit. Buildbot is another well-known tool. But perhaps
the fastest way forward is to investigate if we can use yocto
AutoBuilder for meta-raspberrypi. Alex, can you please start a new
thread for this subject (like you proposed) and see what it can lead
to.. 

BR Petter 

Links:
------
[1]
https://bugzilla.yoctoproject.org/show_bug.cgi?id=7474
[2]
http://www.yoctoproject.org/docs/1.8/kernel-dev/kernel-dev.html#using-an-in-tree-defconfig-file

[-- Attachment #2: Type: text/html, Size: 7874 bytes --]

Re: [meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

Hello,

On Tuesday, August 11, 2015, Petter Mabäcker <petter@technux.se> wrote:

> 2015-08-11 19:04 skrev Alex J Lennon:
>
> Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk <javascript:_e(%7B%7D,'cvml','ajlennon@dynamicdevices.co.uk');>>
> ---
>  recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
> index e38d905..8024412 100644
> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
> @@ -6,6 +6,10 @@ SECTION = "kernel"
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>
> +SRC_URI += " \
> +        file://build-in-audio.cfg \
> +        "
>
>
This one didn't make it.

--
Andrei Gherzan


-- 
--
Andrei Gherzan

[-- Attachment #2: Type: text/html, Size: 1471 bytes --]

Re: [meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Petter Mabäcker]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

 

2015-08-17 09:57 skrev Andrei Gherzan: 

> Hello,
> 
> On Tuesday,
August 11, 2015, Petter Mabäcker <petter@technux.se> wrote: 
> 
>>
2015-08-11 19:04 skrev Alex J Lennon: 
>> 
>>> Signed-off-by: Alex J
Lennon <ajlennon@dynamicdevices.co.uk>
>>> ---
>>>
recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++
>>> 1 file changed,
4 insertions(+)
>>> 
>>> diff --git
a/recipes-kernel/linux/linux-raspberrypi.inc
b/recipes-kernel/linux/linux-raspberrypi.inc
>>> index e38d905..8024412
100644
>>> --- a/recipes-kernel/linux/linux-raspberrypi.inc
>>> +++
b/recipes-kernel/linux/linux-raspberrypi.inc
>>> @@ -6,6 +6,10 @@
SECTION = "kernel"
>>> LICENSE = "GPLv2"
>>> LIC_FILES_CHKSUM =
"file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>>> 
>>> +SRC_URI
+= " 
>>> + file://build-in-audio.cfg 
>>> + "
> 
> This one didn't make
it. 
> 
> -- 
> Andrei Gherzan 
> 
> -- 
> 
> -- Andrei Gherzan

Think
you got the wrong receiver =) I notified Alex about this some days ago,
Alex can you send up a v2 for this? 

BR, Petter 

[-- Attachment #2: Type: text/html, Size: 2022 bytes --]

Re: [meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Alex J Lennon]

On 17/08/2015 09:11, Petter Mabäcker wrote:
> 2015-08-17 09:57 skrev Andrei Gherzan:
> 
>> Hello,
>>
>> On Tuesday, August 11, 2015, Petter Mabäcker <petter@technux.se
>> <mailto:petter@technux.se>> wrote:
>>
>>     2015-08-11 19:04 skrev Alex J Lennon:
>>
>>         Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
>>         ---
>>          recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++
>>          1 file changed, 4 insertions(+)
>>
>>         diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
>>         index e38d905..8024412 100644
>>         --- a/recipes-kernel/linux/linux-raspberrypi.inc
>>         +++ b/recipes-kernel/linux/linux-raspberrypi.inc
>>         @@ -6,6 +6,10 @@ SECTION = "kernel"
>>          LICENSE = "GPLv2"
>>          LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>>          
>>         +SRC_URI += " \
>>         +        file://build-in-audio.cfg \
>>         +        "
>>
>>  
>> This one didn't make it.
>>  
>>  
>>  
>>  
>> --
>> Andrei Gherzan
>>
>>
>> -- 
>> --
>> Andrei Gherzan
> 
> Think you got the wrong receiver =) I notified Alex about this some days
> ago, Alex can you send up a v2 for this?
> 
>

The build-in-audio.cfg patch was just for testing of fragment support.
It's understood that we're not going to have this build into the kernel
by default, although I do still need to find some words to add to the
README on audio routing setup and so forth.

I started testing a build with master over the weekend and it built OK.
Just need to find some time to run up a couple of kernels and will
resubmit the v2 patch with Petter's enhanced commit message.

I don't have an RPiv1 around at the moment but I will probably double
check the kernel does still actually build for RPiv1 machine

Cheers,

Alex


> 
> BR, Petter
> 

Re: [meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Alex J Lennon]

On 17/08/2015 09:11, Petter Mabäcker wrote:
> 2015-08-17 09:57 skrev Andrei Gherzan:
> 
>> Hello,
>>
>> On Tuesday, August 11, 2015, Petter Mabäcker <petter@technux.se
>> <mailto:petter@technux.se>> wrote:
>>
>>     2015-08-11 19:04 skrev Alex J Lennon:
>>
>>         Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
>>         ---
>>          recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++
>>          1 file changed, 4 insertions(+)
>>
>>         diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
>>         index e38d905..8024412 100644
>>         --- a/recipes-kernel/linux/linux-raspberrypi.inc
>>         +++ b/recipes-kernel/linux/linux-raspberrypi.inc
>>         @@ -6,6 +6,10 @@ SECTION = "kernel"
>>          LICENSE = "GPLv2"
>>          LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>>          
>>         +SRC_URI += " \
>>         +        file://build-in-audio.cfg \
>>         +        "
>>
>>  
>> This one didn't make it.
>>  
>>  
>>  
>>  
>> --
>> Andrei Gherzan
>>
>>
>> -- 
>> --
>> Andrei Gherzan
> 
> Think you got the wrong receiver =) I notified Alex about this some days
> ago, Alex can you send up a v2 for this?
> 
>

The build-in-audio.cfg patch was just for testing of fragment support.
It's understood that we're not going to have this build into the kernel
by default, although I do still need to find some words to add to the
README on audio routing setup and so forth.

I started testing a build with master over the weekend and it built OK.
Just need to find some time to run up a couple of kernels and will
resubmit the v2 patch with Petter's enhanced commit message.

I don't have an RPiv1 around at the moment but I will probably double
check the kernel does still actually build for RPiv1 machine

Cheers,

Alex


> 
> BR, Petter
> 

Re: [meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Petter Mabäcker]

[-- Attachment #1: Type: text/plain, Size: 1891 bytes --]

 

2015-08-17 11:23 skrev Alex J Lennon: 

> On 17/08/2015 09:11,
Petter Mabäcker wrote:
> 
>> 2015-08-17 09:57 skrev Andrei Gherzan: 
>>

>>> Hello, On Tuesday, August 11, 2015, Petter Mabäcker
<petter@technux.se <mailto:petter@technux.se>> wrote: 2015-08-11 19:04
skrev Alex J Lennon: Signed-off-by: Alex J Lennon
<ajlennon@dynamicdevices.co.uk> ---
recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++ 1 file changed, 4
insertions(+) diff --git a/recipes-kernel/linux/linux-raspberrypi.inc
b/recipes-kernel/linux/linux-raspberrypi.inc index e38d905..8024412
100644 --- a/recipes-kernel/linux/linux-raspberrypi.inc +++
b/recipes-kernel/linux/linux-raspberrypi.inc @@ -6,6 +6,10 @@ SECTION =
"kernel" LICENSE = "GPLv2" LIC_FILES_CHKSUM =
"file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" +SRC_URI += " +
file://build-in-audio.cfg [1] + " This one didn't make it. -- Andrei
Gherzan -- -- Andrei Gherzan
>> Think you got the wrong receiver =) I
notified Alex about this some days ago, Alex can you send up a v2 for
this?
> 
> The build-in-audio.cfg patch was just for testing of fragment
support.
> It's understood that we're not going to have this build into
the kernel
> by default, although I do still need to find some words to
add to the
> README on audio routing setup and so forth.
> 
> I started
testing a build with master over the weekend and it built OK.
> Just
need to find some time to run up a couple of kernels and will
> resubmit
the v2 patch with Petter's enhanced commit message.
> 
> I don't have an
RPiv1 around at the moment but I will probably double
> check the kernel
does still actually build for RPiv1 machine
> 
> Cheers,
> 
> Alex
> 
>>
BR, Petter

Hi Alex, Any news for the v2 changeset? Would be awesome to
get the 4.x integrated soon. 

BR Petter 

Links:
------
[1]
file://build-in-audio.cfg

[-- Attachment #2: Type: text/html, Size: 2689 bytes --]

Re: [meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Alex J Lennon]

On 25/08/2015 07:57, Petter Mabäcker wrote:
>  
> 
> 2015-08-17 11:23 skrev Alex J Lennon:
> 
>> On 17/08/2015 09:11, Petter Mabäcker wrote:
>>> 2015-08-17 09:57 skrev Andrei Gherzan:
>>>> Hello, On Tuesday, August 11, 2015, Petter Mabäcker
>>>> <petter@technux.se <mailto:petter@technux.se>
>>>> <mailto:petter@technux.se <mailto:petter@technux.se>>> wrote:
>>>> 2015-08-11 19:04 skrev Alex J Lennon: Signed-off-by: Alex J Lennon
>>>> <ajlennon@dynamicdevices.co.uk
>>>> <mailto:ajlennon@dynamicdevices.co.uk>> ---
>>>> recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++ 1 file changed,
>>>> 4 insertions(+) diff --git
>>>> a/recipes-kernel/linux/linux-raspberrypi.inc
>>>> b/recipes-kernel/linux/linux-raspberrypi.inc index e38d905..8024412
>>>> 100644 --- a/recipes-kernel/linux/linux-raspberrypi.inc +++
>>>> b/recipes-kernel/linux/linux-raspberrypi.inc @@ -6,6 +6,10 @@
>>>> SECTION = "kernel" LICENSE = "GPLv2" LIC_FILES_CHKSUM =
>>>> "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" +SRC_URI += "
>>>> \ + file://build-in-audio.cfg \ + " This one didn't make it. --
>>>> Andrei Gherzan -- -- Andrei Gherzan
>>> Think you got the wrong receiver =) I notified Alex about this some
>>> days ago, Alex can you send up a v2 for this?
>> The build-in-audio.cfg patch was just for testing of fragment support.
>> It's understood that we're not going to have this build into the kernel
>> by default, although I do still need to find some words to add to the
>> README on audio routing setup and so forth.
>>
>> I started testing a build with master over the weekend and it built OK.
>> Just need to find some time to run up a couple of kernels and will
>> resubmit the v2 patch with Petter's enhanced commit message.
>>
>> I don't have an RPiv1 around at the moment but I will probably double
>> check the kernel does still actually build for RPiv1 machine
>>
>> Cheers,
>>
>> Alex
>>> BR, Petter
> 
> Hi Alex, Any news for the v2 changeset? Would be awesome to get the 4.x
> integrated soon.
>

Hi, yeah I got a little sidetracked I'm afraid. Turns out
core-image-sato isn't building in master any more due to a new
dependency on libexpoxy which in turn requires EGL.

Anyway, so I did successfully build 4.x and 3.x kernels for RPiv2 in an
rpi-xxx-image. I just didn't get around to running them up although I
see no reason to think they won't.

I'll try to take a look at this, as I like you would like this signed off :)

Cheers, Alex

Re: [meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Andrei Gherzan]

On Tue, Aug 25, 2015 at 09:00:06AM +0100, Alex J Lennon wrote:
> On 25/08/2015 07:57, Petter Mabäcker wrote:
> >
> >
> > 2015-08-17 11:23 skrev Alex J Lennon:
> >
> >> On 17/08/2015 09:11, Petter Mabäcker wrote:
> >>> 2015-08-17 09:57 skrev Andrei Gherzan:
> >>>> Hello, On Tuesday, August 11, 2015, Petter Mabäcker
> >>>> <petter@technux.se <mailto:petter@technux.se>
> >>>> <mailto:petter@technux.se <mailto:petter@technux.se>>> wrote:
> >>>> 2015-08-11 19:04 skrev Alex J Lennon: Signed-off-by: Alex J Lennon
> >>>> <ajlennon@dynamicdevices.co.uk
> >>>> <mailto:ajlennon@dynamicdevices.co.uk>> ---
> >>>> recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++ 1 file changed,
> >>>> 4 insertions(+) diff --git
> >>>> a/recipes-kernel/linux/linux-raspberrypi.inc
> >>>> b/recipes-kernel/linux/linux-raspberrypi.inc index e38d905..8024412
> >>>> 100644 --- a/recipes-kernel/linux/linux-raspberrypi.inc +++
> >>>> b/recipes-kernel/linux/linux-raspberrypi.inc @@ -6,6 +6,10 @@
> >>>> SECTION = "kernel" LICENSE = "GPLv2" LIC_FILES_CHKSUM =
> >>>> "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" +SRC_URI += "
> >>>> \ + file://build-in-audio.cfg \ + " This one didn't make it. --
> >>>> Andrei Gherzan -- -- Andrei Gherzan
> >>> Think you got the wrong receiver =) I notified Alex about this some
> >>> days ago, Alex can you send up a v2 for this?
> >> The build-in-audio.cfg patch was just for testing of fragment support.
> >> It's understood that we're not going to have this build into the kernel
> >> by default, although I do still need to find some words to add to the
> >> README on audio routing setup and so forth.
> >>
> >> I started testing a build with master over the weekend and it built OK.
> >> Just need to find some time to run up a couple of kernels and will
> >> resubmit the v2 patch with Petter's enhanced commit message.
> >>
> >> I don't have an RPiv1 around at the moment but I will probably double
> >> check the kernel does still actually build for RPiv1 machine
> >>
> >> Cheers,
> >>
> >> Alex
> >>> BR, Petter
> >
> > Hi Alex, Any news for the v2 changeset? Would be awesome to get the 4.x
> > integrated soon.
> >
>
> Hi, yeah I got a little sidetracked I'm afraid. Turns out
> core-image-sato isn't building in master any more due to a new
> dependency on libexpoxy which in turn requires EGL.
>
> Anyway, so I did successfully build 4.x and 3.x kernels for RPiv2 in an
> rpi-xxx-image. I just didn't get around to running them up although I
> see no reason to think they won't.
>
> I'll try to take a look at this, as I like you would like this signed off :)
>
> Cheers, Alex
>

Any chances this is still coming soon?

--
Andrei Gherzan

Re: [meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Alex J Lennon]

On 21/10/2015 13:12, Andrei Gherzan wrote:
> On Tue, Aug 25, 2015 at 09:00:06AM +0100, Alex J Lennon wrote:
>> On 25/08/2015 07:57, Petter Mabäcker wrote:
>>>
>>>
>>> 2015-08-17 11:23 skrev Alex J Lennon:
>>>
>>>> On 17/08/2015 09:11, Petter Mabäcker wrote:
>>>>> 2015-08-17 09:57 skrev Andrei Gherzan:
>>>>>> Hello, On Tuesday, August 11, 2015, Petter Mabäcker
>>>>>> <petter@technux.se <mailto:petter@technux.se>
>>>>>> <mailto:petter@technux.se <mailto:petter@technux.se>>> wrote:
>>>>>> 2015-08-11 19:04 skrev Alex J Lennon: Signed-off-by: Alex J Lennon
>>>>>> <ajlennon@dynamicdevices.co.uk
>>>>>> <mailto:ajlennon@dynamicdevices.co.uk>> ---
>>>>>> recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++ 1 file changed,
>>>>>> 4 insertions(+) diff --git
>>>>>> a/recipes-kernel/linux/linux-raspberrypi.inc
>>>>>> b/recipes-kernel/linux/linux-raspberrypi.inc index e38d905..8024412
>>>>>> 100644 --- a/recipes-kernel/linux/linux-raspberrypi.inc +++
>>>>>> b/recipes-kernel/linux/linux-raspberrypi.inc @@ -6,6 +6,10 @@
>>>>>> SECTION = "kernel" LICENSE = "GPLv2" LIC_FILES_CHKSUM =
>>>>>> "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" +SRC_URI += "
>>>>>> \ + file://build-in-audio.cfg \ + " This one didn't make it. --
>>>>>> Andrei Gherzan -- -- Andrei Gherzan
>>>>> Think you got the wrong receiver =) I notified Alex about this some
>>>>> days ago, Alex can you send up a v2 for this?
>>>> The build-in-audio.cfg patch was just for testing of fragment support.
>>>> It's understood that we're not going to have this build into the kernel
>>>> by default, although I do still need to find some words to add to the
>>>> README on audio routing setup and so forth.
>>>>
>>>> I started testing a build with master over the weekend and it built OK.
>>>> Just need to find some time to run up a couple of kernels and will
>>>> resubmit the v2 patch with Petter's enhanced commit message.
>>>>
>>>> I don't have an RPiv1 around at the moment but I will probably double
>>>> check the kernel does still actually build for RPiv1 machine
>>>>
>>>> Cheers,
>>>>
>>>> Alex
>>>>> BR, Petter
>>>
>>> Hi Alex, Any news for the v2 changeset? Would be awesome to get the 4.x
>>> integrated soon.
>>>
>>
>> Hi, yeah I got a little sidetracked I'm afraid. Turns out
>> core-image-sato isn't building in master any more due to a new
>> dependency on libexpoxy which in turn requires EGL.
>>
>> Anyway, so I did successfully build 4.x and 3.x kernels for RPiv2 in an
>> rpi-xxx-image. I just didn't get around to running them up although I
>> see no reason to think they won't.
>>
>> I'll try to take a look at this, as I like you would like this signed off :)
>>
>> Cheers, Alex
>>
> 
> Any chances this is still coming soon?
> 
> --
> Andrei Gherzan
> 

Yes I'd like to wrap this up too. Can we take a step back first and
revisit the earlier patch-set to update to 3.8.16 and add support for
4.1.3 kernels first? If so I'll try to test with what seems to be the
latest long term kernels on kernel.org, 3.8.22 and 4.1.10.

With that in place I can then add the kernel fragment support on top.
(And then start looking into Dockerification which looks intriguing... ;)

How does that sound?

Best, Alex

Re: [meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Alex J Lennon]

On 21/10/2015 13:12, Andrei Gherzan wrote:
> On Tue, Aug 25, 2015 at 09:00:06AM +0100, Alex J Lennon wrote:
>> On 25/08/2015 07:57, Petter Mabäcker wrote:
>>>
>>>
>>> 2015-08-17 11:23 skrev Alex J Lennon:
>>>
>>>> On 17/08/2015 09:11, Petter Mabäcker wrote:
>>>>> 2015-08-17 09:57 skrev Andrei Gherzan:
>>>>>> Hello, On Tuesday, August 11, 2015, Petter Mabäcker
>>>>>> <petter@technux.se <mailto:petter@technux.se>
>>>>>> <mailto:petter@technux.se <mailto:petter@technux.se>>> wrote:
>>>>>> 2015-08-11 19:04 skrev Alex J Lennon: Signed-off-by: Alex J Lennon
>>>>>> <ajlennon@dynamicdevices.co.uk
>>>>>> <mailto:ajlennon@dynamicdevices.co.uk>> ---
>>>>>> recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++ 1 file changed,
>>>>>> 4 insertions(+) diff --git
>>>>>> a/recipes-kernel/linux/linux-raspberrypi.inc
>>>>>> b/recipes-kernel/linux/linux-raspberrypi.inc index e38d905..8024412
>>>>>> 100644 --- a/recipes-kernel/linux/linux-raspberrypi.inc +++
>>>>>> b/recipes-kernel/linux/linux-raspberrypi.inc @@ -6,6 +6,10 @@
>>>>>> SECTION = "kernel" LICENSE = "GPLv2" LIC_FILES_CHKSUM =
>>>>>> "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" +SRC_URI += "
>>>>>> \ + file://build-in-audio.cfg \ + " This one didn't make it. --
>>>>>> Andrei Gherzan -- -- Andrei Gherzan
>>>>> Think you got the wrong receiver =) I notified Alex about this some
>>>>> days ago, Alex can you send up a v2 for this?
>>>> The build-in-audio.cfg patch was just for testing of fragment support.
>>>> It's understood that we're not going to have this build into the kernel
>>>> by default, although I do still need to find some words to add to the
>>>> README on audio routing setup and so forth.
>>>>
>>>> I started testing a build with master over the weekend and it built OK.
>>>> Just need to find some time to run up a couple of kernels and will
>>>> resubmit the v2 patch with Petter's enhanced commit message.
>>>>
>>>> I don't have an RPiv1 around at the moment but I will probably double
>>>> check the kernel does still actually build for RPiv1 machine
>>>>
>>>> Cheers,
>>>>
>>>> Alex
>>>>> BR, Petter
>>>
>>> Hi Alex, Any news for the v2 changeset? Would be awesome to get the 4.x
>>> integrated soon.
>>>
>>
>> Hi, yeah I got a little sidetracked I'm afraid. Turns out
>> core-image-sato isn't building in master any more due to a new
>> dependency on libexpoxy which in turn requires EGL.
>>
>> Anyway, so I did successfully build 4.x and 3.x kernels for RPiv2 in an
>> rpi-xxx-image. I just didn't get around to running them up although I
>> see no reason to think they won't.
>>
>> I'll try to take a look at this, as I like you would like this signed off :)
>>
>> Cheers, Alex
>>
> 
> Any chances this is still coming soon?
> 
> --
> Andrei Gherzan
> 

Yes I'd like to wrap this up too. Can we take a step back first and
revisit the earlier patch-set to update to 3.8.16 and add support for
4.1.3 kernels first? If so I'll try to test with what seems to be the
latest long term kernels on kernel.org, 3.8.22 and 4.1.10.

With that in place I can then add the kernel fragment support on top.
(And then start looking into Dockerification which looks intriguing... ;)

How does that sound?

Best, Alex

Re: [meta-raspberrypi][PATCH 2/2] linux-raspberrypi: build audio driver into kernel

[Andrei Gherzan]

On Wed, Oct 21, 2015 at 6:51 PM, Alex J Lennon <ajlennon@gmail.com> wrote:
> On 21/10/2015 13:12, Andrei Gherzan wrote:
>> On Tue, Aug 25, 2015 at 09:00:06AM +0100, Alex J Lennon wrote:
>>> On 25/08/2015 07:57, Petter Mabäcker wrote:
>>>>
>>>>
>>>> 2015-08-17 11:23 skrev Alex J Lennon:
>>>>
>>>>> On 17/08/2015 09:11, Petter Mabäcker wrote:
>>>>>> 2015-08-17 09:57 skrev Andrei Gherzan:
>>>>>>> Hello, On Tuesday, August 11, 2015, Petter Mabäcker
>>>>>>> <petter@technux.se <mailto:petter@technux.se>
>>>>>>> <mailto:petter@technux.se <mailto:petter@technux.se>>> wrote:
>>>>>>> 2015-08-11 19:04 skrev Alex J Lennon: Signed-off-by: Alex J Lennon
>>>>>>> <ajlennon@dynamicdevices.co.uk
>>>>>>> <mailto:ajlennon@dynamicdevices.co.uk>> ---
>>>>>>> recipes-kernel/linux/linux-raspberrypi.inc | 4 ++++ 1 file changed,
>>>>>>> 4 insertions(+) diff --git
>>>>>>> a/recipes-kernel/linux/linux-raspberrypi.inc
>>>>>>> b/recipes-kernel/linux/linux-raspberrypi.inc index e38d905..8024412
>>>>>>> 100644 --- a/recipes-kernel/linux/linux-raspberrypi.inc +++
>>>>>>> b/recipes-kernel/linux/linux-raspberrypi.inc @@ -6,6 +6,10 @@
>>>>>>> SECTION = "kernel" LICENSE = "GPLv2" LIC_FILES_CHKSUM =
>>>>>>> "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7" +SRC_URI += "
>>>>>>> \ + file://build-in-audio.cfg \ + " This one didn't make it. --
>>>>>>> Andrei Gherzan -- -- Andrei Gherzan
>>>>>> Think you got the wrong receiver =) I notified Alex about this some
>>>>>> days ago, Alex can you send up a v2 for this?
>>>>> The build-in-audio.cfg patch was just for testing of fragment support.
>>>>> It's understood that we're not going to have this build into the kernel
>>>>> by default, although I do still need to find some words to add to the
>>>>> README on audio routing setup and so forth.
>>>>>
>>>>> I started testing a build with master over the weekend and it built OK.
>>>>> Just need to find some time to run up a couple of kernels and will
>>>>> resubmit the v2 patch with Petter's enhanced commit message.
>>>>>
>>>>> I don't have an RPiv1 around at the moment but I will probably double
>>>>> check the kernel does still actually build for RPiv1 machine
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Alex
>>>>>> BR, Petter
>>>>
>>>> Hi Alex, Any news for the v2 changeset? Would be awesome to get the 4.x
>>>> integrated soon.
>>>>
>>>
>>> Hi, yeah I got a little sidetracked I'm afraid. Turns out
>>> core-image-sato isn't building in master any more due to a new
>>> dependency on libexpoxy which in turn requires EGL.
>>>
>>> Anyway, so I did successfully build 4.x and 3.x kernels for RPiv2 in an
>>> rpi-xxx-image. I just didn't get around to running them up although I
>>> see no reason to think they won't.
>>>
>>> I'll try to take a look at this, as I like you would like this signed off :)
>>>
>>> Cheers, Alex
>>>
>>
>> Any chances this is still coming soon?
>>
>> --
>> Andrei Gherzan
>>
>
> Yes I'd like to wrap this up too. Can we take a step back first and
> revisit the earlier patch-set to update to 3.8.16 and add support for
> 4.1.3 kernels first? If so I'll try to test with what seems to be the
> latest long term kernels on kernel.org, 3.8.22 and 4.1.10.
>
> With that in place I can then add the kernel fragment support on top.
> (And then start looking into Dockerification which looks intriguing... ;)
>

Tomorrow everything will be updated. If they still compile and run :)


--
Andrei Gherzan