From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
David Miller <davem@davemloft.net>,
fw@strlen.de, netdev@vger.kernel.org, cwang@twopensource.com
Subject: Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable
Date: Wed, 12 Aug 2015 07:55:26 -0700 [thread overview]
Message-ID: <1439391326.29802.12.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20150812011347.GA58200@Alexeis-MacBook-Pro.local>
On Tue, 2015-08-11 at 18:13 -0700, Alexei Starovoitov wrote:
> Also why introduce the flag? Why not just add 'tx_queue_len = 0;'
> to veth_setup() like the whole bunch of devices do?
Sigh.
Because some people install htb or pfifo on veth, leaving tx_queue_len
unchanged.
If you install htb while tx_queue_len is 0, pfifo created on htb classe
can only queue one packet.
static int fifo_init(struct Qdisc *sch, struct nlattr *opt)
{
bool bypass;
bool is_bfifo = sch->ops == &bfifo_qdisc_ops;
if (opt == NULL) {
u32 limit = qdisc_dev(sch)->tx_queue_len ? : 1;
if (is_bfifo)
limit *= psched_mtu(qdisc_dev(sch));
sch->limit = limit;
Changing veth txqueuelen is too late.
next prev parent reply other threads:[~2015-08-12 14:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 20:51 [net-next PATCH 0/3] Backwards-compatible noqueue in virtual interfaces Phil Sutter
2015-07-29 20:51 ` [net-next PATCH 1/3] net: make default tx_queue_len configurable Phil Sutter
2015-07-29 20:51 ` [net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc Phil Sutter
2015-07-29 20:51 ` [net-next PATCH 3/3] veth: don't assign a qdisc to veth Phil Sutter
2015-07-29 21:10 ` [net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc Florian Westphal
2015-07-29 21:10 ` Eric Dumazet
2015-07-29 22:08 ` Phil Sutter
2015-07-29 21:06 ` [net-next PATCH 1/3] net: make default tx_queue_len configurable Florian Westphal
2015-07-29 21:34 ` Phil Sutter
2015-07-29 21:37 ` David Miller
2015-08-11 15:48 ` Jesper Dangaard Brouer
2015-08-11 16:23 ` Phil Sutter
2015-08-12 1:13 ` Alexei Starovoitov
2015-08-12 14:55 ` Eric Dumazet [this message]
2015-08-13 1:13 ` Phil Sutter
2015-08-13 13:10 ` Jesper Dangaard Brouer
2015-08-13 15:06 ` Phil Sutter
2015-07-29 23:10 ` [net-next PATCH 0/3] Backwards-compatible noqueue in virtual interfaces Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439391326.29802.12.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=brouer@redhat.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.