All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <cwang@twopensource.com>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev <netdev@vger.kernel.org>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	David Miller <davem@davemloft.net>
Subject: Re: [net-next PATCH 0/3] Backwards-compatible noqueue in virtual interfaces
Date: Wed, 29 Jul 2015 16:10:03 -0700	[thread overview]
Message-ID: <CAHA+R7MadVkeka-ccJBHT7+tuLbw8ZhtO0QD5jRagtx-+DpRpw@mail.gmail.com> (raw)
In-Reply-To: <1438203103-27013-1-git-send-email-phil@nwl.cc>

On Wed, Jul 29, 2015 at 1:51 PM, Phil Sutter <phil@nwl.cc> wrote:
> This series is inspired by a patch sent[1] in from Jesper Brouer and the
> discussion it started. Basically it tries to provide a solution which is
> backwards compatible while still enabling the veth performance
> improvement by default.

You can specify the tx_queue_len when you create the veth device,
if that can be your "default".

tx_queue_len ties too much with qdisc probably due to historical
reasons, ideally we should only specify the queue len via qdisc
interface since at least a per-device tx_queue_len doesn't make
much sense for those multiqueue or hierarchical qdisc's. It's hard
to change without breaking existing scripts/code.

Like David said, maybe you can add a new netdev flag saying
not to have any qdisc even when tx_queue_len !=0, or let each
device choose its default qdisc...

      parent reply	other threads:[~2015-07-29 23:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 20:51 [net-next PATCH 0/3] Backwards-compatible noqueue in virtual interfaces Phil Sutter
2015-07-29 20:51 ` [net-next PATCH 1/3] net: make default tx_queue_len configurable Phil Sutter
2015-07-29 20:51   ` [net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc Phil Sutter
2015-07-29 20:51     ` [net-next PATCH 3/3] veth: don't assign a qdisc to veth Phil Sutter
2015-07-29 21:10     ` [net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc Florian Westphal
2015-07-29 21:10     ` Eric Dumazet
2015-07-29 22:08       ` Phil Sutter
2015-07-29 21:06   ` [net-next PATCH 1/3] net: make default tx_queue_len configurable Florian Westphal
2015-07-29 21:34     ` Phil Sutter
2015-07-29 21:37       ` David Miller
2015-08-11 15:48         ` Jesper Dangaard Brouer
2015-08-11 16:23           ` Phil Sutter
2015-08-12  1:13             ` Alexei Starovoitov
2015-08-12 14:55               ` Eric Dumazet
2015-08-13  1:13               ` Phil Sutter
2015-08-13 13:10                 ` Jesper Dangaard Brouer
2015-08-13 15:06                   ` Phil Sutter
2015-07-29 23:10 ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHA+R7MadVkeka-ccJBHT7+tuLbw8ZhtO0QD5jRagtx-+DpRpw@mail.gmail.com \
    --to=cwang@twopensource.com \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.