[PATCH][dizzy] qemu-vnc: CVE-2014-7815

[PATCH][dizzy] qemu-vnc: CVE-2014-7815

[Sona Sarmadi]

Fixes an uninitialized data structure use flaw in qemu-vnc
which allows remote attackers to cause a denial of service
(crash).

Upstream patch:
http://git.qemu.org/?p=qemu.git;a=commit;
h=b2f1d90530301d7915dddc8a750063757675b21a

References:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2014-7815
http://www.securityfocus.com/bid/70998

Signed-off-by: Sona Sarmadi <sona.sarmadi@enea.com>
---
 .../qemu/qemu/vnc-CVE-2014-7815.patch              | 53 ++++++++++++++++++++++
 meta/recipes-devtools/qemu/qemu_2.1.0.bb           |  1 +
 2 files changed, 54 insertions(+)
 create mode 100644 meta/recipes-devtools/qemu/qemu/vnc-CVE-2014-7815.patch

diff --git a/meta/recipes-devtools/qemu/qemu/vnc-CVE-2014-7815.patch b/meta/recipes-devtools/qemu/qemu/vnc-CVE-2014-7815.patch
new file mode 100644
index 0000000..10a6dac
--- /dev/null
+++ b/meta/recipes-devtools/qemu/qemu/vnc-CVE-2014-7815.patch
@@ -0,0 +1,53 @@
+From b2f1d90530301d7915dddc8a750063757675b21a Mon Sep 17 00:00:00 2001
+From: Petr Matousek <pmatouse@redhat.com>
+Date: Mon, 27 Oct 2014 12:41:44 +0100
+Subject: [PATCH] vnc: sanitize bits_per_pixel from the client
+
+bits_per_pixel that are less than 8 could result in accessing
+non-initialized buffers later in the code due to the expectation
+that bytes_per_pixel value that is used to initialize these buffers is
+never zero.
+
+To fix this check that bits_per_pixel from the client is one of the
+values that the rfb protocol specification allows.
+
+This is CVE-2014-7815.
+
+Upstream-Status: Backport
+
+Signed-off-by: Petr Matousek <pmatouse@redhat.com>
+
+[ kraxel: apply codestyle fix ]
+
+Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
+(cherry picked from commit e6908bfe8e07f2b452e78e677da1b45b1c0f6829)
+Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
+Signed-off-by: Sona Sarmadi <sona.sarmadi@enea.com>
+---
+ ui/vnc.c | 10 ++++++++++
+ 1 file changed, 10 insertions(+)
+
+diff --git a/ui/vnc.c b/ui/vnc.c
+index f8d9b7d..87e34ae 100644
+--- a/ui/vnc.c
++++ b/ui/vnc.c
+@@ -2026,6 +2026,16 @@ static void set_pixel_format(VncState *vs,
+         return;
+     }
+ 
++    switch (bits_per_pixel) {
++    case 8:
++    case 16:
++    case 32:
++        break;
++    default:
++        vnc_client_error(vs);
++        return;
++    }
++
+     vs->client_pf.rmax = red_max;
+     vs->client_pf.rbits = hweight_long(red_max);
+     vs->client_pf.rshift = red_shift;
+-- 
+1.9.1
+
diff --git a/meta/recipes-devtools/qemu/qemu_2.1.0.bb b/meta/recipes-devtools/qemu/qemu_2.1.0.bb
index 5e5ecf0..444a422 100644
--- a/meta/recipes-devtools/qemu/qemu_2.1.0.bb
+++ b/meta/recipes-devtools/qemu/qemu_2.1.0.bb
@@ -9,6 +9,7 @@ SRC_URI += "file://configure-fix-Darwin-target-detection.patch \
             file://0001-Back-porting-security-fix-CVE-2014-5388.patch \
             file://qemu-CVE-2015-3456.patch \
             file://CVE-2014-7840.patch \
+            file://vnc-CVE-2014-7815.patch \
             "
 SRC_URI_prepend = "http://wiki.qemu-project.org/download/${BP}.tar.bz2"
 SRC_URI[md5sum] = "6726977292b448cbc7f89998fac6983b"
-- 
1.9.1

Re: [PATCH][dizzy] qemu-vnc: CVE-2014-7815

[akuster808]

On 8/19/15 5:14 AM, Sona Sarmadi wrote:
> Fixes an uninitialized data structure use flaw in qemu-vnc
> which allows remote attackers to cause a denial of service
> (crash).
>
> Upstream patch:
> http://git.qemu.org/?p=qemu.git;a=commit;
> h=b2f1d90530301d7915dddc8a750063757675b21a
>
> References:
> https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2014-7815
> http://www.securityfocus.com/bid/70998
>
> Signed-off-by: Sona Sarmadi <sona.sarmadi@enea.com>
merged to staging,
Armin
> ---
>  .../qemu/qemu/vnc-CVE-2014-7815.patch              | 53 ++++++++++++++++++++++
>  meta/recipes-devtools/qemu/qemu_2.1.0.bb           |  1 +
>  2 files changed, 54 insertions(+)
>  create mode 100644 meta/recipes-devtools/qemu/qemu/vnc-CVE-2014-7815.patch
>
> diff --git a/meta/recipes-devtools/qemu/qemu/vnc-CVE-2014-7815.patch b/meta/recipes-devtools/qemu/qemu/vnc-CVE-2014-7815.patch
> new file mode 100644
> index 0000000..10a6dac
> --- /dev/null
> +++ b/meta/recipes-devtools/qemu/qemu/vnc-CVE-2014-7815.patch
> @@ -0,0 +1,53 @@
> +From b2f1d90530301d7915dddc8a750063757675b21a Mon Sep 17 00:00:00 2001
> +From: Petr Matousek <pmatouse@redhat.com>
> +Date: Mon, 27 Oct 2014 12:41:44 +0100
> +Subject: [PATCH] vnc: sanitize bits_per_pixel from the client
> +
> +bits_per_pixel that are less than 8 could result in accessing
> +non-initialized buffers later in the code due to the expectation
> +that bytes_per_pixel value that is used to initialize these buffers is
> +never zero.
> +
> +To fix this check that bits_per_pixel from the client is one of the
> +values that the rfb protocol specification allows.
> +
> +This is CVE-2014-7815.
> +
> +Upstream-Status: Backport
> +
> +Signed-off-by: Petr Matousek <pmatouse@redhat.com>
> +
> +[ kraxel: apply codestyle fix ]
> +
> +Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> +(cherry picked from commit e6908bfe8e07f2b452e78e677da1b45b1c0f6829)
> +Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> +Signed-off-by: Sona Sarmadi <sona.sarmadi@enea.com>
> +---
> + ui/vnc.c | 10 ++++++++++
> + 1 file changed, 10 insertions(+)
> +
> +diff --git a/ui/vnc.c b/ui/vnc.c
> +index f8d9b7d..87e34ae 100644
> +--- a/ui/vnc.c
> ++++ b/ui/vnc.c
> +@@ -2026,6 +2026,16 @@ static void set_pixel_format(VncState *vs,
> +         return;
> +     }
> + 
> ++    switch (bits_per_pixel) {
> ++    case 8:
> ++    case 16:
> ++    case 32:
> ++        break;
> ++    default:
> ++        vnc_client_error(vs);
> ++        return;
> ++    }
> ++
> +     vs->client_pf.rmax = red_max;
> +     vs->client_pf.rbits = hweight_long(red_max);
> +     vs->client_pf.rshift = red_shift;
> +-- 
> +1.9.1
> +
> diff --git a/meta/recipes-devtools/qemu/qemu_2.1.0.bb b/meta/recipes-devtools/qemu/qemu_2.1.0.bb
> index 5e5ecf0..444a422 100644
> --- a/meta/recipes-devtools/qemu/qemu_2.1.0.bb
> +++ b/meta/recipes-devtools/qemu/qemu_2.1.0.bb
> @@ -9,6 +9,7 @@ SRC_URI += "file://configure-fix-Darwin-target-detection.patch \
>              file://0001-Back-porting-security-fix-CVE-2014-5388.patch \
>              file://qemu-CVE-2015-3456.patch \
>              file://CVE-2014-7840.patch \
> +            file://vnc-CVE-2014-7815.patch \
>              "
>  SRC_URI_prepend = "http://wiki.qemu-project.org/download/${BP}.tar.bz2"
>  SRC_URI[md5sum] = "6726977292b448cbc7f89998fac6983b"