* [Qemu-devel] [PATCH] usb:xhci:fix memory leak in usb_xhci_exit
@ 2016-09-13 5:22 李强
2016-09-13 7:13 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: 李强 @ 2016-09-13 5:22 UTC (permalink / raw)
To: kraxel, Qemu developers (qemu-devel@nongnu.org)
If the xhci uses msix, it doesn't free the corresponding
memory, thus leading a memory leak issue. This patch avoid this.
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
---
hw/usb/hcd-xhci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 188f954..281a2a5 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -3709,8 +3709,7 @@ static void usb_xhci_exit(PCIDevice *dev)
/* destroy msix memory region */
if (dev->msix_table && dev->msix_pba
&& dev->msix_entry_used) {
- memory_region_del_subregion(&xhci->mem, &dev->msix_table_mmio);
- memory_region_del_subregion(&xhci->mem, &dev->msix_pba_mmio);
+ msix_uninit(dev, &xhci->mem, &xhci->mem);
}
usb_bus_release(&xhci->bus);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] usb:xhci:fix memory leak in usb_xhci_exit
2016-09-13 5:22 [Qemu-devel] [PATCH] usb:xhci:fix memory leak in usb_xhci_exit 李强
@ 2016-09-13 7:13 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2016-09-13 7:13 UTC (permalink / raw)
To: 李强; +Cc: Qemu developers (qemu-devel@nongnu.org)
On Di, 2016-09-13 at 05:22 +0000, 李强 wrote:
> If the xhci uses msix, it doesn't free the corresponding
>
> memory, thus leading a memory leak issue. This patch avoid this.
Patch looks good but is corrupted:
Applying: usb:xhci:fix memory leak in usb_xhci_exit
fatal: corrupt patch at line 19
Please send patches using "git send-email" to avoid this.
thanks,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-13 7:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-13 5:22 [Qemu-devel] [PATCH] usb:xhci:fix memory leak in usb_xhci_exit 李强
2016-09-13 7:13 ` Gerd Hoffmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.