From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 3/3] IB: remove xrc_remote_srq_num from struct ib_send_wr
Date: Wed, 19 Aug 2015 18:37:34 +0200 [thread overview]
Message-ID: <1440002254-795-4-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1440002254-795-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
The field is only initialized in mlx, but never used.
If we want to add proper XRC support it should be done with a new
struct ib_xrc_wr.
This shrinks the various WR structures by another 4 bytes.
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
drivers/infiniband/hw/mlx5/qp.c | 1 -
include/rdma/ib_verbs.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index 04df156..83a290f 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -2634,7 +2634,6 @@ int mlx5_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
switch (ibqp->qp_type) {
case IB_QPT_XRC_INI:
xrc = seg;
- xrc->xrc_srqn = htonl(wr->xrc_remote_srq_num);
seg += sizeof(*xrc);
size += sizeof(*xrc) / 16;
/* fall through */
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 9b29c78..b855189 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -1100,7 +1100,6 @@ struct ib_send_wr {
__be32 imm_data;
u32 invalidate_rkey;
} ex;
- u32 xrc_remote_srq_num; /* XRC TGT QPs only */
};
struct ib_rdma_wr {
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-08-19 16:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 16:37 shrink struct ib_send_wr Christoph Hellwig
[not found] ` <1440002254-795-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-08-19 16:37 ` [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes Christoph Hellwig
2015-08-19 16:37 ` Christoph Hellwig
[not found] ` <1440002254-795-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-08-19 17:46 ` Jason Gunthorpe
2015-08-19 17:46 ` Jason Gunthorpe
2015-08-19 17:48 ` Christoph Hellwig
[not found] ` <20150819174802.GA13875-jcswGhMUV9g@public.gmane.org>
2015-08-19 17:54 ` Jason Gunthorpe
2015-08-19 17:54 ` Jason Gunthorpe
[not found] ` <20150819175425.GE22646-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-08-20 8:49 ` Sagi Grimberg
2015-08-20 8:49 ` Sagi Grimberg
[not found] ` <55D594B3.7090807-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-08-20 22:30 ` Steve Wise
2015-08-20 22:30 ` Steve Wise
[not found] ` <20150819174614.GC22646-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-08-19 19:50 ` Hefty, Sean
2015-08-19 19:50 ` Hefty, Sean
2015-08-20 9:22 ` Christoph Hellwig
2015-08-20 8:52 ` Sagi Grimberg
[not found] ` <55D59553.4080306-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-08-22 6:38 ` Haggai Eran
2015-08-22 6:38 ` Haggai Eran
2015-08-22 8:25 ` Christoph Hellwig
2015-08-24 6:52 ` Haggai Eran
[not found] ` <55DABF1E.2050804-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-08-24 6:55 ` Christoph Hellwig
2015-08-24 6:55 ` Christoph Hellwig
[not found] ` <20150824065501.GA31990-jcswGhMUV9g@public.gmane.org>
2015-08-24 7:59 ` Haggai Eran
2015-08-24 7:59 ` Haggai Eran
2015-08-25 8:55 ` Christoph Hellwig
2015-08-19 16:37 ` Christoph Hellwig [this message]
[not found] ` <1440002254-795-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-08-19 17:48 ` [PATCH 3/3] IB: remove xrc_remote_srq_num from struct ib_send_wr Jason Gunthorpe
2015-08-20 8:57 ` Sagi Grimberg
2015-08-20 9:01 ` shrink " Sagi Grimberg
2015-08-26 9:00 shrink struct ib_send_wr V3 Christoph Hellwig
[not found] ` <1440579639-10684-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-08-26 9:00 ` [PATCH 3/3] IB: remove xrc_remote_srq_num from struct ib_send_wr Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440002254-795-4-git-send-email-hch@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.