All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	Sagi Grimberg
	<sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Hal Rosenstock
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes
Date: Mon, 24 Aug 2015 08:55:01 +0200	[thread overview]
Message-ID: <20150824065501.GA31990@lst.de> (raw)
In-Reply-To: <55DABF1E.2050804-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

On Mon, Aug 24, 2015 at 09:52:14AM +0300, Haggai Eran wrote:
> Okay. Maybe you can just add a case for IB_WR_SEND in this patch to
> avoid hurting bisectability.

I've done this already, just waiting for more feedback before resending:

http://git.infradead.org/users/hch/rdma.git/commitdiff/20f34ca8ecac302984f3a92b9ad29f5f4b41780d

> Looking at the uverbs part in patch 2, I think the changes are okay. I
> noticed there's a (__be32 __force) cast of the immediate data from
> userspace (it was already in the existing code). I wonder, why not
> define the field in the uapi struct as __be32 in the first place?

It looks odd to me as well, but it's not really something I want to
change in this series.  Note that sparse annoted types like __be32
aren't really common in userspace, but with a bit of effort they can
be supported.  We have them and regularly run sparse for xfsprogs for
example.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Haggai Eran <haggaie@mellanox.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagig@dev.mellanox.co.il>,
	Doug Ledford <dledford@redhat.com>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	Eli Cohen <eli@mellanox.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes
Date: Mon, 24 Aug 2015 08:55:01 +0200	[thread overview]
Message-ID: <20150824065501.GA31990@lst.de> (raw)
In-Reply-To: <55DABF1E.2050804@mellanox.com>

On Mon, Aug 24, 2015 at 09:52:14AM +0300, Haggai Eran wrote:
> Okay. Maybe you can just add a case for IB_WR_SEND in this patch to
> avoid hurting bisectability.

I've done this already, just waiting for more feedback before resending:

http://git.infradead.org/users/hch/rdma.git/commitdiff/20f34ca8ecac302984f3a92b9ad29f5f4b41780d

> Looking at the uverbs part in patch 2, I think the changes are okay. I
> noticed there's a (__be32 __force) cast of the immediate data from
> userspace (it was already in the existing code). I wonder, why not
> define the field in the uapi struct as __be32 in the first place?

It looks odd to me as well, but it's not really something I want to
change in this series.  Note that sparse annoted types like __be32
aren't really common in userspace, but with a bit of effort they can
be supported.  We have them and regularly run sparse for xfsprogs for
example.

  parent reply	other threads:[~2015-08-24  6:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 16:37 shrink struct ib_send_wr Christoph Hellwig
     [not found] ` <1440002254-795-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-08-19 16:37   ` [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes Christoph Hellwig
2015-08-19 16:37     ` Christoph Hellwig
     [not found]     ` <1440002254-795-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-08-19 17:46       ` Jason Gunthorpe
2015-08-19 17:46         ` Jason Gunthorpe
2015-08-19 17:48         ` Christoph Hellwig
     [not found]           ` <20150819174802.GA13875-jcswGhMUV9g@public.gmane.org>
2015-08-19 17:54             ` Jason Gunthorpe
2015-08-19 17:54               ` Jason Gunthorpe
     [not found]               ` <20150819175425.GE22646-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-08-20  8:49                 ` Sagi Grimberg
2015-08-20  8:49                   ` Sagi Grimberg
     [not found]                   ` <55D594B3.7090807-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-08-20 22:30                     ` Steve Wise
2015-08-20 22:30                       ` Steve Wise
     [not found]         ` <20150819174614.GC22646-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-08-19 19:50           ` Hefty, Sean
2015-08-19 19:50             ` Hefty, Sean
2015-08-20  9:22             ` Christoph Hellwig
2015-08-20  8:52     ` Sagi Grimberg
     [not found]       ` <55D59553.4080306-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-08-22  6:38         ` Haggai Eran
2015-08-22  6:38           ` Haggai Eran
2015-08-22  8:25           ` Christoph Hellwig
2015-08-24  6:52             ` Haggai Eran
     [not found]               ` <55DABF1E.2050804-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-08-24  6:55                 ` Christoph Hellwig [this message]
2015-08-24  6:55                   ` Christoph Hellwig
     [not found]                   ` <20150824065501.GA31990-jcswGhMUV9g@public.gmane.org>
2015-08-24  7:59                     ` Haggai Eran
2015-08-24  7:59                       ` Haggai Eran
2015-08-25  8:55                       ` Christoph Hellwig
2015-08-19 16:37   ` [PATCH 3/3] IB: remove xrc_remote_srq_num from struct ib_send_wr Christoph Hellwig
     [not found]     ` <1440002254-795-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-08-19 17:48       ` Jason Gunthorpe
2015-08-20  8:57       ` Sagi Grimberg
2015-08-20  9:01   ` shrink " Sagi Grimberg
2015-08-26  9:00 shrink struct ib_send_wr V3 Christoph Hellwig
2015-08-26  9:00 ` [PATCH 1/3] IB/uverbs: reject invalid or unknown opcodes Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150824065501.GA31990@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.