Re: [PATCH v3] deb-pkg: add source package

From: Ben Hutchings <ben@decadent.org.uk>
To: Michal Marek <mmarek@suse.cz>
Cc: riku.voipio@linaro.org, linux-kbuild@vger.kernel.org,
	debian-kernel@lists.debian.org,
	Chris J Arges <chris.j.arges@canonical.com>,
	maximilian attems <maks@stro.at>
Subject: Re: [PATCH v3] deb-pkg: add source package
Date: Fri, 21 Aug 2015 11:08:44 +0200	[thread overview]
Message-ID: <1440148124.2632.39.camel@decadent.org.uk> (raw)
In-Reply-To: <55D4867B.40802@suse.cz>

[-- Attachment #1: Type: text/plain, Size: 2106 bytes --]

On Wed, 2015-08-19 at 15:36 +0200, Michal Marek wrote:
> On 2015-06-11 10:11, riku.voipio@linaro.org wrote:
> > From: Riku Voipio <riku.voipio@linaro.org>
> > 
> > Make deb-pkg build both source and binary package like make rpm-pkg does.
> > For people who only need binary kernel package, there is now bindeb-pkg
> > target, same target also used to build the .deb files if built from the
> > source package using dpkg-buildpackage.
> > 
> > Generated source package will build the same kernel .config than what
> > was available for make deb-pkg. The name of the source package can
> > be set with KDEB_SOURCENAME enviroment variable.
> > 
> > The source package is useful for gpl compliance, or for feeding to a
> > automated debian package builder.
> > 
> > Cc: Chris J Arges <chris.j.arges@canonical.com>
> > Cc: maximilian attems <maks@stro.at>
> > Cc: Ben Hutchings <ben@decadent.org.uk>
> > Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> > ---
> > v3,
> >  * Allow setting source package name with KDEB_SOURCENAME
> >  * Fix issues noted by Ben: drop python and fix target in debian/rules
> >  * Merge "ensure $MAKE can use jobserver" oneliner from Chris J Arges
> 
> Ben,
> 
> are you OK with the v3 of this patch?

I've gone through this with Riku and found a couple of problems:

- The 'clean' rule in the generated debian/rules calls 'make clean',
  but scripts/package/Makefile includes debian/ in clean-dirs.
  Currently that directory does not get removed for some reason, but I
  think that's a bug and the clean rule in debian/rules should guard
  against removal.
- Building of the 'orig' tarball uses git, i.e. it depends on the
  kernel source being in a git repository and not simply unpacked from
  a tarball (or from other VCS).  The rpmpkg target doesn't have this 
  same restriction.

I leave it to you to decide whether these are important enough to block
it.

Ben.

-- 
Ben Hutchings
Theory and practice are closer in theory than in practice.
                                - John Levine, moderator of comp.compilers

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]