From: Michal Marek <mmarek@suse.cz>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: riku.voipio@linaro.org, linux-kbuild@vger.kernel.org,
debian-kernel@lists.debian.org,
Chris J Arges <chris.j.arges@canonical.com>,
maximilian attems <maks@stro.at>
Subject: Re: [PATCH v3] deb-pkg: add source package
Date: Fri, 21 Aug 2015 14:38:23 +0200 [thread overview]
Message-ID: <20150821123823.GA24978@sepie.suse.cz> (raw)
In-Reply-To: <1440148124.2632.39.camel@decadent.org.uk>
On Fri, Aug 21, 2015 at 11:08:44AM +0200, Ben Hutchings wrote:
> I've gone through this with Riku and found a couple of problems:
>
> - The 'clean' rule in the generated debian/rules calls 'make clean',
> but scripts/package/Makefile includes debian/ in clean-dirs.
> Currently that directory does not get removed for some reason, but I
> think that's a bug and the clean rule in debian/rules should guard
> against removal.
Good catch. make clean is indeed supposed to delete the debian/
directory.
> - Building of the 'orig' tarball uses git, i.e. it depends on the
> kernel source being in a git repository and not simply unpacked from
> a tarball (or from other VCS). The rpmpkg target doesn't have this
> same restriction.
Right. make rpm uses the KBUILD_ALLDIRS to generate the tarball. It's
not perfect, but it behaves consistently.
Michal
next prev parent reply other threads:[~2015-08-21 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 8:11 [PATCH v3] deb-pkg: add source package riku.voipio
2015-08-19 13:36 ` Michal Marek
2015-08-21 9:08 ` Ben Hutchings
2015-08-21 12:38 ` Michal Marek [this message]
2015-08-21 14:40 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821123823.GA24978@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=ben@decadent.org.uk \
--cc=chris.j.arges@canonical.com \
--cc=debian-kernel@lists.debian.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=maks@stro.at \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.