[meta-raspberrypi][PATCH v2] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV

[meta-raspberrypi][PATCH v2] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV

[Jonathan Liu]

SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.

Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
index d60a3e9..ef98421 100644
--- a/recipes-kernel/linux/linux-raspberrypi.inc
+++ b/recipes-kernel/linux/linux-raspberrypi.inc
@@ -12,7 +12,8 @@ SRC_URI += " \
 
 COMPATIBLE_MACHINE = "raspberrypi"
 
-PV = "${LINUX_VERSION}+git${SRCREV}"
+PV = "${LINUX_VERSION}+git${SRCPV}"
+PR = "r1"
 
 # NOTE: For now we pull in the default config from the RPi kernel GIT tree.
 KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
-- 
2.5.0

Re: [meta-raspberrypi][PATCH v2] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV

[Jonathan Liu]

On 22/08/2015 6:25 PM, Jonathan Liu wrote:
> SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>   recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
> index d60a3e9..ef98421 100644
> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
> @@ -12,7 +12,8 @@ SRC_URI += " \
>   
>   COMPATIBLE_MACHINE = "raspberrypi"
>   
> -PV = "${LINUX_VERSION}+git${SRCREV}"
> +PV = "${LINUX_VERSION}+git${SRCPV}"
> +PR = "r1"
>   
>   # NOTE: For now we pull in the default config from the RPi kernel GIT tree.
>   KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
Bump.

Regards,
Jonathan

Re: [meta-raspberrypi][PATCH v2] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV

[Andrei Gherzan]

On Sun, Oct 04, 2015 at 10:42:26AM +1100, Jonathan Liu wrote:
> On 22/08/2015 6:25 PM, Jonathan Liu wrote:
> >SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
> >
> >Signed-off-by: Jonathan Liu <net147@gmail.com>
> >---
> >  recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
> >index d60a3e9..ef98421 100644
> >--- a/recipes-kernel/linux/linux-raspberrypi.inc
> >+++ b/recipes-kernel/linux/linux-raspberrypi.inc
> >@@ -12,7 +12,8 @@ SRC_URI += " \
> >  COMPATIBLE_MACHINE = "raspberrypi"
> >-PV = "${LINUX_VERSION}+git${SRCREV}"
> >+PV = "${LINUX_VERSION}+git${SRCPV}"
> >+PR = "r1"

Why would you want to bump PR? It will eventually end up being the same value,
right? The PV change makes sense and is a good idea. And even if it's not the
same value will trigger a new build cause PV will change.

> >  # NOTE: For now we pull in the default config from the RPi kernel GIT tree.
> >  KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
> Bump.
>
> Regards,
> Jonathan

--
Andrei Gherzan

Re: [meta-raspberrypi][PATCH v2] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV

[Jonathan Liu]

On 4/10/2015 11:04 AM, Andrei Gherzan wrote:
> On Sun, Oct 04, 2015 at 10:42:26AM +1100, Jonathan Liu wrote:
>> On 22/08/2015 6:25 PM, Jonathan Liu wrote:
>>> SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
>>>
>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>> ---
>>>   recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
>>> index d60a3e9..ef98421 100644
>>> --- a/recipes-kernel/linux/linux-raspberrypi.inc
>>> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
>>> @@ -12,7 +12,8 @@ SRC_URI += " \
>>>   COMPATIBLE_MACHINE = "raspberrypi"
>>> -PV = "${LINUX_VERSION}+git${SRCREV}"
>>> +PV = "${LINUX_VERSION}+git${SRCPV}"
>>> +PR = "r1"
> Why would you want to bump PR? It will eventually end up being the same value,
> right? The PV change makes sense and is a good idea. And even if it's not the
> same value will trigger a new build cause PV will change.
Without bumping PR, the version went backwards for me.
The v1 patch posted earlier on the ML doesn't bump PR if you prefer that.

Regards,
Jonathan

Re: [meta-raspberrypi][PATCH v2] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV

[Jonathan Liu]

On 4/10/2015 12:17 PM, Jonathan Liu wrote:
> On 4/10/2015 11:04 AM, Andrei Gherzan wrote:
>> On Sun, Oct 04, 2015 at 10:42:26AM +1100, Jonathan Liu wrote:
>>> On 22/08/2015 6:25 PM, Jonathan Liu wrote:
>>>> SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
>>>>
>>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>>> ---
>>>>   recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
>>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc 
>>>> b/recipes-kernel/linux/linux-raspberrypi.inc
>>>> index d60a3e9..ef98421 100644
>>>> --- a/recipes-kernel/linux/linux-raspberrypi.inc
>>>> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
>>>> @@ -12,7 +12,8 @@ SRC_URI += " \
>>>>   COMPATIBLE_MACHINE = "raspberrypi"
>>>> -PV = "${LINUX_VERSION}+git${SRCREV}"
>>>> +PV = "${LINUX_VERSION}+git${SRCPV}"
>>>> +PR = "r1"
>> Why would you want to bump PR? It will eventually end up being the 
>> same value,
>> right? The PV change makes sense and is a good idea. And even if it's 
>> not the
>> same value will trigger a new build cause PV will change.
> Without bumping PR, the version went backwards for me.
> The v1 patch posted earlier on the ML doesn't bump PR if you prefer that.
Now that I think about, bumping PR doesn't make any sense at all as it 
is after the git revision.
If anything, PE should be bumped to 1. Should I bump PE instead or just 
go with v1 patch?

Regards,
Jonathan