* [PATCH v2] coccinelle: add style check for assignment in if
@ 2015-08-22 17:04 ` Kris Borer
0 siblings, 0 replies; 6+ messages in thread
From: Kris Borer @ 2015-08-22 17:04 UTC (permalink / raw)
To: Julia.Lawall
Cc: Gilles.Muller, nicolas.palix, mmarek, linux-kernel, cocci, Kris Borer
Add a semantic patch for fixing some cases of checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Kris Borer <kborer@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
scripts/coccinelle/style/assignment_in_if.cocci | 128 ++++++++++++++++++++++++
1 file changed, 128 insertions(+)
create mode 100644 scripts/coccinelle/style/assignment_in_if.cocci
diff --git a/scripts/coccinelle/style/assignment_in_if.cocci b/scripts/coccinelle/style/assignment_in_if.cocci
new file mode 100644
index 0000000..b23db8f
--- /dev/null
+++ b/scripts/coccinelle/style/assignment_in_if.cocci
@@ -0,0 +1,128 @@
+/// move assignments out of if conditions
+///
+//# This script is designed to correct code where assignments exist in if
+//# conditions. It is only capable of handling a subset of such problems.
+//# Ideally it would handle all checkpatch errors of the following type:
+//# ERROR: do not use assignment in if condition
+//#
+//# For example:
+//# if(result = myfun())
+//#
+//# would become:
+//# result = myfun();
+//# if(result)
+//
+// Confidence: Moderate
+// Copyright: (C) 2015 Kris Borer. GPLv2.
+// URL: http://coccinelle.lip6.fr/
+// Comments:
+// Options: --no-includes --include-headers
+
+virtual patch
+
+
+// if ( (ret = call()) )
+// if ( (ret = call()) < 0 )
+@if1@
+expression i;
+expression E, E2;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+- (i = E)
++ i
+ b ...
+|
+- (i = E),
+ E2
+)
+ ) S1 else S2
+
+
+// if ( ptr->fun && (ret = ptr->fun()) )
+@if2@
+expression i2;
+expression E1, E2;
+@@
+
++ if( E1 ) {
++ i2 = E2;
++ if (i2) {
+- if( E1 && (i2 = E2) ) {
+ ...
+- }
++ }
++ }
+
+
+// if ( ptr->fun && (ret = ptr->fun()) < 0 )
+@if3@
+expression i2;
+expression E1, E2;
+constant c;
+binary operator b;
+@@
+
++ if( E1 ) {
++ i2 = E2;
++ if (i2 b c) {
+- if( E1 && ((i2 = E2) b c) ) {
+ ...
+- }
++ }
++ }
+
+
+// if ( (ret = call()) && ret != -1 )
+// if ( (ret = call()) < 0 && ret != -1 )
+@if4@
+expression i;
+expression E, E2;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+ (
+- (i = E)
++ i
+ b
+ ...)
+)
+ && E2 ) S1 else S2
+
+
+// if ( (ret = call()) && ret != -1 && ret != -2 )
+// if ( (ret = call()) < 0 && ret != -1 && ret != -2 )
+@if5@
+expression i;
+expression E, E2, E3;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+ (
+- (i = E)
++ i
+ b
+ ...)
+)
+ && E2 && E3 ) S1 else S2
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Cocci] [PATCH v2] coccinelle: add style check for assignment in if
@ 2015-08-22 17:04 ` Kris Borer
0 siblings, 0 replies; 6+ messages in thread
From: Kris Borer @ 2015-08-22 17:04 UTC (permalink / raw)
To: cocci
Add a semantic patch for fixing some cases of checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Kris Borer <kborer@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
scripts/coccinelle/style/assignment_in_if.cocci | 128 ++++++++++++++++++++++++
1 file changed, 128 insertions(+)
create mode 100644 scripts/coccinelle/style/assignment_in_if.cocci
diff --git a/scripts/coccinelle/style/assignment_in_if.cocci b/scripts/coccinelle/style/assignment_in_if.cocci
new file mode 100644
index 0000000..b23db8f
--- /dev/null
+++ b/scripts/coccinelle/style/assignment_in_if.cocci
@@ -0,0 +1,128 @@
+/// move assignments out of if conditions
+///
+//# This script is designed to correct code where assignments exist in if
+//# conditions. It is only capable of handling a subset of such problems.
+//# Ideally it would handle all checkpatch errors of the following type:
+//# ERROR: do not use assignment in if condition
+//#
+//# For example:
+//# if(result = myfun())
+//#
+//# would become:
+//# result = myfun();
+//# if(result)
+//
+// Confidence: Moderate
+// Copyright: (C) 2015 Kris Borer. GPLv2.
+// URL: http://coccinelle.lip6.fr/
+// Comments:
+// Options: --no-includes --include-headers
+
+virtual patch
+
+
+// if ( (ret = call()) )
+// if ( (ret = call()) < 0 )
+@if1@
+expression i;
+expression E, E2;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+- (i = E)
++ i
+ b ...
+|
+- (i = E),
+ E2
+)
+ ) S1 else S2
+
+
+// if ( ptr->fun && (ret = ptr->fun()) )
+ at if2@
+expression i2;
+expression E1, E2;
+@@
+
++ if( E1 ) {
++ i2 = E2;
++ if (i2) {
+- if( E1 && (i2 = E2) ) {
+ ...
+- }
++ }
++ }
+
+
+// if ( ptr->fun && (ret = ptr->fun()) < 0 )
+ at if3@
+expression i2;
+expression E1, E2;
+constant c;
+binary operator b;
+@@
+
++ if( E1 ) {
++ i2 = E2;
++ if (i2 b c) {
+- if( E1 && ((i2 = E2) b c) ) {
+ ...
+- }
++ }
++ }
+
+
+// if ( (ret = call()) && ret != -1 )
+// if ( (ret = call()) < 0 && ret != -1 )
+ at if4@
+expression i;
+expression E, E2;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+ (
+- (i = E)
++ i
+ b
+ ...)
+)
+ && E2 ) S1 else S2
+
+
+// if ( (ret = call()) && ret != -1 && ret != -2 )
+// if ( (ret = call()) < 0 && ret != -1 && ret != -2 )
+@if5@
+expression i;
+expression E, E2, E3;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+ (
+- (i = E)
++ i
+ b
+ ...)
+)
+ && E2 && E3 ) S1 else S2
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] coccinelle: add style check for assignment in if
2016-02-09 8:27 ` SF Markus Elfring
@ 2016-02-09 9:18 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-02-09 9:18 UTC (permalink / raw)
To: SF Markus Elfring
Cc: Kris Borer, Michal Marek, Gilles Muller, Nicolas Palix,
linux-kernel, cocci
On Tue, 9 Feb 2016, SF Markus Elfring wrote:
> > +virtual patch
>
> How do you think about to use this variable in a subsequent
> SmPL rule?
>
> Would you like to consider also the reuse of SmPL variables
> like "org" and "report"?
I think that there is no point for these things, because checkpatch
already gives warnings about this issue.
It could be nice for the provided rules to actually depend on patch. But
in the context of make coccicheck, it doesn't matter, because attempts to
run the rule in another mode will just fail, due to the mode not being
declared.
julia
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] coccinelle: add style check for assignment in if
2016-02-08 12:46 Kris Borer
@ 2016-02-09 8:27 ` SF Markus Elfring
2016-02-09 9:18 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: SF Markus Elfring @ 2016-02-09 8:27 UTC (permalink / raw)
To: Kris Borer
Cc: Michal Marek, Julia Lawall, Gilles Muller, Nicolas Palix,
linux-kernel, cocci
> +virtual patch
How do you think about to use this variable in a subsequent
SmPL rule?
Would you like to consider also the reuse of SmPL variables
like "org" and "report"?
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] coccinelle: add style check for assignment in if
@ 2016-02-08 12:46 Kris Borer
2016-02-09 8:27 ` SF Markus Elfring
0 siblings, 1 reply; 6+ messages in thread
From: Kris Borer @ 2016-02-08 12:46 UTC (permalink / raw)
To: mmarek
Cc: Julia.Lawall, Gilles.Muller, nicolas.palix, linux-kernel, cocci,
Kris Borer
Add a semantic patch for fixing some cases of checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Kris Borer <kborer@gmail.com>
---
scripts/coccinelle/style/assignment_in_if.cocci | 128 ++++++++++++++++++++++++
1 file changed, 128 insertions(+)
create mode 100644 scripts/coccinelle/style/assignment_in_if.cocci
diff --git a/scripts/coccinelle/style/assignment_in_if.cocci b/scripts/coccinelle/style/assignment_in_if.cocci
new file mode 100644
index 0000000..b23db8f
--- /dev/null
+++ b/scripts/coccinelle/style/assignment_in_if.cocci
@@ -0,0 +1,128 @@
+/// move assignments out of if conditions
+///
+//# This script is designed to correct code where assignments exist in if
+//# conditions. It is only capable of handling a subset of such problems.
+//# Ideally it would handle all checkpatch errors of the following type:
+//# ERROR: do not use assignment in if condition
+//#
+//# For example:
+//# if(result = myfun())
+//#
+//# would become:
+//# result = myfun();
+//# if(result)
+//
+// Confidence: Moderate
+// Copyright: (C) 2015 Kris Borer. GPLv2.
+// URL: http://coccinelle.lip6.fr/
+// Comments:
+// Options: --no-includes --include-headers
+
+virtual patch
+
+
+// if ( (ret = call()) )
+// if ( (ret = call()) < 0 )
+@if1@
+expression i;
+expression E, E2;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+- (i = E)
++ i
+ b ...
+|
+- (i = E),
+ E2
+)
+ ) S1 else S2
+
+
+// if ( ptr->fun && (ret = ptr->fun()) )
+@if2@
+expression i2;
+expression E1, E2;
+@@
+
++ if( E1 ) {
++ i2 = E2;
++ if (i2) {
+- if( E1 && (i2 = E2) ) {
+ ...
+- }
++ }
++ }
+
+
+// if ( ptr->fun && (ret = ptr->fun()) < 0 )
+@if3@
+expression i2;
+expression E1, E2;
+constant c;
+binary operator b;
+@@
+
++ if( E1 ) {
++ i2 = E2;
++ if (i2 b c) {
+- if( E1 && ((i2 = E2) b c) ) {
+ ...
+- }
++ }
++ }
+
+
+// if ( (ret = call()) && ret != -1 )
+// if ( (ret = call()) < 0 && ret != -1 )
+@if4@
+expression i;
+expression E, E2;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+ (
+- (i = E)
++ i
+ b
+ ...)
+)
+ && E2 ) S1 else S2
+
+
+// if ( (ret = call()) && ret != -1 && ret != -2 )
+// if ( (ret = call()) < 0 && ret != -1 && ret != -2 )
+@if5@
+expression i;
+expression E, E2, E3;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+ (
+- (i = E)
++ i
+ b
+ ...)
+)
+ && E2 && E3 ) S1 else S2
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] coccinelle: add style check for assignment in if
@ 2015-11-17 16:34 Kris Borer
0 siblings, 0 replies; 6+ messages in thread
From: Kris Borer @ 2015-11-17 16:34 UTC (permalink / raw)
To: mmarek
Cc: Julia.Lawall, Gilles.Muller, nicolas.palix, linux-kernel, cocci,
Kris Borer
Add a semantic patch for fixing some cases of checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Kris Borer <kborer@gmail.com>
---
scripts/coccinelle/style/assignment_in_if.cocci | 128 ++++++++++++++++++++++++
1 file changed, 128 insertions(+)
create mode 100644 scripts/coccinelle/style/assignment_in_if.cocci
diff --git a/scripts/coccinelle/style/assignment_in_if.cocci b/scripts/coccinelle/style/assignment_in_if.cocci
new file mode 100644
index 0000000..b23db8f
--- /dev/null
+++ b/scripts/coccinelle/style/assignment_in_if.cocci
@@ -0,0 +1,128 @@
+/// move assignments out of if conditions
+///
+//# This script is designed to correct code where assignments exist in if
+//# conditions. It is only capable of handling a subset of such problems.
+//# Ideally it would handle all checkpatch errors of the following type:
+//# ERROR: do not use assignment in if condition
+//#
+//# For example:
+//# if(result = myfun())
+//#
+//# would become:
+//# result = myfun();
+//# if(result)
+//
+// Confidence: Moderate
+// Copyright: (C) 2015 Kris Borer. GPLv2.
+// URL: http://coccinelle.lip6.fr/
+// Comments:
+// Options: --no-includes --include-headers
+
+virtual patch
+
+
+// if ( (ret = call()) )
+// if ( (ret = call()) < 0 )
+@if1@
+expression i;
+expression E, E2;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+- (i = E)
++ i
+ b ...
+|
+- (i = E),
+ E2
+)
+ ) S1 else S2
+
+
+// if ( ptr->fun && (ret = ptr->fun()) )
+@if2@
+expression i2;
+expression E1, E2;
+@@
+
++ if( E1 ) {
++ i2 = E2;
++ if (i2) {
+- if( E1 && (i2 = E2) ) {
+ ...
+- }
++ }
++ }
+
+
+// if ( ptr->fun && (ret = ptr->fun()) < 0 )
+@if3@
+expression i2;
+expression E1, E2;
+constant c;
+binary operator b;
+@@
+
++ if( E1 ) {
++ i2 = E2;
++ if (i2 b c) {
+- if( E1 && ((i2 = E2) b c) ) {
+ ...
+- }
++ }
++ }
+
+
+// if ( (ret = call()) && ret != -1 )
+// if ( (ret = call()) < 0 && ret != -1 )
+@if4@
+expression i;
+expression E, E2;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+ (
+- (i = E)
++ i
+ b
+ ...)
+)
+ && E2 ) S1 else S2
+
+
+// if ( (ret = call()) && ret != -1 && ret != -2 )
+// if ( (ret = call()) < 0 && ret != -1 && ret != -2 )
+@if5@
+expression i;
+expression E, E2, E3;
+statement S1, S2;
+binary operator b;
+@@
+
++ i = E;
+ if (
+(
+- (i = E)
++ i
+|
+ (
+- (i = E)
++ i
+ b
+ ...)
+)
+ && E2 && E3 ) S1 else S2
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-09 9:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-22 17:04 [PATCH v2] coccinelle: add style check for assignment in if Kris Borer
2015-08-22 17:04 ` [Cocci] " Kris Borer
2015-11-17 16:34 Kris Borer
2016-02-08 12:46 Kris Borer
2016-02-09 8:27 ` SF Markus Elfring
2016-02-09 9:18 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.