[PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl

[PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl

[Andrea Adami]

After commit 24fde4d do_compile fails:

| mkfs.jffs2.c:70:21: fatal error: sys/acl.h: No such file or directory
|  #include <sys/acl.h>

This is a missing dependency on acl.
To fix this we add a check to disable xattr when acl is not in
DISTRO_FEATURES.

Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
 meta/recipes-devtools/mtd/mtd-utils_git.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb b/meta/recipes-devtools/mtd/mtd-utils_git.bb
index 8d4892a..6a388c8 100644
--- a/meta/recipes-devtools/mtd/mtd-utils_git.bb
+++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb
@@ -19,7 +19,8 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git \
 
 S = "${WORKDIR}/git/"
 
-EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include' 'BUILDDIR=${S}'"
+DISABLE_XATTR = "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '', '-DWITHOUT_XATTR', d)}"
+EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include ${DISABLE_XATTR}' 'BUILDDIR=${S}'"
 
 do_install () {
 	oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}
-- 
1.9.1

Re: [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl

[Patrick Ohly]

On Sat, 2015-08-22 at 23:59 +0200, Andrea Adami wrote:
> After commit 24fde4d do_compile fails:
> 
> | mkfs.jffs2.c:70:21: fatal error: sys/acl.h: No such file or directory
> |  #include <sys/acl.h>
> 
> This is a missing dependency on acl.
> To fix this we add a check to disable xattr when acl is not in
> DISTRO_FEATURES.

I'm unsure whether checking for acl is the right approach. If "xattr"
was added to DISTRO_FEATURES, I'd expect the xattr support in mtd-utils
to be enabled, even if that creates some additional dependencies.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.

Re: [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl

[Huang, Jie (Jackie)]

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-
> bounces@lists.openembedded.org] On Behalf Of Andrea Adami
> Sent: Sunday, August 23, 2015 5:59 AM
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl
> 
> After commit 24fde4d do_compile fails:
> 
> | mkfs.jffs2.c:70:21: fatal error: sys/acl.h: No such file or directory
> | #include <sys/acl.h>
> 
> This is a missing dependency on acl.
> To fix this we add a check to disable xattr when acl is not in DISTRO_FEATURES.

I think you should check the xattr distro feature, but only checking the DISTRO_FEATURES
can't ensure the dependency satisfied, why not use the PACKAGECONFIG, something like:

PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)}"
PACKAGECONFIG[xattr] = ", -DWITHOUT_XATTR,attr acl,"

Thanks,
Jackie


> 
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
>  meta/recipes-devtools/mtd/mtd-utils_git.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb b/meta/recipes-devtools/mtd/mtd-
> utils_git.bb
> index 8d4892a..6a388c8 100644
> --- a/meta/recipes-devtools/mtd/mtd-utils_git.bb
> +++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb
> @@ -19,7 +19,8 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git \
> 
>  S = "${WORKDIR}/git/"
> 
> -EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include'
> 'BUILDDIR=${S}'"
> +DISABLE_XATTR = "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '', '-DWITHOUT_XATTR', d)}"
> +EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include
> ${DISABLE_XATTR}' 'BUILDDIR=${S}'"
> 
>  do_install () {
>  	oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir}
> INCLUDEDIR=${includedir}
> --
> 1.9.1
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl

[Patrick Ohly]

On Wed, 2015-08-26 at 09:50 +0000, Huang, Jie (Jackie) wrote:
> 
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-
> > bounces@lists.openembedded.org] On Behalf Of Andrea Adami
> > Sent: Sunday, August 23, 2015 5:59 AM
> > To: openembedded-core@lists.openembedded.org
> > Subject: [OE-core] [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl
> > 
> > After commit 24fde4d do_compile fails:
> > 
> > | mkfs.jffs2.c:70:21: fatal error: sys/acl.h: No such file or directory
> > | #include <sys/acl.h>
> > 
> > This is a missing dependency on acl.
> > To fix this we add a check to disable xattr when acl is not in DISTRO_FEATURES.
> 
> I think you should check the xattr distro feature, but only checking the DISTRO_FEATURES
> can't ensure the dependency satisfied, why not use the PACKAGECONFIG, something like:
> 
> PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)}"
> PACKAGECONFIG[xattr] = ", -DWITHOUT_XATTR,attr acl,"

I agree that we should check the xattr distro feature. The actual patch
is a bit more complex, though, because PACKAGECONFIG cannot influence
EXTRA_OEMAKE, can it?

I'll reply with a patch that worked for me.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.

[PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

[Patrick Ohly]

The unconditional removal of -DWITHOUT_XATTR accidentally introduced a
compile-time dependency on "acl", because "sys/acl.h" gets
included. This caused random compile failures.

To fix this, we introduce a proper PACKAGECONFIG for the "xattr"
support, with the distro's "xattr" feature determining the
default. Setting the define must be done with custom code because
PACKAGECONFIG can only influence configure parameters.

The "acl" distro feature is not checked because although enabling
"xattr" support now triggers a build of acl, nothing from it will not
get included in the resulting target image. This seems more suitable
than not enabling xattr support in mtd-utils when acl support in the
distro is disabled.

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
---
 meta/recipes-devtools/mtd/mtd-utils_git.bb | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb b/meta/recipes-devtools/mtd/mtd-utils_git.bb
index 8d4892a..17dca77 100644
--- a/meta/recipes-devtools/mtd/mtd-utils_git.bb
+++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb
@@ -19,7 +19,13 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git \
 
 S = "${WORKDIR}/git/"
 
-EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include' 'BUILDDIR=${S}'"
+# xattr support creates an additional compile-time dependency on acl because
+# the sys/acl.h header is needed. libacl is not needed and thus enabling xattr
+# regardless whether acl is enabled or disabled in the distro should be okay.
+PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)}"
+PACKAGECONFIG[xattr] = ",,acl,"
+
+EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} ${@bb.utils.contains('PACKAGECONFIG', 'xattr', '', '-DWITHOUT_XATTR', d)} -I${S}/include' 'BUILDDIR=${S}'"
 
 do_install () {
 	oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}
-- 
2.1.4

Re: [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

[Mark Hatle]

While I haven't tried this, it is exactly what I would have expected.

Acked-by: Mark Hatle <mark.hatle@windriver.com>

On 8/26/15 11:10 AM, Patrick Ohly wrote:
> The unconditional removal of -DWITHOUT_XATTR accidentally introduced a
> compile-time dependency on "acl", because "sys/acl.h" gets
> included. This caused random compile failures.
> 
> To fix this, we introduce a proper PACKAGECONFIG for the "xattr"
> support, with the distro's "xattr" feature determining the
> default. Setting the define must be done with custom code because
> PACKAGECONFIG can only influence configure parameters.
> 
> The "acl" distro feature is not checked because although enabling
> "xattr" support now triggers a build of acl, nothing from it will not
> get included in the resulting target image. This seems more suitable
> than not enabling xattr support in mtd-utils when acl support in the
> distro is disabled.
> 
> Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
> ---
>  meta/recipes-devtools/mtd/mtd-utils_git.bb | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb b/meta/recipes-devtools/mtd/mtd-utils_git.bb
> index 8d4892a..17dca77 100644
> --- a/meta/recipes-devtools/mtd/mtd-utils_git.bb
> +++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb
> @@ -19,7 +19,13 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git \
>  
>  S = "${WORKDIR}/git/"
>  
> -EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include' 'BUILDDIR=${S}'"
> +# xattr support creates an additional compile-time dependency on acl because
> +# the sys/acl.h header is needed. libacl is not needed and thus enabling xattr
> +# regardless whether acl is enabled or disabled in the distro should be okay.
> +PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)}"
> +PACKAGECONFIG[xattr] = ",,acl,"
> +
> +EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} ${@bb.utils.contains('PACKAGECONFIG', 'xattr', '', '-DWITHOUT_XATTR', d)} -I${S}/include' 'BUILDDIR=${S}'"
>  
>  do_install () {
>  	oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}
> 

Re: [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

[Andre McCurdy]

On Wed, Aug 26, 2015 at 9:10 AM, Patrick Ohly <patrick.ohly@intel.com> wrote:
> The unconditional removal of -DWITHOUT_XATTR accidentally introduced a
> compile-time dependency on "acl", because "sys/acl.h" gets
> included. This caused random compile failures.
>
> To fix this, we introduce a proper PACKAGECONFIG for the "xattr"
> support, with the distro's "xattr" feature determining the
> default. Setting the define must be done with custom code because
> PACKAGECONFIG can only influence configure parameters.
>
> The "acl" distro feature is not checked because although enabling
> "xattr" support now triggers a build of acl, nothing from it will not
> get included in the resulting target image.

Typo?

> This seems more suitable
> than not enabling xattr support in mtd-utils when acl support in the
> distro is disabled.
>
> Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
> ---
>  meta/recipes-devtools/mtd/mtd-utils_git.bb | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb b/meta/recipes-devtools/mtd/mtd-utils_git.bb
> index 8d4892a..17dca77 100644
> --- a/meta/recipes-devtools/mtd/mtd-utils_git.bb
> +++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb
> @@ -19,7 +19,13 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git \
>
>  S = "${WORKDIR}/git/"
>
> -EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include' 'BUILDDIR=${S}'"
> +# xattr support creates an additional compile-time dependency on acl because
> +# the sys/acl.h header is needed. libacl is not needed and thus enabling xattr
> +# regardless whether acl is enabled or disabled in the distro should be okay.
> +PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)}"
> +PACKAGECONFIG[xattr] = ",,acl,"
> +
> +EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} ${@bb.utils.contains('PACKAGECONFIG', 'xattr', '', '-DWITHOUT_XATTR', d)} -I${S}/include' 'BUILDDIR=${S}'"
>
>  do_install () {
>         oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}
> --
> 2.1.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2428 bytes --]

On Aug 26, 2015 9:11 AM, "Patrick Ohly" <patrick.ohly@intel.com> wrote:
>
> The unconditional removal of -DWITHOUT_XATTR accidentally introduced a
> compile-time dependency on "acl", because "sys/acl.h" gets
> included. This caused random compile failures.
>
> To fix this, we introduce a proper PACKAGECONFIG for the "xattr"
> support, with the distro's "xattr" feature determining the
> default. Setting the define must be done with custom code because
> PACKAGECONFIG can only influence configure parameters.
>
> The "acl" distro feature is not checked because although enabling
> "xattr" support now triggers a build of acl, nothing from it will not
> get included in the resulting target image. This seems more suitable
> than not enabling xattr support in mtd-utils when acl support in the
> distro is disabled.
>
> Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
> ---
>  meta/recipes-devtools/mtd/mtd-utils_git.bb | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb
b/meta/recipes-devtools/mtd/mtd-utils_git.bb
> index 8d4892a..17dca77 100644
> --- a/meta/recipes-devtools/mtd/mtd-utils_git.bb
> +++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb
> @@ -19,7 +19,13 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git \
>
>  S = "${WORKDIR}/git/"
>
> -EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}'
'CFLAGS=${CFLAGS} -I${S}/include' 'BUILDDIR=${S}'"
> +# xattr support creates an additional compile-time dependency on acl
because
> +# the sys/acl.h header is needed. libacl is not needed and thus enabling
xattr
> +# regardless whether acl is enabled or disabled in the distro should be
okay.
> +PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'xattr',
'xattr', '', d)}"
> +PACKAGECONFIG[xattr] = ",,acl,"
> +
> +EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}'
'CFLAGS=${CFLAGS} ${@bb.utils.contains('PACKAGECONFIG', 'xattr', '',
'-DWITHOUT_XATTR', d)} -I${S}/include' 'BUILDDIR=${S}'"
>
Do I see a spurious " in the middle
>  do_install () {
>         oe_runmake install DESTDIR=${D} SBINDIR=${sbindir}
MANDIR=${mandir} INCLUDEDIR=${includedir}
> --
> 2.1.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #2: Type: text/html, Size: 3558 bytes --]

Re: [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl

[Huang, Jie (Jackie)]

> -----Original Message-----
> From: Patrick Ohly [mailto:patrick.ohly@intel.com]
> Sent: Thursday, August 27, 2015 12:04 AM
> To: Huang, Jie (Jackie); Hatle, Mark
> Cc: Andrea Adami; openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH v2] mtd-utils: disable xattr if DISTRO_FEATURES doesn't contain acl
> 
> On Wed, 2015-08-26 at 09:50 +0000, Huang, Jie (Jackie) wrote:
> >
> > > -----Original Message-----
> > > From: openembedded-core-bounces@lists.openembedded.org
> > > [mailto:openembedded-core- bounces@lists.openembedded.org] On Behalf
> > > Of Andrea Adami
> > > Sent: Sunday, August 23, 2015 5:59 AM
> > > To: openembedded-core@lists.openembedded.org
> > > Subject: [OE-core] [PATCH v2] mtd-utils: disable xattr if
> > > DISTRO_FEATURES doesn't contain acl
> > >
> > > After commit 24fde4d do_compile fails:
> > >
> > > | mkfs.jffs2.c:70:21: fatal error: sys/acl.h: No such file or
> > > | directory #include <sys/acl.h>
> > >
> > > This is a missing dependency on acl.
> > > To fix this we add a check to disable xattr when acl is not in DISTRO_FEATURES.
> >
> > I think you should check the xattr distro feature, but only checking
> > the DISTRO_FEATURES can't ensure the dependency satisfied, why not use the PACKAGECONFIG,
> something like:
> >
> > PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)}"
> > PACKAGECONFIG[xattr] = ", -DWITHOUT_XATTR,attr acl,"
> 
> I agree that we should check the xattr distro feature. The actual patch is a bit more complex, though,
> because PACKAGECONFIG cannot influence EXTRA_OEMAKE, can it?

Oh, I didn't notice it was for EXTRA_OEMAKE.

> 
> I'll reply with a patch that worked for me.

I see your patch, it looks fine to me.

Thanks,
Jackie

> 
> --
> Best Regards, Patrick Ohly
> 
> The content of this message is my personal opinion only and although I am an employee of Intel, the
> statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak
> on behalf of Intel on this matter.
> 
> 

Re: [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

[Patrick Ohly]

On Wed, 2015-08-26 at 12:16 -0700, Khem Raj wrote:
> 
> On Aug 26, 2015 9:11 AM, "Patrick Ohly" <patrick.ohly@intel.com>
> wrote:
> > +EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} ${@bb.utils.contains('PACKAGECONFIG', 'xattr', '', '-DWITHOUT_XATTR', d)} -I${S}/include' 'BUILDDIR=${S}'"
> >
> Do I see a spurious " in the middle

The one in bb.utils.contains()? That is there intentionally: it's for
the "xattr enabled" case, in which case nothing gets added to
EXTRA_OEMAKE.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.

Re: [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

[Patrick Ohly]

On Wed, 2015-08-26 at 12:02 -0700, Andre McCurdy wrote:
> On Wed, Aug 26, 2015 at 9:10 AM, Patrick Ohly <patrick.ohly@intel.com> wrote:
> > The unconditional removal of -DWITHOUT_XATTR accidentally introduced a
> > compile-time dependency on "acl", because "sys/acl.h" gets
> > included. This caused random compile failures.
> >
> > To fix this, we introduce a proper PACKAGECONFIG for the "xattr"
> > support, with the distro's "xattr" feature determining the
> > default. Setting the define must be done with custom code because
> > PACKAGECONFIG can only influence configure parameters.
> >
> > The "acl" distro feature is not checked because although enabling
> > "xattr" support now triggers a build of acl, nothing from it will not
> > get included in the resulting target image.
> 
> Typo?

Yes, the "not" needs to be removed. Can whoever merges the patch fix
that or should I send a revised version?

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.

Re: [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

[Khem Raj]

On Wed, Aug 26, 2015 at 11:43 PM, Patrick Ohly <patrick.ohly@intel.com> wrote:
> The one in bb.utils.contains()? That is there intentionally: it's for
> the "xattr enabled" case, in which case nothing gets added to
> EXTRA_OEMAKE.

is it required to have extra " ?
can it work without it

Re: [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

[Patrick Ohly]

On Thu, 2015-08-27 at 06:32 -0700, Khem Raj wrote:
> On Wed, Aug 26, 2015 at 11:43 PM, Patrick Ohly <patrick.ohly@intel.com> wrote:
> > The one in bb.utils.contains()? That is there intentionally: it's for
> > the "xattr enabled" case, in which case nothing gets added to
> > EXTRA_OEMAKE.
> 
> is it required to have extra " ?
> can it work without it

bb.utils.contains() expects exactly 5 parameters and has no defaults, so
no, that empty string cannot be omitted.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.