All of lore.kernel.org
 help / color / mirror / Atom feed
From: Haojian Zhuang <haojian.zhuang@linaro.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
	"leo.yan@linaro.org" <leo.yan@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Bintian Wang <bintian.wang@huawei.com>,
	Yiping Xu <xuyiping@hisilicon.com>, Wei Xu <xuwei5@hisilicon.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"guodong.xu@linaro.org" <guodong.xu@linaro.org>,
	Jian Zhang <zhangjian001@hisilicon.com>,
	Zhenwei Wang <Zhenwei.wang@hisilicon.com>,
	Haoju Mo <mohaoju@hisilicon.com>,
	Dan Zhao <dan.zhao@hisilicon.com>,
	"kongfei@hisilicon.com" <kongfei@hisilicon.com>,
	Guangyue Zeng <zengguangyue@hisilicon.com>
Subject: Re: [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node
Date: Tue, 25 Aug 2015 21:43:14 +0800	[thread overview]
Message-ID: <1440510194.10987.52.camel@linaro.org> (raw)
In-Reply-To: <20150825104256.GB13471@leverpostej>

On Tue, 2015-08-25 at 11:42 +0100, Mark Rutland wrote:
> > > Are you then going to hack GRUB, release a special HiKey version of
> > > GRUB, not support any other versions, and still can your firmware
> > > UEFI?
> > 
> > I don't need to hack GRUB at all.
> 
> Then it is working for you by pure chance alone.
> 
> Please listen to the advice you are being given here; we're trying to
> ensure that your platform functions (and continues to function) as best
> it can.

Since we discussed a lot on this, let's make a conclusion on it.

1. UEFI could append the reserved buffer in it's memory mapping.
2. These reserved buffer must be declared in DT, since we also need to
   support non-UEFI (uboot) at the same time.
3. Mailbox node should reference reserved buffer by phandle in DT. Then
   map the buffer as non-cacheable in driver.
4. These reserved buffer must use "no-map" property since it should be
   non-cacheable in driver.
5. A patch is necessary in kernel. If efi stub feature is enabled,
   arm kernel should not parse memory node or reserved memory buffer in
   DT any more. Arm kernel should either fetch memory information from 
   efi or DT. Currently arm kernel fetch both efi memory information and
   reserved buffer from DTB at the same time.

Do you agree on these points?

Regards
Haojian


WARNING: multiple messages have this Message-ID (diff)
From: Haojian Zhuang <haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: Leif Lindholm
	<leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Catalin Marinas <Catalin.Marinas-5wv7dgnIgG8@public.gmane.org>,
	Will Deacon <Will.Deacon-5wv7dgnIgG8@public.gmane.org>,
	Jassi Brar
	<jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Bintian Wang
	<bintian.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	Yiping Xu <xuyiping-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	Wei Xu <xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"guodong.xu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<guodong.xu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Jian Zhang <zhangjian001-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	Zhenwei Wang
	<Zhenwei.wang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	Haoju Mo <mohaoju-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	Dan Zhao <dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	kongfei@hisil
Subject: Re: [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node
Date: Tue, 25 Aug 2015 21:43:14 +0800	[thread overview]
Message-ID: <1440510194.10987.52.camel@linaro.org> (raw)
In-Reply-To: <20150825104256.GB13471@leverpostej>

On Tue, 2015-08-25 at 11:42 +0100, Mark Rutland wrote:
> > > Are you then going to hack GRUB, release a special HiKey version of
> > > GRUB, not support any other versions, and still can your firmware
> > > UEFI?
> > 
> > I don't need to hack GRUB at all.
> 
> Then it is working for you by pure chance alone.
> 
> Please listen to the advice you are being given here; we're trying to
> ensure that your platform functions (and continues to function) as best
> it can.

Since we discussed a lot on this, let's make a conclusion on it.

1. UEFI could append the reserved buffer in it's memory mapping.
2. These reserved buffer must be declared in DT, since we also need to
   support non-UEFI (uboot) at the same time.
3. Mailbox node should reference reserved buffer by phandle in DT. Then
   map the buffer as non-cacheable in driver.
4. These reserved buffer must use "no-map" property since it should be
   non-cacheable in driver.
5. A patch is necessary in kernel. If efi stub feature is enabled,
   arm kernel should not parse memory node or reserved memory buffer in
   DT any more. Arm kernel should either fetch memory information from 
   efi or DT. Currently arm kernel fetch both efi memory information and
   reserved buffer from DTB at the same time.

Do you agree on these points?

Regards
Haojian

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: haojian.zhuang@linaro.org (Haojian Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node
Date: Tue, 25 Aug 2015 21:43:14 +0800	[thread overview]
Message-ID: <1440510194.10987.52.camel@linaro.org> (raw)
In-Reply-To: <20150825104256.GB13471@leverpostej>

On Tue, 2015-08-25 at 11:42 +0100, Mark Rutland wrote:
> > > Are you then going to hack GRUB, release a special HiKey version of
> > > GRUB, not support any other versions, and still can your firmware
> > > UEFI?
> > 
> > I don't need to hack GRUB at all.
> 
> Then it is working for you by pure chance alone.
> 
> Please listen to the advice you are being given here; we're trying to
> ensure that your platform functions (and continues to function) as best
> it can.

Since we discussed a lot on this, let's make a conclusion on it.

1. UEFI could append the reserved buffer in it's memory mapping.
2. These reserved buffer must be declared in DT, since we also need to
   support non-UEFI (uboot) at the same time.
3. Mailbox node should reference reserved buffer by phandle in DT. Then
   map the buffer as non-cacheable in driver.
4. These reserved buffer must use "no-map" property since it should be
   non-cacheable in driver.
5. A patch is necessary in kernel. If efi stub feature is enabled,
   arm kernel should not parse memory node or reserved memory buffer in
   DT any more. Arm kernel should either fetch memory information from 
   efi or DT. Currently arm kernel fetch both efi memory information and
   reserved buffer from DTB at the same time.

Do you agree on these points?

Regards
Haojian

  reply	other threads:[~2015-08-25 13:43 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19  9:37 [PATCH v1 0/3] mailbox: hisilicon: add Hi6220 mailbox driver Leo Yan
2015-08-19  9:37 ` Leo Yan
2015-08-19  9:37 ` Leo Yan
2015-08-19  9:37 ` [PATCH v1 1/3] dt-bindings: mailbox: Document " Leo Yan
2015-08-19  9:37   ` Leo Yan
2015-08-25 11:17   ` Sudeep Holla
2015-08-25 11:17     ` Sudeep Holla
2015-08-25 11:17     ` Sudeep Holla
2015-08-25 13:01     ` Leo Yan
2015-08-25 13:01       ` Leo Yan
2015-08-25 13:01       ` Leo Yan
2015-08-19  9:37 ` [PATCH v1 2/3] mailbox: Hi6220: add " Leo Yan
2015-08-19  9:37   ` Leo Yan
2015-08-19  9:37 ` [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node Leo Yan
2015-08-19  9:37   ` Leo Yan
2015-08-21 18:40   ` Mark Rutland
2015-08-21 18:40     ` Mark Rutland
2015-08-21 18:40     ` Mark Rutland
2015-08-22 13:30     ` Leo Yan
2015-08-22 13:30       ` Leo Yan
2015-08-22 13:30       ` Leo Yan
2015-08-24  3:27       ` Leo Yan
2015-08-24  3:27         ` Leo Yan
2015-08-24  3:27         ` Leo Yan
2015-08-24  9:18     ` Leo Yan
2015-08-24  9:18       ` Leo Yan
2015-08-24  9:18       ` Leo Yan
2015-08-24  9:51       ` Mark Rutland
2015-08-24  9:51         ` Mark Rutland
2015-08-24  9:51         ` Mark Rutland
2015-08-24 10:19         ` Haojian Zhuang
2015-08-24 10:19           ` Haojian Zhuang
2015-08-24 10:19           ` Haojian Zhuang
2015-08-24 11:49           ` Leif Lindholm
2015-08-24 11:49             ` Leif Lindholm
2015-08-24 11:49             ` Leif Lindholm
2015-08-25  8:13             ` Haojian Zhuang
2015-08-25  8:13               ` Haojian Zhuang
2015-08-25  8:13               ` Haojian Zhuang
2015-08-25  9:46               ` Leif Lindholm
2015-08-25  9:46                 ` Leif Lindholm
2015-08-25  9:46                 ` Leif Lindholm
2015-08-25 10:15                 ` Haojian Zhuang
2015-08-25 10:15                   ` Haojian Zhuang
2015-08-25 10:15                   ` Haojian Zhuang
2015-08-25 10:40                   ` Leif Lindholm
2015-08-25 10:40                     ` Leif Lindholm
2015-08-25 10:40                     ` Leif Lindholm
2015-08-25 10:42                   ` Mark Rutland
2015-08-25 10:42                     ` Mark Rutland
2015-08-25 10:42                     ` Mark Rutland
2015-08-25 13:43                     ` Haojian Zhuang [this message]
2015-08-25 13:43                       ` Haojian Zhuang
2015-08-25 13:43                       ` Haojian Zhuang
2015-08-25 14:24                       ` Leif Lindholm
2015-08-25 14:24                         ` Leif Lindholm
2015-08-25 14:24                         ` Leif Lindholm
2015-08-25 14:51                         ` Ard Biesheuvel
2015-08-25 14:51                           ` Ard Biesheuvel
2015-08-25 14:51                           ` Ard Biesheuvel
2015-08-25 15:37                           ` Leif Lindholm
2015-08-25 15:37                             ` Leif Lindholm
2015-08-25 15:37                             ` Leif Lindholm
2015-08-25 15:45                             ` Ard Biesheuvel
2015-08-25 15:45                               ` Ard Biesheuvel
2015-08-25 15:45                               ` Ard Biesheuvel
2015-08-26  2:41                             ` Haojian Zhuang
2015-08-26  2:41                               ` Haojian Zhuang
2015-08-26  2:41                               ` Haojian Zhuang
2015-08-25 16:00                       ` Leo Yan
2015-08-25 16:00                         ` Leo Yan
2015-08-25 16:00                         ` Leo Yan
2015-08-26  1:25                         ` Haojian Zhuang
2015-08-26  1:25                           ` Haojian Zhuang
2015-08-26  1:25                           ` Haojian Zhuang
2015-08-26  6:59                           ` Leo Yan
2015-08-26  6:59                             ` Leo Yan
2015-08-26  6:59                             ` Leo Yan
2015-08-27 16:31                             ` Mark Rutland
2015-08-27 16:31                               ` Mark Rutland
2015-08-27 16:31                               ` Mark Rutland
2015-08-28  6:37                               ` Leo Yan
2015-08-28  6:37                                 ` Leo Yan
2015-08-28  6:37                                 ` Leo Yan
2015-08-27 15:54                           ` Daniel Thompson
2015-08-27 15:54                             ` Daniel Thompson
2015-08-27 15:54                             ` Daniel Thompson
2015-08-27 16:46                           ` Mark Rutland
2015-08-27 16:46                             ` Mark Rutland
2015-08-27 16:46                             ` Mark Rutland
2015-08-24 12:48           ` Mark Rutland
2015-08-24 12:48             ` Mark Rutland
2015-08-24 12:48             ` Mark Rutland
2015-08-25  8:04             ` Haojian Zhuang
2015-08-25  8:04               ` Haojian Zhuang
2015-08-25  8:04               ` Haojian Zhuang
2015-08-25 11:09               ` Mark Rutland
2015-08-25 11:09                 ` Mark Rutland
2015-08-25 11:09                 ` Mark Rutland
2015-08-25 11:36   ` Sudeep Holla
2015-08-25 11:36     ` Sudeep Holla
2015-08-25 11:36     ` Sudeep Holla
2015-08-25 14:04     ` Leo Yan
2015-08-25 14:04       ` Leo Yan
2015-08-25 14:04       ` Leo Yan
2015-08-25 14:13       ` Sudeep Holla
2015-08-25 14:13         ` Sudeep Holla
2015-08-25 14:13         ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440510194.10987.52.camel@linaro.org \
    --to=haojian.zhuang@linaro.org \
    --cc=Catalin.Marinas@arm.com \
    --cc=Pawel.Moll@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=Zhenwei.wang@hisilicon.com \
    --cc=bintian.wang@huawei.com \
    --cc=dan.zhao@hisilicon.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=guodong.xu@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jassisinghbrar@gmail.com \
    --cc=kongfei@hisilicon.com \
    --cc=leif.lindholm@linaro.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mohaoju@hisilicon.com \
    --cc=robh+dt@kernel.org \
    --cc=xuwei5@hisilicon.com \
    --cc=xuyiping@hisilicon.com \
    --cc=zengguangyue@hisilicon.com \
    --cc=zhangjian001@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.