All of lore.kernel.org
 help / color / mirror / Atom feed
From: Changsheng Liu <liuchangsheng@inspur.com>
To: <akpm@linux-foundation.org>, <isimatu.yasuaki@jp.fujitsu.com>,
	<vbabka@suse.cz>, <yasu.isimatu@gmail.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<wunan@inspur.com>, <yanxiaofeng@inspur.com>,
	<liuchangsheng@inspur.com>, <fandd@inspur.com>,
	Changsheng Liu <liuchangcheng@inspur.com>
Subject: [PATCH V4] mm: memory hot-add: memory can not be added to movable zone defaultly
Date: Mon, 31 Aug 2015 01:58:40 -0400	[thread overview]
Message-ID: <1441000720-28506-1-git-send-email-liuchangsheng@inspur.com> (raw)

From: Changsheng Liu <liuchangcheng@inspur.com>

After the user config CONFIG_MOVABLE_NODE and movable_node kernel option,
When the memory is hot added, should_add_memory_movable() return 0
because all zones including movable zone are empty,
so the memory that was hot added will be added  to the normal zone
and the normal zone will be created firstly.
But we want the whole node to be added to movable zone defaultly.

So we change should_add_memory_movable(): if the user config
CONFIG_MOVABLE_NODE and movable_node kernel option
it will always return 1 and all zones is empty at the same time,
so that the movable zone will be created firstly
and then the whole node will be added to movable zone defaultly.
If we want the node to be added to normal zone,
we can do it as follows:
"echo online_kernel > /sys/devices/system/memory/memoryXXX/state"

If the memory is added to movable zone defaultly,
the user can offline it and add it to other zone again.
But if the memory is added to normal zone defaultly,
the user will not offline the memory used by kernel.

Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Xiaofeng Yan <yanxiaofeng@inspur.com>
Signed-off-by: Changsheng Liu <liuchangcheng@inspur.com>
Tested-by: Dongdong Fan <fandd@inspur.com>
---
 mm/memory_hotplug.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 26fbba7..d1149ff 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1197,6 +1197,11 @@ static int should_add_memory_movable(int nid, u64 start, u64 size)
 	unsigned long start_pfn = start >> PAGE_SHIFT;
 	pg_data_t *pgdat = NODE_DATA(nid);
 	struct zone *movable_zone = pgdat->node_zones + ZONE_MOVABLE;
+	struct zone *normal_zone = pgdat->node_zones + ZONE_NORMAL;
+
+	if (movable_node_is_enabled()
+	&& (zone_end_pfn(normal_zone) <= start_pfn))
+		return 1;
 
 	if (zone_is_empty(movable_zone))
 		return 0;
-- 
1.7.1


WARNING: multiple messages have this Message-ID (diff)
From: Changsheng Liu <liuchangsheng@inspur.com>
To: akpm@linux-foundation.org, isimatu.yasuaki@jp.fujitsu.com,
	vbabka@suse.cz, yasu.isimatu@gmail.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	wunan@inspur.com, yanxiaofeng@inspur.com,
	liuchangsheng@inspur.com, fandd@inspur.com,
	Changsheng Liu <liuchangcheng@inspur.com>
Subject: [PATCH V4] mm: memory hot-add: memory can not be added to movable zone defaultly
Date: Mon, 31 Aug 2015 01:58:40 -0400	[thread overview]
Message-ID: <1441000720-28506-1-git-send-email-liuchangsheng@inspur.com> (raw)

From: Changsheng Liu <liuchangcheng@inspur.com>

After the user config CONFIG_MOVABLE_NODE and movable_node kernel option,
When the memory is hot added, should_add_memory_movable() return 0
because all zones including movable zone are empty,
so the memory that was hot added will be added  to the normal zone
and the normal zone will be created firstly.
But we want the whole node to be added to movable zone defaultly.

So we change should_add_memory_movable(): if the user config
CONFIG_MOVABLE_NODE and movable_node kernel option
it will always return 1 and all zones is empty at the same time,
so that the movable zone will be created firstly
and then the whole node will be added to movable zone defaultly.
If we want the node to be added to normal zone,
we can do it as follows:
"echo online_kernel > /sys/devices/system/memory/memoryXXX/state"

If the memory is added to movable zone defaultly,
the user can offline it and add it to other zone again.
But if the memory is added to normal zone defaultly,
the user will not offline the memory used by kernel.

Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Xiaofeng Yan <yanxiaofeng@inspur.com>
Signed-off-by: Changsheng Liu <liuchangcheng@inspur.com>
Tested-by: Dongdong Fan <fandd@inspur.com>
---
 mm/memory_hotplug.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 26fbba7..d1149ff 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1197,6 +1197,11 @@ static int should_add_memory_movable(int nid, u64 start, u64 size)
 	unsigned long start_pfn = start >> PAGE_SHIFT;
 	pg_data_t *pgdat = NODE_DATA(nid);
 	struct zone *movable_zone = pgdat->node_zones + ZONE_MOVABLE;
+	struct zone *normal_zone = pgdat->node_zones + ZONE_NORMAL;
+
+	if (movable_node_is_enabled()
+	&& (zone_end_pfn(normal_zone) <= start_pfn))
+		return 1;
 
 	if (zone_is_empty(movable_zone))
 		return 0;
-- 
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2015-08-31  5:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0bc3aaab6cea54112f1c444880f9b832@s.corp-email.com>
2015-08-31  5:58 ` Changsheng Liu [this message]
2015-08-31  5:58   ` [PATCH V4] mm: memory hot-add: memory can not be added to movable zone defaultly Changsheng Liu
2015-08-31 13:08   ` Vlastimil Babka
2015-08-31 13:08     ` Vlastimil Babka
2015-09-01  6:05     ` Changsheng Liu
2015-09-01  6:05       ` Changsheng Liu
2015-09-01 15:37   ` Yasuaki Ishimatsu
2015-09-01 15:37     ` Yasuaki Ishimatsu
2015-09-02  9:06     ` Changsheng Liu
2015-09-02  9:06       ` Changsheng Liu
2015-09-06  8:33     ` Changsheng Liu
2015-09-06  8:33       ` Changsheng Liu
2015-09-11 19:42       ` Yasuaki Ishimatsu
2015-09-11 19:42         ` Yasuaki Ishimatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441000720-28506-1-git-send-email-liuchangsheng@inspur.com \
    --to=liuchangsheng@inspur.com \
    --cc=akpm@linux-foundation.org \
    --cc=fandd@inspur.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuchangcheng@inspur.com \
    --cc=vbabka@suse.cz \
    --cc=wunan@inspur.com \
    --cc=yanxiaofeng@inspur.com \
    --cc=yasu.isimatu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.