* [PATCH v2] stmmac: fix check for phydev being open
@ 2015-09-07 20:50 Alexey Brodkin
2015-09-07 20:53 ` Sergei Shtylyov
2015-09-07 21:24 ` Sergei Shtylyov
0 siblings, 2 replies; 7+ messages in thread
From: Alexey Brodkin @ 2015-09-07 20:50 UTC (permalink / raw)
To: netdev
Cc: Alexey Brodkin, Giuseppe Cavallaro, linux-kernel, stable,
David Miller, Sergei Shtylyov
Current implementation via IS_ERR(phydev) may make no sense because
of_phy_attach() returns NULL on failure instead of error value.
Still for checking result of phy_connect() IS_ERR() is useful.
To address both situations we use combined IS_ERR_OR_NULL() check.
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Cc: David Miller <davem@davemloft.net>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
---
Changes compared to v1:
* Use IS_ERR_OR_NULL() instead of discrete checks for null and err
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 864b476..7985d8a 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -837,7 +837,7 @@ static int stmmac_init_phy(struct net_device *dev)
interface);
}
- if (IS_ERR(phydev)) {
+ if (IS_ERR_OR_NULL(phydev)) {
pr_err("%s: Could not attach to PHY\n", dev->name);
return PTR_ERR(phydev);
}
--
2.4.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] stmmac: fix check for phydev being open
2015-09-07 20:50 [PATCH v2] stmmac: fix check for phydev being open Alexey Brodkin
@ 2015-09-07 20:53 ` Sergei Shtylyov
2015-09-07 21:08 ` Alexey Brodkin
2015-09-07 21:24 ` Sergei Shtylyov
1 sibling, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2015-09-07 20:53 UTC (permalink / raw)
To: Alexey Brodkin, netdev
Cc: Giuseppe Cavallaro, linux-kernel, stable, David Miller
On 09/07/2015 11:50 PM, Alexey Brodkin wrote:
> Current implementation via IS_ERR(phydev) may make no sense because
> of_phy_attach() returns NULL on failure instead of error value.
>
> Still for checking result of phy_connect() IS_ERR() is useful.
>
> To address both situations we use combined IS_ERR_OR_NULL() check.
>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> Cc: David Miller <davem@davemloft.net>
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> ---
>
> Changes compared to v1:
> * Use IS_ERR_OR_NULL() instead of discrete checks for null and err
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 864b476..7985d8a 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -837,7 +837,7 @@ static int stmmac_init_phy(struct net_device *dev)
> interface);
> }
>
> - if (IS_ERR(phydev)) {
> + if (IS_ERR_OR_NULL(phydev)) {
> pr_err("%s: Could not attach to PHY\n", dev->name);
> return PTR_ERR(phydev);
Hm, in case of phydev == NULL, you're going to return 0 here... is that
what you want?
MBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] stmmac: fix check for phydev being open
2015-09-07 20:53 ` Sergei Shtylyov
@ 2015-09-07 21:08 ` Alexey Brodkin
0 siblings, 0 replies; 7+ messages in thread
From: Alexey Brodkin @ 2015-09-07 21:08 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: linux-kernel, davem, stable, peppe.cavallaro, netdev
Hi Sergei,
On Mon, 2015-09-07 at 23:53 +0300, Sergei Shtylyov wrote:
> On 09/07/2015 11:50 PM, Alexey Brodkin wrote:
>
> > Current implementation via IS_ERR(phydev) may make no sense because
> > of_phy_attach() returns NULL on failure instead of error value.
> >
> > Still for checking result of phy_connect() IS_ERR() is useful.
> >
> > To address both situations we use combined IS_ERR_OR_NULL() check.
> >
> > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> > Cc: linux-kernel@vger.kernel.org
> > Cc: stable@vger.kernel.org
> > Cc: David Miller <davem@davemloft.net>
> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > ---
> >
> > Changes compared to v1:
> > * Use IS_ERR_OR_NULL() instead of discrete checks for null and err
> >
> > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > index 864b476..7985d8a 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > @@ -837,7 +837,7 @@ static int stmmac_init_phy(struct net_device *dev)
> > interface);
> > }
> >
> > - if (IS_ERR(phydev)) {
> > + if (IS_ERR_OR_NULL(phydev)) {
> > pr_err("%s: Could not attach to PHY\n", dev->name);
> > return PTR_ERR(phydev);
>
> Hm, in case of phydev == NULL, you're going to return 0 here... is that
> what you want?
Ah, right.
So then the question would be what's a proper error code for !phydev:
-ENOENT or -ENODEV?
-Alexey
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] stmmac: fix check for phydev being open
@ 2015-09-07 21:08 ` Alexey Brodkin
0 siblings, 0 replies; 7+ messages in thread
From: Alexey Brodkin @ 2015-09-07 21:08 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: linux-kernel, davem, stable, peppe.cavallaro, netdev
Hi Sergei,
On Mon, 2015-09-07 at 23:53 +0300, Sergei Shtylyov wrote:
> On 09/07/2015 11:50 PM, Alexey Brodkin wrote:
>
> > Current implementation via IS_ERR(phydev) may make no sense because
> > of_phy_attach() returns NULL on failure instead of error value.
> >
> > Still for checking result of phy_connect() IS_ERR() is useful.
> >
> > To address both situations we use combined IS_ERR_OR_NULL() check.
> >
> > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> > Cc: linux-kernel@vger.kernel.org
> > Cc: stable@vger.kernel.org
> > Cc: David Miller <davem@davemloft.net>
> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > ---
> >
> > Changes compared to v1:
> > * Use IS_ERR_OR_NULL() instead of discrete checks for null and err
> >
> > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > index 864b476..7985d8a 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > @@ -837,7 +837,7 @@ static int stmmac_init_phy(struct net_device *dev)
> > interface);
> > }
> >
> > - if (IS_ERR(phydev)) {
> > + if (IS_ERR_OR_NULL(phydev)) {
> > pr_err("%s: Could not attach to PHY\n", dev->name);
> > return PTR_ERR(phydev);
>
> Hm, in case of phydev == NULL, you're going to return 0 here... is that
> what you want?
Ah, right.
So then the question would be what's a proper error code for !phydev:
-ENOENT or -ENODEV?
-Alexey
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] stmmac: fix check for phydev being open
2015-09-07 20:50 [PATCH v2] stmmac: fix check for phydev being open Alexey Brodkin
2015-09-07 20:53 ` Sergei Shtylyov
@ 2015-09-07 21:24 ` Sergei Shtylyov
2015-09-07 21:26 ` Alexey Brodkin
1 sibling, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2015-09-07 21:24 UTC (permalink / raw)
To: Alexey Brodkin, netdev
Cc: Giuseppe Cavallaro, linux-kernel, stable, David Miller
On 09/07/2015 11:50 PM, Alexey Brodkin wrote:
> Current implementation via IS_ERR(phydev) may make no sense because
> of_phy_attach() returns NULL on failure instead of error value.
Not of_phy_connect()?
> Still for checking result of phy_connect() IS_ERR() is useful.
>
> To address both situations we use combined IS_ERR_OR_NULL() check.
>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> Cc: David Miller <davem@davemloft.net>
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] stmmac: fix check for phydev being open
2015-09-07 21:24 ` Sergei Shtylyov
@ 2015-09-07 21:26 ` Alexey Brodkin
0 siblings, 0 replies; 7+ messages in thread
From: Alexey Brodkin @ 2015-09-07 21:26 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: linux-kernel, davem, stable, peppe.cavallaro, netdev
Hi Sergei,
On Tue, 2015-09-08 at 00:24 +0300, Sergei Shtylyov wrote:
> On 09/07/2015 11:50 PM, Alexey Brodkin wrote:
>
> > Current implementation via IS_ERR(phydev) may make no sense because
> > of_phy_attach() returns NULL on failure instead of error value.
>
> Not of_phy_connect()?
I already noticed this misspelling - it came from my exploration of
what happens inside of_phy_connect(). So sort of braindump.
I will fix in v3 re-spin.
-Alexey
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] stmmac: fix check for phydev being open
@ 2015-09-07 21:26 ` Alexey Brodkin
0 siblings, 0 replies; 7+ messages in thread
From: Alexey Brodkin @ 2015-09-07 21:26 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: linux-kernel, davem, stable, peppe.cavallaro, netdev
Hi Sergei,
On Tue, 2015-09-08 at 00:24 +0300, Sergei Shtylyov wrote:
> On 09/07/2015 11:50 PM, Alexey Brodkin wrote:
>
> > Current implementation via IS_ERR(phydev) may make no sense because
> > of_phy_attach() returns NULL on failure instead of error value.
>
> Not of_phy_connect()?
I already noticed this misspelling - it came from my exploration of
what happens inside of_phy_connect(). So sort of braindump.
I will fix in v3 re-spin.
-Alexey
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-09-07 21:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-07 20:50 [PATCH v2] stmmac: fix check for phydev being open Alexey Brodkin
2015-09-07 20:53 ` Sergei Shtylyov
2015-09-07 21:08 ` Alexey Brodkin
2015-09-07 21:08 ` Alexey Brodkin
2015-09-07 21:24 ` Sergei Shtylyov
2015-09-07 21:26 ` Alexey Brodkin
2015-09-07 21:26 ` Alexey Brodkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.