All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH, RESEND] gitk: adjust the menu line numbers to compensate for the new entry
@ 2015-09-07 23:16 Beat Bolli
  2015-09-13 12:24 ` Paul Mackerras
  0 siblings, 1 reply; 2+ messages in thread
From: Beat Bolli @ 2015-09-07 23:16 UTC (permalink / raw)
  To: git; +Cc: Beat Bolli, Paul Mackerras

Commit d835dbb9 ("gitk: Add a "Copy commit summary" command",
2015-08-13) in the upstream gitk repo added a new context menu entry.
Therefore, the line numbers of the entries below the new one need to be
adjusted when their text or state is changed.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
Cc: Paul Mackerras <paulus@samba.org>
---
 gitk-git/gitk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gitk-git/gitk b/gitk-git/gitk
index d05169a..bc0e586 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -8877,13 +8877,13 @@ proc rowmenu {x y id} {
     if {$id ne $nullid && $id ne $nullid2} {
 	set menu $rowctxmenu
 	if {$mainhead ne {}} {
-	    $menu entryconfigure 7 -label [mc "Reset %s branch to here" $mainhead] -state normal
+	    $menu entryconfigure 8 -label [mc "Reset %s branch to here" $mainhead] -state normal
 	} else {
-	    $menu entryconfigure 7 -label [mc "Detached head: can't reset" $mainhead] -state disabled
+	    $menu entryconfigure 8 -label [mc "Detached head: can't reset" $mainhead] -state disabled
 	}
-	$menu entryconfigure 9 -state $mstate
 	$menu entryconfigure 10 -state $mstate
 	$menu entryconfigure 11 -state $mstate
+	$menu entryconfigure 12 -state $mstate
     } else {
 	set menu $fakerowmenu
     }
-- 
2.5.0.492.g918e48c

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH, RESEND] gitk: adjust the menu line numbers to compensate for the new entry
  2015-09-07 23:16 [PATCH, RESEND] gitk: adjust the menu line numbers to compensate for the new entry Beat Bolli
@ 2015-09-13 12:24 ` Paul Mackerras
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Mackerras @ 2015-09-13 12:24 UTC (permalink / raw)
  To: Beat Bolli; +Cc: git

On Tue, Sep 08, 2015 at 01:16:37AM +0200, Beat Bolli wrote:
> Commit d835dbb9 ("gitk: Add a "Copy commit summary" command",
> 2015-08-13) in the upstream gitk repo added a new context menu entry.
> Therefore, the line numbers of the entries below the new one need to be
> adjusted when their text or state is changed.
> 
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> Cc: Paul Mackerras <paulus@samba.org>

Thanks, applied.

Paul.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-13 12:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-07 23:16 [PATCH, RESEND] gitk: adjust the menu line numbers to compensate for the new entry Beat Bolli
2015-09-13 12:24 ` Paul Mackerras

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.