patchset for fgetgrent fgetpwent getspnam mallinfo sigpause and termios

patchset for fgetgrent fgetpwent getspnam mallinfo sigpause and termios

[Zeng Linggang]

Hello,

This patchset is for fgetgrent.3, fgetpwent.3, sigpause.3, termios.3,
getspnam.3 and mallinfo.3

1. fgetgrent.3 and fgetpwent.3:
   We have some discussions about these two functions, the Subject:
   "Re: question about markings of fgetgrent and fgetpwent"
   However, something about the copyright impeded the progress.
   I am sorry for that, if you are OK, please see these two patches below,
   I have added some "FIXME:" descriptions in them.

2. getspnam.3
   getspnam.3 is a little like fgetgrent.3 and fgetpwent.3, but there are not
   markings in glibc document. I use the function names for the identifiers like
   fgetgrent.3 and fgetpwent.3.

3. mallinfo.3
   Hope the descriptions about "const:mallopt" could explain clearly enough in
   the patch.

4. sigpause.3 and termios.3
   These two functions are safety in Linux kernel, the markings in glibc manual
   are more detailed. I also have added some "FIXME:" descriptions in them.


Thanks and best regards,
Zeng
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] fgetgrent.3: ATTRIBUTES: Note function that is not thread-safe

[Zeng Linggang]

The marking matches glibc marking.
marking of function in glibc is:
- fgetgrent: MT-Unsafe race:fgrent

ps: We think race:fgrent in glibc maybe hard for users to understand,
and have sent a patch to the GNU libc community for changing it to
race:fgetgrent, however, something about the copyright impeded the progress.
Here we mark it "race:fgetgrent", so there is a little different.

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/fgetgrent.3 | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/man3/fgetgrent.3 b/man3/fgetgrent.3
index 57665dd..aa08e0f 100644
--- a/man3/fgetgrent.3
+++ b/man3/fgetgrent.3
@@ -90,6 +90,25 @@ is set to indicate the cause.
 Insufficient memory to allocate
 .I group
 structure.
+.SH ATTRIBUTES
+For an explanation of the terms used in this section, see
+.BR attributes (7).
+.TS
+allbox;
+lb lb lb
+l l l.
+Interface	Attribute	Value
+T{
+.BR fgetgrent ()
+.\" FIXME: the following marking is different from which in glibc manual,
+.\" marking in glibc manual is,
+.\" fgetgrent: MT-Unsafe race:fgrent
+.\" We think race:fgrent in glibc maybe hard for users to understand,
+.\" and have sent a patch to the GNU libc community for changing it to
+.\" race:fgetgrent, however, something about the copyright impeded the progress.
+T}	Thread safety	MT-Unsafe race:fgetgrent
+.TE
+
 .SH CONFORMING TO
 SVr4.
 .SH SEE ALSO
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] fgetpwent.3: ATTRIBUTES: Note function that is not thread-safe

[Zeng Linggang]

The marking matches glibc marking.
marking of function in glibc is:
- fgetgrent: MT-Unsafe race:fpwent

ps: We think race:fpwent in glibc maybe hard for users to understand,
and have sent a patch to the GNU libc community for changing it to
race:fgetpwent, however, something about the copyright impeded the progress.
Here we mark it "race:fgetpwent", so there is a little different.

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/fgetpwent.3 | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/man3/fgetpwent.3 b/man3/fgetpwent.3
index 3076494..84e0379 100644
--- a/man3/fgetpwent.3
+++ b/man3/fgetpwent.3
@@ -98,6 +98,22 @@ structure.
 .TP
 .I /etc/passwd
 password database file
+.TS
+allbox;
+lb lb lb
+l l l.
+Interface	Attribute	Value
+T{
+.BR fgetpwent ()
+.\" FIXME: the following marking is different from which in glibc manual,
+.\" marking in glibc manual is,
+.\" fgetpwent: MT-Unsafe race:fpwent
+.\" We think race:fpwent in glibc maybe hard for users to understand,
+.\" and have sent a patch to the GNU libc community for changing it to
+.\" race:fgetpwent, however, something about the copyright impeded the progress.
+T}	Thread safety	MT-Unsafe race:fgetpwent
+.TE
+
 .SH CONFORMING TO
 SVr4.
 .SH SEE ALSO
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] getspnam.3: ATTRIBUTES: Note functions that are/aren't thread-safe

[Zeng Linggang]

After research, We think
* getspnam(),
* getspent(),
* setspent(),
* endspent(),
* getspent_r(),
* fgetspent(),
* sgetspent(),
are not thread-safe. And
* putspent(),
* getspnam_r(),
* sgetspent_r(),
* lckpwdf(),
* ulckpwdf(),
* fgetspent_r(),
are thread-safe. But, there are not
markings of them in glibc document.

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/getspnam.3 | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/man3/getspnam.3 b/man3/getspnam.3
index 43ee61c..9efd643 100644
--- a/man3/getspnam.3
+++ b/man3/getspnam.3
@@ -246,6 +246,66 @@ The include file
 defines the constant
 .B _PATH_SHADOW
 to the pathname of the shadow password file.
+.SH ATTRIBUTES
+For an explanation of the terms used in this section, see
+.BR attributes (7).
+.TS
+allbox;
+lbw25 lb lbw30
+l l l.
+Interface	Attribute	Value
+T{
+.BR getspnam ()
+T}	Thread safety	T{
+MT-Unsafe race:getspnam locale
+T}
+T{
+.BR getspent ()
+T}	Thread safety	T{
+MT-Unsafe race:getspent
+.br
+race:spentbuf locale
+T}
+T{
+.BR setspent (),
+.BR endspent (),
+.br
+.BR getspent_r ()
+T}	Thread safety	T{
+MT-Unsafe race:getspent locale
+T}
+T{
+.BR fgetspent ()
+T}	Thread safety	MT-Unsafe race:fgetspent
+T{
+.BR sgetspent ()
+T}	Thread safety	MT-Unsafe race:sgetspent
+T{
+.BR putspent (),
+.BR getspnam_r (),
+.br
+.BR sgetspent_r ()
+T}	Thread safety	MT-Safe locale
+T{
+.BR lckpwdf (),
+.BR ulckpwdf (),
+.br
+.BR fgetspent_r ()
+T}	Thread safety	MT-Safe
+.TE
+
+In the above table,
+.I getspent
+in
+.I race:getspent
+signifies that if any of the functions
+.BR setspent (3),
+.BR getspent (3),
+.BR getspent_r (3),
+or
+.BR endspent (3)
+are used in parallel in different threads of a program,
+then data races could occur.
 .SH CONFORMING TO
 The shadow password database and its associated API are
 not specified in POSIX.1.
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mallinfo.3: ATTRIBUTES: Note function that is not thread-safe

[Zeng Linggang]

The marking matches glibc marking.
The marking of functions in glibc is:
- mallinfo: MT-Unsafe init const:mallopt

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/mallinfo.3 | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/man3/mallinfo.3 b/man3/mallinfo.3
index 7797169..e6661d1 100644
--- a/man3/mallinfo.3
+++ b/man3/mallinfo.3
@@ -107,6 +107,31 @@ This is the maximum number of bytes that could ideally
 .BR malloc_trim (3).
 .\" .SH VERSIONS
 .\" Available already in glibc 2.0, possibly earlier
+.SH ATTRIBUTES
+For an explanation of the terms used in this section, see
+.BR attributes (7).
+.TS
+allbox;
+lb lb lbw28
+l l l.
+Interface	Attribute	Value
+T{
+.BR mallinfo ()
+T}	Thread safety	MT-Unsafe init const:mallopt
+.TE
+
+.BR mallinfo ()
+would access some global iternal objects. If modify them with non-atomically,
+may get inconsistent results.
+The identifier
+.I mallopt
+in
+.I const:mallopt
+mean that
+.BR mallopt ()
+would modify the global iternal objects with atomics, that make sure
+.BR mallinfo ()
+is safe enough, others modify with non-atomically maybe not.
 .SH CONFORMING TO
 This function is not specified by POSIX or the C standards.
 A similar function exists on many System V derivatives,
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] sigpause.3: srcfix: add FIXME

[Zeng Linggang]

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/sigpause.3 | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/man3/sigpause.3 b/man3/sigpause.3
index 847bd10..dbc10de 100644
--- a/man3/sigpause.3
+++ b/man3/sigpause.3
@@ -63,6 +63,12 @@ l l l.
 Interface	Attribute	Value
 T{
 .BR sigpause ()
+.\" FIXME: the following marking is different from which in glibc manual,
+.\" marking in glibc manual is more detailed.
+.\" sigpause: MT-Unsafe race:sigprocmask/!bsd!linux
+.\" glibc manual says /!linux!bsd indicate the preceding marker only applies
+./" when the underlying kernel is neither Linux nor a BSD kernel.
+.\" So, it is safety in Linux kernel.
 T}	Thread safety	MT-Safe
 .TE
 .SH CONFORMING TO
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] termios.3: srcfix: add FIXME

[Zeng Linggang]

Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 man3/termios.3 | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/man3/termios.3 b/man3/termios.3
index 02aee64..1ea5236 100644
--- a/man3/termios.3
+++ b/man3/termios.3
@@ -994,6 +994,13 @@ T{
 .BR cfsetispeed (),
 .BR cfsetospeed (),
 .BR cfsetspeed ()
+.\" FIXME: the following markings are different from which in glibc manual,
+.\" markings in glibc manual are more detailed.
+.\" tcsendbreak: MT-Unsafe race:tcattr(filedes)/bsd
+.\" tcflow: MT-Unsafe race:tcattr(filedes)/bsd
+.\" glibc manual says /bsd indicate the preceding marker only applies
+./" when the underlying kernel is a BSD kernel.
+.\" So, it is safety in Linux kernel.
 T}	Thread safety	MT-Safe
 .TE
 .ad
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: patchset for fgetgrent fgetpwent getspnam mallinfo sigpause and termios

[Zeng Linggang]

Hello,

Ping! :)

Thanks and best regards,
Zeng

On Mon, 2015-08-24 at 18:19 +0800, Zeng Linggang wrote:
> Hello,
> 
> This patchset is for fgetgrent.3, fgetpwent.3, sigpause.3, termios.3,
> getspnam.3 and mallinfo.3
> 
> 1. fgetgrent.3 and fgetpwent.3:
>    We have some discussions about these two functions, the Subject:
>    "Re: question about markings of fgetgrent and fgetpwent"
>    However, something about the copyright impeded the progress.
>    I am sorry for that, if you are OK, please see these two patches below,
>    I have added some "FIXME:" descriptions in them.
> 
> 2. getspnam.3
>    getspnam.3 is a little like fgetgrent.3 and fgetpwent.3, but there are not
>    markings in glibc document. I use the function names for the identifiers like
>    fgetgrent.3 and fgetpwent.3.
> 
> 3. mallinfo.3
>    Hope the descriptions about "const:mallopt" could explain clearly enough in
>    the patch.
> 
> 4. sigpause.3 and termios.3
>    These two functions are safety in Linux kernel, the markings in glibc manual
>    are more detailed. I also have added some "FIXME:" descriptions in them.
> 
> 
> Thanks and best regards,
> Zeng
> --
> To unsubscribe from this list: send the line "unsubscribe linux-man" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: patchset for fgetgrent fgetpwent getspnam mallinfo sigpause and termios

[Zeng Linggang]

Hello,

Could someone help to review these?
I think these codes is not really too much if you have scanned them.
Please keep a little patience. :)

Thanks and best regards,
Zeng

On Tue, 2015-09-01 at 16:00 +0800, Zeng Linggang wrote:
> Hello,
> 
> Ping! :)
> 
> Thanks and best regards,
> Zeng
> 
> On Mon, 2015-08-24 at 18:19 +0800, Zeng Linggang wrote:
> > Hello,
> > 
> > This patchset is for fgetgrent.3, fgetpwent.3, sigpause.3, termios.3,
> > getspnam.3 and mallinfo.3
> > 
> > 1. fgetgrent.3 and fgetpwent.3:
> >    We have some discussions about these two functions, the Subject:
> >    "Re: question about markings of fgetgrent and fgetpwent"
> >    However, something about the copyright impeded the progress.
> >    I am sorry for that, if you are OK, please see these two patches below,
> >    I have added some "FIXME:" descriptions in them.
> > 
> > 2. getspnam.3
> >    getspnam.3 is a little like fgetgrent.3 and fgetpwent.3, but there are not
> >    markings in glibc document. I use the function names for the identifiers like
> >    fgetgrent.3 and fgetpwent.3.
> > 
> > 3. mallinfo.3
> >    Hope the descriptions about "const:mallopt" could explain clearly enough in
> >    the patch.
> > 
> > 4. sigpause.3 and termios.3
> >    These two functions are safety in Linux kernel, the markings in glibc manual
> >    are more detailed. I also have added some "FIXME:" descriptions in them.
> > 
> > 
> > Thanks and best regards,
> > Zeng
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-man" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-man" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fgetgrent.3: ATTRIBUTES: Note function that is not thread-safe

[Michael Kerrisk (man-pages)]

On 08/24/2015 12:19 PM, Zeng Linggang wrote:
> The marking matches glibc marking.
> marking of function in glibc is:
> - fgetgrent: MT-Unsafe race:fgrent
> 
> ps: We think race:fgrent in glibc maybe hard for users to understand,
> and have sent a patch to the GNU libc community for changing it to
> race:fgetgrent, however, something about the copyright impeded the progress.
> Here we mark it "race:fgetgrent", so there is a little different.

Applied!  Thanks, Zeng Linggang.

Cheers,

Michael


> Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/fgetgrent.3 | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/man3/fgetgrent.3 b/man3/fgetgrent.3
> index 57665dd..aa08e0f 100644
> --- a/man3/fgetgrent.3
> +++ b/man3/fgetgrent.3
> @@ -90,6 +90,25 @@ is set to indicate the cause.
>  Insufficient memory to allocate
>  .I group
>  structure.
> +.SH ATTRIBUTES
> +For an explanation of the terms used in this section, see
> +.BR attributes (7).
> +.TS
> +allbox;
> +lb lb lb
> +l l l.
> +Interface	Attribute	Value
> +T{
> +.BR fgetgrent ()
> +.\" FIXME: the following marking is different from which in glibc manual,
> +.\" marking in glibc manual is,
> +.\" fgetgrent: MT-Unsafe race:fgrent
> +.\" We think race:fgrent in glibc maybe hard for users to understand,
> +.\" and have sent a patch to the GNU libc community for changing it to
> +.\" race:fgetgrent, however, something about the copyright impeded the progress.
> +T}	Thread safety	MT-Unsafe race:fgetgrent
> +.TE
> +
>  .SH CONFORMING TO
>  SVr4.
>  .SH SEE ALSO
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fgetpwent.3: ATTRIBUTES: Note function that is not thread-safe

[Michael Kerrisk (man-pages)]

On 08/24/2015 12:19 PM, Zeng Linggang wrote:
> The marking matches glibc marking.
> marking of function in glibc is:
> - fgetgrent: MT-Unsafe race:fpwent
> 
> ps: We think race:fpwent in glibc maybe hard for users to understand,
> and have sent a patch to the GNU libc community for changing it to
> race:fgetpwent, however, something about the copyright impeded the progress.
> Here we mark it "race:fgetpwent", so there is a little different.

Applied!  Thanks, Zeng Linggang.

Cheers,

Michael

> Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/fgetpwent.3 | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/man3/fgetpwent.3 b/man3/fgetpwent.3
> index 3076494..84e0379 100644
> --- a/man3/fgetpwent.3
> +++ b/man3/fgetpwent.3
> @@ -98,6 +98,22 @@ structure.
>  .TP
>  .I /etc/passwd
>  password database file
> +.TS
> +allbox;
> +lb lb lb
> +l l l.
> +Interface	Attribute	Value
> +T{
> +.BR fgetpwent ()
> +.\" FIXME: the following marking is different from which in glibc manual,
> +.\" marking in glibc manual is,
> +.\" fgetpwent: MT-Unsafe race:fpwent
> +.\" We think race:fpwent in glibc maybe hard for users to understand,
> +.\" and have sent a patch to the GNU libc community for changing it to
> +.\" race:fgetpwent, however, something about the copyright impeded the progress.
> +T}	Thread safety	MT-Unsafe race:fgetpwent
> +.TE
> +
>  .SH CONFORMING TO
>  SVr4.
>  .SH SEE ALSO
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] getspnam.3: ATTRIBUTES: Note functions that are/aren't thread-safe

[Michael Kerrisk (man-pages)]

On 08/24/2015 12:19 PM, Zeng Linggang wrote:
> After research, We think
> * getspnam(),
> * getspent(),
> * setspent(),
> * endspent(),
> * getspent_r(),
> * fgetspent(),
> * sgetspent(),
> are not thread-safe. And
> * putspent(),
> * getspnam_r(),
> * sgetspent_r(),
> * lckpwdf(),
> * ulckpwdf(),
> * fgetspent_r(),
> are thread-safe. But, there are not
> markings of them in glibc document.

Applied!  Thanks, Zeng Linggang.

Cheers,

Michael

> Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/getspnam.3 | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/man3/getspnam.3 b/man3/getspnam.3
> index 43ee61c..9efd643 100644
> --- a/man3/getspnam.3
> +++ b/man3/getspnam.3
> @@ -246,6 +246,66 @@ The include file
>  defines the constant
>  .B _PATH_SHADOW
>  to the pathname of the shadow password file.
> +.SH ATTRIBUTES
> +For an explanation of the terms used in this section, see
> +.BR attributes (7).
> +.TS
> +allbox;
> +lbw25 lb lbw30
> +l l l.
> +Interface	Attribute	Value
> +T{
> +.BR getspnam ()
> +T}	Thread safety	T{
> +MT-Unsafe race:getspnam locale
> +T}
> +T{
> +.BR getspent ()
> +T}	Thread safety	T{
> +MT-Unsafe race:getspent
> +.br
> +race:spentbuf locale
> +T}
> +T{
> +.BR setspent (),
> +.BR endspent (),
> +.br
> +.BR getspent_r ()
> +T}	Thread safety	T{
> +MT-Unsafe race:getspent locale
> +T}
> +T{
> +.BR fgetspent ()
> +T}	Thread safety	MT-Unsafe race:fgetspent
> +T{
> +.BR sgetspent ()
> +T}	Thread safety	MT-Unsafe race:sgetspent
> +T{
> +.BR putspent (),
> +.BR getspnam_r (),
> +.br
> +.BR sgetspent_r ()
> +T}	Thread safety	MT-Safe locale
> +T{
> +.BR lckpwdf (),
> +.BR ulckpwdf (),
> +.br
> +.BR fgetspent_r ()
> +T}	Thread safety	MT-Safe
> +.TE
> +
> +In the above table,
> +.I getspent
> +in
> +.I race:getspent
> +signifies that if any of the functions
> +.BR setspent (3),
> +.BR getspent (3),
> +.BR getspent_r (3),
> +or
> +.BR endspent (3)
> +are used in parallel in different threads of a program,
> +then data races could occur.
>  .SH CONFORMING TO
>  The shadow password database and its associated API are
>  not specified in POSIX.1.
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mallinfo.3: ATTRIBUTES: Note function that is not thread-safe

[Michael Kerrisk (man-pages)]

On 08/24/2015 12:19 PM, Zeng Linggang wrote:
> The marking matches glibc marking.
> The marking of functions in glibc is:
> - mallinfo: MT-Unsafe init const:mallopt

Applied!  Thanks, Zeng Linggang.

Cheers,

Michael

> Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> ---
>  man3/mallinfo.3 | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/man3/mallinfo.3 b/man3/mallinfo.3
> index 7797169..e6661d1 100644
> --- a/man3/mallinfo.3
> +++ b/man3/mallinfo.3
> @@ -107,6 +107,31 @@ This is the maximum number of bytes that could ideally
>  .BR malloc_trim (3).
>  .\" .SH VERSIONS
>  .\" Available already in glibc 2.0, possibly earlier
> +.SH ATTRIBUTES
> +For an explanation of the terms used in this section, see
> +.BR attributes (7).
> +.TS
> +allbox;
> +lb lb lbw28
> +l l l.
> +Interface	Attribute	Value
> +T{
> +.BR mallinfo ()
> +T}	Thread safety	MT-Unsafe init const:mallopt
> +.TE
> +
> +.BR mallinfo ()
> +would access some global iternal objects. If modify them with non-atomically,
> +may get inconsistent results.
> +The identifier
> +.I mallopt
> +in
> +.I const:mallopt
> +mean that
> +.BR mallopt ()
> +would modify the global iternal objects with atomics, that make sure
> +.BR mallinfo ()
> +is safe enough, others modify with non-atomically maybe not.
>  .SH CONFORMING TO
>  This function is not specified by POSIX or the C standards.
>  A similar function exists on many System V derivatives,
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sigpause.3: srcfix: add FIXME

[Michael Kerrisk (man-pages)]

On 08/24/2015 12:19 PM, Zeng Linggang wrote:
> Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>

Applied!  Thanks, Zeng Linggang.

Cheers,

Michael

> ---
>  man3/sigpause.3 | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/man3/sigpause.3 b/man3/sigpause.3
> index 847bd10..dbc10de 100644
> --- a/man3/sigpause.3
> +++ b/man3/sigpause.3
> @@ -63,6 +63,12 @@ l l l.
>  Interface	Attribute	Value
>  T{
>  .BR sigpause ()
> +.\" FIXME: the following marking is different from which in glibc manual,
> +.\" marking in glibc manual is more detailed.
> +.\" sigpause: MT-Unsafe race:sigprocmask/!bsd!linux
> +.\" glibc manual says /!linux!bsd indicate the preceding marker only applies
> +./" when the underlying kernel is neither Linux nor a BSD kernel.
> +.\" So, it is safety in Linux kernel.
>  T}	Thread safety	MT-Safe
>  .TE
>  .SH CONFORMING TO
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] termios.3: srcfix: add FIXME

[Michael Kerrisk (man-pages)]

On 08/24/2015 12:19 PM, Zeng Linggang wrote:
> Signed-off-by: Zeng Linggang <zenglg.jy-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>

Applied!  Thanks, Zeng Linggang.

Cheers,

Michael

> ---
>  man3/termios.3 | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/man3/termios.3 b/man3/termios.3
> index 02aee64..1ea5236 100644
> --- a/man3/termios.3
> +++ b/man3/termios.3
> @@ -994,6 +994,13 @@ T{
>  .BR cfsetispeed (),
>  .BR cfsetospeed (),
>  .BR cfsetspeed ()
> +.\" FIXME: the following markings are different from which in glibc manual,
> +.\" markings in glibc manual are more detailed.
> +.\" tcsendbreak: MT-Unsafe race:tcattr(filedes)/bsd
> +.\" tcflow: MT-Unsafe race:tcattr(filedes)/bsd
> +.\" glibc manual says /bsd indicate the preceding marker only applies
> +./" when the underlying kernel is a BSD kernel.
> +.\" So, it is safety in Linux kernel.
>  T}	Thread safety	MT-Safe
>  .TE
>  .ad
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: patchset for fgetgrent fgetpwent getspnam mallinfo sigpause and termios

[Michael Kerrisk (man-pages)]

On 09/09/2015 07:31 AM, Zeng Linggang wrote:
> Hello,
> 
> Could someone help to review these?
> I think these codes is not really too much if you have scanned them.
> Please keep a little patience. :)

My apologies for the delay, Zeng Linggang. I'm a little too busy
at the moment.

Cheers,

Michael


> Thanks and best regards,
> Zeng
> 
> On Tue, 2015-09-01 at 16:00 +0800, Zeng Linggang wrote:
>> Hello,
>>
>> Ping! :)
>>
>> Thanks and best regards,
>> Zeng
>>
>> On Mon, 2015-08-24 at 18:19 +0800, Zeng Linggang wrote:
>>> Hello,
>>>
>>> This patchset is for fgetgrent.3, fgetpwent.3, sigpause.3, termios.3,
>>> getspnam.3 and mallinfo.3
>>>
>>> 1. fgetgrent.3 and fgetpwent.3:
>>>    We have some discussions about these two functions, the Subject:
>>>    "Re: question about markings of fgetgrent and fgetpwent"
>>>    However, something about the copyright impeded the progress.
>>>    I am sorry for that, if you are OK, please see these two patches below,
>>>    I have added some "FIXME:" descriptions in them.
>>>
>>> 2. getspnam.3
>>>    getspnam.3 is a little like fgetgrent.3 and fgetpwent.3, but there are not
>>>    markings in glibc document. I use the function names for the identifiers like
>>>    fgetgrent.3 and fgetpwent.3.
>>>
>>> 3. mallinfo.3
>>>    Hope the descriptions about "const:mallopt" could explain clearly enough in
>>>    the patch.
>>>
>>> 4. sigpause.3 and termios.3
>>>    These two functions are safety in Linux kernel, the markings in glibc manual
>>>    are more detailed. I also have added some "FIXME:" descriptions in them.
>>>
>>>
>>> Thanks and best regards,
>>> Zeng
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-man" in
>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-man" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: patchset for fgetgrent fgetpwent getspnam mallinfo sigpause and termios

[Zeng Linggang]

Hello,

On Fri, 2015-09-11 at 12:10 +0200, Michael Kerrisk (man-pages) wrote:
> On 09/09/2015 07:31 AM, Zeng Linggang wrote:
> > Hello,
> > 
> > Could someone help to review these?
> > I think these codes is not really too much if you have scanned them.
> > Please keep a little patience. :)
> 
> My apologies for the delay, Zeng Linggang. I'm a little too busy
> at the moment.
> 

That's OK.
And thank you very much.

Best regards,
Zeng

> Cheers,
> 
> Michael
> 
> 
> > Thanks and best regards,
> > Zeng
> > 
> > On Tue, 2015-09-01 at 16:00 +0800, Zeng Linggang wrote:
> >> Hello,
> >>
> >> Ping! :)
> >>
> >> Thanks and best regards,
> >> Zeng
> >>
> >> On Mon, 2015-08-24 at 18:19 +0800, Zeng Linggang wrote:
> >>> Hello,
> >>>
> >>> This patchset is for fgetgrent.3, fgetpwent.3, sigpause.3, termios.3,
> >>> getspnam.3 and mallinfo.3
> >>>
> >>> 1. fgetgrent.3 and fgetpwent.3:
> >>>    We have some discussions about these two functions, the Subject:
> >>>    "Re: question about markings of fgetgrent and fgetpwent"
> >>>    However, something about the copyright impeded the progress.
> >>>    I am sorry for that, if you are OK, please see these two patches below,
> >>>    I have added some "FIXME:" descriptions in them.
> >>>
> >>> 2. getspnam.3
> >>>    getspnam.3 is a little like fgetgrent.3 and fgetpwent.3, but there are not
> >>>    markings in glibc document. I use the function names for the identifiers like
> >>>    fgetgrent.3 and fgetpwent.3.
> >>>
> >>> 3. mallinfo.3
> >>>    Hope the descriptions about "const:mallopt" could explain clearly enough in
> >>>    the patch.
> >>>
> >>> 4. sigpause.3 and termios.3
> >>>    These two functions are safety in Linux kernel, the markings in glibc manual
> >>>    are more detailed. I also have added some "FIXME:" descriptions in them.
> >>>
> >>>
> >>> Thanks and best regards,
> >>> Zeng
> >>> --
> >>> To unsubscribe from this list: send the line "unsubscribe linux-man" in
> >>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> >>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >>
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-man" in
> >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > 
> > 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html