[PATCH] bitbake: bb.fetch2.git: Import errno module

[PATCH] bitbake: bb.fetch2.git: Import errno module

[Romain Perier]

Currently this module is dereferencing errno.ENOENT but the python module "errno"
is not imported, which causes a crash when fetching from a git repository.

Signed-off-by: Romain Perier <romain.perier@gmail.com>
---
 bitbake/lib/bb/fetch2/git.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index 4a32a31..9bd87ad 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -66,6 +66,7 @@ Supported SRC_URI options are:
 # with this program; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+import errno
 import os
 import re
 import bb
-- 
2.1.4

Re: [PATCH] bitbake: bb.fetch2.git: Import errno module

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

On Fri, Sep 18, 2015 at 9:35 AM, Romain Perier <romain.perier@gmail.com>
wrote:

> Currently this module is dereferencing errno.ENOENT but the python module
> "errno"
> is not imported, which causes a crash when fetching from a git repository.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
>

Eep, that would be my fault, sorry about that.

Acked-by: Christopher Larson <chris_larson@mentor.com>
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1180 bytes --]

Re: [PATCH] bitbake: bb.fetch2.git: Import errno module

[Khem Raj]

On Fri, Sep 18, 2015 at 9:35 AM, Romain Perier <romain.perier@gmail.com> wrote:
> Currently this module is dereferencing errno.ENOENT but the python module "errno"
> is not imported, which causes a crash when fetching from a git repository.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
>  bitbake/lib/bb/fetch2/git.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
> index 4a32a31..9bd87ad 100644
> --- a/bitbake/lib/bb/fetch2/git.py
> +++ b/bitbake/lib/bb/fetch2/git.py
> @@ -66,6 +66,7 @@ Supported SRC_URI options are:
>  # with this program; if not, write to the Free Software Foundation, Inc.,
>  # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>
> +import errno
>  import os
>  import re
>  import bb

this patch is against poky repo, please rebase it against bitbake repo
and resend. Its breaking all my builds currently.

Re: [PATCH] bitbake: bb.fetch2.git: Import errno module

[Khem Raj]

On Sat, Sep 19, 2015 at 2:10 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Fri, Sep 18, 2015 at 9:35 AM, Romain Perier <romain.perier@gmail.com> wrote:
>> Currently this module is dereferencing errno.ENOENT but the python module "errno"
>> is not imported, which causes a crash when fetching from a git repository.
>>
>> Signed-off-by: Romain Perier <romain.perier@gmail.com>
>> ---
>>  bitbake/lib/bb/fetch2/git.py | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
>> index 4a32a31..9bd87ad 100644
>> --- a/bitbake/lib/bb/fetch2/git.py
>> +++ b/bitbake/lib/bb/fetch2/git.py
>> @@ -66,6 +66,7 @@ Supported SRC_URI options are:
>>  # with this program; if not, write to the Free Software Foundation, Inc.,
>>  # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>>
>> +import errno
>>  import os
>>  import re
>>  import bb
>
> this patch is against poky repo, please rebase it against bitbake repo
> and resend. Its breaking all my builds currently.

This will fix my build issues like
http://errors.yoctoproject.org/Errors/Details/17879/
but it needs to be posted against bitbake repo.