* [PATCH] shared/gatt-helpers: Fix reporting discovery failure
@ 2015-09-22 18:09 Szymon Janc
2015-09-23 7:55 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 2+ messages in thread
From: Szymon Janc @ 2015-09-22 18:09 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Szymon Janc
If sending ATT request failed discovery should be reported as failed.
Due to missing goto success was overwritten with true value.
This regression was introduced in db24bf09d66325a.
---
src/shared/gatt-helpers.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/shared/gatt-helpers.c b/src/shared/gatt-helpers.c
index c773df7..008b8bc 100644
--- a/src/shared/gatt-helpers.c
+++ b/src/shared/gatt-helpers.c
@@ -1490,6 +1490,7 @@ static void discover_descs_cb(uint8_t opcode, const void *pdu,
return;
success = false;
+ goto done;
}
success = true;
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] shared/gatt-helpers: Fix reporting discovery failure
2015-09-22 18:09 [PATCH] shared/gatt-helpers: Fix reporting discovery failure Szymon Janc
@ 2015-09-23 7:55 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2015-09-23 7:55 UTC (permalink / raw)
To: Szymon Janc; +Cc: linux-bluetooth
Hi Szymon,
On Tue, Sep 22, 2015 at 9:09 PM, Szymon Janc <szymon.janc@gmail.com> wrote:
> If sending ATT request failed discovery should be reported as failed.
> Due to missing goto success was overwritten with true value.
> This regression was introduced in db24bf09d66325a.
> ---
> src/shared/gatt-helpers.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/shared/gatt-helpers.c b/src/shared/gatt-helpers.c
> index c773df7..008b8bc 100644
> --- a/src/shared/gatt-helpers.c
> +++ b/src/shared/gatt-helpers.c
> @@ -1490,6 +1490,7 @@ static void discover_descs_cb(uint8_t opcode, const void *pdu,
> return;
>
> success = false;
> + goto done;
> }
>
> success = true;
> --
> 2.5.0
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-23 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-22 18:09 [PATCH] shared/gatt-helpers: Fix reporting discovery failure Szymon Janc
2015-09-23 7:55 ` Luiz Augusto von Dentz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.