* [PATCH RESEND] CMA: fix CONFIG_CMA_SIZE_MBYTES overflow in 64bit
@ 2015-09-24 3:27 ` Tan Xiaojun
0 siblings, 0 replies; 3+ messages in thread
From: Tan Xiaojun @ 2015-09-24 3:27 UTC (permalink / raw)
To: gregkh, kyungmin.park, iamjoonsoo.kim, grant.likely, arnd, joshc
Cc: linux-mm, linux-kernel, linux-arm-kernel, Tan Xiaojun
In 64bit system, if you set CONFIG_CMA_SIZE_MBYTES>=2048, it will
overflow and size_bytes will be a big wrong number.
Set CONFIG_CMA_SIZE_MBYTES=2048 and you will get an info below
during system boot:
*********
cma: Failed to reserve 17592186042368 MiB
*********
Signed-off-by: Tan Xiaojun <tanxiaojun@huawei.com>
---
drivers/base/dma-contiguous.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c
index 950fff9..426ba27 100644
--- a/drivers/base/dma-contiguous.c
+++ b/drivers/base/dma-contiguous.c
@@ -46,7 +46,7 @@ struct cma *dma_contiguous_default_area;
* Users, who want to set the size of global CMA area for their system
* should use cma= kernel parameter.
*/
-static const phys_addr_t size_bytes = CMA_SIZE_MBYTES * SZ_1M;
+static const phys_addr_t size_bytes = (phys_addr_t)CMA_SIZE_MBYTES * SZ_1M;
static phys_addr_t size_cmdline = -1;
static phys_addr_t base_cmdline;
static phys_addr_t limit_cmdline;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH RESEND] CMA: fix CONFIG_CMA_SIZE_MBYTES overflow in 64bit
@ 2015-09-24 3:27 ` Tan Xiaojun
0 siblings, 0 replies; 3+ messages in thread
From: Tan Xiaojun @ 2015-09-24 3:27 UTC (permalink / raw)
To: gregkh, kyungmin.park, iamjoonsoo.kim, grant.likely, arnd, joshc
Cc: linux-mm, linux-kernel, linux-arm-kernel, Tan Xiaojun
In 64bit system, if you set CONFIG_CMA_SIZE_MBYTES>=2048, it will
overflow and size_bytes will be a big wrong number.
Set CONFIG_CMA_SIZE_MBYTES=2048 and you will get an info below
during system boot:
*********
cma: Failed to reserve 17592186042368 MiB
*********
Signed-off-by: Tan Xiaojun <tanxiaojun@huawei.com>
---
drivers/base/dma-contiguous.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c
index 950fff9..426ba27 100644
--- a/drivers/base/dma-contiguous.c
+++ b/drivers/base/dma-contiguous.c
@@ -46,7 +46,7 @@ struct cma *dma_contiguous_default_area;
* Users, who want to set the size of global CMA area for their system
* should use cma= kernel parameter.
*/
-static const phys_addr_t size_bytes = CMA_SIZE_MBYTES * SZ_1M;
+static const phys_addr_t size_bytes = (phys_addr_t)CMA_SIZE_MBYTES * SZ_1M;
static phys_addr_t size_cmdline = -1;
static phys_addr_t base_cmdline;
static phys_addr_t limit_cmdline;
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH RESEND] CMA: fix CONFIG_CMA_SIZE_MBYTES overflow in 64bit
@ 2015-09-24 3:27 ` Tan Xiaojun
0 siblings, 0 replies; 3+ messages in thread
From: Tan Xiaojun @ 2015-09-24 3:27 UTC (permalink / raw)
To: linux-arm-kernel
In 64bit system, if you set CONFIG_CMA_SIZE_MBYTES>=2048, it will
overflow and size_bytes will be a big wrong number.
Set CONFIG_CMA_SIZE_MBYTES=2048 and you will get an info below
during system boot:
*********
cma: Failed to reserve 17592186042368 MiB
*********
Signed-off-by: Tan Xiaojun <tanxiaojun@huawei.com>
---
drivers/base/dma-contiguous.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c
index 950fff9..426ba27 100644
--- a/drivers/base/dma-contiguous.c
+++ b/drivers/base/dma-contiguous.c
@@ -46,7 +46,7 @@ struct cma *dma_contiguous_default_area;
* Users, who want to set the size of global CMA area for their system
* should use cma= kernel parameter.
*/
-static const phys_addr_t size_bytes = CMA_SIZE_MBYTES * SZ_1M;
+static const phys_addr_t size_bytes = (phys_addr_t)CMA_SIZE_MBYTES * SZ_1M;
static phys_addr_t size_cmdline = -1;
static phys_addr_t base_cmdline;
static phys_addr_t limit_cmdline;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-24 3:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-24 3:27 [PATCH RESEND] CMA: fix CONFIG_CMA_SIZE_MBYTES overflow in 64bit Tan Xiaojun
2015-09-24 3:27 ` Tan Xiaojun
2015-09-24 3:27 ` Tan Xiaojun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.