* [meta-oe][PATCH] vim: Compile and provide xxd in package vim-xxd
@ 2015-09-28 11:44 Ioan-Adrian Ratiu
2015-09-28 16:07 ` Khem Raj
2015-09-29 10:15 ` [meta-oe][PATCH v2] vim: provide the xxd tool (package vim-xxd) Ioan-Adrian Ratiu
0 siblings, 2 replies; 6+ messages in thread
From: Ioan-Adrian Ratiu @ 2015-09-28 11:44 UTC (permalink / raw)
To: openembedded-devel
Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
---
meta-oe/recipes-support/vim/vim_7.4.481.bb | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/meta-oe/recipes-support/vim/vim_7.4.481.bb b/meta-oe/recipes-support/vim/vim_7.4.481.bb
index 2ece53b..fcd036b 100644
--- a/meta-oe/recipes-support/vim/vim_7.4.481.bb
+++ b/meta-oe/recipes-support/vim/vim_7.4.481.bb
@@ -59,6 +59,11 @@ EXTRA_OECONF = " \
STRIP=/bin/true \
"
+do_compile_append() {
+ cd "${S}/xxd"
+ make
+}
+
do_install() {
autotools_do_install
@@ -70,17 +75,20 @@ do_install() {
# Install example vimrc from runtime files
install -m 0644 ../runtime/vimrc_example.vim ${D}/${datadir}/${BPN}/vimrc
+ install -m 0755 xxd/xxd ${D}${bindir}/xxd
+
# we use --with-features=big as default
mv ${D}${bindir}/${BPN} ${D}${bindir}/${BPN}.${BPN}
}
PARALLEL_MAKEINST = ""
-PACKAGES =+ "${PN}-common ${PN}-syntax ${PN}-help ${PN}-tutor ${PN}-vimrc"
+PACKAGES =+ "${PN}-common ${PN}-syntax ${PN}-help ${PN}-tutor ${PN}-vimrc ${PN}-xxd"
FILES_${PN}-syntax = "${datadir}/${BPN}/${VIMDIR}/syntax"
FILES_${PN}-help = "${datadir}/${BPN}/${VIMDIR}/doc"
FILES_${PN}-tutor = "${datadir}/${BPN}/${VIMDIR}/tutor ${bindir}/${BPN}tutor"
FILES_${PN}-vimrc = "${datadir}/${BPN}/vimrc"
+FILES_${PN}-xxd = "${bindir}/xxd"
FILES_${PN}-data = "${datadir}/${BPN}"
FILES_${PN}-common = " \
${datadir}/${BPN}/${VIMDIR}/*.vim \
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH] vim: Compile and provide xxd in package vim-xxd
2015-09-28 11:44 [meta-oe][PATCH] vim: Compile and provide xxd in package vim-xxd Ioan-Adrian Ratiu
@ 2015-09-28 16:07 ` Khem Raj
2015-09-29 10:03 ` Ioan-Adrian Ratiu
2015-09-29 10:15 ` [meta-oe][PATCH v2] vim: provide the xxd tool (package vim-xxd) Ioan-Adrian Ratiu
1 sibling, 1 reply; 6+ messages in thread
From: Khem Raj @ 2015-09-28 16:07 UTC (permalink / raw)
To: Martin Jansa
[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]
> On Sep 28, 2015, at 4:44 AM, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
>
> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> ---
> meta-oe/recipes-support/vim/vim_7.4.481.bb | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/vim/vim_7.4.481.bb b/meta-oe/recipes-support/vim/vim_7.4.481.bb
> index 2ece53b..fcd036b 100644
> --- a/meta-oe/recipes-support/vim/vim_7.4.481.bb
> +++ b/meta-oe/recipes-support/vim/vim_7.4.481.bb
> @@ -59,6 +59,11 @@ EXTRA_OECONF = " \
> STRIP=/bin/true \
> "
>
> +do_compile_append() {
> + cd "${S}/xxd"
> + make
why not oe_runmake ?
> +}
> +
> do_install() {
> autotools_do_install
>
> @@ -70,17 +75,20 @@ do_install() {
> # Install example vimrc from runtime files
> install -m 0644 ../runtime/vimrc_example.vim ${D}/${datadir}/${BPN}/vimrc
>
> + install -m 0755 xxd/xxd ${D}${bindir}/xxd
> +
> # we use --with-features=big as default
> mv ${D}${bindir}/${BPN} ${D}${bindir}/${BPN}.${BPN}
> }
>
> PARALLEL_MAKEINST = ""
>
> -PACKAGES =+ "${PN}-common ${PN}-syntax ${PN}-help ${PN}-tutor ${PN}-vimrc"
> +PACKAGES =+ "${PN}-common ${PN}-syntax ${PN}-help ${PN}-tutor ${PN}-vimrc ${PN}-xxd"
> FILES_${PN}-syntax = "${datadir}/${BPN}/${VIMDIR}/syntax"
> FILES_${PN}-help = "${datadir}/${BPN}/${VIMDIR}/doc"
> FILES_${PN}-tutor = "${datadir}/${BPN}/${VIMDIR}/tutor ${bindir}/${BPN}tutor"
> FILES_${PN}-vimrc = "${datadir}/${BPN}/vimrc"
> +FILES_${PN}-xxd = "${bindir}/xxd"
> FILES_${PN}-data = "${datadir}/${BPN}"
> FILES_${PN}-common = " \
> ${datadir}/${BPN}/${VIMDIR}/*.vim \
> --
> 2.1.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH] vim: Compile and provide xxd in package vim-xxd
2015-09-28 16:07 ` Khem Raj
@ 2015-09-29 10:03 ` Ioan-Adrian Ratiu
0 siblings, 0 replies; 6+ messages in thread
From: Ioan-Adrian Ratiu @ 2015-09-29 10:03 UTC (permalink / raw)
To: openembedded-devel
On 28.09.2015 19:07, Khem Raj wrote:
>
>> On Sep 28, 2015, at 4:44 AM, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
>>
>> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
>> ---
>> meta-oe/recipes-support/vim/vim_7.4.481.bb | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-support/vim/vim_7.4.481.bb b/meta-oe/recipes-support/vim/vim_7.4.481.bb
>> index 2ece53b..fcd036b 100644
>> --- a/meta-oe/recipes-support/vim/vim_7.4.481.bb
>> +++ b/meta-oe/recipes-support/vim/vim_7.4.481.bb
>> @@ -59,6 +59,11 @@ EXTRA_OECONF = " \
>> STRIP=/bin/true \
>> "
>>
>> +do_compile_append() {
>> + cd "${S}/xxd"
>> + make
>
> why not oe_runmake ?
I did some more research and indeed oe_runmake should be used and the
default oe_runmake call already compiles xxd when calling the top level
Makefile so there's no need for do_compile_append altogether.
The same goes for the install append.
The only thing needed to be done is simply package xxd. I'll rewrite and
resubmit.
Thank you,
Adrian
^ permalink raw reply [flat|nested] 6+ messages in thread
* [meta-oe][PATCH v2] vim: provide the xxd tool (package vim-xxd)
2015-09-28 11:44 [meta-oe][PATCH] vim: Compile and provide xxd in package vim-xxd Ioan-Adrian Ratiu
2015-09-28 16:07 ` Khem Raj
@ 2015-09-29 10:15 ` Ioan-Adrian Ratiu
2015-09-29 11:22 ` Martin Jansa
1 sibling, 1 reply; 6+ messages in thread
From: Ioan-Adrian Ratiu @ 2015-09-29 10:15 UTC (permalink / raw)
To: openembedded-devel
Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
---
meta-oe/recipes-support/vim/vim_7.4.481.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta-oe/recipes-support/vim/vim_7.4.481.bb b/meta-oe/recipes-support/vim/vim_7.4.481.bb
index 2ece53b..44e6571 100644
--- a/meta-oe/recipes-support/vim/vim_7.4.481.bb
+++ b/meta-oe/recipes-support/vim/vim_7.4.481.bb
@@ -76,11 +76,12 @@ do_install() {
PARALLEL_MAKEINST = ""
-PACKAGES =+ "${PN}-common ${PN}-syntax ${PN}-help ${PN}-tutor ${PN}-vimrc"
+PACKAGES =+ "${PN}-common ${PN}-syntax ${PN}-help ${PN}-tutor ${PN}-vimrc ${PN}-xxd"
FILES_${PN}-syntax = "${datadir}/${BPN}/${VIMDIR}/syntax"
FILES_${PN}-help = "${datadir}/${BPN}/${VIMDIR}/doc"
FILES_${PN}-tutor = "${datadir}/${BPN}/${VIMDIR}/tutor ${bindir}/${BPN}tutor"
FILES_${PN}-vimrc = "${datadir}/${BPN}/vimrc"
+FILES_${PN}-xxd = "${bindir}/xxd"
FILES_${PN}-data = "${datadir}/${BPN}"
FILES_${PN}-common = " \
${datadir}/${BPN}/${VIMDIR}/*.vim \
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH v2] vim: provide the xxd tool (package vim-xxd)
2015-09-29 10:15 ` [meta-oe][PATCH v2] vim: provide the xxd tool (package vim-xxd) Ioan-Adrian Ratiu
@ 2015-09-29 11:22 ` Martin Jansa
2015-09-29 11:50 ` Ioan-Adrian Ratiu
0 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2015-09-29 11:22 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]
On Tue, Sep 29, 2015 at 01:15:22PM +0300, Ioan-Adrian Ratiu wrote:
> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> ---
> meta-oe/recipes-support/vim/vim_7.4.481.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/vim/vim_7.4.481.bb b/meta-oe/recipes-support/vim/vim_7.4.481.bb
> index 2ece53b..44e6571 100644
> --- a/meta-oe/recipes-support/vim/vim_7.4.481.bb
> +++ b/meta-oe/recipes-support/vim/vim_7.4.481.bb
> @@ -76,11 +76,12 @@ do_install() {
>
> PARALLEL_MAKEINST = ""
>
> -PACKAGES =+ "${PN}-common ${PN}-syntax ${PN}-help ${PN}-tutor ${PN}-vimrc"
> +PACKAGES =+ "${PN}-common ${PN}-syntax ${PN}-help ${PN}-tutor ${PN}-vimrc ${PN}-xxd"
> FILES_${PN}-syntax = "${datadir}/${BPN}/${VIMDIR}/syntax"
> FILES_${PN}-help = "${datadir}/${BPN}/${VIMDIR}/doc"
> FILES_${PN}-tutor = "${datadir}/${BPN}/${VIMDIR}/tutor ${bindir}/${BPN}tutor"
> FILES_${PN}-vimrc = "${datadir}/${BPN}/vimrc"
> +FILES_${PN}-xxd = "${bindir}/xxd"
So it was already included in some other package (probably main vim
package)?
> FILES_${PN}-data = "${datadir}/${BPN}"
> FILES_${PN}-common = " \
> ${datadir}/${BPN}/${VIMDIR}/*.vim \
> --
> 2.1.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH v2] vim: provide the xxd tool (package vim-xxd)
2015-09-29 11:22 ` Martin Jansa
@ 2015-09-29 11:50 ` Ioan-Adrian Ratiu
0 siblings, 0 replies; 6+ messages in thread
From: Ioan-Adrian Ratiu @ 2015-09-29 11:50 UTC (permalink / raw)
To: openembedded-devel
On 29.09.2015 14:22, Martin Jansa wrote:
> On Tue, Sep 29, 2015 at 01:15:22PM +0300, Ioan-Adrian Ratiu wrote:
>> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
>> ---
>> meta-oe/recipes-support/vim/vim_7.4.481.bb | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-support/vim/vim_7.4.481.bb b/meta-oe/recipes-support/vim/vim_7.4.481.bb
>> index 2ece53b..44e6571 100644
>> --- a/meta-oe/recipes-support/vim/vim_7.4.481.bb
>> +++ b/meta-oe/recipes-support/vim/vim_7.4.481.bb
>> @@ -76,11 +76,12 @@ do_install() {
>>
>> PARALLEL_MAKEINST = ""
>>
>> -PACKAGES =+ "${PN}-common ${PN}-syntax ${PN}-help ${PN}-tutor ${PN}-vimrc"
>> +PACKAGES =+ "${PN}-common ${PN}-syntax ${PN}-help ${PN}-tutor ${PN}-vimrc ${PN}-xxd"
>> FILES_${PN}-syntax = "${datadir}/${BPN}/${VIMDIR}/syntax"
>> FILES_${PN}-help = "${datadir}/${BPN}/${VIMDIR}/doc"
>> FILES_${PN}-tutor = "${datadir}/${BPN}/${VIMDIR}/tutor ${bindir}/${BPN}tutor"
>> FILES_${PN}-vimrc = "${datadir}/${BPN}/vimrc"
>> +FILES_${PN}-xxd = "${bindir}/xxd"
>
> So it was already included in some other package (probably main vim
> package)?
Yes, it is as you say, included in the main package.
If you think it's a good idea to leave it there, then we can simply
ignore these patches.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-29 11:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-28 11:44 [meta-oe][PATCH] vim: Compile and provide xxd in package vim-xxd Ioan-Adrian Ratiu
2015-09-28 16:07 ` Khem Raj
2015-09-29 10:03 ` Ioan-Adrian Ratiu
2015-09-29 10:15 ` [meta-oe][PATCH v2] vim: provide the xxd tool (package vim-xxd) Ioan-Adrian Ratiu
2015-09-29 11:22 ` Martin Jansa
2015-09-29 11:50 ` Ioan-Adrian Ratiu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.