[PATCH] staging: wilc1000: fix build error for openrisc-allmodconfig

[PATCH] staging: wilc1000: fix build error for openrisc-allmodconfig

[Chaehyun Lim]

The kbuild test robot reports the following build error for
openrisc-allmodconfig.

>> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit
>> declaration of function 'memset'

The error occurs due to missing a standard header file as
<linux/string.h> so that three .c files are included it.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
---
 drivers/staging/wilc1000/wilc_sdio.c     | 1 +
 drivers/staging/wilc1000/wilc_spi.c      | 1 +
 drivers/staging/wilc1000/wilc_wlan_cfg.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/wilc_sdio.c
index 6da65e8..6e28ca0 100644
--- a/drivers/staging/wilc1000/wilc_sdio.c
+++ b/drivers/staging/wilc1000/wilc_sdio.c
@@ -7,6 +7,7 @@
 /*  */
 /* //////////////////////////////////////////////////////////////////////////// */
 
+#include <linux/string.h>
 #include "wilc_wlan_if.h"
 #include "wilc_wlan.h"
 
diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index f762770..0e06fc2 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -7,6 +7,7 @@
 /*  */
 /* //////////////////////////////////////////////////////////////////////////// */
 
+#include <linux/string.h>
 #include "wilc_wlan_if.h"
 #include "wilc_wlan.h"
 
diff --git a/drivers/staging/wilc1000/wilc_wlan_cfg.c b/drivers/staging/wilc1000/wilc_wlan_cfg.c
index 73a1508..d761a37 100644
--- a/drivers/staging/wilc1000/wilc_wlan_cfg.c
+++ b/drivers/staging/wilc1000/wilc_wlan_cfg.c
@@ -7,6 +7,7 @@
 /*  */
 /* ///////////////////////////////////////////////////////////////////////// */
 
+#include <linux/string.h>
 #include "wilc_wlan_if.h"
 #include "wilc_wlan.h"
 #include "wilc_wlan_cfg.h"
-- 
2.6.0

Re: [PATCH] staging: wilc1000: fix build error for openrisc-allmodconfig

[Greg KH]

On Wed, Sep 30, 2015 at 05:52:14PM +0900, Chaehyun Lim wrote:
> The kbuild test robot reports the following build error for
> openrisc-allmodconfig.
> 
> >> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit
> >> declaration of function 'memset'
> 
> The error occurs due to missing a standard header file as
> <linux/string.h> so that three .c files are included it.
> 
> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>

You forgot to add a Reported-by: line giving credit to kbuild, I've done
that by hand.

thanks,

greg k-h

Re: [PATCH] staging: wilc1000: fix build error for openrisc-allmodconfig

[Chaehyun Lim]

On Wed, Sep 30, 2015 at 7:20 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Sep 30, 2015 at 05:52:14PM +0900, Chaehyun Lim wrote:
>> The kbuild test robot reports the following build error for
>> openrisc-allmodconfig.
>>
>> >> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit
>> >> declaration of function 'memset'
>>
>> The error occurs due to missing a standard header file as
>> <linux/string.h> so that three .c files are included it.
>>
>> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
>
> You forgot to add a Reported-by: line giving credit to kbuild, I've done
> that by hand.
>
> thanks,
>
> greg k-h

I understood. I will keep it in my mind to send patch.

Regards
Chaehyun Lim