All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH]ntp: fix perl path
@ 2015-01-13 21:44 Szombathelyi György
  2015-01-18 14:42 ` Szombathelyi György
  0 siblings, 1 reply; 6+ messages in thread
From: Szombathelyi György @ 2015-01-13 21:44 UTC (permalink / raw)
  To: openembedded-devel

    Fix perl path in ntp-wait and calc_tickadj.
    
    Signed-off-by: Gyorgy Szombathelyi <gyurco@freemail.hu>

diff --git a/meta-networking/recipes-support/ntp/ntp_4.2.8.bb b/meta-networking/recipes-support/ntp/ntp_4.2.8.bb
index 9f74f6b..e802ee7 100644
--- a/meta-networking/recipes-support/ntp/ntp_4.2.8.bb
+++ b/meta-networking/recipes-support/ntp/ntp_4.2.8.bb
@@ -74,8 +74,10 @@ do_install_append() {
     sed -i 's!^PATH=.*!PATH=${base_sbindir}:${base_bindir}:${sbindir}:${bindir}!' ${D}${bindir}/ntpdate-sync
     sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,' ${D}${sbindir}/ntptrace
     sed -i '/use/i use warnings;' ${D}${sbindir}/ntptrace
-    sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,' ${D}${sbindir}/ntp-wait
+    sed -i '1s,#!.*perl,#! ${bindir}/env perl,' ${D}${sbindir}/ntp-wait
     sed -i '/use/i use warnings;' ${D}${sbindir}/ntp-wait
+    sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,' ${D}${sbindir}/calc_tickadj
+    sed -i '/use/i use warnings;' ${D}${sbindir}/calc_tickadj
 
     install -d ${D}/${sysconfdir}/default
     install -m 644 ${WORKDIR}/ntpdate.default ${D}${sysconfdir}/default/ntpdate




^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH]ntp: fix perl path
  2015-01-13 21:44 [meta-oe][PATCH]ntp: fix perl path Szombathelyi György
@ 2015-01-18 14:42 ` Szombathelyi György
  2015-01-21 20:05   ` Szombathelyi György
  0 siblings, 1 reply; 6+ messages in thread
From: Szombathelyi György @ 2015-01-18 14:42 UTC (permalink / raw)
  To: openembedded-devel

Hi,

Any chance to get this into git? Now if one has a system /bin/perl, ntp build 
will fail.

Br,
György

On Tuesday 13 January 2015 22:44:03 Szombathelyi György wrote:
>     Fix perl path in ntp-wait and calc_tickadj.
> 
>     Signed-off-by: Gyorgy Szombathelyi <gyurco@freemail.hu>
> 
> diff --git a/meta-networking/recipes-support/ntp/ntp_4.2.8.bb
> b/meta-networking/recipes-support/ntp/ntp_4.2.8.bb index 9f74f6b..e802ee7
> 100644
> --- a/meta-networking/recipes-support/ntp/ntp_4.2.8.bb
> +++ b/meta-networking/recipes-support/ntp/ntp_4.2.8.bb
> @@ -74,8 +74,10 @@ do_install_append() {
>      sed -i
> 's!^PATH=.*!PATH=${base_sbindir}:${base_bindir}:${sbindir}:${bindir}!'
> ${D}${bindir}/ntpdate-sync sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,'
> ${D}${sbindir}/ntptrace sed -i '/use/i use warnings;'
> ${D}${sbindir}/ntptrace
> -    sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,' ${D}${sbindir}/ntp-wait
> +    sed -i '1s,#!.*perl,#! ${bindir}/env perl,' ${D}${sbindir}/ntp-wait
>      sed -i '/use/i use warnings;' ${D}${sbindir}/ntp-wait
> +    sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,'
> ${D}${sbindir}/calc_tickadj +    sed -i '/use/i use warnings;'
> ${D}${sbindir}/calc_tickadj
> 
>      install -d ${D}/${sysconfdir}/default
>      install -m 644 ${WORKDIR}/ntpdate.default
> ${D}${sysconfdir}/default/ntpdate



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH]ntp: fix perl path
  2015-01-18 14:42 ` Szombathelyi György
@ 2015-01-21 20:05   ` Szombathelyi György
  2015-01-23 11:22     ` Paul Eggleton
  0 siblings, 1 reply; 6+ messages in thread
From: Szombathelyi György @ 2015-01-21 20:05 UTC (permalink / raw)
  To: openembedded-devel

...more precisely, without the patch ntp-utils will have a /bin/perl 
dependency, so it becomes uninstallable (nothing provides /bin/perl).

Br,
György

On Sunday 18 January 2015 15:42:59 Szombathelyi György wrote:
> Hi,
> 
> Any chance to get this into git? Now if one has a system /bin/perl, ntp
> build will fail.
> 
> Br,
> György
> 
> On Tuesday 13 January 2015 22:44:03 Szombathelyi György wrote:
> >     Fix perl path in ntp-wait and calc_tickadj.
> >     
> >     Signed-off-by: Gyorgy Szombathelyi <gyurco@freemail.hu>
> > 
> > diff --git a/meta-networking/recipes-support/ntp/ntp_4.2.8.bb
> > b/meta-networking/recipes-support/ntp/ntp_4.2.8.bb index 9f74f6b..e802ee7
> > 100644
> > --- a/meta-networking/recipes-support/ntp/ntp_4.2.8.bb
> > +++ b/meta-networking/recipes-support/ntp/ntp_4.2.8.bb
> > @@ -74,8 +74,10 @@ do_install_append() {
> > 
> >      sed -i
> > 
> > 's!^PATH=.*!PATH=${base_sbindir}:${base_bindir}:${sbindir}:${bindir}!'
> > ${D}${bindir}/ntpdate-sync sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,'
> > ${D}${sbindir}/ntptrace sed -i '/use/i use warnings;'
> > ${D}${sbindir}/ntptrace
> > -    sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,'
> > ${D}${sbindir}/ntp-wait
> > +    sed -i '1s,#!.*perl,#! ${bindir}/env perl,' ${D}${sbindir}/ntp-wait
> > 
> >      sed -i '/use/i use warnings;' ${D}${sbindir}/ntp-wait
> > 
> > +    sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,'
> > ${D}${sbindir}/calc_tickadj +    sed -i '/use/i use warnings;'
> > ${D}${sbindir}/calc_tickadj
> > 
> >      install -d ${D}/${sysconfdir}/default
> >      install -m 644 ${WORKDIR}/ntpdate.default
> > 
> > ${D}${sysconfdir}/default/ntpdate



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH]ntp: fix perl path
  2015-01-21 20:05   ` Szombathelyi György
@ 2015-01-23 11:22     ` Paul Eggleton
  2015-01-23 12:42       ` Joe MacDonald
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Eggleton @ 2015-01-23 11:22 UTC (permalink / raw)
  To: Szombathelyi György, Joe MacDonald; +Cc: openembedded-devel

On Wednesday 21 January 2015 21:05:12 Szombathelyi György wrote:
> ...more precisely, without the patch ntp-utils will have a /bin/perl
> dependency, so it becomes uninstallable (nothing provides /bin/perl).

We do definitely want to fix this, yes - and the breakage may have been my 
fault, sorry about that.

I think one reason your patch hasn't been picked up yet may be that it should 
have been marked as [meta-networking] rather than [meta-oe] since meta-
networking is the layer in which the ntp recipe resides.

Joe, can you please apply this?

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH]ntp: fix perl path
  2015-01-23 11:22     ` Paul Eggleton
@ 2015-01-23 12:42       ` Joe MacDonald
  0 siblings, 0 replies; 6+ messages in thread
From: Joe MacDonald @ 2015-01-23 12:42 UTC (permalink / raw)
  To: Paul Eggleton; +Cc: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

[Re: [oe] [meta-oe][PATCH]ntp: fix perl path] On 15.01.23 (Fri 11:22) Paul Eggleton wrote:

> On Wednesday 21 January 2015 21:05:12 Szombathelyi György wrote:
> > ...more precisely, without the patch ntp-utils will have a /bin/perl
> > dependency, so it becomes uninstallable (nothing provides /bin/perl).
> 
> We do definitely want to fix this, yes - and the breakage may have been my 
> fault, sorry about that.
> 
> I think one reason your patch hasn't been picked up yet may be that it should 
> have been marked as [meta-networking] rather than [meta-oe] since meta-
> networking is the layer in which the ntp recipe resides.
> 
> Joe, can you please apply this?

Yep, no problem.  I'll grab it right now.  I did notice it last night,
finally, but never thought to check the status as I thought it was
typically the sort of thing Martin would grab.

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 501 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [meta-oe][PATCH]ntp: fix perl path
@ 2015-01-13 21:40 Szombathelyi György
  0 siblings, 0 replies; 6+ messages in thread
From: Szombathelyi György @ 2015-01-13 21:40 UTC (permalink / raw)
  To: openembedded-devel

    Fix perl path in ntp-wait and calc_tickadj.
    
    Signed-off-by: Gyorgy Szombathelyi <gyurco@freemail.hu>

diff --git a/meta-networking/recipes-support/ntp/ntp_4.2.8.bb b/meta-
networking/recipes-support/ntp/ntp_4.2.8.bb
index 9f74f6b..e802ee7 100644
--- a/meta-networking/recipes-support/ntp/ntp_4.2.8.bb
+++ b/meta-networking/recipes-support/ntp/ntp_4.2.8.bb
@@ -74,8 +74,10 @@ do_install_append() {
     sed -i 's!^PATH=.*!PATH=${base_sbindir}:${base_bindir}:${sbindir}:
${bindir}!' ${D}${bindir}/ntpdate-sync
     sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,' ${D}${sbindir}/ntptrace
     sed -i '/use/i use warnings;' ${D}${sbindir}/ntptrace
-    sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,' ${D}${sbindir}/ntp-wait
+    sed -i '1s,#!.*perl,#! ${bindir}/env perl,' ${D}${sbindir}/ntp-wait
     sed -i '/use/i use warnings;' ${D}${sbindir}/ntp-wait
+    sed -i '1s,#!.*perl -w,#! ${bindir}/env perl,' 
${D}${sbindir}/calc_tickadj
+    sed -i '/use/i use warnings;' ${D}${sbindir}/calc_tickadj
 
     install -d ${D}/${sysconfdir}/default
     install -m 644 ${WORKDIR}/ntpdate.default 
${D}${sysconfdir}/default/ntpdate




^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-23 12:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-13 21:44 [meta-oe][PATCH]ntp: fix perl path Szombathelyi György
2015-01-18 14:42 ` Szombathelyi György
2015-01-21 20:05   ` Szombathelyi György
2015-01-23 11:22     ` Paul Eggleton
2015-01-23 12:42       ` Joe MacDonald
  -- strict thread matches above, loose matches on Subject: below --
2015-01-13 21:40 Szombathelyi György

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.