* [PATCH] staging: octeon: Remove bad line
@ 2015-10-02 18:47 Cristina Moraru
2015-10-03 18:32 ` [Outreachy kernel] " Daniel Baluta
0 siblings, 1 reply; 2+ messages in thread
From: Cristina Moraru @ 2015-10-02 18:47 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Cristina Moraru
Fix 'bad line' kernel-doc warning
Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
---
drivers/staging/octeon/ethernet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 7274fda..a8da250 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -368,7 +368,7 @@ static void cvm_oct_common_set_multicast_list(struct net_device *dev)
* cvm_oct_common_set_mac_address - set the hardware MAC address for a device
* @dev: The device in question.
* @addr: Address structure to change it too.
-
+ *
* Returns Zero on success
*/
static int cvm_oct_set_mac_filter(struct net_device *dev)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: octeon: Remove bad line
2015-10-02 18:47 [PATCH] staging: octeon: Remove bad line Cristina Moraru
@ 2015-10-03 18:32 ` Daniel Baluta
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Baluta @ 2015-10-03 18:32 UTC (permalink / raw)
To: Cristina Moraru; +Cc: outreachy-kernel
Commit message should be more explicit.
Do not focus exactly on the message reported by kernel-doc tool, but on
why we do need this patch.
e.g staging: octeon: Remove empty line to fix kernel-doc warning
Kernel-doc styles comments should always start with a *.
We are now free of the following kernel-doc warning:
<insert kernel-doc warning>
thanks,
Daniel.
On Fri, Oct 2, 2015 at 9:47 PM, Cristina Moraru
<cristina.moraru09@gmail.com> wrote:
> Fix 'bad line' kernel-doc warning
>
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
> ---
> drivers/staging/octeon/ethernet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 7274fda..a8da250 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -368,7 +368,7 @@ static void cvm_oct_common_set_multicast_list(struct net_device *dev)
> * cvm_oct_common_set_mac_address - set the hardware MAC address for a device
> * @dev: The device in question.
> * @addr: Address structure to change it too.
> -
> + *
> * Returns Zero on success
> */
> static int cvm_oct_set_mac_filter(struct net_device *dev)
> --
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-03 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-02 18:47 [PATCH] staging: octeon: Remove bad line Cristina Moraru
2015-10-03 18:32 ` [Outreachy kernel] " Daniel Baluta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.