* [Patch net] act_mirred: clear sender cpu before sending to tx
@ 2015-10-07 0:23 Cong Wang
2015-10-07 1:27 ` Eric Dumazet
2015-10-08 12:05 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Cong Wang @ 2015-10-07 0:23 UTC (permalink / raw)
To: netdev; +Cc: Cong Wang, Eric Dumazet, Jamal Hadi Salim, Cong Wang
Similar to commit c29390c6dfee ("xps: must clear sender_cpu before forwarding")
the skb->sender_cpu needs to be cleared when moving from Rx
Tx, otherwise kernel could crash.
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Cong Wang <cwang@twopensource.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
net/sched/act_mirred.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c
index 2efaf4e..32fcdec 100644
--- a/net/sched/act_mirred.c
+++ b/net/sched/act_mirred.c
@@ -179,6 +179,7 @@ static int tcf_mirred(struct sk_buff *skb, const struct tc_action *a,
skb2->skb_iif = skb->dev->ifindex;
skb2->dev = dev;
+ skb_sender_cpu_clear(skb2);
err = dev_queue_xmit(skb2);
if (err) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch net] act_mirred: clear sender cpu before sending to tx
2015-10-07 0:23 [Patch net] act_mirred: clear sender cpu before sending to tx Cong Wang
@ 2015-10-07 1:27 ` Eric Dumazet
2015-10-08 12:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2015-10-07 1:27 UTC (permalink / raw)
To: Cong Wang; +Cc: netdev, Eric Dumazet, Jamal Hadi Salim, Cong Wang
On Tue, 2015-10-06 at 17:23 -0700, Cong Wang wrote:
> Similar to commit c29390c6dfee ("xps: must clear sender_cpu before forwarding")
> the skb->sender_cpu needs to be cleared when moving from Rx
> Tx, otherwise kernel could crash.
>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Cong Wang <cwang@twopensource.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch net] act_mirred: clear sender cpu before sending to tx
2015-10-07 0:23 [Patch net] act_mirred: clear sender cpu before sending to tx Cong Wang
2015-10-07 1:27 ` Eric Dumazet
@ 2015-10-08 12:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-10-08 12:05 UTC (permalink / raw)
To: xiyou.wangcong; +Cc: netdev, edumazet, jhs, cwang
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Tue, 6 Oct 2015 17:23:47 -0700
> Similar to commit c29390c6dfee ("xps: must clear sender_cpu before forwarding")
> the skb->sender_cpu needs to be cleared when moving from Rx
> Tx, otherwise kernel could crash.
>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Cong Wang <cwang@twopensource.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-08 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-07 0:23 [Patch net] act_mirred: clear sender cpu before sending to tx Cong Wang
2015-10-07 1:27 ` Eric Dumazet
2015-10-08 12:05 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.