* [LTP] [PATCH] inotify06: kernel version fix
@ 2015-10-09 14:26 Cedric Hnyda
2015-10-12 10:23 ` Cyril Hrubis
0 siblings, 1 reply; 2+ messages in thread
From: Cedric Hnyda @ 2015-10-09 14:26 UTC (permalink / raw)
To: ltp
inotify06 is a regression test for kernels >= 4.2.
Add a condition so that only >= 4.2 kernels can run the test
because previous kernel are likely to crash because of the test.
Signed-off-by: Cedric Hnyda <chnyda@suse.com>
---
testcases/kernel/syscalls/inotify/inotify06.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/testcases/kernel/syscalls/inotify/inotify06.c b/testcases/kernel/syscalls/inotify/inotify06.c
index 71f7596..090729d 100644
--- a/testcases/kernel/syscalls/inotify/inotify06.c
+++ b/testcases/kernel/syscalls/inotify/inotify06.c
@@ -69,6 +69,11 @@ static void setup(void)
{
int i;
+ if ((tst_kvercmp(4, 2, 0)) < 0) {
+ tst_brkm(TCONF, NULL,
+ "This test can only run on kernels that are 4.2. and higher");
+ }
+
tst_sig(FORK, DEF_HANDLER, cleanup);
TEST_PAUSE;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [LTP] [PATCH] inotify06: kernel version fix
2015-10-09 14:26 [LTP] [PATCH] inotify06: kernel version fix Cedric Hnyda
@ 2015-10-12 10:23 ` Cyril Hrubis
0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2015-10-12 10:23 UTC (permalink / raw)
To: ltp
Hi!
> inotify06 is a regression test for kernels >= 4.2.
> Add a condition so that only >= 4.2 kernels can run the test
> because previous kernel are likely to crash because of the test.
No, it's a regression test for a bug that was fixed in 4.2 and
backported to stable kernel branches. It's okay that it brings down
unpatched kernels, since they are buggy and should be updated.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-12 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-09 14:26 [LTP] [PATCH] inotify06: kernel version fix Cedric Hnyda
2015-10-12 10:23 ` Cyril Hrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.