All of lore.kernel.org
 help / color / mirror / Atom feed
From: Feng Wu <feng.wu@intel.com>
To: xen-devel@lists.xen.org
Cc: Kevin Tian <kevin.tian@intel.com>,
	feng.wu@intel.com, Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v8 03/17] iommu: Add iommu_intpost to control VT-d Posted-Interrupts feature
Date: Mon, 12 Oct 2015 16:54:49 +0800	[thread overview]
Message-ID: <1444640103-4685-4-git-send-email-feng.wu@intel.com> (raw)
In-Reply-To: <1444640103-4685-1-git-send-email-feng.wu@intel.com>

VT-d Posted-Interrupts is an enhancement to CPU side Posted-Interrupt.
With VT-d Posted-Interrupts enabled, external interrupts from
direct-assigned devices can be delivered to guests without VMM
intervention when guest is running in non-root mode.

This patch adds variable 'iommu_intpost' to control whether enable VT-d
posted-interrupt or not in the generic IOMMU code.

CC: Jan Beulich <jbeulich@suse.com>
CC: Kevin Tian <kevin.tian@intel.com>
Signed-off-by: Feng Wu <feng.wu@intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v5:
- Remove the "if no intremap then no intpost" logic in parse_iommu_param(), which
  can be covered in iommu_setup()

v3:
- Remove pointless initializer for 'iommu_intpost'.
- Some adjustment for "if no intremap then no intpost" logic.
    * For parse_iommu_param(), move it to the end of the function,
      so we don't need to add the some logic when introduing the
      new kernel parameter 'intpost' in later patch.
    * Add this logic in iommu_setup() after iommu_hardware_setup()
      is called.

 xen/drivers/passthrough/iommu.c | 13 ++++++++++++-
 xen/include/xen/iommu.h         |  2 +-
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index fc7831e..36d5cc0 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -51,6 +51,14 @@ bool_t __read_mostly iommu_passthrough;
 bool_t __read_mostly iommu_snoop = 1;
 bool_t __read_mostly iommu_qinval = 1;
 bool_t __read_mostly iommu_intremap = 1;
+
+/*
+ * In the current implementation of VT-d posted interrupts, in some extreme
+ * cases, the per cpu list which saves the blocked vCPU will be very long,
+ * and this will affect the interrupt latency, so let this feature off by
+ * default until we find a good solution to resolve it.
+ */
+bool_t __read_mostly iommu_intpost;
 bool_t __read_mostly iommu_hap_pt_share = 1;
 bool_t __read_mostly iommu_debug;
 bool_t __read_mostly amd_iommu_perdev_intremap = 1;
@@ -307,6 +315,9 @@ int __init iommu_setup(void)
         panic("Couldn't enable %s and iommu=required/force",
               !iommu_enabled ? "IOMMU" : "Interrupt Remapping");
 
+    if ( !iommu_intremap )
+        iommu_intpost = 0;
+
     if ( !iommu_enabled )
     {
         iommu_snoop = 0;
@@ -374,7 +385,7 @@ void iommu_crash_shutdown(void)
     const struct iommu_ops *ops = iommu_get_ops();
     if ( iommu_enabled )
         ops->crash_shutdown();
-    iommu_enabled = iommu_intremap = 0;
+    iommu_enabled = iommu_intremap = iommu_intpost = 0;
 }
 
 int iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h
index 8f3a20e..1f5d04a 100644
--- a/xen/include/xen/iommu.h
+++ b/xen/include/xen/iommu.h
@@ -30,7 +30,7 @@
 extern bool_t iommu_enable, iommu_enabled;
 extern bool_t force_iommu, iommu_verbose;
 extern bool_t iommu_workaround_bios_bug, iommu_igfx, iommu_passthrough;
-extern bool_t iommu_snoop, iommu_qinval, iommu_intremap;
+extern bool_t iommu_snoop, iommu_qinval, iommu_intremap, iommu_intpost;
 extern bool_t iommu_hap_pt_share;
 extern bool_t iommu_debug;
 extern bool_t amd_iommu_perdev_intremap;
-- 
2.1.0

  parent reply	other threads:[~2015-10-12  8:54 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12  8:54 [PATCH v8 00/17] Add VT-d Posted-Interrupts support Feng Wu
2015-10-12  8:54 ` [PATCH v8 01/17] VT-d Posted-intterrupt (PI) design Feng Wu
2015-10-12 10:41   ` Andrew Cooper
2015-10-13  0:53     ` Wu, Feng
2015-10-29 15:56   ` Dario Faggioli
2015-10-12  8:54 ` [PATCH v8 02/17] Add cmpxchg16b support for x86-64 Feng Wu
2015-10-13 15:29   ` Jan Beulich
2015-10-14  5:57     ` Wu, Feng
2015-10-14  9:05       ` Jan Beulich
2015-10-14  9:29         ` Wu, Feng
2015-10-14  9:45           ` Jan Beulich
2015-10-14 10:03             ` Wu, Feng
2015-10-14 10:21               ` Jan Beulich
2015-10-14 10:25                 ` Wu, Feng
2015-10-12  8:54 ` Feng Wu [this message]
2015-10-12  8:54 ` [PATCH v8 04/17] vt-d: VT-d Posted-Interrupts feature detection Feng Wu
2015-10-12  8:54 ` [PATCH v8 05/17] vmx: Extend struct pi_desc to support VT-d Posted-Interrupts Feng Wu
2015-10-12  8:54 ` [PATCH v8 06/17] vmx: Add some helper functions for Posted-Interrupts Feng Wu
2015-10-12  8:54 ` [PATCH v8 07/17] vmx: Initialize VT-d Posted-Interrupts Descriptor Feng Wu
2015-10-12  8:54 ` [PATCH v8 08/17] vmx: Suppress posting interrupts when 'SN' is set Feng Wu
2015-10-12  8:54 ` [PATCH v8 09/17] VT-d: Remove pointless casts Feng Wu
2015-10-12  8:54 ` [PATCH v8 10/17] vt-d: Extend struct iremap_entry to support VT-d Posted-Interrupts Feng Wu
2015-10-12  8:54 ` [PATCH v8 11/17] vt-d: Add API to update IRTE when VT-d PI is used Feng Wu
2015-10-12  8:54 ` [PATCH v8 12/17] x86: move some APIC related macros to apicdef.h Feng Wu
2015-10-12  8:54 ` [PATCH v8 13/17] Update IRTE according to guest interrupt config changes Feng Wu
2015-10-12  8:55 ` [PATCH v8 14/17] vmx: Properly handle notification event when vCPU is running Feng Wu
2015-10-12  8:55 ` [PATCH v8 15/17] vmx: VT-d posted-interrupt core logic handling Feng Wu
2015-10-26 14:39   ` Dario Faggioli
2015-10-27  5:19     ` Wu, Feng
2015-10-27  9:51       ` Jan Beulich
2015-10-28  1:50         ` Dario Faggioli
2015-10-28  2:58         ` Wu, Feng
2015-10-28  9:03           ` Jan Beulich
2015-10-28 16:36             ` Dario Faggioli
2015-10-29  5:39               ` Wu, Feng
2015-10-29  9:26                 ` Dario Faggioli
2015-10-29 14:07                   ` Wu, Feng
2015-10-27 12:16       ` Dario Faggioli
2015-10-28  2:40         ` Wu, Feng
2015-10-27 12:22   ` Dario Faggioli
2015-10-12  8:55 ` [PATCH v8 16/17] VT-d: Dump the posted format IRTE Feng Wu
2015-10-12  8:55 ` [PATCH v8 17/17] Add a command line parameter for VT-d posted-interrupts Feng Wu
2015-10-23  2:12 ` [PATCH v8 00/17] Add VT-d Posted-Interrupts support Wu, Feng
2015-10-23  8:13   ` Jan Beulich
2015-10-23  8:35     ` Wu, Feng
2015-10-23  8:46       ` Dario Faggioli
2015-10-23  8:52         ` Wu, Feng
2015-10-29 10:51 ` Dario Faggioli
2015-10-29 14:05   ` Wu, Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444640103-4685-4-git-send-email-feng.wu@intel.com \
    --to=feng.wu@intel.com \
    --cc=jbeulich@suse.com \
    --cc=kevin.tian@intel.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.