* [PATCH 0/3] Split Arizona DT bindings between subsystems
@ 2015-10-14 14:12 ` Charles Keepax
0 siblings, 0 replies; 12+ messages in thread
From: Charles Keepax @ 2015-10-14 14:12 UTC (permalink / raw)
To: broonie, lee.jones, cw00.choi
Cc: myungjoo.ham, lgirdwood, devicetree, linux-kernel, patches
As discussed the Arizona device tree bindings documentation
will be split up into a seperate document holding properties
specific to each subsystem.
This series factors out the regulator and extcon
bindings. It will probably make sense to split out a GPIO
binding document as well but at the moment the only property
here is the gpio-defaults which are still handled in the MFD
driver and probably require significantly more thought to
split out.
Thanks,
Charles
Charles Keepax (3):
extcon: arizona: Add extcon specific device tree binding document
regulator: arizona: Add regulator specific device tree binding
document
mfd: arizona: Remove bindings covered in new subsystem specific docs
.../devicetree/bindings/extcon/extcon-arizona.txt | 15 +++++++++
Documentation/devicetree/bindings/mfd/arizona.txt | 30 ++---------------
.../bindings/regulator/arizona-regulator.txt | 34 ++++++++++++++++++++
MAINTAINERS | 3 ++
4 files changed, 55 insertions(+), 27 deletions(-)
create mode 100644 Documentation/devicetree/bindings/extcon/extcon-arizona.txt
create mode 100644 Documentation/devicetree/bindings/regulator/arizona-regulator.txt
--
1.7.2.5
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/3] Split Arizona DT bindings between subsystems
@ 2015-10-14 14:12 ` Charles Keepax
0 siblings, 0 replies; 12+ messages in thread
From: Charles Keepax @ 2015-10-14 14:12 UTC (permalink / raw)
To: broonie, lee.jones, cw00.choi
Cc: myungjoo.ham, lgirdwood, devicetree, linux-kernel, patches
As discussed the Arizona device tree bindings documentation
will be split up into a seperate document holding properties
specific to each subsystem.
This series factors out the regulator and extcon
bindings. It will probably make sense to split out a GPIO
binding document as well but at the moment the only property
here is the gpio-defaults which are still handled in the MFD
driver and probably require significantly more thought to
split out.
Thanks,
Charles
Charles Keepax (3):
extcon: arizona: Add extcon specific device tree binding document
regulator: arizona: Add regulator specific device tree binding
document
mfd: arizona: Remove bindings covered in new subsystem specific docs
.../devicetree/bindings/extcon/extcon-arizona.txt | 15 +++++++++
Documentation/devicetree/bindings/mfd/arizona.txt | 30 ++---------------
.../bindings/regulator/arizona-regulator.txt | 34 ++++++++++++++++++++
MAINTAINERS | 3 ++
4 files changed, 55 insertions(+), 27 deletions(-)
create mode 100644 Documentation/devicetree/bindings/extcon/extcon-arizona.txt
create mode 100644 Documentation/devicetree/bindings/regulator/arizona-regulator.txt
--
1.7.2.5
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/3] extcon: arizona: Add extcon specific device tree binding document
2015-10-14 14:12 ` Charles Keepax
@ 2015-10-14 14:12 ` Charles Keepax
-1 siblings, 0 replies; 12+ messages in thread
From: Charles Keepax @ 2015-10-14 14:12 UTC (permalink / raw)
To: broonie, lee.jones, cw00.choi
Cc: myungjoo.ham, lgirdwood, devicetree, linux-kernel, patches
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
.../devicetree/bindings/extcon/extcon-arizona.txt | 15 +++++++++++++++
MAINTAINERS | 1 +
2 files changed, 16 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/extcon/extcon-arizona.txt
diff --git a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
new file mode 100644
index 0000000..e1705fa
--- /dev/null
+++ b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
@@ -0,0 +1,15 @@
+Cirrus Logic Arizona class audio SoCs
+
+These devices are audio SoCs with extensive digital capabilities and a range
+of analogue I/O.
+
+This document lists Extcon specific bindings, see the primary binding document:
+ ../mfd/arizona.txt
+
+Optional properties:
+
+ - wlf,hpdet-channel : Headphone detection channel.
+ ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
+ ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
+ If this node is not mentioned or if the value is unknown, then
+ headphone detection mode is set to HPDETL.
diff --git a/MAINTAINERS b/MAINTAINERS
index 9f6685f..08c804a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11393,6 +11393,7 @@ T: git https://github.com/CirrusLogic/linux-drivers.git
W: https://github.com/CirrusLogic/linux-drivers/wiki
S: Supported
F: Documentation/hwmon/wm83??
+F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt
F: arch/arm/mach-s3c64xx/mach-crag6410*
F: drivers/clk/clk-wm83*.c
F: drivers/extcon/extcon-arizona.c
--
1.7.2.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/3] extcon: arizona: Add extcon specific device tree binding document
@ 2015-10-14 14:12 ` Charles Keepax
0 siblings, 0 replies; 12+ messages in thread
From: Charles Keepax @ 2015-10-14 14:12 UTC (permalink / raw)
To: broonie, lee.jones, cw00.choi
Cc: myungjoo.ham, lgirdwood, devicetree, linux-kernel, patches
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
.../devicetree/bindings/extcon/extcon-arizona.txt | 15 +++++++++++++++
MAINTAINERS | 1 +
2 files changed, 16 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/extcon/extcon-arizona.txt
diff --git a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
new file mode 100644
index 0000000..e1705fa
--- /dev/null
+++ b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
@@ -0,0 +1,15 @@
+Cirrus Logic Arizona class audio SoCs
+
+These devices are audio SoCs with extensive digital capabilities and a range
+of analogue I/O.
+
+This document lists Extcon specific bindings, see the primary binding document:
+ ../mfd/arizona.txt
+
+Optional properties:
+
+ - wlf,hpdet-channel : Headphone detection channel.
+ ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
+ ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
+ If this node is not mentioned or if the value is unknown, then
+ headphone detection mode is set to HPDETL.
diff --git a/MAINTAINERS b/MAINTAINERS
index 9f6685f..08c804a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11393,6 +11393,7 @@ T: git https://github.com/CirrusLogic/linux-drivers.git
W: https://github.com/CirrusLogic/linux-drivers/wiki
S: Supported
F: Documentation/hwmon/wm83??
+F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt
F: arch/arm/mach-s3c64xx/mach-crag6410*
F: drivers/clk/clk-wm83*.c
F: drivers/extcon/extcon-arizona.c
--
1.7.2.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/3] regulator: arizona: Add regulator specific device tree binding document
2015-10-14 14:12 ` Charles Keepax
@ 2015-10-14 14:12 ` Charles Keepax
-1 siblings, 0 replies; 12+ messages in thread
From: Charles Keepax @ 2015-10-14 14:12 UTC (permalink / raw)
To: broonie, lee.jones, cw00.choi
Cc: myungjoo.ham, lgirdwood, devicetree, linux-kernel, patches
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
.../bindings/regulator/arizona-regulator.txt | 34 ++++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 35 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/arizona-regulator.txt
diff --git a/Documentation/devicetree/bindings/regulator/arizona-regulator.txt b/Documentation/devicetree/bindings/regulator/arizona-regulator.txt
new file mode 100644
index 0000000..25bb7f3
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/arizona-regulator.txt
@@ -0,0 +1,34 @@
+Cirrus Logic Arizona class audio SoCs
+
+These devices are audio SoCs with extensive digital capabilities and a range
+of analogue I/O.
+
+This document lists regulator specific bindings, see the primary binding
+document:
+ ../mfd/arizona.txt
+
+Required properties:
+
+ - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
+ as covered in regulator.txt
+
+ - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
+ wm5110, wm8280, wm8998, wm1814)
+
+ - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
+ wm5110, wm8280, wm8998, wm1814)
+
+ - SPKVDD-supply : Speaker driver power supply (wm8997)
+
+Optional properties:
+ - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
+
+ - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
+ they are being externally supplied. As covered in
+ Documentation/devicetree/bindings/regulator/regulator.txt
+
+Optional subnodes:
+ - ldo1 : Initial data for the LDO1 regulator, as covered in
+ Documentation/devicetree/bindings/regulator/regulator.txt
+ - micvdd : Initial data for the MICVDD regulator, as covered in
+ Documentation/devicetree/bindings/regulator/regulator.txt
diff --git a/MAINTAINERS b/MAINTAINERS
index 08c804a..f353491 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11394,6 +11394,7 @@ W: https://github.com/CirrusLogic/linux-drivers/wiki
S: Supported
F: Documentation/hwmon/wm83??
F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt
+F: Documentation/devicetree/bindings/regulator/arizona-regulator.txt
F: arch/arm/mach-s3c64xx/mach-crag6410*
F: drivers/clk/clk-wm83*.c
F: drivers/extcon/extcon-arizona.c
--
1.7.2.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/3] regulator: arizona: Add regulator specific device tree binding document
@ 2015-10-14 14:12 ` Charles Keepax
0 siblings, 0 replies; 12+ messages in thread
From: Charles Keepax @ 2015-10-14 14:12 UTC (permalink / raw)
To: broonie, lee.jones, cw00.choi
Cc: myungjoo.ham, lgirdwood, devicetree, linux-kernel, patches
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
.../bindings/regulator/arizona-regulator.txt | 34 ++++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 35 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/arizona-regulator.txt
diff --git a/Documentation/devicetree/bindings/regulator/arizona-regulator.txt b/Documentation/devicetree/bindings/regulator/arizona-regulator.txt
new file mode 100644
index 0000000..25bb7f3
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/arizona-regulator.txt
@@ -0,0 +1,34 @@
+Cirrus Logic Arizona class audio SoCs
+
+These devices are audio SoCs with extensive digital capabilities and a range
+of analogue I/O.
+
+This document lists regulator specific bindings, see the primary binding
+document:
+ ../mfd/arizona.txt
+
+Required properties:
+
+ - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
+ as covered in regulator.txt
+
+ - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
+ wm5110, wm8280, wm8998, wm1814)
+
+ - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
+ wm5110, wm8280, wm8998, wm1814)
+
+ - SPKVDD-supply : Speaker driver power supply (wm8997)
+
+Optional properties:
+ - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
+
+ - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
+ they are being externally supplied. As covered in
+ Documentation/devicetree/bindings/regulator/regulator.txt
+
+Optional subnodes:
+ - ldo1 : Initial data for the LDO1 regulator, as covered in
+ Documentation/devicetree/bindings/regulator/regulator.txt
+ - micvdd : Initial data for the MICVDD regulator, as covered in
+ Documentation/devicetree/bindings/regulator/regulator.txt
diff --git a/MAINTAINERS b/MAINTAINERS
index 08c804a..f353491 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11394,6 +11394,7 @@ W: https://github.com/CirrusLogic/linux-drivers/wiki
S: Supported
F: Documentation/hwmon/wm83??
F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt
+F: Documentation/devicetree/bindings/regulator/arizona-regulator.txt
F: arch/arm/mach-s3c64xx/mach-crag6410*
F: drivers/clk/clk-wm83*.c
F: drivers/extcon/extcon-arizona.c
--
1.7.2.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/3] mfd: arizona: Remove bindings covered in new subsystem specific docs
2015-10-14 14:12 ` Charles Keepax
@ 2015-10-14 14:12 ` Charles Keepax
-1 siblings, 0 replies; 12+ messages in thread
From: Charles Keepax @ 2015-10-14 14:12 UTC (permalink / raw)
To: broonie, lee.jones, cw00.choi
Cc: myungjoo.ham, lgirdwood, devicetree, linux-kernel, patches
Binding documentation has been added in new subsystem specific binding
documents. This patch removes the now duplicate documentation from the
MFD documentation. Also whilst we are at it add a missing maintainers
entry for the MFD binding document.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
Documentation/devicetree/bindings/mfd/arizona.txt | 30 ++------------------
MAINTAINERS | 1 +
2 files changed, 4 insertions(+), 27 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
index a8fee60..077c4fe 100644
--- a/Documentation/devicetree/bindings/mfd/arizona.txt
+++ b/Documentation/devicetree/bindings/mfd/arizona.txt
@@ -30,21 +30,9 @@ Required properties:
- #gpio-cells : Must be 2. The first cell is the pin number and the
second cell is used to specify optional parameters (currently unused).
- - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
- as covered in Documentation/devicetree/bindings/regulator/regulator.txt
-
- - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
- wm5110, wm8280, wm8998, wm1814)
-
- - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
- wm5110, wm8280, wm8998, wm1814)
-
- - SPKVDD-supply : Speaker driver power supply (wm8997)
-
Optional properties:
- wlf,reset : GPIO specifier for the GPIO controlling /RESET
- - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
- wlf,gpio-defaults : A list of GPIO configuration register values. Defines
for the appropriate values can found in <dt-bindings/mfd/arizona.txt>. If
@@ -67,21 +55,9 @@ Optional properties:
present, the number of values should be less than or equal to the
number of inputs, unspecified inputs will use the chip default.
- - wlf,hpdet-channel : Headphone detection channel.
- ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
- ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
- If this node is not mentioned or if the value is unknown, then
- headphone detection mode is set to HPDETL.
-
- - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
- they are being externally supplied. As covered in
- Documentation/devicetree/bindings/regulator/regulator.txt
-
-Optional subnodes:
- - ldo1 : Initial data for the LDO1 regulator, as covered in
- Documentation/devicetree/bindings/regulator/regulator.txt
- - micvdd : Initial data for the MICVDD regulator, as covered in
- Documentation/devicetree/bindings/regulator/regulator.txt
+Also see child specific device properties:
+ Regulator - ../regulator/arizona-regulator.txt
+ Extcon - ../extcon/extcon-arizona.txt
Example:
diff --git a/MAINTAINERS b/MAINTAINERS
index f353491..544c747 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11395,6 +11395,7 @@ S: Supported
F: Documentation/hwmon/wm83??
F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt
F: Documentation/devicetree/bindings/regulator/arizona-regulator.txt
+F: Documentation/devicetree/bindings/mfd/arizona.txt
F: arch/arm/mach-s3c64xx/mach-crag6410*
F: drivers/clk/clk-wm83*.c
F: drivers/extcon/extcon-arizona.c
--
1.7.2.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/3] mfd: arizona: Remove bindings covered in new subsystem specific docs
@ 2015-10-14 14:12 ` Charles Keepax
0 siblings, 0 replies; 12+ messages in thread
From: Charles Keepax @ 2015-10-14 14:12 UTC (permalink / raw)
To: broonie, lee.jones, cw00.choi
Cc: myungjoo.ham, lgirdwood, devicetree, linux-kernel, patches
Binding documentation has been added in new subsystem specific binding
documents. This patch removes the now duplicate documentation from the
MFD documentation. Also whilst we are at it add a missing maintainers
entry for the MFD binding document.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
Documentation/devicetree/bindings/mfd/arizona.txt | 30 ++------------------
MAINTAINERS | 1 +
2 files changed, 4 insertions(+), 27 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
index a8fee60..077c4fe 100644
--- a/Documentation/devicetree/bindings/mfd/arizona.txt
+++ b/Documentation/devicetree/bindings/mfd/arizona.txt
@@ -30,21 +30,9 @@ Required properties:
- #gpio-cells : Must be 2. The first cell is the pin number and the
second cell is used to specify optional parameters (currently unused).
- - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
- as covered in Documentation/devicetree/bindings/regulator/regulator.txt
-
- - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
- wm5110, wm8280, wm8998, wm1814)
-
- - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
- wm5110, wm8280, wm8998, wm1814)
-
- - SPKVDD-supply : Speaker driver power supply (wm8997)
-
Optional properties:
- wlf,reset : GPIO specifier for the GPIO controlling /RESET
- - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
- wlf,gpio-defaults : A list of GPIO configuration register values. Defines
for the appropriate values can found in <dt-bindings/mfd/arizona.txt>. If
@@ -67,21 +55,9 @@ Optional properties:
present, the number of values should be less than or equal to the
number of inputs, unspecified inputs will use the chip default.
- - wlf,hpdet-channel : Headphone detection channel.
- ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
- ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
- If this node is not mentioned or if the value is unknown, then
- headphone detection mode is set to HPDETL.
-
- - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
- they are being externally supplied. As covered in
- Documentation/devicetree/bindings/regulator/regulator.txt
-
-Optional subnodes:
- - ldo1 : Initial data for the LDO1 regulator, as covered in
- Documentation/devicetree/bindings/regulator/regulator.txt
- - micvdd : Initial data for the MICVDD regulator, as covered in
- Documentation/devicetree/bindings/regulator/regulator.txt
+Also see child specific device properties:
+ Regulator - ../regulator/arizona-regulator.txt
+ Extcon - ../extcon/extcon-arizona.txt
Example:
diff --git a/MAINTAINERS b/MAINTAINERS
index f353491..544c747 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11395,6 +11395,7 @@ S: Supported
F: Documentation/hwmon/wm83??
F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt
F: Documentation/devicetree/bindings/regulator/arizona-regulator.txt
+F: Documentation/devicetree/bindings/mfd/arizona.txt
F: arch/arm/mach-s3c64xx/mach-crag6410*
F: drivers/clk/clk-wm83*.c
F: drivers/extcon/extcon-arizona.c
--
1.7.2.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] mfd: arizona: Remove bindings covered in new subsystem specific docs
@ 2015-10-15 8:08 ` Lee Jones
0 siblings, 0 replies; 12+ messages in thread
From: Lee Jones @ 2015-10-15 8:08 UTC (permalink / raw)
To: Charles Keepax
Cc: broonie, cw00.choi, myungjoo.ham, lgirdwood, devicetree,
linux-kernel, patches
On Wed, 14 Oct 2015, Charles Keepax wrote:
> Binding documentation has been added in new subsystem specific binding
> documents. This patch removes the now duplicate documentation from the
> MFD documentation. Also whilst we are at it add a missing maintainers
> entry for the MFD binding document.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 30 ++------------------
> MAINTAINERS | 1 +
> 2 files changed, 4 insertions(+), 27 deletions(-)
Nice. For my own reference:
Acked-by: Lee Jones <lee.jones@linaro.org>
Once everyone is happy with the other two patches, I'll pick this.
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index a8fee60..077c4fe 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -30,21 +30,9 @@ Required properties:
> - #gpio-cells : Must be 2. The first cell is the pin number and the
> second cell is used to specify optional parameters (currently unused).
>
> - - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
> - as covered in Documentation/devicetree/bindings/regulator/regulator.txt
> -
> - - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
> - wm5110, wm8280, wm8998, wm1814)
> -
> - - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
> - wm5110, wm8280, wm8998, wm1814)
> -
> - - SPKVDD-supply : Speaker driver power supply (wm8997)
> -
> Optional properties:
>
> - wlf,reset : GPIO specifier for the GPIO controlling /RESET
> - - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
>
> - wlf,gpio-defaults : A list of GPIO configuration register values. Defines
> for the appropriate values can found in <dt-bindings/mfd/arizona.txt>. If
> @@ -67,21 +55,9 @@ Optional properties:
> present, the number of values should be less than or equal to the
> number of inputs, unspecified inputs will use the chip default.
>
> - - wlf,hpdet-channel : Headphone detection channel.
> - ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
> - ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
> - If this node is not mentioned or if the value is unknown, then
> - headphone detection mode is set to HPDETL.
> -
> - - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
> - they are being externally supplied. As covered in
> - Documentation/devicetree/bindings/regulator/regulator.txt
> -
> -Optional subnodes:
> - - ldo1 : Initial data for the LDO1 regulator, as covered in
> - Documentation/devicetree/bindings/regulator/regulator.txt
> - - micvdd : Initial data for the MICVDD regulator, as covered in
> - Documentation/devicetree/bindings/regulator/regulator.txt
> +Also see child specific device properties:
> + Regulator - ../regulator/arizona-regulator.txt
> + Extcon - ../extcon/extcon-arizona.txt
>
> Example:
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f353491..544c747 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11395,6 +11395,7 @@ S: Supported
> F: Documentation/hwmon/wm83??
> F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> F: Documentation/devicetree/bindings/regulator/arizona-regulator.txt
> +F: Documentation/devicetree/bindings/mfd/arizona.txt
> F: arch/arm/mach-s3c64xx/mach-crag6410*
> F: drivers/clk/clk-wm83*.c
> F: drivers/extcon/extcon-arizona.c
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] mfd: arizona: Remove bindings covered in new subsystem specific docs
@ 2015-10-15 8:08 ` Lee Jones
0 siblings, 0 replies; 12+ messages in thread
From: Lee Jones @ 2015-10-15 8:08 UTC (permalink / raw)
To: Charles Keepax
Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A, cw00.choi-Sze3O3UU22JBDgjK7y7TUQ,
myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E
On Wed, 14 Oct 2015, Charles Keepax wrote:
> Binding documentation has been added in new subsystem specific binding
> documents. This patch removes the now duplicate documentation from the
> MFD documentation. Also whilst we are at it add a missing maintainers
> entry for the MFD binding document.
>
> Signed-off-by: Charles Keepax <ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 30 ++------------------
> MAINTAINERS | 1 +
> 2 files changed, 4 insertions(+), 27 deletions(-)
Nice. For my own reference:
Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Once everyone is happy with the other two patches, I'll pick this.
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index a8fee60..077c4fe 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -30,21 +30,9 @@ Required properties:
> - #gpio-cells : Must be 2. The first cell is the pin number and the
> second cell is used to specify optional parameters (currently unused).
>
> - - AVDD-supply, DBVDD1-supply, CPVDD-supply : Power supplies for the device,
> - as covered in Documentation/devicetree/bindings/regulator/regulator.txt
> -
> - - DBVDD2-supply, DBVDD3-supply : Additional databus power supplies (wm5102,
> - wm5110, wm8280, wm8998, wm1814)
> -
> - - SPKVDDL-supply, SPKVDDR-supply : Speaker driver power supplies (wm5102,
> - wm5110, wm8280, wm8998, wm1814)
> -
> - - SPKVDD-supply : Speaker driver power supply (wm8997)
> -
> Optional properties:
>
> - wlf,reset : GPIO specifier for the GPIO controlling /RESET
> - - wlf,ldoena : GPIO specifier for the GPIO controlling LDOENA
>
> - wlf,gpio-defaults : A list of GPIO configuration register values. Defines
> for the appropriate values can found in <dt-bindings/mfd/arizona.txt>. If
> @@ -67,21 +55,9 @@ Optional properties:
> present, the number of values should be less than or equal to the
> number of inputs, unspecified inputs will use the chip default.
>
> - - wlf,hpdet-channel : Headphone detection channel.
> - ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
> - ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
> - If this node is not mentioned or if the value is unknown, then
> - headphone detection mode is set to HPDETL.
> -
> - - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
> - they are being externally supplied. As covered in
> - Documentation/devicetree/bindings/regulator/regulator.txt
> -
> -Optional subnodes:
> - - ldo1 : Initial data for the LDO1 regulator, as covered in
> - Documentation/devicetree/bindings/regulator/regulator.txt
> - - micvdd : Initial data for the MICVDD regulator, as covered in
> - Documentation/devicetree/bindings/regulator/regulator.txt
> +Also see child specific device properties:
> + Regulator - ../regulator/arizona-regulator.txt
> + Extcon - ../extcon/extcon-arizona.txt
>
> Example:
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f353491..544c747 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11395,6 +11395,7 @@ S: Supported
> F: Documentation/hwmon/wm83??
> F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> F: Documentation/devicetree/bindings/regulator/arizona-regulator.txt
> +F: Documentation/devicetree/bindings/mfd/arizona.txt
> F: arch/arm/mach-s3c64xx/mach-crag6410*
> F: drivers/clk/clk-wm83*.c
> F: drivers/extcon/extcon-arizona.c
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] extcon: arizona: Add extcon specific device tree binding document
@ 2015-10-15 8:39 ` Chanwoo Choi
0 siblings, 0 replies; 12+ messages in thread
From: Chanwoo Choi @ 2015-10-15 8:39 UTC (permalink / raw)
To: Charles Keepax, broonie, lee.jones
Cc: myungjoo.ham, lgirdwood, devicetree, linux-kernel, patches
Hi Charles,
On 2015년 10월 14일 23:12, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> .../devicetree/bindings/extcon/extcon-arizona.txt | 15 +++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 16 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/extcon/extcon-arizona.txt
>
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> new file mode 100644
> index 0000000..e1705fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> @@ -0,0 +1,15 @@
> +Cirrus Logic Arizona class audio SoCs
> +
> +These devices are audio SoCs with extensive digital capabilities and a range
> +of analogue I/O.
> +
> +This document lists Extcon specific bindings, see the primary binding document:
> + ../mfd/arizona.txt
> +
> +Optional properties:
> +
> + - wlf,hpdet-channel : Headphone detection channel.
> + ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
> + ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
> + If this node is not mentioned or if the value is unknown, then
> + headphone detection mode is set to HPDETL.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9f6685f..08c804a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11393,6 +11393,7 @@ T: git https://github.com/CirrusLogic/linux-drivers.git
> W: https://github.com/CirrusLogic/linux-drivers/wiki
> S: Supported
> F: Documentation/hwmon/wm83??
> +F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> F: arch/arm/mach-s3c64xx/mach-crag6410*
> F: drivers/clk/clk-wm83*.c
> F: drivers/extcon/extcon-arizona.c
>
You should add the description of patch.
If you add the description, looks good to me and you can add my acked tag.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] extcon: arizona: Add extcon specific device tree binding document
@ 2015-10-15 8:39 ` Chanwoo Choi
0 siblings, 0 replies; 12+ messages in thread
From: Chanwoo Choi @ 2015-10-15 8:39 UTC (permalink / raw)
To: Charles Keepax, broonie-DgEjT+Ai2ygdnm+yROfE0A,
lee.jones-QSEj5FYQhm4dnm+yROfE0A
Cc: myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E
Hi Charles,
On 2015년 10월 14일 23:12, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> ---
> .../devicetree/bindings/extcon/extcon-arizona.txt | 15 +++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 16 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/extcon/extcon-arizona.txt
>
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> new file mode 100644
> index 0000000..e1705fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> @@ -0,0 +1,15 @@
> +Cirrus Logic Arizona class audio SoCs
> +
> +These devices are audio SoCs with extensive digital capabilities and a range
> +of analogue I/O.
> +
> +This document lists Extcon specific bindings, see the primary binding document:
> + ../mfd/arizona.txt
> +
> +Optional properties:
> +
> + - wlf,hpdet-channel : Headphone detection channel.
> + ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL
> + ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR
> + If this node is not mentioned or if the value is unknown, then
> + headphone detection mode is set to HPDETL.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9f6685f..08c804a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11393,6 +11393,7 @@ T: git https://github.com/CirrusLogic/linux-drivers.git
> W: https://github.com/CirrusLogic/linux-drivers/wiki
> S: Supported
> F: Documentation/hwmon/wm83??
> +F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> F: arch/arm/mach-s3c64xx/mach-crag6410*
> F: drivers/clk/clk-wm83*.c
> F: drivers/extcon/extcon-arizona.c
>
You should add the description of patch.
If you add the description, looks good to me and you can add my acked tag.
Acked-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2015-10-15 8:39 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-14 14:12 [PATCH 0/3] Split Arizona DT bindings between subsystems Charles Keepax
2015-10-14 14:12 ` Charles Keepax
2015-10-14 14:12 ` [PATCH 1/3] extcon: arizona: Add extcon specific device tree binding document Charles Keepax
2015-10-14 14:12 ` Charles Keepax
2015-10-15 8:39 ` Chanwoo Choi
2015-10-15 8:39 ` Chanwoo Choi
2015-10-14 14:12 ` [PATCH 2/3] regulator: arizona: Add regulator " Charles Keepax
2015-10-14 14:12 ` Charles Keepax
2015-10-14 14:12 ` [PATCH 3/3] mfd: arizona: Remove bindings covered in new subsystem specific docs Charles Keepax
2015-10-14 14:12 ` Charles Keepax
2015-10-15 8:08 ` Lee Jones
2015-10-15 8:08 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.