* [PATCH net-next] net: hisilicon: fixes a bug when using ethtool -S
@ 2015-10-15 4:40 yankejian
2015-10-15 13:02 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: yankejian @ 2015-10-15 4:40 UTC (permalink / raw)
To: liguozhu, yisen.zhuang, huangdaode, lipeng321, yankejian, davem
Cc: netdev, linux-kernel, linuxarm
From: lipeng <lipeng321@huawei.com>
this patch fixes a bug in hns driver. when we want to get statistic info
by using ethtool -S, it shows us there are 3 wrong counters info. because
the strings related to the registers are wrong. it needs to modify the
strings which give us wrong info.
Signed-off-by: lipeng <lipeng321@huawei.com>
Signed-off-by: yankejian <yankejian@huawei.com>
Signed-off-by: Yisen Zhuang <yisen.zhuang@huawei.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c
index dab5ecf..802d554 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c
@@ -51,9 +51,9 @@ static const struct mac_stats_string g_xgmac_stats_string[] = {
{"xgmac_rx_bad_pkt_from_dsaf", MAC_STATS_FIELD_OFF(rx_bad_from_sw)},
{"xgmac_tx_bad_pkt_64tomax", MAC_STATS_FIELD_OFF(tx_bad_pkts)},
- {"xgmac_rx_not_well_pkt", MAC_STATS_FIELD_OFF(rx_fragment_err)},
- {"xgmac_rx_good_well_pkt", MAC_STATS_FIELD_OFF(rx_undersize)},
- {"xgmac_rx_total_pkt", MAC_STATS_FIELD_OFF(rx_under_min)},
+ {"xgmac_rx_bad_pkts_minto64", MAC_STATS_FIELD_OFF(rx_fragment_err)},
+ {"xgmac_rx_good_pkts_minto64", MAC_STATS_FIELD_OFF(rx_undersize)},
+ {"xgmac_rx_total_pkts_minto64", MAC_STATS_FIELD_OFF(rx_under_min)},
{"xgmac_rx_pkt_64", MAC_STATS_FIELD_OFF(rx_64bytes)},
{"xgmac_rx_pkt_65to127", MAC_STATS_FIELD_OFF(rx_65to127)},
{"xgmac_rx_pkt_128to255", MAC_STATS_FIELD_OFF(rx_128to255)},
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: hisilicon: fixes a bug when using ethtool -S
2015-10-15 4:40 [PATCH net-next] net: hisilicon: fixes a bug when using ethtool -S yankejian
@ 2015-10-15 13:02 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-10-15 13:02 UTC (permalink / raw)
To: yankejian
Cc: liguozhu, yisen.zhuang, huangdaode, lipeng321, netdev,
linux-kernel, linuxarm
From: yankejian <yankejian@huawei.com>
Date: Thu, 15 Oct 2015 12:40:34 +0800
> From: lipeng <lipeng321@huawei.com>
>
> this patch fixes a bug in hns driver. when we want to get statistic info
> by using ethtool -S, it shows us there are 3 wrong counters info. because
> the strings related to the registers are wrong. it needs to modify the
> strings which give us wrong info.
>
> Signed-off-by: lipeng <lipeng321@huawei.com>
> Signed-off-by: yankejian <yankejian@huawei.com>
> Signed-off-by: Yisen Zhuang <yisen.zhuang@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-15 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-15 4:40 [PATCH net-next] net: hisilicon: fixes a bug when using ethtool -S yankejian
2015-10-15 13:02 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.