* [PATCH] h8300: Don't set CROSS_COMPILE unconditionally
@ 2015-10-16 11:31 Javier Martinez Canillas
2015-10-21 14:55 ` Yoshinori Sato
0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez Canillas @ 2015-10-16 11:31 UTC (permalink / raw)
To: linux-kernel; +Cc: Javier Martinez Canillas, Yoshinori Sato, uclinux-h8-devel
The h8300 architecture Makefile sets the CROSS_COMPILE variable to
"h8300-unknown-linux-" unconditionally but doing that prevents the
variable to be used if a toolchain with a different binary name is
installed in the machine.
So only set CROSS_COMPILE to that default if the variable has not
been set by the user before.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Hello,
After $SUBJECT, I'm able to build using the toolchain installed by
my Linux distribution but the linker gives me an error about an
unrecognised emulation mode:
h8300-linux-gnu-ld: unrecognised emulation mode: h8300helf_linux
I see that h8300helf_linux and 8300self_linux are hardcoded in the
Makefile as well and these are not listed as supported emulations:
Supported emulations: h8300elf h8300helf h8300self h8300hnelf h8300snelf h8300sxelf h8300sxnelf
I tried changing -mh8300helf_linux for -mh8300helf that is listed
as a supported emulation but then I got the following error:
h8300-linux-gnu-ld: cannot open linker script file ldscripts/h8300helf.xr: No such file or directory
Best regards,
Javier
arch/h8300/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/h8300/Makefile b/arch/h8300/Makefile
index 0d2d96e52d9f..e1c02ca230cb 100644
--- a/arch/h8300/Makefile
+++ b/arch/h8300/Makefile
@@ -22,7 +22,9 @@ KBUILD_CFLAGS += -DUTS_SYSNAME=\"uClinux\"
KBUILD_AFLAGS += $(aflags-y)
LDFLAGS += $(ldflags-y)
+ifeq ($(CROSS_COMPILE),)
CROSS_COMPILE := h8300-unknown-linux-
+endif
core-y += arch/$(ARCH)/kernel/ arch/$(ARCH)/mm/
ifneq '$(CONFIG_H8300_BUILTIN_DTB)' '""'
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] h8300: Don't set CROSS_COMPILE unconditionally
2015-10-16 11:31 [PATCH] h8300: Don't set CROSS_COMPILE unconditionally Javier Martinez Canillas
@ 2015-10-21 14:55 ` Yoshinori Sato
2015-10-21 15:01 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Yoshinori Sato @ 2015-10-21 14:55 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel, uclinux-h8-devel
On Fri, 16 Oct 2015 20:31:27 +0900,
Javier Martinez Canillas wrote:
>
> The h8300 architecture Makefile sets the CROSS_COMPILE variable to
> "h8300-unknown-linux-" unconditionally but doing that prevents the
> variable to be used if a toolchain with a different binary name is
> installed in the machine.
>
> So only set CROSS_COMPILE to that default if the variable has not
> been set by the user before.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Hello,
>
> After $SUBJECT, I'm able to build using the toolchain installed by
> my Linux distribution but the linker gives me an error about an
> unrecognised emulation mode:
>
> h8300-linux-gnu-ld: unrecognised emulation mode: h8300helf_linux
>
> I see that h8300helf_linux and 8300self_linux are hardcoded in the
> Makefile as well and these are not listed as supported emulations:
>
> Supported emulations: h8300elf h8300helf h8300self h8300hnelf h8300snelf h8300sxelf h8300sxnelf
>
> I tried changing -mh8300helf_linux for -mh8300helf that is listed
> as a supported emulation but then I got the following error:
>
> h8300-linux-gnu-ld: cannot open linker script file ldscripts/h8300helf.xr: No such file or directory
>
h8300-linux is alias of h8300-*-elf.
kernel building toolchain is h8300-*-linux.
h8300-*-linux toolchain is already merged for trunk.
But not include latest release.
Backported patch is https://osdn.jp/projects/uclinux-h8/releases/p14625
> Best regards,
> Javier
>
> arch/h8300/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/h8300/Makefile b/arch/h8300/Makefile
> index 0d2d96e52d9f..e1c02ca230cb 100644
> --- a/arch/h8300/Makefile
> +++ b/arch/h8300/Makefile
> @@ -22,7 +22,9 @@ KBUILD_CFLAGS += -DUTS_SYSNAME=\"uClinux\"
> KBUILD_AFLAGS += $(aflags-y)
> LDFLAGS += $(ldflags-y)
>
> +ifeq ($(CROSS_COMPILE),)
> CROSS_COMPILE := h8300-unknown-linux-
> +endif
>
> core-y += arch/$(ARCH)/kernel/ arch/$(ARCH)/mm/
> ifneq '$(CONFIG_H8300_BUILTIN_DTB)' '""'
> --
> 2.4.3
>
Applied.
Thanks.
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] h8300: Don't set CROSS_COMPILE unconditionally
2015-10-21 14:55 ` Yoshinori Sato
@ 2015-10-21 15:01 ` Javier Martinez Canillas
0 siblings, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2015-10-21 15:01 UTC (permalink / raw)
To: Yoshinori Sato; +Cc: linux-kernel, uclinux-h8-devel
Hello Yoshinori,
On 10/21/2015 04:55 PM, Yoshinori Sato wrote:
> On Fri, 16 Oct 2015 20:31:27 +0900,
> Javier Martinez Canillas wrote:
>>
>> The h8300 architecture Makefile sets the CROSS_COMPILE variable to
>> "h8300-unknown-linux-" unconditionally but doing that prevents the
>> variable to be used if a toolchain with a different binary name is
>> installed in the machine.
>>
>> So only set CROSS_COMPILE to that default if the variable has not
>> been set by the user before.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>>
>> Hello,
>>
>> After $SUBJECT, I'm able to build using the toolchain installed by
>> my Linux distribution but the linker gives me an error about an
>> unrecognised emulation mode:
>>
>> h8300-linux-gnu-ld: unrecognised emulation mode: h8300helf_linux
>>
>> I see that h8300helf_linux and 8300self_linux are hardcoded in the
>> Makefile as well and these are not listed as supported emulations:
>>
>> Supported emulations: h8300elf h8300helf h8300self h8300hnelf h8300snelf h8300sxelf h8300sxnelf
>>
>> I tried changing -mh8300helf_linux for -mh8300helf that is listed
>> as a supported emulation but then I got the following error:
>>
>> h8300-linux-gnu-ld: cannot open linker script file ldscripts/h8300helf.xr: No such file or directory
>>
>
> h8300-linux is alias of h8300-*-elf.
> kernel building toolchain is h8300-*-linux.
>
> h8300-*-linux toolchain is already merged for trunk.
> But not include latest release.
> Backported patch is https://osdn.jp/projects/uclinux-h8/releases/p14625
>
I see, thanks a lot for the information.
>> Best regards,
>> Javier
>>
>> arch/h8300/Makefile | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/h8300/Makefile b/arch/h8300/Makefile
>> index 0d2d96e52d9f..e1c02ca230cb 100644
>> --- a/arch/h8300/Makefile
>> +++ b/arch/h8300/Makefile
>> @@ -22,7 +22,9 @@ KBUILD_CFLAGS += -DUTS_SYSNAME=\"uClinux\"
>> KBUILD_AFLAGS += $(aflags-y)
>> LDFLAGS += $(ldflags-y)
>>
>> +ifeq ($(CROSS_COMPILE),)
>> CROSS_COMPILE := h8300-unknown-linux-
>> +endif
>>
>> core-y += arch/$(ARCH)/kernel/ arch/$(ARCH)/mm/
>> ifneq '$(CONFIG_H8300_BUILTIN_DTB)' '""'
>> --
>> 2.4.3
>>
>
> Applied.
> Thanks.
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-21 15:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-16 11:31 [PATCH] h8300: Don't set CROSS_COMPILE unconditionally Javier Martinez Canillas
2015-10-21 14:55 ` Yoshinori Sato
2015-10-21 15:01 ` Javier Martinez Canillas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.