* [PATCH 1/5] gc: remove unused #include "sigchain.h"
2015-10-22 12:43 [PATCH 0/5] Remove unused #include "sigchain.h" Tobias Klauser
@ 2015-10-22 12:43 ` Tobias Klauser
2015-10-22 20:14 ` Junio C Hamano
2015-10-22 12:43 ` [PATCH 2/5] credential-cache--daemon: " Tobias Klauser
` (5 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: Tobias Klauser @ 2015-10-22 12:43 UTC (permalink / raw)
To: Junio C Hamano, Michael Haggerty, git
After switching to use the tempfile module in commit ebebeaea (gc: use
tempfile module to handle gc.pid file), no declarations from sigchain.h
are used in builtin/gc.c anymore. Thus, remove the #include.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
builtin/gc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/gc.c b/builtin/gc.c
index 9ff0204..dc8a242 100644
--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -15,7 +15,6 @@
#include "lockfile.h"
#include "parse-options.h"
#include "run-command.h"
-#include "sigchain.h"
#include "argv-array.h"
#include "commit.h"
--
2.6.1.148.g7927db1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/5] gc: remove unused #include "sigchain.h"
2015-10-22 12:43 ` [PATCH 1/5] gc: remove " Tobias Klauser
@ 2015-10-22 20:14 ` Junio C Hamano
2015-10-23 7:25 ` Tobias Klauser
0 siblings, 1 reply; 11+ messages in thread
From: Junio C Hamano @ 2015-10-22 20:14 UTC (permalink / raw)
To: Tobias Klauser; +Cc: Michael Haggerty, git
Tobias Klauser <tklauser@distanz.ch> writes:
> After switching to use the tempfile module in commit ebebeaea (gc: use
> tempfile module to handle gc.pid file), no declarations from sigchain.h
> are used in builtin/gc.c anymore. Thus, remove the #include.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
I'll drop this one as we seem to have gained another user of the API
in this file in the nd/gc-auto-background-fix topic.
> builtin/gc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/builtin/gc.c b/builtin/gc.c
> index 9ff0204..dc8a242 100644
> --- a/builtin/gc.c
> +++ b/builtin/gc.c
> @@ -15,7 +15,6 @@
> #include "lockfile.h"
> #include "parse-options.h"
> #include "run-command.h"
> -#include "sigchain.h"
> #include "argv-array.h"
> #include "commit.h"
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/5] gc: remove unused #include "sigchain.h"
2015-10-22 20:14 ` Junio C Hamano
@ 2015-10-23 7:25 ` Tobias Klauser
2015-10-23 17:00 ` Junio C Hamano
0 siblings, 1 reply; 11+ messages in thread
From: Tobias Klauser @ 2015-10-23 7:25 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Michael Haggerty, git
On 2015-10-22 at 22:14:29 +0200, Junio C Hamano <gitster@pobox.com> wrote:
> Tobias Klauser <tklauser@distanz.ch> writes:
>
> > After switching to use the tempfile module in commit ebebeaea (gc: use
> > tempfile module to handle gc.pid file), no declarations from sigchain.h
> > are used in builtin/gc.c anymore. Thus, remove the #include.
> >
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> > ---
>
> I'll drop this one as we seem to have gained another user of the API
> in this file in the nd/gc-auto-background-fix topic.
Opps, sorry I didn't check against 'pu' carefully enough. Thanks for
catching it.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/5] gc: remove unused #include "sigchain.h"
2015-10-23 7:25 ` Tobias Klauser
@ 2015-10-23 17:00 ` Junio C Hamano
0 siblings, 0 replies; 11+ messages in thread
From: Junio C Hamano @ 2015-10-23 17:00 UTC (permalink / raw)
To: Tobias Klauser; +Cc: Michael Haggerty, git
Tobias Klauser <tklauser@distanz.ch> writes:
> On 2015-10-22 at 22:14:29 +0200, Junio C Hamano <gitster@pobox.com> wrote:
>> Tobias Klauser <tklauser@distanz.ch> writes:
>>
>> > After switching to use the tempfile module in commit ebebeaea (gc: use
>> > tempfile module to handle gc.pid file), no declarations from sigchain.h
>> > are used in builtin/gc.c anymore. Thus, remove the #include.
>> >
>> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
>> > ---
>>
>> I'll drop this one as we seem to have gained another user of the API
>> in this file in the nd/gc-auto-background-fix topic.
>
> Opps, sorry I didn't check against 'pu' carefully enough. Thanks for
> catching it.
Heh, that topic has been in master since Oct 15, I think.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/5] credential-cache--daemon: remove unused #include "sigchain.h"
2015-10-22 12:43 [PATCH 0/5] Remove unused #include "sigchain.h" Tobias Klauser
2015-10-22 12:43 ` [PATCH 1/5] gc: remove " Tobias Klauser
@ 2015-10-22 12:43 ` Tobias Klauser
2015-10-22 12:43 ` [PATCH 3/5] diff: " Tobias Klauser
` (4 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Tobias Klauser @ 2015-10-22 12:43 UTC (permalink / raw)
To: Junio C Hamano, Michael Haggerty, git
After switching to use the tempfile module in commit 9e903316
(credential-cache--daemon: use tempfile module), no declarations from
sigchain.h are used in credential-cache--daemon.c anymore. Thus, remove
the #include.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
credential-cache--daemon.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/credential-cache--daemon.c b/credential-cache--daemon.c
index eef6fce..82715aa 100644
--- a/credential-cache--daemon.c
+++ b/credential-cache--daemon.c
@@ -2,7 +2,6 @@
#include "tempfile.h"
#include "credential.h"
#include "unix-socket.h"
-#include "sigchain.h"
#include "parse-options.h"
static struct tempfile socket_file;
--
2.6.1.148.g7927db1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/5] diff: remove unused #include "sigchain.h"
2015-10-22 12:43 [PATCH 0/5] Remove unused #include "sigchain.h" Tobias Klauser
2015-10-22 12:43 ` [PATCH 1/5] gc: remove " Tobias Klauser
2015-10-22 12:43 ` [PATCH 2/5] credential-cache--daemon: " Tobias Klauser
@ 2015-10-22 12:43 ` Tobias Klauser
2015-10-22 12:43 ` [PATCH 4/5] read-cache: " Tobias Klauser
` (3 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Tobias Klauser @ 2015-10-22 12:43 UTC (permalink / raw)
To: Junio C Hamano, Michael Haggerty, git
After switching to use the tempfile module in commit 284098f1
(diff: use tempfile module), no declarations from sigchain.h are used in
diff.c anymore. Thus, remove the #include.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
diff.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/diff.c b/diff.c
index 46260ed..df47592 100644
--- a/diff.c
+++ b/diff.c
@@ -13,7 +13,6 @@
#include "run-command.h"
#include "utf8.h"
#include "userdiff.h"
-#include "sigchain.h"
#include "submodule-config.h"
#include "submodule.h"
#include "ll-merge.h"
--
2.6.1.148.g7927db1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/5] read-cache: remove unused #include "sigchain.h"
2015-10-22 12:43 [PATCH 0/5] Remove unused #include "sigchain.h" Tobias Klauser
` (2 preceding siblings ...)
2015-10-22 12:43 ` [PATCH 3/5] diff: " Tobias Klauser
@ 2015-10-22 12:43 ` Tobias Klauser
2015-10-22 12:43 ` [PATCH 5/5] shallow: " Tobias Klauser
` (2 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Tobias Klauser @ 2015-10-22 12:43 UTC (permalink / raw)
To: Junio C Hamano, Michael Haggerty, git
After switching to use the tempfile module in commit f6ecc62d
(write_shared_index(): use tempfile module), no declarations from
sigchain.h are used in read-cache.c anymore. Thus, remove the #include.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
read-cache.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/read-cache.c b/read-cache.c
index 87204a5..3ecb99d 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -17,7 +17,6 @@
#include "strbuf.h"
#include "varint.h"
#include "split-index.h"
-#include "sigchain.h"
#include "utf8.h"
static struct cache_entry *refresh_cache_entry(struct cache_entry *ce,
--
2.6.1.148.g7927db1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/5] shallow: remove unused #include "sigchain.h"
2015-10-22 12:43 [PATCH 0/5] Remove unused #include "sigchain.h" Tobias Klauser
` (3 preceding siblings ...)
2015-10-22 12:43 ` [PATCH 4/5] read-cache: " Tobias Klauser
@ 2015-10-22 12:43 ` Tobias Klauser
2015-10-22 17:30 ` [PATCH 0/5] Remove " Junio C Hamano
2015-10-26 20:59 ` Michael Haggerty
6 siblings, 0 replies; 11+ messages in thread
From: Tobias Klauser @ 2015-10-22 12:43 UTC (permalink / raw)
To: Junio C Hamano, Michael Haggerty, git
After switching to use the tempfile module in commit 6e122b44
(setup_temporary_shallow(): use tempfile module), no declarations from
sigchain.h are used in read-cache.c anymore. Thus, remove the #include.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
shallow.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/shallow.c b/shallow.c
index d49a3d6..4f9d667 100644
--- a/shallow.c
+++ b/shallow.c
@@ -10,7 +10,6 @@
#include "diff.h"
#include "revision.h"
#include "commit-slab.h"
-#include "sigchain.h"
static int is_shallow = -1;
static struct stat_validity shallow_stat;
--
2.6.1.148.g7927db1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] Remove unused #include "sigchain.h"
2015-10-22 12:43 [PATCH 0/5] Remove unused #include "sigchain.h" Tobias Klauser
` (4 preceding siblings ...)
2015-10-22 12:43 ` [PATCH 5/5] shallow: " Tobias Klauser
@ 2015-10-22 17:30 ` Junio C Hamano
2015-10-26 20:59 ` Michael Haggerty
6 siblings, 0 replies; 11+ messages in thread
From: Junio C Hamano @ 2015-10-22 17:30 UTC (permalink / raw)
To: Tobias Klauser; +Cc: Michael Haggerty, git
Makes sense; will queue directly on top of the original tempfile
series and merge.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] Remove unused #include "sigchain.h"
2015-10-22 12:43 [PATCH 0/5] Remove unused #include "sigchain.h" Tobias Klauser
` (5 preceding siblings ...)
2015-10-22 17:30 ` [PATCH 0/5] Remove " Junio C Hamano
@ 2015-10-26 20:59 ` Michael Haggerty
6 siblings, 0 replies; 11+ messages in thread
From: Michael Haggerty @ 2015-10-26 20:59 UTC (permalink / raw)
To: Tobias Klauser, Junio C Hamano, git
On 10/22/2015 02:43 PM, Tobias Klauser wrote:
> This series removes the #include of sigchain.h from several modules
> after they were changed to use the tempfile module and they thus no
> longer use any declarations from sigchain.h
>
> Tobias Klauser (5):
> gc: remove unused #include "sigchain.h"
> credential-cache--daemon: remove unused #include "sigchain.h"
> diff: remove unused #include "sigchain.h"
> read-cache: remove unused #include "sigchain.h"
> shallow: remove unused #include "sigchain.h"
Thanks for cleaning these up, Tobias. I totally forgot to look for
includes that were no longer needed.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
^ permalink raw reply [flat|nested] 11+ messages in thread