[PATCH] xen/device-tree: Print the DT path on error in dt_for_each_range

[PATCH] xen/device-tree: Print the DT path on error in dt_for_each_range

[Julien Grall]

With the current log is not possible for the user to understand
properly the error:

(XEN) Grant table range: 0x0000007fc00000-0x0000007fc72000
(XEN) DT: no ranges; cannot enumerate
(XEN) Device tree generation failed (-22).
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) Could not set up DOM0 guest OS
(XEN) ****************************************
(XEN)

The other error message within the function already print the DT path.
Do the same here.

Signed-off-by: Julien Grall <julien.grall@citrix.com>

---

    This patch is a good candidate to backport in Xen 4.6. It helps the
    user to directly know which DT node may be invalid rather than having
    to add debug in Xen.
---
 xen/common/device_tree.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 87c3f71..0ed86a7 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -880,7 +880,8 @@ int dt_for_each_range(const struct dt_device_node *dev,
     ranges = dt_get_property(dev, "ranges", &rlen);
     if ( ranges == NULL )
     {
-        printk(XENLOG_ERR "DT: no ranges; cannot enumerate\n");
+        printk(XENLOG_ERR "DT: no ranges; cannot enumerate %s\n",
+               dev->full_name);
         return -EINVAL;
     }
     if ( rlen == 0 ) /* Nothing to do */
-- 
2.1.4

Re: [PATCH] xen/device-tree: Print the DT path on error in dt_for_each_range

[Ian Campbell]

On Mon, 2015-10-19 at 13:58 +0100, Julien Grall wrote:
> With the current log is not possible for the user to understand
> properly the error:
> 
> (XEN) Grant table range: 0x0000007fc00000-0x0000007fc72000
> (XEN) DT: no ranges; cannot enumerate
> (XEN) Device tree generation failed (-22).
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) Could not set up DOM0 guest OS
> (XEN) ****************************************
> (XEN)
> 
> The other error message within the function already print the DT path.
> Do the same here.
> 
> Signed-off-by: Julien Grall <julien.grall@citrix.com>

Acked + applied.
> 
> ---
> 
>     This patch is a good candidate to backport in Xen 4.6. It helps the
>     user to directly know which DT node may be invalid rather than having
>     to add debug in Xen.

Queued.