All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] Staging: mt29f_spinand: Fix "blank line" checkpatch issues
@ 2015-10-22 17:07 Eva Rachel Retuya
  2015-10-22 17:07 ` [PATCH 1/3] Staging: mt29f_spinand: Add blank line after function declaration Eva Rachel Retuya
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Eva Rachel Retuya @ 2015-10-22 17:07 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Eva Rachel Retuya

This patchset fixes multiple checkpatch "CHECK" warnings concerning blank line/s.

Eva Rachel Retuya (3):
  Staging: mt29f_spinand: Add blank line after function declaration
  Staging: mt29f_spinand: Remove blank line before '}' and after '{'
    braces
  Staging: mt29f_spinand: Remove multiple blank lines

 drivers/staging/mt29f_spinand/mt29f_spinand.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
1.9.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/3] Staging: mt29f_spinand: Add blank line after function declaration
  2015-10-22 17:07 [PATCH 0/3] Staging: mt29f_spinand: Fix "blank line" checkpatch issues Eva Rachel Retuya
@ 2015-10-22 17:07 ` Eva Rachel Retuya
  2015-10-22 17:07 ` [PATCH 2/3] Staging: mt29f_spinand: Remove blank line before '}' and after '{' braces Eva Rachel Retuya
  2015-10-22 17:07 ` [PATCH 3/3] Staging: mt29f_spinand: Remove multiple blank lines Eva Rachel Retuya
  2 siblings, 0 replies; 4+ messages in thread
From: Eva Rachel Retuya @ 2015-10-22 17:07 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Eva Rachel Retuya

Add missing blank line in-between function declarations.
Issue found by checkpatch.

CHECK: Please use a blank line after function/struct/union/enum
declarations

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
---
 drivers/staging/mt29f_spinand/mt29f_spinand.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c
index cf98228..dc9877e 100644
--- a/drivers/staging/mt29f_spinand/mt29f_spinand.c
+++ b/drivers/staging/mt29f_spinand/mt29f_spinand.c
@@ -186,6 +186,7 @@ static int wait_till_ready(struct spi_device *spi_nand)
 
 	return -1;
 }
+
 /**
  * spinand_get_otp- send command 0xf to read the SPI Nand OTP register
  * Description:
@@ -839,6 +840,7 @@ static int spinand_lock_block(struct spi_device *spi_nand, u8 lock)
 
 	return ret;
 }
+
 /*
  * spinand_probe - [spinand Interface]
  * @spi_nand: registered device driver.
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] Staging: mt29f_spinand: Remove blank line before '}' and after '{' braces
  2015-10-22 17:07 [PATCH 0/3] Staging: mt29f_spinand: Fix "blank line" checkpatch issues Eva Rachel Retuya
  2015-10-22 17:07 ` [PATCH 1/3] Staging: mt29f_spinand: Add blank line after function declaration Eva Rachel Retuya
@ 2015-10-22 17:07 ` Eva Rachel Retuya
  2015-10-22 17:07 ` [PATCH 3/3] Staging: mt29f_spinand: Remove multiple blank lines Eva Rachel Retuya
  2 siblings, 0 replies; 4+ messages in thread
From: Eva Rachel Retuya @ 2015-10-22 17:07 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Eva Rachel Retuya

Remove unneeded blank lines preceding/following '}' and '{' braces, as
pointed out by checkpatch.

This patch addresses the following checkpatch checks:

CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
---
 drivers/staging/mt29f_spinand/mt29f_spinand.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c
index dc9877e..c00749e 100644
--- a/drivers/staging/mt29f_spinand/mt29f_spinand.c
+++ b/drivers/staging/mt29f_spinand/mt29f_spinand.c
@@ -660,7 +660,6 @@ static int spinand_read_page_hwecc(struct mtd_info *mtd, struct nand_chip *chip,
 		}
 	}
 	return 0;
-
 }
 #endif
 
@@ -711,7 +710,6 @@ static int spinand_wait(struct mtd_info *mtd, struct nand_chip *chip)
 
 static void spinand_write_buf(struct mtd_info *mtd, const uint8_t *buf, int len)
 {
-
 	struct spinand_state *state = mtd_to_state(mtd);
 
 	memcpy(state->buf + state->buf_ptr, buf, len);
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] Staging: mt29f_spinand: Remove multiple blank lines
  2015-10-22 17:07 [PATCH 0/3] Staging: mt29f_spinand: Fix "blank line" checkpatch issues Eva Rachel Retuya
  2015-10-22 17:07 ` [PATCH 1/3] Staging: mt29f_spinand: Add blank line after function declaration Eva Rachel Retuya
  2015-10-22 17:07 ` [PATCH 2/3] Staging: mt29f_spinand: Remove blank line before '}' and after '{' braces Eva Rachel Retuya
@ 2015-10-22 17:07 ` Eva Rachel Retuya
  2 siblings, 0 replies; 4+ messages in thread
From: Eva Rachel Retuya @ 2015-10-22 17:07 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Eva Rachel Retuya

Remove excess blank line in-between two function declarations.
Issue found by checkpatch.

CHECK: Please don't use multiple blank lines

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
---
 drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c
index c00749e..7691417 100644
--- a/drivers/staging/mt29f_spinand/mt29f_spinand.c
+++ b/drivers/staging/mt29f_spinand/mt29f_spinand.c
@@ -677,7 +677,6 @@ static uint8_t spinand_read_byte(struct mtd_info *mtd)
 	return data;
 }
 
-
 static int spinand_wait(struct mtd_info *mtd, struct nand_chip *chip)
 {
 	struct spinand_info *info = (struct spinand_info *)chip->priv;
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-10-22 17:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-22 17:07 [PATCH 0/3] Staging: mt29f_spinand: Fix "blank line" checkpatch issues Eva Rachel Retuya
2015-10-22 17:07 ` [PATCH 1/3] Staging: mt29f_spinand: Add blank line after function declaration Eva Rachel Retuya
2015-10-22 17:07 ` [PATCH 2/3] Staging: mt29f_spinand: Remove blank line before '}' and after '{' braces Eva Rachel Retuya
2015-10-22 17:07 ` [PATCH 3/3] Staging: mt29f_spinand: Remove multiple blank lines Eva Rachel Retuya

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.