* [PATCH] audit: removing unused variable
@ 2015-10-28 4:10 Saurabh Sengar
2015-10-28 20:35 ` Paul Moore
0 siblings, 1 reply; 4+ messages in thread
From: Saurabh Sengar @ 2015-10-28 4:10 UTC (permalink / raw)
To: paul, eparis, linux-audit, linux-kernel; +Cc: Saurabh Sengar
variavle rc in not required as it is just used for unchanged for return,
and return is always 0 in the function.
Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
kernel/audit.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/kernel/audit.c b/kernel/audit.c
index 662c007..409482f 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -686,23 +686,22 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type)
static int audit_log_common_recv_msg(struct audit_buffer **ab, u16 msg_type)
{
- int rc = 0;
uid_t uid = from_kuid(&init_user_ns, current_uid());
pid_t pid = task_tgid_nr(current);
if (!audit_enabled && msg_type != AUDIT_USER_AVC) {
*ab = NULL;
- return rc;
+ return 0;
}
*ab = audit_log_start(NULL, GFP_KERNEL, msg_type);
if (unlikely(!*ab))
- return rc;
+ return 0;
audit_log_format(*ab, "pid=%d uid=%u", pid, uid);
audit_log_session_info(*ab);
audit_log_task_context(*ab);
- return rc;
+ return 0;
}
int is_audit_feature_set(int i)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] audit: removing unused variable
2015-10-28 4:10 [PATCH] audit: removing unused variable Saurabh Sengar
@ 2015-10-28 20:35 ` Paul Moore
2015-10-28 22:12 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Paul Moore @ 2015-10-28 20:35 UTC (permalink / raw)
To: Saurabh Sengar; +Cc: eparis, linux-audit, linux-kernel
On Wednesday, October 28, 2015 09:40:34 AM Saurabh Sengar wrote:
> variavle rc in not required as it is just used for unchanged for return,
> and return is always 0 in the function.
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
> ---
> kernel/audit.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Thanks, applied with some spelling corrections to the description.
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 662c007..409482f 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -686,23 +686,22 @@ static int audit_netlink_ok(struct sk_buff *skb, u16
> msg_type)
>
> static int audit_log_common_recv_msg(struct audit_buffer **ab, u16
> msg_type) {
> - int rc = 0;
> uid_t uid = from_kuid(&init_user_ns, current_uid());
> pid_t pid = task_tgid_nr(current);
>
> if (!audit_enabled && msg_type != AUDIT_USER_AVC) {
> *ab = NULL;
> - return rc;
> + return 0;
> }
>
> *ab = audit_log_start(NULL, GFP_KERNEL, msg_type);
> if (unlikely(!*ab))
> - return rc;
> + return 0;
> audit_log_format(*ab, "pid=%d uid=%u", pid, uid);
> audit_log_session_info(*ab);
> audit_log_task_context(*ab);
>
> - return rc;
> + return 0;
> }
>
> int is_audit_feature_set(int i)
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] audit: removing unused variable
2015-10-28 20:35 ` Paul Moore
@ 2015-10-28 22:12 ` Joe Perches
2015-10-29 14:06 ` Paul Moore
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2015-10-28 22:12 UTC (permalink / raw)
To: Paul Moore; +Cc: Saurabh Sengar, eparis, linux-audit, linux-kernel
On Wed, 2015-10-28 at 16:35 -0400, Paul Moore wrote:
> On Wednesday, October 28, 2015 09:40:34 AM Saurabh Sengar wrote:
> > variavle rc in not required as it is just used for unchanged for return,
> > and return is always 0 in the function.
[]
> Thanks, applied with some spelling corrections to the description.
As the return value is never actually tested,
it seems better to make it a void function,
> > diff --git a/kernel/audit.c b/kernel/audit.c
[]
> > @@ -686,23 +686,22 @@ static int audit_netlink_ok(struct sk_buff *skb, u16
> > msg_type)
> >
> > static int audit_log_common_recv_msg(struct audit_buffer **ab, u16
> > msg_type) {
> > - int rc = 0;
> > uid_t uid = from_kuid(&init_user_ns, current_uid());
> > pid_t pid = task_tgid_nr(current);
> >
> > if (!audit_enabled && msg_type != AUDIT_USER_AVC) {
> > *ab = NULL;
> > - return rc;
> > + return 0;
> > }
> >
> > *ab = audit_log_start(NULL, GFP_KERNEL, msg_type);
> > if (unlikely(!*ab))
> > - return rc;
> > + return 0;
> > audit_log_format(*ab, "pid=%d uid=%u", pid, uid);
> > audit_log_session_info(*ab);
> > audit_log_task_context(*ab);
> >
> > - return rc;
> > + return 0;
> > }
> >
> > int is_audit_feature_set(int i)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] audit: removing unused variable
2015-10-28 22:12 ` Joe Perches
@ 2015-10-29 14:06 ` Paul Moore
0 siblings, 0 replies; 4+ messages in thread
From: Paul Moore @ 2015-10-29 14:06 UTC (permalink / raw)
To: Joe Perches; +Cc: Saurabh Sengar, Eric Paris, linux-audit, linux-kernel
On Wed, Oct 28, 2015 at 6:12 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2015-10-28 at 16:35 -0400, Paul Moore wrote:
>> On Wednesday, October 28, 2015 09:40:34 AM Saurabh Sengar wrote:
>> > variavle rc in not required as it is just used for unchanged for return,
>> > and return is always 0 in the function.
> []
>> Thanks, applied with some spelling corrections to the description.
>
> As the return value is never actually tested,
> it seems better to make it a void function,
Agreed, I did just that yesterday.
* https://www.redhat.com/archives/linux-audit/2015-October/msg00125.html
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-29 14:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-28 4:10 [PATCH] audit: removing unused variable Saurabh Sengar
2015-10-28 20:35 ` Paul Moore
2015-10-28 22:12 ` Joe Perches
2015-10-29 14:06 ` Paul Moore
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.