From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH V2 06/10] Drivers: hv: utils: use memdup_user in hvt_op_write
Date: Thu, 29 Oct 2015 18:12:42 -0700 [thread overview]
Message-ID: <1446167566-19448-6-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1446167566-19448-1-git-send-email-kys@microsoft.com>
From: Olaf Hering <olaf@aepfle.de>
Use memdup_user to handle OOM.
Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport abstraction')
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/hv/hv_utils_transport.c | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv/hv_utils_transport.c
index 1505ee6..24b2766 100644
--- a/drivers/hv/hv_utils_transport.c
+++ b/drivers/hv/hv_utils_transport.c
@@ -80,11 +80,10 @@ static ssize_t hvt_op_write(struct file *file, const char __user *buf,
hvt = container_of(file->f_op, struct hvutil_transport, fops);
- inmsg = kzalloc(count, GFP_KERNEL);
- if (copy_from_user(inmsg, buf, count)) {
- kfree(inmsg);
- return -EFAULT;
- }
+ inmsg = memdup_user(buf, count);
+ if (IS_ERR(inmsg))
+ return PTR_ERR(inmsg);
+
if (hvt->on_msg(inmsg, count))
return -EFAULT;
kfree(inmsg);
--
1.7.4.1
next prev parent reply other threads:[~2015-10-29 23:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 1:12 [PATCH V2 00/10] Drivers: hv: Miscellaneous fixes K. Y. Srinivasan
2015-10-30 1:12 ` [PATCH V2 01/10] Drivers: hv: util: Increase the timeout for util services K. Y. Srinivasan
2015-10-30 1:12 ` [PATCH V2 02/10] Drivers: hv: utils: run polling callback always in interrupt context K. Y. Srinivasan
2015-12-10 10:18 ` Dexuan Cui
2015-12-10 23:23 ` KY Srinivasan
2015-12-11 7:33 ` Dexuan Cui
2015-12-12 0:49 ` KY Srinivasan
2015-10-30 1:12 ` [PATCH V2 03/10] tools: hv: report ENOSPC errors in hv_fcopy_daemon K. Y. Srinivasan
2015-10-30 1:12 ` [PATCH V2 04/10] tools: hv: remove repeated HV_FCOPY string K. Y. Srinivasan
2015-10-30 1:12 ` [PATCH V2 05/10] Drivers: hv: util: catch allocation errors K. Y. Srinivasan
2015-10-30 1:12 ` K. Y. Srinivasan [this message]
2015-10-30 1:12 ` [PATCH V2 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed K. Y. Srinivasan
2015-10-30 1:12 ` [PATCH V2 08/10] drivers:hv: Export a function that maps Linux CPU num onto Hyper-V proc num K. Y. Srinivasan
2015-10-30 1:12 ` [PATCH V2 09/10] drivers:hv: Export the API to invoke a hypercall on Hyper-V K. Y. Srinivasan
2015-10-30 1:12 ` [PATCH V2 10/10] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through K. Y. Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446167566-19448-6-git-send-email-kys@microsoft.com \
--to=kys@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.