All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Paul Turner <pjt@google.com>, Len Brown <len.brown@intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Andi Kleen <andi.kleen@intel.com>,
	Rafael Wysocki <rafael.j.wysocki@intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: [RFC PATCH 2/3] timer: relax tick stop in idle entry
Date: Mon,  2 Nov 2015 16:10:27 -0800	[thread overview]
Message-ID: <1446509428-5616-3-git-send-email-jacob.jun.pan@linux.intel.com> (raw)
In-Reply-To: <1446509428-5616-1-git-send-email-jacob.jun.pan@linux.intel.com>

Upon entering idle, we can turn off tick if the next timeout
is exactly one tick away. Otherwise, we could enter inner idle loop
with tick still enabled, without resched set, the tick will continue
during idle therefore less optimal in terms of energy savings.

Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
 kernel/time/tick-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 7c7ec45..bcadaab 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -606,7 +606,7 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts,
 	 * restart it proper.
 	 */
 	delta = next_tick - basemono;
-	if (delta <= (u64)TICK_NSEC) {
+	if (delta < (u64)TICK_NSEC) {
 		tick.tv64 = 0;
 		if (!ts->tick_stopped)
 			goto out;
-- 
1.9.1


  parent reply	other threads:[~2015-11-03  0:11 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03  0:10 [RFC PATCH 0/3] CFS idle injection Jacob Pan
2015-11-03  0:10 ` [RFC PATCH 1/3] ktime: add a roundup function Jacob Pan
2015-11-03  0:10 ` Jacob Pan [this message]
2015-11-03  0:10 ` [RFC PATCH 3/3] sched: introduce synchronized idle injection Jacob Pan
2015-11-03 13:31   ` Peter Zijlstra
2015-11-03 14:16     ` Jacob Pan
2015-11-03 16:45     ` Jacob Pan
2015-11-05 10:09       ` Peter Zijlstra
2015-11-05 14:22         ` Arjan van de Ven
2015-11-05 14:33           ` Peter Zijlstra
2015-11-05 14:48             ` Peter Zijlstra
2015-11-05 15:28             ` Arjan van de Ven
2015-11-05 16:52               ` Peter Zijlstra
2015-11-05 18:55                 ` Thomas Gleixner
2015-11-05 18:47               ` Thomas Gleixner
2015-11-05 15:32             ` Jacob Pan
2015-11-05 16:06               ` Arjan van de Ven
2015-11-05 19:27         ` Jacob Pan
2015-11-05 19:32           ` Jacob Pan
2015-11-05 13:59     ` Peter Zijlstra
2015-11-05 23:36       ` Jacob Pan
2015-11-06  7:45         ` Peter Zijlstra
2015-11-06 23:49           ` Jacob Pan
2015-11-10  0:19             ` Jacob Pan
2015-11-04  6:06 ` [RFC PATCH 0/3] CFS " Eduardo Valentin
2015-11-04 16:58   ` Jacob Pan
2015-11-04 17:05     ` Srinivas Pandruvada
2015-11-04 18:43       ` Eduardo Valentin
2015-11-05 10:12     ` Peter Zijlstra
2015-11-06 16:50       ` Punit Agrawal
2015-11-06 19:18         ` Jacob Pan
2015-11-09 11:56           ` Punit Agrawal
2015-11-09 14:15             ` Peter Zijlstra
2015-11-09 14:43               ` Jacob Pan
2015-11-10 10:07               ` Juri Lelli
2015-11-10 10:34                 ` Peter Zijlstra
2015-11-10 10:56                   ` Juri Lelli
2015-11-09 14:36             ` Jacob Pan
2015-11-06 18:30       ` Dietmar Eggemann
2015-11-06 19:10         ` Jacob Pan
2015-11-06 21:55           ` Dietmar Eggemann
2015-11-09 21:23             ` Jacob Pan
2015-11-09 21:45               ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446509428-5616-3-git-send-email-jacob.jun.pan@linux.intel.com \
    --to=jacob.jun.pan@linux.intel.com \
    --cc=andi.kleen@intel.com \
    --cc=arjan@linux.intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.