All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Paul Turner <pjt@google.com>, Len Brown <len.brown@intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Andi Kleen <andi.kleen@intel.com>,
	Rafael Wysocki <rafael.j.wysocki@intel.com>
Subject: Re: [RFC PATCH 3/3] sched: introduce synchronized idle injection
Date: Thu, 5 Nov 2015 11:09:22 +0100	[thread overview]
Message-ID: <20151105100922.GA3604@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151103084501.289ec5d1@yairi>

On Tue, Nov 03, 2015 at 08:45:01AM -0800, Jacob Pan wrote:
> Fair enough, I will give that a try, I guess it would be costly
> and hard to scale if we were to dequeue/enqueue every se for every
> period of injection plus locking. Let me get some data first.

Yeah, don't go dequeue/enqueue everything, the regular throttle code
doesn't do that either.

Throttling the root is more interesting though, becuase you can simply
dequeue the child group representative, whereas you cannot dequeue the
root (for being the root means there is no parent to dequeue from).

> I understand we don't want to sacrifice the hot patch for some code
> almost 'never' run. But I also have follow up plan to use this code for
> consolidating/synchronizing idle during balanced semi-active workload.
> In that case, it may run more often. e.g.
> 
> Before:
> CPU0 ______||| ||  |___________| || || |_____
> CPU1 _________||| ||  |_______| || |_______
> 
> After:
> 
> CPU0 ______||| ||  |___________| || || |_____
> CPU1 ______||| ||  |___________| || |_______
> 
> The goal is to have overlapping idle time if the load is already
> balanced. The energy saving can be significant.

I can see such a scheme having a fairly big impact on latency, esp. with
forced idleness such as this. That's not going to be popular for many
workloads.

  reply	other threads:[~2015-11-05 10:09 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03  0:10 [RFC PATCH 0/3] CFS idle injection Jacob Pan
2015-11-03  0:10 ` [RFC PATCH 1/3] ktime: add a roundup function Jacob Pan
2015-11-03  0:10 ` [RFC PATCH 2/3] timer: relax tick stop in idle entry Jacob Pan
2015-11-03  0:10 ` [RFC PATCH 3/3] sched: introduce synchronized idle injection Jacob Pan
2015-11-03 13:31   ` Peter Zijlstra
2015-11-03 14:16     ` Jacob Pan
2015-11-03 16:45     ` Jacob Pan
2015-11-05 10:09       ` Peter Zijlstra [this message]
2015-11-05 14:22         ` Arjan van de Ven
2015-11-05 14:33           ` Peter Zijlstra
2015-11-05 14:48             ` Peter Zijlstra
2015-11-05 15:28             ` Arjan van de Ven
2015-11-05 16:52               ` Peter Zijlstra
2015-11-05 18:55                 ` Thomas Gleixner
2015-11-05 18:47               ` Thomas Gleixner
2015-11-05 15:32             ` Jacob Pan
2015-11-05 16:06               ` Arjan van de Ven
2015-11-05 19:27         ` Jacob Pan
2015-11-05 19:32           ` Jacob Pan
2015-11-05 13:59     ` Peter Zijlstra
2015-11-05 23:36       ` Jacob Pan
2015-11-06  7:45         ` Peter Zijlstra
2015-11-06 23:49           ` Jacob Pan
2015-11-10  0:19             ` Jacob Pan
2015-11-04  6:06 ` [RFC PATCH 0/3] CFS " Eduardo Valentin
2015-11-04 16:58   ` Jacob Pan
2015-11-04 17:05     ` Srinivas Pandruvada
2015-11-04 18:43       ` Eduardo Valentin
2015-11-05 10:12     ` Peter Zijlstra
2015-11-06 16:50       ` Punit Agrawal
2015-11-06 19:18         ` Jacob Pan
2015-11-09 11:56           ` Punit Agrawal
2015-11-09 14:15             ` Peter Zijlstra
2015-11-09 14:43               ` Jacob Pan
2015-11-10 10:07               ` Juri Lelli
2015-11-10 10:34                 ` Peter Zijlstra
2015-11-10 10:56                   ` Juri Lelli
2015-11-09 14:36             ` Jacob Pan
2015-11-06 18:30       ` Dietmar Eggemann
2015-11-06 19:10         ` Jacob Pan
2015-11-06 21:55           ` Dietmar Eggemann
2015-11-09 21:23             ` Jacob Pan
2015-11-09 21:45               ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105100922.GA3604@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=andi.kleen@intel.com \
    --cc=arjan@linux.intel.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pjt@google.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.