* [U-Boot] [PATCH v5 4/5] spi: cadence_qspi: Ensure check for max frequency in place
@ 2015-10-17 13:32 Chin Liang See
2015-10-17 14:14 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Chin Liang See @ 2015-10-17 13:32 UTC (permalink / raw)
To: u-boot
Ensure the intended SCLK frequency not exceeding the maximum
frequency. If that happen, SCLK will set to maximum frequency.
Signed-off-by: Chin Liang See <clsee@altera.com>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: Dinh Nguyen <dinh.linux@gmail.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Stefan Roese <sr@denx.de>
Cc: Vikas Manocha <vikas.manocha@st.com>
Cc: Jagannadh Teki <jteki@openedev.com>
Cc: Pavel Machek <pavel@denx.de>
Acked-by: Pavel Machek <pavel@denx.de>
---
Changes for v5
- shuffling the patches
Changes for v4
- no changes
Changes for v3
- Remove the printout
Changes for v2
- no changes
---
drivers/spi/cadence_qspi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c
index 5756178..4f7fd52 100644
--- a/drivers/spi/cadence_qspi.c
+++ b/drivers/spi/cadence_qspi.c
@@ -122,6 +122,9 @@ static int cadence_spi_set_speed(struct udevice *bus, uint hz)
struct cadence_spi_priv *priv = dev_get_priv(bus);
int err;
+ if (hz > plat->max_hz)
+ hz = plat->max_hz;
+
/* Disable QSPI */
cadence_qspi_apb_controller_disable(priv->regbase);
--
2.2.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v5 4/5] spi: cadence_qspi: Ensure check for max frequency in place
2015-10-17 13:32 [U-Boot] [PATCH v5 4/5] spi: cadence_qspi: Ensure check for max frequency in place Chin Liang See
@ 2015-10-17 14:14 ` Marek Vasut
2015-11-04 14:51 ` Chin Liang See
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2015-10-17 14:14 UTC (permalink / raw)
To: u-boot
On Saturday, October 17, 2015 at 03:32:38 PM, Chin Liang See wrote:
> Ensure the intended SCLK frequency not exceeding the maximum
> frequency. If that happen, SCLK will set to maximum frequency.
>
> Signed-off-by: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Dinh Nguyen <dinh.linux@gmail.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Vikas Manocha <vikas.manocha@st.com>
> Cc: Jagannadh Teki <jteki@openedev.com>
> Cc: Pavel Machek <pavel@denx.de>
> Acked-by: Pavel Machek <pavel@denx.de>
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v5 4/5] spi: cadence_qspi: Ensure check for max frequency in place
2015-10-17 14:14 ` Marek Vasut
@ 2015-11-04 14:51 ` Chin Liang See
2015-11-05 1:34 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Chin Liang See @ 2015-11-04 14:51 UTC (permalink / raw)
To: u-boot
On Sat, 2015-10-17 at 16:14 +0200, marex at denx.de wrote:
> On Saturday, October 17, 2015 at 03:32:38 PM, Chin Liang See wrote:
> > Ensure the intended SCLK frequency not exceeding the maximum
> > frequency. If that happen, SCLK will set to maximum frequency.
> >
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
> > Cc: Vikas Manocha <vikas.manocha@st.com>
> > Cc: Jagannadh Teki <jteki@openedev.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > Acked-by: Pavel Machek <pavel@denx.de>
>
> Acked-by: Marek Vasut <marex@denx.de>
>
Thanks Marek for the review.
I noticed these patches yet to be applied.
Wonder you able to apply these?
Thanks
Chin Liang
> Best regards,
> Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v5 4/5] spi: cadence_qspi: Ensure check for max frequency in place
2015-11-04 14:51 ` Chin Liang See
@ 2015-11-05 1:34 ` Marek Vasut
2015-11-05 2:42 ` Chin Liang See
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2015-11-05 1:34 UTC (permalink / raw)
To: u-boot
On Wednesday, November 04, 2015 at 03:51:56 PM, Chin Liang See wrote:
> On Sat, 2015-10-17 at 16:14 +0200, marex at denx.de wrote:
> > On Saturday, October 17, 2015 at 03:32:38 PM, Chin Liang See wrote:
> > > Ensure the intended SCLK frequency not exceeding the maximum
> > > frequency. If that happen, SCLK will set to maximum frequency.
> > >
> > > Signed-off-by: Chin Liang See <clsee@altera.com>
> > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > > Cc: Marek Vasut <marex@denx.de>
> > > Cc: Stefan Roese <sr@denx.de>
> > > Cc: Vikas Manocha <vikas.manocha@st.com>
> > > Cc: Jagannadh Teki <jteki@openedev.com>
> > > Cc: Pavel Machek <pavel@denx.de>
> > > Acked-by: Pavel Machek <pavel@denx.de>
> >
> > Acked-by: Marek Vasut <marex@denx.de>
>
> Thanks Marek for the review.
>
> I noticed these patches yet to be applied.
> Wonder you able to apply these?
Sorry about that, applied all five, thanks!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v5 4/5] spi: cadence_qspi: Ensure check for max frequency in place
2015-11-05 1:34 ` Marek Vasut
@ 2015-11-05 2:42 ` Chin Liang See
0 siblings, 0 replies; 5+ messages in thread
From: Chin Liang See @ 2015-11-05 2:42 UTC (permalink / raw)
To: u-boot
On Thu, 2015-11-05 at 02:34 +0100, marex at denx.de wrote:
> On Wednesday, November 04, 2015 at 03:51:56 PM, Chin Liang See wrote:
> > On Sat, 2015-10-17 at 16:14 +0200, marex at denx.de wrote:
> > > On Saturday, October 17, 2015 at 03:32:38 PM, Chin Liang See wrote:
> > > > Ensure the intended SCLK frequency not exceeding the maximum
> > > > frequency. If that happen, SCLK will set to maximum frequency.
> > > >
> > > > Signed-off-by: Chin Liang See <clsee@altera.com>
> > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > > > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > > > Cc: Marek Vasut <marex@denx.de>
> > > > Cc: Stefan Roese <sr@denx.de>
> > > > Cc: Vikas Manocha <vikas.manocha@st.com>
> > > > Cc: Jagannadh Teki <jteki@openedev.com>
> > > > Cc: Pavel Machek <pavel@denx.de>
> > > > Acked-by: Pavel Machek <pavel@denx.de>
> > >
> > > Acked-by: Marek Vasut <marex@denx.de>
> >
> > Thanks Marek for the review.
> >
> > I noticed these patches yet to be applied.
> > Wonder you able to apply these?
>
> Sorry about that, applied all five, thanks!
No worries, thanks Marek!
Thanks
Chin Liang
>
> Best regards,
> Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-05 2:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-17 13:32 [U-Boot] [PATCH v5 4/5] spi: cadence_qspi: Ensure check for max frequency in place Chin Liang See
2015-10-17 14:14 ` Marek Vasut
2015-11-04 14:51 ` Chin Liang See
2015-11-05 1:34 ` Marek Vasut
2015-11-05 2:42 ` Chin Liang See
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.