* v2 mfd: wm8994: Add module description/author/license
@ 2015-11-07 16:25 Peter Robinson
2015-11-07 16:25 ` [PATCH] mfd: wm8994: Add module description/author/license information Peter Robinson
0 siblings, 1 reply; 5+ messages in thread
From: Peter Robinson @ 2015-11-07 16:25 UTC (permalink / raw)
To: Lee Jones, patches, linux-kernel, Mark Brown
Changes since v1:
* include module.h in wm8994_regmap
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] mfd: wm8994: Add module description/author/license information
2015-11-07 16:25 v2 mfd: wm8994: Add module description/author/license Peter Robinson
@ 2015-11-07 16:25 ` Peter Robinson
2015-11-10 10:10 ` Charles Keepax
0 siblings, 1 reply; 5+ messages in thread
From: Peter Robinson @ 2015-11-07 16:25 UTC (permalink / raw)
To: Lee Jones, patches, linux-kernel, Mark Brown; +Cc: Peter Robinson, stable
When compiled as a module we get a tainted kernel because of the lack
of the module information and the following errors. Add details to
fix the issue when wm8994_irq/wm8994_regmap are modular.
wm8994_irq: module license 'unspecified' taints kernel.
wm8994_irq: Unknown symbol irq_domain_xlate_twocell (err 0)
wm8994_irq: Unknown symbol regmap_write (err 0)
wm8994_irq: Unknown symbol gpiod_to_irq (err 0)
wm8994_irq: Unknown symbol irq_modify_status (err 0)
wm8994_irq: Unknown symbol irq_set_chip_and_handler_name (err 0)
wm8994_irq: Unknown symbol regmap_add_irq_chip (err 0)
wm8994_irq: Unknown symbol gpiod_get_raw_value_cansleep (err 0)
wm8994_irq: Unknown symbol handle_nested_irq (err 0)
wm8994_irq: Unknown symbol __irq_domain_add (err 0)
wm8994_irq: Unknown symbol irq_create_mapping (err 0)
wm8994_irq: Unknown symbol gpio_to_desc (err 0)
wm8994_irq: Unknown symbol regmap_del_irq_chip (err 0)
wm8994_regmap: module license 'unspecified' taints kernel.
Cc: <stable@vger.kernel.org>
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
drivers/mfd/wm8994-irq.c | 5 +++++
drivers/mfd/wm8994-regmap.c | 6 ++++++
2 files changed, 11 insertions(+)
diff --git a/drivers/mfd/wm8994-irq.c b/drivers/mfd/wm8994-irq.c
index 18710f3..5538521 100644
--- a/drivers/mfd/wm8994-irq.c
+++ b/drivers/mfd/wm8994-irq.c
@@ -262,3 +262,8 @@ void wm8994_irq_exit(struct wm8994 *wm8994)
regmap_del_irq_chip(wm8994->irq, wm8994->irq_data);
}
EXPORT_SYMBOL(wm8994_irq_exit);
+
+MODULE_DESCRIPTION("WM8994 interrupt controller");
+MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:wm8994-irq");
diff --git a/drivers/mfd/wm8994-regmap.c b/drivers/mfd/wm8994-regmap.c
index c56b160..d088185 100644
--- a/drivers/mfd/wm8994-regmap.c
+++ b/drivers/mfd/wm8994-regmap.c
@@ -14,6 +14,7 @@
#include <linux/mfd/wm8994/core.h>
#include <linux/mfd/wm8994/registers.h>
+#include <linux/module.h>
#include <linux/regmap.h>
#include <linux/device.h>
@@ -1289,3 +1290,8 @@ struct regmap_config wm8994_base_regmap_config = {
.val_bits = 16,
};
EXPORT_SYMBOL(wm8994_base_regmap_config);
+
+MODULE_DESCRIPTION("WM8994 Register mapping data");
+MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:wm8994-regmap");
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mfd: wm8994: Add module description/author/license information
2015-11-07 16:25 ` [PATCH] mfd: wm8994: Add module description/author/license information Peter Robinson
@ 2015-11-10 10:10 ` Charles Keepax
0 siblings, 0 replies; 5+ messages in thread
From: Charles Keepax @ 2015-11-10 10:10 UTC (permalink / raw)
To: Peter Robinson; +Cc: Lee Jones, patches, linux-kernel, Mark Brown, stable
On Sat, Nov 07, 2015 at 04:25:39PM +0000, Peter Robinson wrote:
> When compiled as a module we get a tainted kernel because of the lack
> of the module information and the following errors. Add details to
> fix the issue when wm8994_irq/wm8994_regmap are modular.
>
> wm8994_irq: module license 'unspecified' taints kernel.
>
> wm8994_irq: Unknown symbol irq_domain_xlate_twocell (err 0)
> wm8994_irq: Unknown symbol regmap_write (err 0)
> wm8994_irq: Unknown symbol gpiod_to_irq (err 0)
> wm8994_irq: Unknown symbol irq_modify_status (err 0)
> wm8994_irq: Unknown symbol irq_set_chip_and_handler_name (err 0)
> wm8994_irq: Unknown symbol regmap_add_irq_chip (err 0)
> wm8994_irq: Unknown symbol gpiod_get_raw_value_cansleep (err 0)
> wm8994_irq: Unknown symbol handle_nested_irq (err 0)
> wm8994_irq: Unknown symbol __irq_domain_add (err 0)
> wm8994_irq: Unknown symbol irq_create_mapping (err 0)
> wm8994_irq: Unknown symbol gpio_to_desc (err 0)
> wm8994_irq: Unknown symbol regmap_del_irq_chip (err 0)
> wm8994_regmap: module license 'unspecified' taints kernel.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
This looks like the intention was for 8994 to be a single module
can you try the following and see if that also fixes your issue.
Thanks,
Charles
>From ba8cea5e6193c501070553f2f78d1ac59aae252d Mon Sep 17 00:00:00 2001
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Date: Tue, 10 Nov 2015 10:06:29 +0000
Subject: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/mfd/Makefile | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index ef09bf1..b9c229d 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -63,7 +63,8 @@ wm8350-objs := wm8350-core.o wm8350-regmap.o wm8350-gpio.o
wm8350-objs += wm8350-irq.o
obj-$(CONFIG_MFD_WM8350) += wm8350.o
obj-$(CONFIG_MFD_WM8350_I2C) += wm8350-i2c.o
-obj-$(CONFIG_MFD_WM8994) += wm8994-core.o wm8994-irq.o wm8994-regmap.o
+wm8994-objs := wm8994-core.o wm8994-irq.o wm8994-regmap.o
+obj-$(CONFIG_MFD_WM8994) += wm8994.o
obj-$(CONFIG_TPS6105X) += tps6105x.o
obj-$(CONFIG_TPS65010) += tps65010.o
--
1.7.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mfd: wm8994: Add module description/author/license information
2015-11-07 12:28 Peter Robinson
@ 2015-11-07 13:55 ` kbuild test robot
0 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2015-11-07 13:55 UTC (permalink / raw)
To: Peter Robinson
Cc: kbuild-all, Lee Jones, patches, linux-kernel, Mark Brown,
Peter Robinson, stable
[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]
Hi Peter,
[auto build test ERROR on: ljones-mfd/for-mfd-next]
[also build test ERROR on: v4.3 next-20151106]
url: https://github.com/0day-ci/linux/commits/Peter-Robinson/mfd-wm8994-Add-module-description-author-license-information/20151107-203151
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: x86_64-randconfig-i0-11072104 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/mfd/wm8994-regmap.c:1293:20: error: expected declaration specifiers or '...' before string constant
MODULE_DESCRIPTION("WM8994 Register mapping data");
^
drivers/mfd/wm8994-regmap.c:1294:15: error: expected declaration specifiers or '...' before string constant
MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>");
^
drivers/mfd/wm8994-regmap.c:1295:16: error: expected declaration specifiers or '...' before string constant
MODULE_LICENSE("GPL v2");
^
drivers/mfd/wm8994-regmap.c:1296:14: error: expected declaration specifiers or '...' before string constant
MODULE_ALIAS("platform:wm8994-regmap");
^
vim +1293 drivers/mfd/wm8994-regmap.c
1287 struct regmap_config wm8994_base_regmap_config = {
1288 .reg_bits = 16,
1289 .val_bits = 16,
1290 };
1291 EXPORT_SYMBOL(wm8994_base_regmap_config);
1292
> 1293 MODULE_DESCRIPTION("WM8994 Register mapping data");
1294 MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>");
1295 MODULE_LICENSE("GPL v2");
1296 MODULE_ALIAS("platform:wm8994-regmap");
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 18321 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] mfd: wm8994: Add module description/author/license information
@ 2015-11-07 12:28 Peter Robinson
2015-11-07 13:55 ` kbuild test robot
0 siblings, 1 reply; 5+ messages in thread
From: Peter Robinson @ 2015-11-07 12:28 UTC (permalink / raw)
To: Lee Jones, patches, linux-kernel, Mark Brown; +Cc: Peter Robinson, stable
When compiled as a module we get a tainted kernel because of the lack
of the module information and the following errors. Add details to
fix the issue when wm8994_irq/wm8994_regmap are modular.
wm8994_irq: module license 'unspecified' taints kernel.
wm8994_irq: Unknown symbol irq_domain_xlate_twocell (err 0)
wm8994_irq: Unknown symbol regmap_write (err 0)
wm8994_irq: Unknown symbol gpiod_to_irq (err 0)
wm8994_irq: Unknown symbol irq_modify_status (err 0)
wm8994_irq: Unknown symbol irq_set_chip_and_handler_name (err 0)
wm8994_irq: Unknown symbol regmap_add_irq_chip (err 0)
wm8994_irq: Unknown symbol gpiod_get_raw_value_cansleep (err 0)
wm8994_irq: Unknown symbol handle_nested_irq (err 0)
wm8994_irq: Unknown symbol __irq_domain_add (err 0)
wm8994_irq: Unknown symbol irq_create_mapping (err 0)
wm8994_irq: Unknown symbol gpio_to_desc (err 0)
wm8994_irq: Unknown symbol regmap_del_irq_chip (err 0)
wm8994_regmap: module license 'unspecified' taints kernel.
Cc: <stable@vger.kernel.org>
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
drivers/mfd/wm8994-irq.c | 5 +++++
drivers/mfd/wm8994-regmap.c | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/drivers/mfd/wm8994-irq.c b/drivers/mfd/wm8994-irq.c
index 18710f3..5538521 100644
--- a/drivers/mfd/wm8994-irq.c
+++ b/drivers/mfd/wm8994-irq.c
@@ -262,3 +262,8 @@ void wm8994_irq_exit(struct wm8994 *wm8994)
regmap_del_irq_chip(wm8994->irq, wm8994->irq_data);
}
EXPORT_SYMBOL(wm8994_irq_exit);
+
+MODULE_DESCRIPTION("WM8994 interrupt controller");
+MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:wm8994-irq");
diff --git a/drivers/mfd/wm8994-regmap.c b/drivers/mfd/wm8994-regmap.c
index c56b160..16b3e75 100644
--- a/drivers/mfd/wm8994-regmap.c
+++ b/drivers/mfd/wm8994-regmap.c
@@ -1289,3 +1289,8 @@ struct regmap_config wm8994_base_regmap_config = {
.val_bits = 16,
};
EXPORT_SYMBOL(wm8994_base_regmap_config);
+
+MODULE_DESCRIPTION("WM8994 Register mapping data");
+MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:wm8994-regmap");
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-10 10:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-07 16:25 v2 mfd: wm8994: Add module description/author/license Peter Robinson
2015-11-07 16:25 ` [PATCH] mfd: wm8994: Add module description/author/license information Peter Robinson
2015-11-10 10:10 ` Charles Keepax
-- strict thread matches above, loose matches on Subject: below --
2015-11-07 12:28 Peter Robinson
2015-11-07 13:55 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.