* [PATCH 0/2] stm class/intel_th: Kconfig fixes
@ 2015-11-09 10:08 Alexander Shishkin
2015-11-09 10:08 ` [PATCH 1/2] stm class: Hide STM-specific options if STM is disabled Alexander Shishkin
2015-11-09 10:08 ` [PATCH 2/2] intel_th: INTEL_TH should depend on HAS_DMA Alexander Shishkin
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Shishkin @ 2015-11-09 10:08 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, Alexander Shishkin
Hi Greg,
These are two Kconfig fixes from Geert. 1/2 is the one that Linus
noticed, 2/2 is a fresh one.
Geert Uytterhoeven (2):
stm class: Hide STM-specific options if STM is disabled
intel_th: INTEL_TH should depend on HAS_DMA
drivers/hwtracing/intel_th/Kconfig | 1 +
drivers/hwtracing/stm/Kconfig | 4 ++++
2 files changed, 5 insertions(+)
--
2.6.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] stm class: Hide STM-specific options if STM is disabled
2015-11-09 10:08 [PATCH 0/2] stm class/intel_th: Kconfig fixes Alexander Shishkin
@ 2015-11-09 10:08 ` Alexander Shishkin
2015-11-09 10:08 ` [PATCH 2/2] intel_th: INTEL_TH should depend on HAS_DMA Alexander Shishkin
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Shishkin @ 2015-11-09 10:08 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, Geert Uytterhoeven, Alexander Shishkin
From: Geert Uytterhoeven <geert@linux-m68k.org>
If STM=n, it doesn't make sense to ask about STM_DUMMY and
STM_SOURCE_CONSOLE support, which are not even built when enabled
anyway. Hence hide these options if STM=n.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
drivers/hwtracing/stm/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index 83e9f591a5..4c13762f2b 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -8,6 +8,8 @@ config STM
Say Y here to enable System Trace Module device support.
+if STM
+
config STM_DUMMY
tristate "Dummy STM driver"
help
@@ -24,3 +26,5 @@ config STM_SOURCE_CONSOLE
If you want to send kernel console messages over STM devices,
say Y.
+
+endif
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] intel_th: INTEL_TH should depend on HAS_DMA
2015-11-09 10:08 [PATCH 0/2] stm class/intel_th: Kconfig fixes Alexander Shishkin
2015-11-09 10:08 ` [PATCH 1/2] stm class: Hide STM-specific options if STM is disabled Alexander Shishkin
@ 2015-11-09 10:08 ` Alexander Shishkin
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Shishkin @ 2015-11-09 10:08 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, Geert Uytterhoeven, Alexander Shishkin
From: Geert Uytterhoeven <geert@linux-m68k.org>
If NO_DMA=y:
ERROR: "dma_free_coherent" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
ERROR: "dma_supported" [drivers/hwtracing/intel_th/intel_th.ko] undefined!
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
drivers/hwtracing/intel_th/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwtracing/intel_th/Kconfig b/drivers/hwtracing/intel_th/Kconfig
index b7a9073d96..90b0844093 100644
--- a/drivers/hwtracing/intel_th/Kconfig
+++ b/drivers/hwtracing/intel_th/Kconfig
@@ -1,5 +1,6 @@
config INTEL_TH
tristate "Intel(R) Trace Hub controller"
+ depends on HAS_DMA
help
Intel(R) Trace Hub (TH) is a set of hardware blocks (subdevices) that
produce, switch and output trace data from multiple hardware and
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-09 10:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-09 10:08 [PATCH 0/2] stm class/intel_th: Kconfig fixes Alexander Shishkin
2015-11-09 10:08 ` [PATCH 1/2] stm class: Hide STM-specific options if STM is disabled Alexander Shishkin
2015-11-09 10:08 ` [PATCH 2/2] intel_th: INTEL_TH should depend on HAS_DMA Alexander Shishkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.