[PATCH] nl80211: clarify NL80211_ATTR_SCHED_SCAN_DELAY usage with net-detect

[PATCH] nl80211: clarify NL80211_ATTR_SCHED_SCAN_DELAY usage with net-detect

[Luca Coelho]

From: Luca Coelho <luciano.coelho@intel.com>

In this attribute's documentation, it was not clear whether the delay
started counting when WoWLAN net-detect was enabled or when the system
was suspended.  The correct answer is that it starts when the system
suspends (which is when, in practice, the scan is scheduled).  Clarify
that in the nl80211.h documentation.

Suggested-by: Samuel Tan <samueltan@google.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 include/uapi/linux/nl80211.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index 1f0b4cf..ea24d66 100644
--- a/include/uapi/linux/nl80211.h
+++ b/include/uapi/linux/nl80211.h
@@ -1764,8 +1764,9 @@ enum nl80211_commands {
  *	over all channels.
  *
  * @NL80211_ATTR_SCHED_SCAN_DELAY: delay before the first cycle of a
- *	scheduled scan (or a WoWLAN net-detect scan) is started, u32
- *	in seconds.
+ *	scheduled scan is started.  Or the dealy before a WoWLAN
+ *	net-detect scan is started, counting from the moment the
+ *	system is suspended.  This value is a u32, in seconds.
 
  * @NL80211_ATTR_REG_INDOOR: flag attribute, if set indicates that the device
  *      is operating in an indoor environment.
-- 
2.6.2

Re: [PATCH] nl80211: clarify NL80211_ATTR_SCHED_SCAN_DELAY usage with net-detect

[Johannes Berg]

On Mon, 2015-11-09 at 12:11 +0200, Luca Coelho wrote:
> From: Luca Coelho <luciano.coelho@intel.com>
> 
> In this attribute's documentation, it was not clear whether the delay
> started counting when WoWLAN net-detect was enabled or when the
> system
> was suspended.  The correct answer is that it starts when the system
> suspends (which is when, in practice, the scan is
> scheduled).  Clarify
> that in the nl80211.h documentation.
> 
> Suggested-by: Samuel Tan <samueltan@google.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
>  include/uapi/linux/nl80211.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/uapi/linux/nl80211.h
> b/include/uapi/linux/nl80211.h
> index 1f0b4cf..ea24d66 100644
> --- a/include/uapi/linux/nl80211.h
> +++ b/include/uapi/linux/nl80211.h
> @@ -1764,8 +1764,9 @@ enum nl80211_commands {
>   *	over all channels.
>   *
>   * @NL80211_ATTR_SCHED_SCAN_DELAY: delay before the first cycle of a
> - *	scheduled scan (or a WoWLAN net-detect scan) is started,
> u32
> - *	in seconds.
> + *	scheduled scan is started.  Or the dealy before a WoWLAN
> + *	net-detect scan is started, counting from the moment the
> + *	system is suspended.  This value is a u32, in seconds.
> 
delay :)

johannes